percentable 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0fbd045effde2a7949bd1f83593a92c8d320abf1
-  data.tar.gz: 0f629c3a9f5afb113e17a62265d47320cb78ae4d
+  metadata.gz: d9096b94ae18a9333ed3c0c62c5e073c25cd0fdc
+  data.tar.gz: 147fe75ef459749f6ac2761ea89e27db2ad99412
 SHA512:
-  metadata.gz: 21674843db344a6ae56bab761521e302194d7350c891ccc0ee15d567f36ab1902e4590fb6c86878d12130550aaade1f602f9c0883ca35fe66160c7a610bd56eb
-  data.tar.gz: a9709db91180a7edb2498cbaee2a23d4999fdb0087d905ce9f236f2e1b6d6708f9765892ec8953f5b712d1013ea1add97a37be9afe9a9b48c4064542eb8de287
+  metadata.gz: eff8be4785754451bb00d48688e43674e114e09eb79ab568534db8134055a0ecae5e036c094f73cf9a686ebdd7112ea7754329ef3c3e246639adec174462135b
+  data.tar.gz: 28295c08b4d64035a69b91ed21e1afab836b274d9fd2a7f3ae904d31291c82353e52ee6fa5c02868e6d034d1e77fe7128c3372edbb69d32a5834a945355207fd

data/README.md

@@ -68,7 +68,7 @@ percent = Percent.new(50)
 
 Repeat steps above for Floats, BigDecimals, etc. It should all work.
 
-### Can I turn other Numerics into Percents?
+### Can I turn Numerics into Percents?
 
 Yes, yes you can.
 
@@ -76,6 +76,14 @@ Yes, yes you can.
 10.to_percent   #=> Percent.new(10)
 ```
 
+### What if I want to turn my Numeric into what it would actually be as a percent?
+
+Sometimes 10.to_percent is not what you want. That returns you `Percent.new(10)` which is equal only to 0.1. If you have 0.1 and want to turn that into a percent representation, use the code below:
+
+``` ruby
+Percent.from_numeric(1)   #=> Percent.new(100)
+```
+
 ### How do I use this with Rails?
 
 Well let's say you have a User model, and on that user model you have a health attribute. You want to set that to a number that represents the percent. Just use the extend Percentable::Percentize method, and then use the percentize method to make sure you are returned percent objects always. Example below:
@@ -112,7 +120,9 @@ percentize_object = PercentizedClass.new
 percentize_object.returns_a_percent     #=> Percent.new(10)
 ```
 
-You can do percentize multiple methods at a time:
+### What else can percentize do?
+
+You can percentize multiple methods at a time:
 
 ``` ruby
 class PercentizedClass < OriginalClass
@@ -122,7 +132,7 @@ class PercentizedClass < OriginalClass
 end
 ```
 
-You can define defaults for when the percentized method returns nil:
+You can also define defaults for when the percentized method returns nil:
 
 ``` ruby
 class PercentizedClass < OriginalClass

data/lib/percentable.rb

@@ -1,4 +1,5 @@
 require_relative 'percentable/version'
 require_relative 'percentable/numeric'
+require_relative 'percentable/applied_percent'
 require_relative 'percentable/percent'
 require_relative 'percentable/percentize'

data/lib/percentable/applied_percent.rb

@@ -0,0 +1,17 @@
+class AppliedPercent < Struct.new(:percent)
+  def + other
+    other + self * other
+  end
+
+  def - other
+    other - self * other
+  end
+
+  def * other
+    other * percent.to_f
+  end
+
+  def / other
+    other / percent.to_f
+  end
+end

data/lib/percentable/percent.rb

@@ -1,7 +1,11 @@
 module Percentable
   class Percent < ::Numeric
     def initialize(value)
-      @value = value.to_f
+      if value.is_a? Percent
+        @value = value.value
+      else
+        @value = value.to_f
+      end
     end
 
     def value
@@ -20,24 +24,6 @@ module Percentable
       value.to_i
     end
 
-    def coerce other
-      method = caller[0].match("`(.+)'")[1].to_sym
-
-      case other
-      when Numeric
-        case method
-        when :+
-          [to_f * other, other]
-        when :-
-          [other, to_f * other]
-        else
-          [other, to_f]
-        end
-      else
-        fail TypeError, "#{self.class} can't be coerced into #{other.class}"
-      end
-    end
-
     def == other
       (other.class == self.class && other.value == self.value) || other == self.to_f
     end
@@ -70,6 +56,10 @@ module Percentable
       end
     end
 
+    def to_percent
+      self
+    end
+
     def self.from_numeric(numeric)
       case numeric
       when Numeric
@@ -78,6 +68,15 @@ module Percentable
         fail TypeError, 'must inherit from Numeric'
       end
     end
+
+    def coerce other
+      case other
+      when Numeric
+        [AppliedPercent.new(self), other]
+      else
+        fail TypeError, "#{self.class} can't be coerced into #{other.class}"
+      end
+    end
   end
 end
 

data/lib/percentable/version.rb

@@ -1,3 +1,3 @@
 module Percentable
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

data/spec/lib/percentable/percent_spec.rb

@@ -14,6 +14,15 @@ describe Percentable::Percent do
         expect(subject.value).to eq 50
       end
     end
+
+    context 'with percent value' do
+      let(:value) { percent }
+      let(:percent) { Percentable::Percent.new(50) }
+
+      it 'should return an equivalent percent' do
+        expect(subject).to eq percent
+      end
+    end
   end
 
   describe '#to_s' do
@@ -277,6 +286,14 @@ describe Percentable::Percent do
     end
   end
 
+  describe '#to_percent' do
+    let(:value) { 50 }
+
+    it 'should return self' do
+      expect(subject.to_percent).to eq subject
+    end
+  end
+
   describe '.from_numeric' do
     let(:n) { 0.5 }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percentable
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Eric Roberts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-30 00:00:00.000000000 Z
+date: 2014-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -82,6 +82,7 @@ files:
 - README.md
 - Rakefile
 - lib/percentable.rb
+- lib/percentable/applied_percent.rb
 - lib/percentable/numeric.rb
 - lib/percentable/percent.rb
 - lib/percentable/percentize.rb