peoplegroup-connectors 0.1.85 → 0.1.88

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad0028411b8229e27b10a2ed4082d465ac19f8707f105906224d40e8ee470ee0
-  data.tar.gz: 64bb20ee1c4c92a0e4fc9ba3d008ae606ff5e1805de82aa2ea580773cf92ecb6
+  metadata.gz: b5438b021525494c7cf68386c73234d714d661d8bb97d4da6805aebbcabace18
+  data.tar.gz: 61269cad8f934e828b527f68559a633efa7ecdd17ac2055d2f5284333db519ce
 SHA512:
-  metadata.gz: fbed757134acb64151d4ca000d7e4bd90e8d73b2cabd3e08742d1a13b6e5089bf6a5bc3fd3496915e992a45da3baa344697a39637188c6f6cba415df9699e820
-  data.tar.gz: 12ef9db327a385db19cbb28210ef1791decb64cab07e7cb0cdcf6e94db1bf51d8466811e389fabbb649123c4f1df827187732c1c9199c6f3a1762fce5cb0bad1
+  metadata.gz: 6157518930851bccf1eedf3f06bae1d405e680c2da947d9286d2f8fb9a0abb8543363b0a630f5e37eab9442f1b521bd6d93d4be8d2aeacd2328bee8e4460f663
+  data.tar.gz: 2a8c60f99d54a5e081532e4645c63b5a1726e5b3a91043a8027e9f5e54798ad95a33207d1d61175ede6d47d024e46e80e765949156dd6d4878713b958e90eaa9

data/data/email_mapper.yml

@@ -1,7 +1,5 @@
 - slack_email: cristiano
   bamboo_email: ccasella
-- slack_email: jmeshell
-  bamboo_email: jporter
 - slack_email: mjacob
   bamboo_email: mgomez
 - slack_email: nprecilla

data/lib/peoplegroup/connectors/bamboo.rb

@@ -26,19 +26,6 @@ module PeopleGroup
         employee_details
       end
 
-      def get_employee(id)
-        retry_on_error do
-          @client.employee.find(id, %w[firstName lastName jobTitle supervisor hireDate country location department division workEmail customCostCenter])
-        end
-      end
-
-      def get_employee!(id)
-        employee = get_employee(id)
-        raise EmployeeNotFoundError, "No employee found with id #{id}" if employee.nil?
-
-        employee
-      end
-
       def search_employee(name)
         return if name.empty?
 
@@ -101,24 +88,12 @@ module PeopleGroup
       end
 
       def fetch_manager(team_member)
-        active_team_members.find { |tm| tm['id'] == team_member['supervisorEId'] }
+        active_team_members.find { |tm| tm['employeeNumber'] == team_member['supervisorId'] }
       end
 
       def fetch_manager!(team_member)
         manager = fetch_manager(team_member)
-        raise EmployeeNotFoundError, "Manager not found for employee #{team_member['id']}" if manager.nil?
-
-        manager
-      end
-
-      def fetch_manager_for_id(team_member_id)
-        team_member = get_employee_details(team_member_id)
-        active_team_members.find { |tm| tm['id'] == team_member['supervisorEId'] }
-      end
-
-      def fetch_manager_for_id!(team_member_id)
-        manager = fetch_manager_for_id(team_member_id)
-        raise EmployeeNotFoundError, "No manager found with id #{team_member_id}" if manager.nil?
+        raise EmployeeNotFoundError, "Manager not found for employee #{team_member['employeeNumber']}" if manager.nil?
 
         manager
       end
@@ -129,7 +104,7 @@ module PeopleGroup
 
       def fetch_second_level_manager!(team_member)
         manager = fetch_second_level_manager(team_member)
-        raise EmployeeNotFoundError, "No second level manager found for employee #{team_member['id']}" if manager.nil?
+        raise EmployeeNotFoundError, "No second level manager found for employee #{team_member['employeeNumber']}" if manager.nil?
 
         manager
       end
@@ -349,7 +324,8 @@ module PeopleGroup
         retry_on_error { @client.employee.table_data(employee_id, 'customCurrencyConversion') }
       end
 
-      def add_bonus(team_member_id, comment)
+      def add_bonus(employee_number, comment)
+        team_member = search_employee_by_field(field: 'employeeNumber', value: employee_number)
         data = {
           customBonusdate: Date.today.to_s,
           customBonusamount: { value: 1_000, currency: 'USD' },
@@ -357,7 +333,7 @@ module PeopleGroup
           customBonuscomments: comment
           # customNominatedBy: 'TODO'
         }
-        retry_on_error { @client.employee.add_table_row(team_member_id, 'customBonus', data) }
+        retry_on_error { @client.employee.add_table_row(team_member['id'], 'customBonus', data) }
       end
 
       def add_rating_details(team_member_id, performance, potential)

data/lib/peoplegroup/connectors/hris.rb

@@ -26,17 +26,6 @@ module PeopleGroup
         employee_details
       end
 
-      def get_employee(id)
-        format_worker(@workday.get_worker(id))
-      end
-
-      def get_employee!(id)
-        employee = get_employee(id)
-        raise EmployeeNotFoundError, "No employee found with id #{id}" if employee.nil?
-
-        employee
-      end
-
       private
 
       # Convert Workday worker to BambooHR employee

data/lib/peoplegroup/connectors/version.rb

@@ -2,6 +2,6 @@
 
 module PeopleGroup
   module Connectors
-    VERSION = '0.1.85'
+    VERSION = '0.1.88'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: peoplegroup-connectors
 version: !ruby/object:Gem::Version
-  version: 0.1.85
+  version: 0.1.88
 platform: ruby
 authors:
 - lien van den steen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-20 00:00:00.000000000 Z
+date: 2022-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gitlab
@@ -221,7 +221,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Library for our shared connectors.