peoplegroup-connectors 0.1.40 → 0.1.45

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecf7d0f6b87ac0685639d2e21cffdb23638a57ee038dca05df2e470cc7247a88
-  data.tar.gz: ca6fee41f611867d0ad89743b88e5cec2cc88f7ed1b84f8b9f95e9e3efcef358
+  metadata.gz: bd447f499b21f3477e1b34d21a4d3b2a4e8efe1bcc69cb62af631ef2dbb3536e
+  data.tar.gz: a82e79f78e7b539e0d27578fc4c22e3a4316833b5e101b82d0bdac1fe6741f09
 SHA512:
-  metadata.gz: 1f654feae15f573b77c9a7148029c8102731f761128d810193adb8019b3ee25d295c9a157fc0c249355009c55677a4d6c91cebf327db15c60f49dd9c4a5ea008
-  data.tar.gz: b7b4ca73c61a45540c341b73a616c79526d94a573e82328867e389aa6fd6dc86f65539be7d9deff7f14baca5903604d84f9496cdbcdc9a8a17855e8d7438c24d
+  metadata.gz: 8cd43728cb472d523a5b4386feb439f1e303021827fbcd9c0a7e3f1bcc4e0c082d8f3f10f22a02dd3c4608ff16a5a605df842cb6c4b01265db55de9f1fecf6c0
+  data.tar.gz: f99e6d578df15f2d577f370d36c8a2ff9d871797731b898f2b1cbd1ddc13dac671f7409a4d48c0b396fc2f8c2c985848e70cd0d0cfe7709ef2f87df5a57eb7af

data/lib/peoplegroup/connectors/bamboo.rb

@@ -5,6 +5,8 @@ require 'bamboozled'
 module PeopleGroup
   module Connectors
     class Bamboo
+      EmployeeNotFoundError = Class.new(StandardError)
+
       def initialize(use_report: false)
         @use_report = use_report
         @client = Bamboozled.client(subdomain: 'gitlab', api_key: ENV['BAMBOO_API_KEY'])
@@ -14,10 +16,24 @@ module PeopleGroup
         employees.find { |emp| emp['id'] == id.to_s }
       end
 
+      def get_employee_details!(id)
+        employee_details = get_employee_details(id)
+        raise EmployeeNotFoundError, "No employee found with id #{id}" if employee_details.nil?
+
+        employee_details
+      end
+
       def get_employee(id)
         @client.employee.find(id, %w[firstName lastName jobTitle supervisor hireDate country location department division workEmail customCostCenter])
       end
 
+      def get_employee!(id)
+        employee = get_employee(id)
+        raise EmployeeNotFoundError, "No employee found with id #{id}" if employee.nil?
+
+        employee
+      end
+
       def search_employee(name)
         return if name.empty?
 
@@ -34,11 +50,27 @@ module PeopleGroup
       end
       alias_method :search_team_member, :search_employee
 
+      def search_employee!(name)
+        employee = search_employee(name)
+        raise EmployeeNotFoundError, "No employee found with name #{name}" if employee.nil?
+
+        employee
+      end
+      alias_method :search_team_member!, :search_employee!
+
       def search_employee_by_field(field:, value:)
         employees.find { |employee| employee[field] == value.to_s }
       end
       alias_method :search_team_member_by_field, :search_employee_by_field
 
+      def search_employee_by_field!(field:, value:)
+        employee = search_employee_by_field(field: field, value: value)
+        raise EmployeeNotFoundError, "No employee found with #{field}: #{value}" if employee.nil?
+
+        employee
+      end
+      alias_method :search_team_member_by_field!, :search_employee_by_field!
+
       def slack_email_lookup_with_fallback(email)
         file_path = File.join(__dir__, '../../../data/email_mapper.yml')
         email_mapper = YAML.load_file(file_path)
@@ -48,19 +80,47 @@ module PeopleGroup
         employees.find { |employee| employee['workEmail'] == email }
       end
 
+      def slack_email_lookup_with_fallback!(email)
+        employee = slack_email_lookup_with_fallback(email)
+        raise EmployeeNotFoundError, "No employee found with Slack email #{email}" if employee.nil?
+
+        employee
+      end
+
       def fetch_manager(team_member)
         active_team_members.find { |tm| tm['id'] == team_member['supervisorEId'] }
       end
 
+      def fetch_manager!(team_member)
+        manager = fetch_manager(team_member)
+        raise EmployeeNotFoundError, "Manager not found for employee #{team_member['id']}" if manager.nil?
+
+        manager
+      end
+
       def fetch_manager_for_id(team_member_id)
         team_member = get_employee_details(team_member_id)
         active_team_members.find { |tm| tm['id'] == team_member['supervisorEId'] }
       end
 
+      def fetch_manager_for_id!(team_member_id)
+        manager = fetch_manager_for_id(team_member_id)
+        raise EmployeeNotFoundError, "No manager found with id #{team_member_id}" if manager.nil?
+
+        manager
+      end
+
       def fetch_second_level_manager(team_member)
         fetch_manager(fetch_manager(team_member))
       end
 
+      def fetch_second_level_manager!(team_member)
+        manager = fetch_second_level_manager(team_member)
+        raise EmployeeNotFoundError, "No second level manager found for employee #{team_member['id']}" if manager.nil?
+
+        manager
+      end
+
       def create_employee(employee_details_hash)
         @client.employee.add(employee_details_hash)
       end
@@ -78,11 +138,7 @@ module PeopleGroup
       end
 
       def fields
-        return @fields if @fields
-
-        @fields = (Bamboozled::API::FieldCollection.all_names + @client.meta.fields.map { |f| f['alias'] }).compact.uniq
-        @fields.delete('fslaCode') # temp fix for problems with BambooHR
-        @fields
+        @fields ||= (Bamboozled::API::FieldCollection.all_names + @client.meta.fields.map { |f| f['alias'] }).compact.uniq
       end
 
       def employees

data/lib/peoplegroup/connectors/gitlab.rb

@@ -49,6 +49,10 @@ module PeopleGroup
         retry_on_error { @client.create_issue_note(project, id, text) }
       end
 
+      def edit_issue(project, id, options)
+        retry_on_error { @client.edit_issue(project, id, options) }
+      end
+
       def get_onboarding_issues(project, args)
         retry_on_error { @client.issues(project, args).auto_paginate }
       end

data/lib/peoplegroup/connectors/google_sheets.rb

@@ -25,7 +25,7 @@ module PeopleGroup
       end
 
       def retry_on_error(&block)
-        Utils.retry_on_error(errors: [Google::Apis::ServerError], delay: 1, &block)
+        Utils.retry_on_error(errors: [Google::Apis::ServerError], delay: 3, max_attempts: 4, &block)
       end
     end
   end

data/lib/peoplegroup/connectors/version.rb

@@ -2,6 +2,6 @@
 
 module PeopleGroup
   module Connectors
-    VERSION = '0.1.40'
+    VERSION = '0.1.45'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: peoplegroup-connectors
 version: !ruby/object:Gem::Version
-  version: 0.1.40
+  version: 0.1.45
 platform: ruby
 authors:
 - lien van den steen
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-30 00:00:00.000000000 Z
+date: 2021-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gitlab
@@ -28,16 +28,16 @@ dependencies:
   name: google_drive
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: slack-ruby-client
   requirement: !ruby/object:Gem::Requirement
@@ -190,7 +190,7 @@ metadata:
   homepage_uri: https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem
   source_code_uri: https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem
   changelog_uri: https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -205,8 +205,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key:
+rubygems_version: 3.2.3
+signing_key: 
 specification_version: 4
 summary: Library for our shared connectors.
 test_files: []