peoplegroup-connectors 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb962e9d43875bb0a19ac206165c335097c6147148d23944a4479e97460613f3
-  data.tar.gz: 521103c3b8289e98752fb6a06f125ed8db47ef5d160030032b00ab478263498d
+  metadata.gz: e340134de5e6005a6abbaf23e43a8eb58a2b544c98ae255c211f58f4e977c12a
+  data.tar.gz: ded841507c511fa4086074c0dcfb0d8a1d23eb1c3635bb98c1653480abf6cca3
 SHA512:
-  metadata.gz: d52daa4d4fddc9a989dc41e601d208167c6a27c36d1c2a0ba09b164c25a9eb829486bae15f09a64bb6c670f57ea803fc37e25966410761f2fefe11b165206700
-  data.tar.gz: 472b1e602fb9ae87b5b25fb6987e4d625a31b2b668c24429ab850adc06314980a7dbd8533f518104d475a554df9fe94b16ac87e365247137636acba14dbcf432
+  metadata.gz: 4f5cce06b2badfcce8d829e1a9a644093b107fdd3ad44e12090d2b664e563f1037aa4e129eacabde7b87b41dc9421ade5ff0119db466d147d6a74b54b82ce6a6
+  data.tar.gz: 480a77c30f5158fc601a543b7b49bc05e7168230a1b243319526aa67c028dd8ecd3be4bd58296c38681441d47a6647505c85e50f5756704e9d6527e7f496c40f

data/.travis.yml

@@ -0,0 +1,6 @@
+---
+language: ruby
+cache: bundler
+rvm:
+  - 2.6.5
+before_install: gem install bundler -v 2.1.4

data/Gemfile

@@ -1,9 +1,7 @@
-# frozen_string_literal: true
+source "https://rubygems.org"
 
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in gl-people-connectors.gemspec
+# Specify your gem's dependencies in connectors.gemspec
 gemspec
 
-gem 'rake', '~> 12.0'
-gem 'rspec', '~> 3.0'
+gem "rake", "~> 12.0"
+gem "rspec", "~> 3.0"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    peoplegroup-connectors (0.1.2)
+    connectors (0.1.0)
       gitlab
 
 GEM
@@ -64,7 +64,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  peoplegroup-connectors!
+  connectors!
   rake (~> 12.0)
   rspec (~> 3.0)
   rubocop (~> 0.85)

data/README.md

@@ -1,6 +1,6 @@
-# PeopleGroup::Connectors
+# Connectors
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/peoplegroup/connectors`. To experiment with that code, run `bin/console` for an interactive prompt.
+Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/connectors`. To experiment with that code, run `bin/console` for an interactive prompt.
 
 TODO: Delete this and the text above, and describe your gem
 
@@ -9,7 +9,7 @@ TODO: Delete this and the text above, and describe your gem
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'peoplegroup-connectors'
+gem 'connectors'
 ```
 
 And then execute:
@@ -18,7 +18,7 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install peoplegroup-connectors
+    $ gem install connectors
 
 ## Usage
 
@@ -30,11 +30,15 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
-## Contributing and Code of Conduct
+## Contributing
 
-Bug reports and pull requests are welcome on GitLab at https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/connectors. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/[USERNAME]/connectors/blob/master/CODE_OF_CONDUCT.md).
 
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
+
+## Code of Conduct
+
+Everyone interacting in the Connectors project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/connectors/blob/master/CODE_OF_CONDUCT.md).

data/Rakefile

@@ -1,8 +1,6 @@
-# frozen_string_literal: true
-
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task default: :spec
+task :default => :spec

data/bin/console

@@ -1,26 +1,14 @@
 #!/usr/bin/env ruby
-# frozen_string_literal: true
 
-require 'bundler/setup'
-require 'peoplegroup/connectors'
+require "bundler/setup"
+require "connectors"
 
-def reload!(print: true)
-  puts 'Reloading ...' if print
-  # Main project directory.
-  root_dir = File.expand_path('..', __dir__)
-  # Directories within the project that should be reloaded.
-  reload_dirs = %w[lib]
-  # Loop through and reload every file in all relevant project directories.
-  reload_dirs.each do |dir|
-    Dir.glob("#{root_dir}/#{dir}/**/*.rb").each { |f| load(f) }
-  end
-  # Return true when complete.
-  true
-end
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
 # require "pry"
 # Pry.start
 
-require 'irb'
+require "irb"
 IRB.start(__FILE__)

data/connectors.gemspec

@@ -0,0 +1,34 @@
+require_relative 'lib/connectors/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "peoplegroup-connectors"
+  spec.version       = Connectors::VERSION
+  spec.authors       = ["lien van den steen"]
+  spec.email         = ["lvandensteen@gitlab.com"]
+
+  spec.summary       = 'Library for our shared connectors.'
+  spec.description   = 'Avoid repeating methods in different projects for our connectos.'
+  spec.homepage      = 'https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem'
+  spec.license       = "MIT"
+  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata['changelog_uri'] = spec.homepage
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  end
+  spec.bindir        = "exe"
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+
+  spec.add_dependency 'gitlab'
+
+  spec.add_development_dependency 'rspec', '~> 3.2'
+  spec.add_development_dependency 'rubocop', '~> 0.85'
+  spec.add_development_dependency 'rubocop-packaging', '~> 0.1'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.39'
+end

data/lib/connectors.rb

@@ -0,0 +1,7 @@
+require "connectors/version"
+require "connectors/gitlab"
+
+module Connectors
+  class Error < StandardError; end
+  # Your code goes here...
+end

data/lib/connectors/version.rb

@@ -0,0 +1,3 @@
+module Connectors
+  VERSION = "0.1.4"
+end

metadata

@@ -1,12 +1,12 @@
 --- !ruby/object:Gem::Specification
 name: peoplegroup-connectors
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - lien van den steen
 autorequire:
-bindir: bin
+bindir: exe
 cert_chain: []
 date: 2021-02-01 00:00:00.000000000 Z
 dependencies:
@@ -83,17 +83,14 @@ dependencies:
 description: Avoid repeating methods in different projects for our connectos.
 email:
 - lvandensteen@gitlab.com
-executables:
-- console
-- setup
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".gitlab-ci.yml"
 - ".rspec"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -102,13 +99,10 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- lib/peoplegroup/connectors.rb
-- lib/peoplegroup/connectors/gitlab.rb
-- lib/peoplegroup/connectors/version.rb
-- peoplegroup-connectors.gemspec
-- spec/peoplegroup/connectors/gitlab_spec.rb
-- spec/peoplegroup/connectors_spec.rb
-- spec/spec_helper.rb
+- connectors.gemspec
+- lib/connectors.rb
+- lib/connectors/gitlab.rb
+- lib/connectors/version.rb
 homepage: https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem
 licenses:
 - MIT
@@ -131,11 +125,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.0.3
 signing_key:
 specification_version: 4
 summary: Library for our shared connectors.
-test_files:
-- spec/peoplegroup/connectors/gitlab_spec.rb
-- spec/peoplegroup/connectors_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.rubocop.yml

@@ -1,21 +0,0 @@
-inherit_from: .rubocop_todo.yml
-
-require:
-  - rubocop-rspec
-  - rubocop-packaging
-
-AllCops:
-  TargetRubyVersion: 2.7
-  # Cop names are displayed in offense messages by default. Change behavior
-  # by overriding DisplayCopNames, or by giving the `--no-display-cop-names`
-  # option.
-  DisplayCopNames: true
-  # Style guide URLs are not displayed in offense messages by default. Change
-  # behavior by overriding DisplayStyleGuide, or by giving the
-  # -S/--display-style-guide option.
-  DisplayStyleGuide: false
-  # Exclude some GitLab files
-  NewCops: enable
-
-Style/Documentation:
-  Enabled: false

data/.rubocop_todo.yml

@@ -1,72 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2021-01-29 12:09:47 UTC using RuboCop version 0.93.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-# Configuration parameters: Include.
-# Include: **/*.gemspec
-Gemspec/RequiredRubyVersion:
-  Exclude:
-    - 'peoplegroup-connectors.gemspec'
-
-# Offense count: 1
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
-# ExcludedMethods: refine
-Metrics/BlockLength:
-  Max: 104
-
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
-Metrics/MethodLength:
-  Max: 22
-
-# Offense count: 2
-# Configuration parameters: CountKeywordArgs.
-Metrics/ParameterLists:
-  Max: 6
-
-# Offense count: 1
-Packaging/GemspecGit:
-  Exclude:
-    - 'peoplegroup-connectors.gemspec'
-
-# Offense count: 1
-# Configuration parameters: Max.
-RSpec/ExampleLength:
-  Exclude:
-    - 'spec/peoplegroup/connectors/gitlab_spec.rb'
-
-# Offense count: 2
-# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
-RSpec/FilePath:
-  Exclude:
-    - 'spec/peoplegroup/connectors/gitlab_spec.rb'
-    - 'spec/peoplegroup/connectors_spec.rb'
-
-# Offense count: 3
-RSpec/MultipleExpectations:
-  Max: 3
-
-# Offense count: 5
-# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
-RSpec/VerifiedDoubles:
-  Exclude:
-    - 'spec/peoplegroup/connectors/gitlab_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowOnConstant.
-Style/CaseEquality:
-  Exclude:
-    - 'lib/peoplegroup/connectors/gitlab.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 185

data/lib/peoplegroup/connectors.rb

@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'connectors/version'
-require_relative 'connectors/gitlab'
-
-module PeopleGroup
-  module Connectors
-    class Error < StandardError; end
-  end
-end

data/lib/peoplegroup/connectors/version.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-module PeopleGroup
-  module Connectors
-    VERSION = '0.1.3'
-  end
-end

data/peoplegroup-connectors.gemspec

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'lib/peoplegroup/connectors/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = 'peoplegroup-connectors'
-  spec.version       = PeopleGroup::Connectors::VERSION
-  spec.authors       = ['lien van den steen']
-  spec.email         = ['lvandensteen@gitlab.com']
-
-  spec.summary       = 'Library for our shared connectors.'
-  spec.description   = 'Avoid repeating methods in different projects for our connectos.'
-  spec.homepage      = 'https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem'
-  spec.license       = 'MIT'
-  spec.required_ruby_version = Gem::Requirement.new('>= 2.3.0')
-
-  spec.metadata['homepage_uri'] = spec.homepage
-  spec.metadata['source_code_uri'] = spec.homepage
-  spec.metadata['changelog_uri'] = spec.homepage
-
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ['lib']
-
-  spec.add_dependency 'gitlab'
-
-  spec.add_development_dependency 'rspec', '~> 3.2'
-  spec.add_development_dependency 'rubocop', '~> 0.85'
-  spec.add_development_dependency 'rubocop-packaging', '~> 0.1'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.39'
-end

data/spec/peoplegroup/connectors/gitlab_spec.rb

@@ -1,125 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe PeopleGroup::Connectors::GitLab do
-  let(:gitlab_members) { spy }
-  let(:gitlab_mock) do
-    instance_double(
-      Gitlab::Client,
-      group_members: gitlab_members,
-      create_issue: true,
-      issues: double(auto_paginate: true),
-      create_issue_note: true,
-      create_epic: true,
-      epics: double(auto_paginate: []),
-      create_branch: true,
-      create_merge_request: true,
-      create_commit: true,
-      create_epic_note: true,
-      epic_issues: double(auto_paginate: []),
-      edit_epic: true
-    )
-  end
-
-  before do
-    allow(Gitlab).to receive(:client).and_return(gitlab_mock)
-  end
-
-  describe '#find_gitlabber' do
-    context 'when given empty query' do
-      it 'returns nil' do
-        expect(described_class.new.find_gitlabber(:username, nil)).to be_nil
-      end
-    end
-
-    context 'when given non-empty query' do
-      it 'calls correct method with proper args' do
-        described_class.new.find_gitlabber(:name, 'john')
-
-        expect(gitlab_mock).to have_received(:group_members).with('gitlab-com', query: 'john')
-        expect(gitlab_members).to have_received(:find)
-      end
-    end
-  end
-
-  describe '#create_issue' do
-    it 'calls correct method with proper args' do
-      described_class.new.create_issue('foo/bar', 'My Issue Title', assignee_id: 123_456)
-      expect(gitlab_mock).to have_received(:create_issue).with('foo/bar', 'My Issue Title', assignee_id: 123_456)
-    end
-  end
-
-  describe '#get_onboarding_issues' do
-    it 'uses specified arguments' do
-      described_class.new.get_onboarding_issues('foo/bar', per_page: 500)
-
-      expect(gitlab_mock).to have_received(:issues).with('foo/bar', per_page: 500)
-    end
-  end
-
-  describe '#create_issue_note' do
-    it 'calls correct method with proper args' do
-      described_class.new.create_issue_note('foo/bar', 15, 'My issue comment')
-
-      expect(gitlab_mock).to have_received(:create_issue_note).with('foo/bar', 15, 'My issue comment')
-    end
-  end
-
-  describe '#find_or_create_epic' do
-    it 'calls correct method with proper args' do
-      described_class.new.find_or_create_epic(123, 'My Epic Title', assignee_id: 123_456)
-      expect(gitlab_mock).to have_received(:create_epic).with(123, 'My Epic Title', { assignee_id: 123_456, confidential: true })
-    end
-
-    context 'when the epic was closed' do
-      before do
-        allow(gitlab_mock).to receive(:epics).and_return(double(auto_paginate: [double(iid: 1, group_id: 2, web_url: 'foo.bar/issues/1', state: 'closed', title: 'Existing Epic')]))
-      end
-
-      it 'reopens the epic' do
-        described_class.new.find_or_create_epic(2, 'Existing Epic', assignee_id: 123_456)
-        expect(gitlab_mock).not_to have_received(:create_epic)
-        expect(gitlab_mock).to have_received(:edit_epic).with(2, 1, state_event: 'reopen')
-      end
-    end
-  end
-
-  describe '#commit_change_to_new_merge_request' do
-    it 'calls correct method with proper args' do
-      described_class.new.commit_change_to_new_merge_request(123, 'my-new-branch', 'foo/bar.md', 'the changed text', 'my commit message')
-      expect(gitlab_mock).to have_received(:create_branch).with(123, 'my-new-branch', 'master')
-      action = {
-        action: 'update',
-        file_path: 'foo/bar.md',
-        content: 'the changed text'
-      }
-      expect(gitlab_mock).to have_received(:create_commit).with(123, 'my-new-branch', 'my commit message', [action])
-      expect(gitlab_mock).to have_received(:create_merge_request).with(123, 'my commit message', { source_branch: 'my-new-branch', target_branch: 'master', remove_source_branch: true })
-    end
-  end
-
-  describe '#get_epics' do
-    it 'calls correct method with proper args' do
-      described_class.new.get_epics(123)
-      expect(gitlab_mock).to have_received(:epics).with(123, {})
-    end
-
-    it 'calls correct method with proper args when you add options' do
-      described_class.new.get_epics(123, state: 'opened')
-      expect(gitlab_mock).to have_received(:epics).with(123, { state: 'opened' })
-    end
-  end
-
-  describe '#get_issue_epics' do
-    it 'calls correct method with proper args' do
-      described_class.new.get_issue_epics(123, 7)
-      expect(gitlab_mock).to have_received(:epic_issues).with(123, 7)
-    end
-  end
-
-  describe '#create_epic_note' do
-    it 'calls correct method with proper args' do
-      described_class.new.create_epic_note(123, 7, 'My epic note')
-      expect(gitlab_mock).to have_received(:create_epic_note).with(123, 7, 'My epic note')
-    end
-  end
-end

data/spec/peoplegroup/connectors_spec.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe PeopleGroup::Connectors do
-  it 'has a version number' do
-    expect(PeopleGroup::Connectors::VERSION).not_to be nil
-  end
-end

data/spec/spec_helper.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-require 'peoplegroup/connectors'
-
-RSpec.configure do |config|
-  # Enable flags like --only-failures and --next-failure
-  config.example_status_persistence_file_path = '.rspec_status'
-
-  # Disable RSpec exposing methods globally on `Module` and `main`
-  config.disable_monkey_patching!
-
-  config.filter_run focus: true
-  config.run_all_when_everything_filtered = true
-
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
-  end
-end