peoplegroup-connectors 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0cd3e2299c0749eacfa79fa3d8f9d4ac9a7cb59b817ed9d85e89ff42d919e7ff
-  data.tar.gz: b5daffe094fd83d2ccb41c97598feef9ab7e31f78b6254ab1e0bf0fb84d4f6d3
+  metadata.gz: eb962e9d43875bb0a19ac206165c335097c6147148d23944a4479e97460613f3
+  data.tar.gz: 521103c3b8289e98752fb6a06f125ed8db47ef5d160030032b00ab478263498d
 SHA512:
-  metadata.gz: fec64050cb1516d8bc1426240d779b1544c3a32a1d8cb6daba836adeccfc1daed3ebc49210962d2da850b7b0d48fc790fa81bc0feebf9b4ab5a8482a1bf19e64
-  data.tar.gz: 9ec82b1b16a7e2d34fac56ab5b860bfd19fbd72ea9a32ef8503b937a1f19c261b930bcdc7ff8fff4535662f7ebcd23d9f934345627151d5736f074a805c4f7b3
+  metadata.gz: d52daa4d4fddc9a989dc41e601d208167c6a27c36d1c2a0ba09b164c25a9eb829486bae15f09a64bb6c670f57ea803fc37e25966410761f2fefe11b165206700
+  data.tar.gz: 472b1e602fb9ae87b5b25fb6987e4d625a31b2b668c24429ab850adc06314980a7dbd8533f518104d475a554df9fe94b16ac87e365247137636acba14dbcf432

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    peoplegroup-connectors (0.1.0)
+    peoplegroup-connectors (0.1.2)
       gitlab
 
 GEM

data/lib/peoplegroup/connectors/version.rb

@@ -2,6 +2,6 @@
 
 module PeopleGroup
   module Connectors
-    VERSION = '0.1.2'
+    VERSION = '0.1.3'
   end
 end

data/peoplegroup-connectors.gemspec

@@ -18,14 +18,11 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri'] = spec.homepage
   spec.metadata['changelog_uri'] = spec.homepage
 
-  spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.files         = `git ls-files -z`.split("\x0")
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-
   spec.add_dependency 'gitlab'
 
   spec.add_development_dependency 'rspec', '~> 3.2'

data/spec/peoplegroup/connectors/gitlab_spec.rb

@@ -0,0 +1,125 @@
+# frozen_string_literal: true
+
+RSpec.describe PeopleGroup::Connectors::GitLab do
+  let(:gitlab_members) { spy }
+  let(:gitlab_mock) do
+    instance_double(
+      Gitlab::Client,
+      group_members: gitlab_members,
+      create_issue: true,
+      issues: double(auto_paginate: true),
+      create_issue_note: true,
+      create_epic: true,
+      epics: double(auto_paginate: []),
+      create_branch: true,
+      create_merge_request: true,
+      create_commit: true,
+      create_epic_note: true,
+      epic_issues: double(auto_paginate: []),
+      edit_epic: true
+    )
+  end
+
+  before do
+    allow(Gitlab).to receive(:client).and_return(gitlab_mock)
+  end
+
+  describe '#find_gitlabber' do
+    context 'when given empty query' do
+      it 'returns nil' do
+        expect(described_class.new.find_gitlabber(:username, nil)).to be_nil
+      end
+    end
+
+    context 'when given non-empty query' do
+      it 'calls correct method with proper args' do
+        described_class.new.find_gitlabber(:name, 'john')
+
+        expect(gitlab_mock).to have_received(:group_members).with('gitlab-com', query: 'john')
+        expect(gitlab_members).to have_received(:find)
+      end
+    end
+  end
+
+  describe '#create_issue' do
+    it 'calls correct method with proper args' do
+      described_class.new.create_issue('foo/bar', 'My Issue Title', assignee_id: 123_456)
+      expect(gitlab_mock).to have_received(:create_issue).with('foo/bar', 'My Issue Title', assignee_id: 123_456)
+    end
+  end
+
+  describe '#get_onboarding_issues' do
+    it 'uses specified arguments' do
+      described_class.new.get_onboarding_issues('foo/bar', per_page: 500)
+
+      expect(gitlab_mock).to have_received(:issues).with('foo/bar', per_page: 500)
+    end
+  end
+
+  describe '#create_issue_note' do
+    it 'calls correct method with proper args' do
+      described_class.new.create_issue_note('foo/bar', 15, 'My issue comment')
+
+      expect(gitlab_mock).to have_received(:create_issue_note).with('foo/bar', 15, 'My issue comment')
+    end
+  end
+
+  describe '#find_or_create_epic' do
+    it 'calls correct method with proper args' do
+      described_class.new.find_or_create_epic(123, 'My Epic Title', assignee_id: 123_456)
+      expect(gitlab_mock).to have_received(:create_epic).with(123, 'My Epic Title', { assignee_id: 123_456, confidential: true })
+    end
+
+    context 'when the epic was closed' do
+      before do
+        allow(gitlab_mock).to receive(:epics).and_return(double(auto_paginate: [double(iid: 1, group_id: 2, web_url: 'foo.bar/issues/1', state: 'closed', title: 'Existing Epic')]))
+      end
+
+      it 'reopens the epic' do
+        described_class.new.find_or_create_epic(2, 'Existing Epic', assignee_id: 123_456)
+        expect(gitlab_mock).not_to have_received(:create_epic)
+        expect(gitlab_mock).to have_received(:edit_epic).with(2, 1, state_event: 'reopen')
+      end
+    end
+  end
+
+  describe '#commit_change_to_new_merge_request' do
+    it 'calls correct method with proper args' do
+      described_class.new.commit_change_to_new_merge_request(123, 'my-new-branch', 'foo/bar.md', 'the changed text', 'my commit message')
+      expect(gitlab_mock).to have_received(:create_branch).with(123, 'my-new-branch', 'master')
+      action = {
+        action: 'update',
+        file_path: 'foo/bar.md',
+        content: 'the changed text'
+      }
+      expect(gitlab_mock).to have_received(:create_commit).with(123, 'my-new-branch', 'my commit message', [action])
+      expect(gitlab_mock).to have_received(:create_merge_request).with(123, 'my commit message', { source_branch: 'my-new-branch', target_branch: 'master', remove_source_branch: true })
+    end
+  end
+
+  describe '#get_epics' do
+    it 'calls correct method with proper args' do
+      described_class.new.get_epics(123)
+      expect(gitlab_mock).to have_received(:epics).with(123, {})
+    end
+
+    it 'calls correct method with proper args when you add options' do
+      described_class.new.get_epics(123, state: 'opened')
+      expect(gitlab_mock).to have_received(:epics).with(123, { state: 'opened' })
+    end
+  end
+
+  describe '#get_issue_epics' do
+    it 'calls correct method with proper args' do
+      described_class.new.get_issue_epics(123, 7)
+      expect(gitlab_mock).to have_received(:epic_issues).with(123, 7)
+    end
+  end
+
+  describe '#create_epic_note' do
+    it 'calls correct method with proper args' do
+      described_class.new.create_epic_note(123, 7, 'My epic note')
+      expect(gitlab_mock).to have_received(:create_epic_note).with(123, 7, 'My epic note')
+    end
+  end
+end

data/spec/peoplegroup/connectors_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+RSpec.describe PeopleGroup::Connectors do
+  it 'has a version number' do
+    expect(PeopleGroup::Connectors::VERSION).not_to be nil
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'peoplegroup/connectors'
+
+RSpec.configure do |config|
+  # Enable flags like --only-failures and --next-failure
+  config.example_status_persistence_file_path = '.rspec_status'
+
+  # Disable RSpec exposing methods globally on `Module` and `main`
+  config.disable_monkey_patching!
+
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

metadata

@@ -1,12 +1,12 @@
 --- !ruby/object:Gem::Specification
 name: peoplegroup-connectors
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - lien van den steen
 autorequire:
-bindir: exe
+bindir: bin
 cert_chain: []
 date: 2021-02-01 00:00:00.000000000 Z
 dependencies:
@@ -83,7 +83,9 @@ dependencies:
 description: Avoid repeating methods in different projects for our connectos.
 email:
 - lvandensteen@gitlab.com
-executables: []
+executables:
+- console
+- setup
 extensions: []
 extra_rdoc_files: []
 files:
@@ -104,6 +106,9 @@ files:
 - lib/peoplegroup/connectors/gitlab.rb
 - lib/peoplegroup/connectors/version.rb
 - peoplegroup-connectors.gemspec
+- spec/peoplegroup/connectors/gitlab_spec.rb
+- spec/peoplegroup/connectors_spec.rb
+- spec/spec_helper.rb
 homepage: https://gitlab.com/gitlab-com/people-group/peopleops-eng/connectors-gem
 licenses:
 - MIT
@@ -130,4 +135,7 @@ rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Library for our shared connectors.
-test_files: []
+test_files:
+- spec/peoplegroup/connectors/gitlab_spec.rb
+- spec/peoplegroup/connectors_spec.rb
+- spec/spec_helper.rb