peoplefinder 0.0.2

data/spec/features/person_edit_notifications_spec.rb

@@ -0,0 +1,193 @@
+require 'rails_helper'
+
+feature 'Person edit notifications' do
+  before do
+    omni_auth_log_in_as 'test.user@digital.justice.gov.uk'
+  end
+
+  scenario 'Creating a person with different email' do
+    visit new_person_path
+
+    fill_in 'First name', with: 'Bob'
+    fill_in 'Surname', with: 'Smith'
+    fill_in 'Email', with: 'bob.smith@digital.justice.gov.uk'
+    expect { click_button 'Create' }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+    expect(last_email.subject).to eq('A new profile on MOJ People Finder has been created for you')
+
+    check_email_to_and_from
+    check_email_has_token_link_to(Peoplefinder::Person.last)
+  end
+
+  scenario 'Creating a person with same email' do
+    visit new_person_path
+
+    fill_in 'First name', with: 'Bob'
+    fill_in 'Surname', with: 'Smith'
+    fill_in 'Email', with: 'test.user@digital.justice.gov.uk'
+    expect { click_button 'Create' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Creating a person with email from invalid domain' do
+    visit new_person_path
+
+    fill_in 'Surname', with: 'Smith'
+    fill_in 'Email', with: 'test.user@something-else.example.com'
+    expect { click_button 'Create' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Creating a person with invalid email' do
+    visit new_person_path
+
+    fill_in 'First name', with: 'Bob'
+    fill_in 'Surname', with: 'Smith'
+    fill_in 'Email', with: 'test.user'
+    expect { click_button 'Create' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Creating a person with nil email' do
+    visit new_person_path
+
+    fill_in 'First name', with: 'Bob'
+    fill_in 'Surname', with: 'Smith'
+    expect { click_button 'Create' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Deleting a person with different email' do
+    person = create(:person, email: 'bob.smith@digital.justice.gov.uk')
+    visit edit_person_path(person)
+    expect { click_link('Delete this profile') }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+    expect(last_email.subject).to eq('Your profile on MOJ People Finder has been deleted')
+    check_email_to_and_from
+  end
+
+  scenario 'Deleting a person with same email' do
+    person = create(:person, email: 'test.user@digital.justice.gov.uk')
+    visit edit_person_path(person)
+    expect { click_link('Delete this profile') }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Deleting a person with email from invalid domain' do
+    person = create(:person, email: 'test.user@something-else.example.com')
+    visit edit_person_path(person)
+    expect { click_link('Delete this profile') }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Deleting a person with invalid email' do
+    person = create(:person, email: 'test.user')
+    visit edit_person_path(person)
+    expect { click_link('Delete this profile') }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Deleting a person with nil email' do
+    person = create(:person, email: nil)
+    visit edit_person_path(person)
+    expect { click_link('Delete this profile') }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Editing a person with different email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'bob.smith@digital.justice.gov.uk')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Surname', with: 'Smelly Pants'
+    expect { click_button 'Update' }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+    expect(last_email.subject).to eq('Your profile on MOJ People Finder has been edited')
+
+    check_email_to_and_from
+    check_email_has_token_link_to(person)
+  end
+
+  scenario 'Editing a person with an email from invalid domain' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'bob.smith@something-else.example.com')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Surname', with: 'Smelly Pants'
+    expect { click_button 'Update' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Editing a person with same email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'test.user@digital.justice.gov.uk')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Surname', with: 'Smelly Pants'
+    expect { click_button 'Update' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Editing a person with nil email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: nil)
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Surname', with: 'Smelly Pants'
+    expect { click_button 'Update' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Editing a person with invalid email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'test.user')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Surname', with: 'Smelly Pants'
+    expect { click_button 'Update' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Editing a person from same email to different email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'test.user@digital.justice.gov.uk')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Email', with: 'bob.smith@digital.justice.gov.uk'
+    expect { click_button 'Update' }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+    expect(last_email.subject).to eq('This email address has been added to a profile on MOJ People Finder')
+
+    check_email_to_and_from
+    check_email_has_token_link_to(person)
+  end
+
+  scenario 'Editing a person from different email to same email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'bob.smith@digital.justice.gov.uk')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Email', with: 'test.user@digital.justice.gov.uk'
+    expect { click_button 'Update' }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+    expect(last_email.subject).to eq('This email address has been removed from a profile on MOJ People Finder')
+
+    check_email_to_and_from
+    check_email_has_token_link_to(person)
+  end
+
+  scenario 'Editing a person from different email to different email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'bob.smith@digital.justice.gov.uk')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Email', with: 'bob.smithe@digital.justice.gov.uk'
+    expect { click_button 'Update' }.to change { ActionMailer::Base.deliveries.count }.by(2)
+  end
+
+  scenario 'Editing a person from invalid email to invalid email' do
+    person = create(:person, given_name: 'Bob', surname: 'Smith', email: 'bob.smith')
+    visit person_path(person)
+    click_link 'Edit this profile'
+    fill_in 'Email', with: 'test.user'
+    expect { click_button 'Update' }.not_to change { ActionMailer::Base.deliveries.count }
+  end
+
+  scenario 'Verifying the link to bob that is render in the emails' do
+    bob = create(:person, email: 'bob@digital.justice.gov.uk', surname: 'bob')
+    visit token_url(Peoplefinder::Token.for_person(bob), desired_path: person_path(bob))
+
+    within('h1') do
+      expect(page).to have_text('bob')
+    end
+  end
+
+  def check_email_to_and_from
+    expect(last_email.to).to eql(['bob.smith@digital.justice.gov.uk'])
+    expect(last_email.body.encoded).to match('test.user@digital.justice.gov.uk')
+  end
+
+  def check_email_has_token_link_to(person)
+    expect(last_email.body.encoded).to match("http.*tokens\/#{ Peoplefinder::Token.last.to_param }.*?desired_path=%2Fpeople%2F*#{ person.to_param }")
+  end
+end

data/spec/features/person_maintenance_spec.rb

@@ -0,0 +1,251 @@
+require 'rails_helper'
+
+feature 'Person maintenance' do
+  before do
+    omni_auth_log_in_as 'test.user@digital.justice.gov.uk'
+  end
+
+  scenario 'Creating a person with a complete profile', js: true do
+    create(:group, name: 'Digital')
+
+    javascript_log_in
+    visit new_person_path
+    fill_in_complete_profile_details
+
+    click_button 'Create'
+    check_creation_of_profile_details
+  end
+
+  scenario 'Creating an invalid person' do
+    visit new_person_path
+    click_button 'Create'
+    expect(page).to have_text('Please review the problems')
+    within('div.person_surname') do
+      expect(page).to have_text('can\'t be blank')
+    end
+  end
+
+  scenario 'Creating a person with an identical name', js: true do
+    create(:group, name: 'Digital')
+    create(:person, given_name: person_attributes[:given_name],
+                    surname: person_attributes[:surname])
+
+    javascript_log_in
+    visit new_person_path
+    fill_in_complete_profile_details
+
+    click_button 'Create'
+
+    expect(page).to have_text('1 result found')
+    click_button 'Continue'
+    check_creation_of_profile_details
+    expect(Peoplefinder::Person.where(surname: person_attributes[:surname]).count).to eql(2)
+  end
+
+  scenario 'Cancelling creation of a person with an identical name' do
+    create(:person, given_name: person_attributes[:given_name],
+                    surname: person_attributes[:surname])
+    visit new_person_path
+
+    fill_in 'First name', with: person_attributes[:given_name]
+    fill_in 'Surname', with: person_attributes[:surname]
+    click_button 'Create'
+
+    click_link 'Return to home page'
+    expect(Peoplefinder::Person.where(surname: person_attributes[:surname]).count).to eql(1)
+  end
+
+  scenario 'Editing a person and giving them a name that already exists' do
+    create(:person, given_name: person_attributes[:given_name],
+                    surname: person_attributes[:surname])
+    person = create(:person, given_name: 'Bobbie', surname: 'Browne')
+    visit edit_person_path(person)
+
+    fill_in 'First name', with: person_attributes[:given_name]
+    fill_in 'Surname', with: person_attributes[:surname]
+    click_button 'Update'
+
+    click_button 'Continue'
+    expect(Peoplefinder::Person.where(surname: person_attributes[:surname]).count).to eql(2)
+  end
+
+  scenario 'Deleting a person' do
+    person = create(:person)
+    visit edit_person_path(person)
+    click_link('Delete this profile')
+    expect { Peoplefinder::Person.find(person) }.to raise_error(ActiveRecord::RecordNotFound)
+  end
+
+  scenario 'Allow deletion of a person even when there are memberships' do
+    membership = create(:membership)
+    person = membership.person
+    visit edit_person_path(person)
+    click_link('Delete this profile')
+    expect { Peoplefinder::Membership.find(membership) }.to raise_error(ActiveRecord::RecordNotFound)
+    expect { Peoplefinder::Person.find(person) }.to raise_error(ActiveRecord::RecordNotFound)
+  end
+
+  scenario 'Editing a person' do
+    visit person_path(create(:person, person_attributes))
+    click_link 'Edit this profile'
+
+    fill_in 'First name', with: 'Jane'
+    fill_in 'Surname', with: 'Doe'
+    click_button 'Update'
+
+    expect(page).to have_content('Updated Jane Doe’s profile')
+    within('h1') do
+      expect(page).to have_text('Jane Doe')
+    end
+  end
+
+  scenario 'Editing an invalid person' do
+    visit person_path(create(:person, person_attributes))
+    click_link 'Edit this profile'
+    fill_in 'Surname', with: ''
+    click_button 'Update'
+
+    expect(page).to have_text('Please review the problems')
+    within('div.person_surname') do
+      expect(page).to have_text('can\'t be blank')
+    end
+  end
+
+  scenario 'Adding a profile image' do
+    visit new_person_path
+    fill_in 'Surname', with: person_attributes[:surname]
+    attach_file 'person[image]', sample_image
+    expect(page).not_to have_link('Crop image')
+    click_button 'Create'
+
+    person = Peoplefinder::Person.find_by_surname(person_attributes[:surname])
+    visit person_path(person)
+    expect(page).to have_css("img[src*='#{person.image.medium}']")
+
+    visit edit_person_path(person)
+    expect(page).to have_link('Crop image', edit_person_image_path(person))
+  end
+
+  context 'Viewing my own profile' do
+    let(:person) { create(:person, email: 'test.user@digital.justice.gov.uk') }
+
+    scenario 'when it is complete' do
+      complete_profile!(person)
+      visit person_path(person)
+      expect(page).not_to have_text('Profile completeness')
+    end
+
+    scenario 'when it is incomplete' do
+      visit person_path(person)
+      expect(page).to have_text('Profile completeness')
+    end
+  end
+
+  context 'Viewing another person\'s profile' do
+    let(:person) { create(:person, email: 'someone.else@digital.justice.gov.uk') }
+
+    scenario 'when it is complete' do
+      complete_profile!(person)
+      visit person_path(person)
+      expect(page).not_to have_text('Profile completeness')
+    end
+
+    scenario 'when it is incomplete and there is no email address' do
+      person.update_attributes email: nil
+      visit person_path(person)
+      expect(page).not_to have_text('Profile completeness')
+      expect(page).not_to have_link('Ask the person to update their details')
+    end
+
+    scenario 'when it is incomplete, I request more information' do
+      visit person_path(person)
+      expect(page).not_to have_text('Profile completeness')
+
+      click_link('Ask the person to update their details')
+      expect(page).to have_link('Cancel', person_path(person))
+
+      within('h1') do
+        expect(page).to have_text('Request profile update')
+      end
+
+      fill_in 'information_request_message', with: 'Hello Bob'
+      expect { click_button 'Submit' }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+      expect(last_email).to have_text('Hello Bob')
+      expect(last_email.to).to include(person.email)
+      expect(last_email.subject).to eql('Request to update your People Finder profile')
+      check_email_has_token_link_to(person)
+      expect(page).to have_text("Your message has been sent to #{ person.name }")
+    end
+  end
+
+  scenario 'UI elements on the new/edit pages' do
+    visit new_person_path
+    expect(page).not_to have_selector('.search-box')
+    expect(page).to have_text('You are currently editing this page')
+
+    fill_in 'Surname', with: person_attributes[:surname]
+    click_button 'Create'
+    expect(page).to have_selector('.search-box')
+    expect(page).not_to have_text('You are currently editing this page')
+
+    click_link 'Edit this profile'
+    expect(page).not_to have_selector('.search-box')
+    expect(page).to have_text('You are currently editing this page')
+  end
+
+  scenario 'Cancelling an edit' do
+    person = create(:person)
+    visit edit_person_path(person)
+    expect(page).to have_link('Cancel', href: person_path(person))
+  end
+
+  scenario 'Cancelling a new form' do
+    visit new_person_path
+    expect(page).to have_link('Cancel', href: 'javascript:history.back()')
+  end
+
+  scenario 'Toggling the phone number fields', js: true do
+    create(:group, name: 'Digital')
+    person = create(:person)
+    javascript_log_in
+
+    visit edit_person_path(person)
+
+    check('No phone number')
+    expect(page).not_to have_field('person_primary_phone_number')
+    expect(page).not_to have_field('person_secondary_phone_number')
+
+    uncheck('No phone number')
+    fill_in('person_primary_phone_number', with: 'my-primary-phone')
+    fill_in('person_secondary_phone_number', with: 'my-secondary-phone')
+
+    check('No phone number')
+    click_button 'Update'
+    expect(Peoplefinder::Person.last.primary_phone_number).to be_blank
+    expect(Peoplefinder::Person.last.secondary_phone_number).to be_blank
+
+    visit edit_person_path(person)
+    expect(page).not_to have_field('person_primary_phone_number')
+    expect(page).not_to have_field('person_secondary_phone_number')
+  end
+
+  scenario 'Reporting a profile' do
+    group = create(:group)
+    person = create(:person)
+    person.groups << group
+
+    visit person_path(person)
+    click_link 'Report this profile'
+
+    select 'Duplicate profile', from: 'Reason for reporting'
+    fill_in 'Additional details (optional)', with: 'Some stuff'
+    expect { click_button 'Submit' }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+    expect(last_email.to).to include(group.team_email_address)
+    expect(last_email.subject).to eql('A People Finder profile has been reported')
+    expect(last_email.body.encoded).to have_text('Reason for reporting: Duplicate profile')
+    expect(last_email.body.encoded).to have_text('Additional details: Some stuff')
+    expect(last_email.body.encoded).to have_text(person_url(person))
+  end
+end

data/spec/features/person_membership_spec.rb

@@ -0,0 +1,91 @@
+require 'rails_helper'
+
+feature "Peoplefinder::Person maintenance" do
+  before do
+    omni_auth_log_in_as 'test.user@digital.justice.gov.uk'
+  end
+
+  scenario 'Creating a person and making them the leader of a group', js: true do
+    group = create(:group, name: 'Digital Justice')
+    javascript_log_in
+
+    visit new_person_path
+    fill_in 'Surname', with: 'Taylor'
+    fill_in 'Job title', with: 'Head Honcho'
+    click_in_org_browser 'Digital Justice'
+    check 'leader'
+    click_button "Create"
+
+    membership = Peoplefinder::Person.last.memberships.last
+    expect(membership.role).to eql('Head Honcho')
+    expect(membership.group).to eql(group)
+    expect(membership.leader?).to be true
+  end
+
+  scenario 'Editing a job title', js: true do
+    person = create_person_in_digital_justice
+
+    javascript_log_in
+    visit edit_person_path(person)
+    click_link 'Edit'
+
+    fill_in 'Job title', with: 'Head Honcho'
+    click_button 'Update'
+
+    membership = Peoplefinder::Person.last.memberships.last
+    expect(membership.role).to eql('Head Honcho')
+  end
+
+  scenario 'Adding an additional role', js: true do
+    person = create_person_in_digital_justice
+    create(:group, name: 'Communications')
+
+    javascript_log_in
+    visit edit_person_path(person)
+
+    click_link('Add new role')
+    sleep 1
+
+    within all('#memberships .membership').last do
+      click_in_org_browser 'Communications'
+      fill_in 'Job title', with: 'Talker'
+    end
+
+    click_button 'Update'
+    expect(Peoplefinder::Person.last.memberships.length).to eql(2)
+  end
+
+  scenario 'Clicking the add another role link', js: true do
+    create(:group)
+
+    javascript_log_in
+    visit new_person_path
+
+    click_link('Add new role')
+    expect(page).to have_selector('#memberships .membership', count: 2)
+
+    click_link('Delete', match: :first)
+    expect(page).to have_selector('#memberships .membership', count: 1)
+  end
+
+  scenario 'Removing a group' do
+    person = create_person_in_digital_justice
+
+    visit edit_person_path(person)
+
+    within('#memberships') do
+      click_link('Delete')
+    end
+    expect(page).to have_content("Removed #{ person.name } from Digital Justice")
+    expect(person.reload.memberships).to be_empty
+    expect(current_path).to eql(edit_person_path(person))
+  end
+end
+
+def create_person_in_digital_justice
+  department = create(:department, name: 'Digital Justice')
+  group = create(:group, name: 'Digital Justice', parent: department)
+  person = create(:person)
+  person.memberships.create(group: group)
+  person
+end