pennmarc 1.4.5 → 1.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '081d17dd7ed356e36a029c244a36c6c8a5e1fd5670e17b8b13af945a888f9465'
-  data.tar.gz: e49fdb730bb47d7afeab2ed4ed47dba4fd8fa11f4c2b88d02b109d7c0a22a892
+  metadata.gz: e7fc0d8c3919655fd8c163b6cbe4da2b38e2988238532fe24dc8f62d784fb5ab
+  data.tar.gz: a9a907d91af9f7cffb42147803137bb9d7bca7cdc553a749575684bc3b96381b
 SHA512:
-  metadata.gz: 66241f9ba06920b4563d1a20d2f219f8b7327b406a7dab717e392975410d4952781d94a5fafec5de0487fe8d0524cd73adc218c9d634ee3dba56e65a430e8738
-  data.tar.gz: e8c43cb88c4dedfb0e63e523c8ccbc88bf47448dc3ed190bb61ac3ec8244be1d9a4bd87d505c6ce7769962005602170889d8d02511d160cbf446fcd075da5c60
+  metadata.gz: ffe68635b6ccb154b26edb8cc65a381fff97db77d284a20b8d5643d96895288d6e0caae592a2ae897d500bcdfd1b3a0c2fb9df5c8abcf3809010a9c146ec5dbf
+  data.tar.gz: '09cf7165edcf2031a921517dd4cdb9364faed586a53c88f9fde8d6e0d79d4fefe7ba8a5a2e4ca7f69cf50dfef22e82b3fc4001d0a64c39c520f8f71ebae4f5ab'

data/lib/pennmarc/helpers/genre.rb

@@ -43,18 +43,13 @@ module PennMARC
         }.uniq
       end
 
-      # Genre values for faceting. We only set Genre facet values for movies (videos) and manuscripts(?), and ensure
-      # that the headings come from our set of approved ontologies.
+      # Genre values for faceting.
+      # @note Prior to 5/2026, we only set Genre facet values for movies (videos) and manuscripts.
       # @todo the Genre facet in Franklin is pretty ugly. It could be cleaned up by limiting the subfields included
       #       here and cleaning up punctuation.
       # @param record [MARC::Record]
       # @return [Array<String>]
       def facet(record)
-        format_code = record.leader[6] || ' '
-        manuscript = Format.include_manuscripts?(format_code)
-        video = record.fields('007').any? { |field| field.value.starts_with? 'v' }
-        return [] unless manuscript || video
-
         record.fields('655').filter_map { |field|
           next unless allowed_genre_field?(field)
 

data/lib/pennmarc/mappings/locations.yml

@@ -317,7 +317,7 @@ cjsfol:
   library: Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Stacks Folio
 cjsgf:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
@@ -338,7 +338,7 @@ cjshur:
   display: Library at the Katz Center - Hurowitz Collection
   aeon: true
 cjsincun:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
@@ -351,7 +351,7 @@ cjsinproc:
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Processing
 cjsinprocn:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
@@ -407,77 +407,77 @@ cjspergal:
   library: Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Periodicals Gallery
 cjsrar:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
-  display: Library at the Katz Center - Rare Book Room
+  display: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   aeon: true
 cjsraram:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Americana
   aeon: true
 cjsrarbx1:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Box 1
   aeon: true
 cjsrarbx2:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Box 2
   aeon: true
 cjsrarbx3:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Box 3
   aeon: true
 cjsrarbx4:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Box 4
   aeon: true
 cjsrarfol:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Folio
   aeon: true
 cjsrargiga:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Giant
   aeon: true
 cjsrarmini:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Miniature
   aeon: true
 cjsrarms:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Rare Book Manuscript
   aeon: true
 cjsrarover:
-  specific_location: Library at the Katz Center - Rare Book Room
+  specific_location: Library at the Katz Center - Ione Apfelbaum & Hilary Strauss Rare Book Room
   library:
     - Special Collections
     - Library at the Katz Center for Advanced Judaic Studies
@@ -1384,12 +1384,11 @@ scteer:
   display: Kislak Center for Special Collections - Teerink Collection
   aeon: true
 sctehon:
-  specific_location: Kislak Center for Special Collections - Tehon Collection
+  specific_location: LIBRA - Tehon Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Tehon Collection
+    - LIBRA
+  display: LIBRA - Tehon Collection
   aeon: true
 sctress:
   specific_location: Kislak Center for Special Collections - Arthur Tress Collection

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.4.5'
+  VERSION = '1.4.6'
 end

data/spec/lib/pennmarc/helpers/genre_spec.rb

@@ -42,44 +42,17 @@ describe 'PennMARC::Genre' do
 
   describe '.facet' do
     let(:values) { helper.facet(record) }
-
-    context 'with a non-video, non-manuscript record' do
-      let(:fields) do
-        [marc_control_field(tag: '007', value: 'x'),
-         marc_field(tag: 'hld', subfields: { c: 'vanp' }),
-         marc_field(tag: '655', indicator2: '0', subfields: { a: 'Genre.' })]
-      end
-
-      it 'returns no genre values for faceting' do
-        expect(values).to be_empty
-      end
-    end
-
-    context 'with a video record' do
-      let(:fields) do
-        [marc_control_field(tag: '007', value: 'v'),
-         marc_field(tag: 'hld', subfields: { c: 'vanp' }),
-         marc_field(tag: '655', indicator2: '0', subfields: { a: 'Documentary films' }),
-         marc_field(tag: '655', indicator2: '7', subfields: { a: 'Sports', '2': 'fast' }),
-         marc_field(tag: '655', indicator2: '7', subfields: { a: 'Le cyclisme', '2': 'qlsp' }), # excluded due to sf2
-         marc_field(tag: '655', indicator2: '1', subfields: { a: 'Shredding' })] # excluded, invalid indicator value
-      end
-
-      it 'contains only the desired genre facet values' do
-        expect(values).to contain_exactly 'Documentary films', 'Sports'
-      end
+    let(:fields) do
+      [marc_control_field(tag: '007', value: 'v'),
+       marc_field(tag: 'hld', subfields: { c: 'vanp' }),
+       marc_field(tag: '655', indicator2: '0', subfields: { a: 'Documentary films' }),
+       marc_field(tag: '655', indicator2: '7', subfields: { a: 'Sports', '2': 'fast' }),
+       marc_field(tag: '655', indicator2: '7', subfields: { a: 'Le cyclisme', '2': 'qlsp' }), # excluded due to sf2
+       marc_field(tag: '655', indicator2: '1', subfields: { a: 'Shredding' })] # excluded, invalid indicator value
     end
 
-    context 'with a manuscript record' do
-      let(:record) { marc_record fields: fields, leader: '      t' }
-      let(:fields) do
-        [marc_control_field(tag: '007', value: 'x'),
-         marc_field(tag: '655', indicator2: '7', subfields: { a: 'Astronomy', '2': 'fast' })]
-      end
-
-      it 'returns the expected genre values' do
-        expect(values).to contain_exactly 'Astronomy'
-      end
+    it 'contains only the genre facet values from approved ontologies' do
+      expect(values).to contain_exactly 'Documentary films', 'Sports'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.4.5
+  version: 1.4.6
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-15 00:00:00.000000000 Z
+date: 2026-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport