pennmarc 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea8b17f4fa038de9e5c44d384b82dfce5cc7a6cb909a5dc63fa1080351096e69
-  data.tar.gz: 58c48f68947d697689499018ca2abdc89d791db97e0ee076b74a12bf161d4470
+  metadata.gz: 81ebb88f882d1b92922aa5dc7338056b6831d4857f91ba1ed1710deb2b678f09
+  data.tar.gz: 9db8caa363ce8ab4515d62612e033c4e73c185fef68c2a5c115a3520928f95b8
 SHA512:
-  metadata.gz: dad1e73ee44fa2635d81c6e0f1b7abc54d648b81679298121e6358c92f6872bf2f22d87f493005dad17b94402166cecb5c4751b3da33ae3a8ca35d90bc283e56
-  data.tar.gz: a23a12db492f9449632cfba5c7d1d247ab8302ede1094ac12ed0ff175f796787a2fa99dc9b17672d35ff67747523d9b4e40b31be7b602d910ae9a220d8f572a3
+  metadata.gz: d3a18e0ff157bdecd8a10cad8c72c4aeffece93dc06117740fb122e27ff972f5940f45b332c8bb3d6d57b05cff2c7b610fc57487b9ce7ae38700df96ca077764
+  data.tar.gz: 0cb04ac15f6f5aa1f7c86005b953bd86e5c952ab2de99479d04688d131bff991ec3a2bbe17a3cf2707bcfa613c71ed8beb2711951c5868c0d5cd4e240d0fca5a

data/lib/pennmarc/helpers/note.rb

@@ -156,7 +156,7 @@ module PennMARC
         system_details_notes += record.fields(%w[344 880]).filter_map do |field|
           next if field.tag == '880' && no_subfield_value_matches?(field, '6', /^344/)
 
-          sub3_and_other_subs(field, &subfield_in?(%w[a b c d e f g h]))
+          sub3_and_other_subs(field, &subfield_in?(%w[a b c d e f g h i j]))
         end
         system_details_notes += record.fields(%w[345 346 880]).filter_map do |field|
           next if field.tag == '880' && no_subfield_value_matches?(field, '6', /^(345|346)/)

data/lib/pennmarc/helpers/title.rb

@@ -77,7 +77,7 @@ module PennMARC
       # @return [Array<String>] array of auxiliary title values for search
       def search_aux(record)
         values = search_aux_values(record: record, title_type: :main, &subfield_not_in?(%w[c 6 8])) +
-                 search_aux_values(record: record, title_type: :related, &subfield_not_in?(%w[s t])) +
+                 search_aux_values(record: record, title_type: :related, &subfield_in?(%w[s t])) +
                  search_aux_values(record: record, title_type: :entity, &subfield_in?(%w[t])) +
                  search_aux_values(record: record, title_type: :note, &subfield_in?(%w[t]))
         values.uniq
@@ -105,7 +105,7 @@ module PennMARC
       # @return [Array<String>] auxiliary journal title information for search
       def journal_search_aux(record)
         values = search_aux_values(record: record, title_type: :main, journal: true, &subfield_not_in?(%w[c 6 8])) +
-                 search_aux_values(record: record, title_type: :related, journal: true, &subfield_not_in?(%w[s t])) +
+                 search_aux_values(record: record, title_type: :related, journal: true, &subfield_in?(%w[s t])) +
                  search_aux_values(record: record, title_type: :entity, journal: true, &subfield_in?(%w[t])) +
                  search_aux_values(record: record, title_type: :note, journal: true, &subfield_in?(%w[t]))
         values.uniq

data/lib/pennmarc/util.rb

@@ -147,7 +147,7 @@ module PennMARC
       string.strip
     end
 
-    # @param trailer [Symbol|String] to target for removal
+    # @param trailer [Symbol, String] to target for removal
     # @param string [String] to modify
     # @return [String]
     def trim_trailing(trailer, string)

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.4.0'
+  VERSION = '1.4.1'
 end

data/spec/lib/pennmarc/helpers/note_spec.rb

@@ -224,89 +224,90 @@ describe 'PennMARC::Note' do
       expect(values).to contain_exactly('An Abstract Additional Summary ProQuest',
                                         'Alt Abstract Alt Additional Summary Alt ProQuest')
     end
+  end
 
-    describe '.arrangement_show' do
-      let(:record) { marc_record(fields: fields) }
+  describe '.arrangement_show' do
+    let(:record) { marc_record(fields: fields) }
 
-      let(:fields) do
-        [
-          marc_field(tag: '351', subfields: { a: 'Organized into five subseries', b: 'Arrangement pattern', c: 'Series',
-                                              '3': 'materials' }),
-          marc_field(tag: '880', subfields: { a: 'Alt organization', b: 'Alt arrangement', c: 'Alt hierarchical level',
-                                              '3': 'Alt materials', '6': '351' })
-        ]
-      end
+    let(:fields) do
+      [
+        marc_field(tag: '351', subfields: { a: 'Organized into five subseries', b: 'Arrangement pattern', c: 'Series',
+                                            '3': 'materials' }),
+        marc_field(tag: '880', subfields: { a: 'Alt organization', b: 'Alt arrangement', c: 'Alt hierarchical level',
+                                            '3': 'Alt materials', '6': '351' })
+      ]
+    end
 
-      let(:values) { helper.arrangement_show(record) }
+    let(:values) { helper.arrangement_show(record) }
 
-      it 'returns expected values from 351 and its linked alternate' do
-        expect(values).to contain_exactly('Organized into five subseries Arrangement pattern Series materials',
-                                          'Alt organization Alt arrangement Alt hierarchical level Alt materials')
-      end
+    it 'returns expected values from 351 and its linked alternate' do
+      expect(values).to contain_exactly('Organized into five subseries Arrangement pattern Series materials',
+                                        'Alt organization Alt arrangement Alt hierarchical level Alt materials')
     end
+  end
 
-    describe '.system_details_show' do
-      let(:record) { marc_record(fields: fields) }
-
-      let(:fields) do
-        [
-          marc_field(tag: '538', subfields: { a: 'Blu-ray, region A, 1080p High Definition, full screen (1.33:1)',
-                                              i: 'display text for URI', u: 'http://www.universal.resource/locator ',
-                                              '3': ['Blu-ray disc.', '2015'] }),
-          marc_field(tag: '344', subfields: { a: 'digital', b: 'optical', c: '1.4 m/s', g: 'stereo',
-                                              h: 'digital recording', '3': 'audio disc' }),
-          marc_field(tag: '345', subfields: { a: '1 film reel (25 min.)', b: '24 fps', '3': 'Polyester print' }),
-          marc_field(tag: '346', subfields: { a: 'VHS', b: 'NTSC', '3': 'original videocassette' }),
-          marc_field(tag: '347', subfields: { a: 'video file', b: 'DVD video', e: 'region', '3': 'DVD' }),
-          marc_field(tag: '880', subfields: { a: 'Alt system details', i: 'Alternative display text', u: 'Alt URI',
-                                              '3': 'Alt materials.', '6': '538' }),
-          marc_field(tag: '880', subfields: { a: 'Alt recording', b: 'Alt medium', c: 'Alt playing speed',
-                                              g: 'Alt channel',
-                                              h: 'Alt characteristic', '3': 'Alt materials.',
-                                              '6': '344' }),
-          marc_field(tag: '880', subfields: { a: 'Alt presentation format', b: 'Alt projection speed',
-                                              '3': 'Alt materials.', '6': '345' }),
-          marc_field(tag: '880', subfields: { a: 'Alt video format', b: 'Alt broadcast', '3': 'Alt materials.',
-                                              '6': '346' }),
-          marc_field(tag: '880', subfields: { a: 'Alt file type', b: 'Alt encoding', '3': 'Alt materials.',
-                                              '6': '347-02' })
-
-        ]
-      end
+  describe '.system_details_show' do
+    let(:record) { marc_record(fields: fields) }
 
-      let(:values) { helper.system_details_show(record) }
+    let(:fields) do
+      [
+        marc_field(tag: '538', subfields: { a: 'Blu-ray, region A, 1080p High Definition, full screen (1.33:1)',
+                                            i: 'display text for URI', u: 'http://www.universal.resource/locator ',
+                                            '3': ['Blu-ray disc.', '2015'] }),
+        marc_field(tag: '344', subfields: { a: 'digital', b: 'optical', c: '1.4 m/s', g: 'stereo',
+                                            h: 'digital recording', i: 'sound', j: 'Electrical capture',
+                                            '3': 'audio disc' }),
+        marc_field(tag: '345', subfields: { a: '1 film reel (25 min.)', b: '24 fps', '3': 'Polyester print' }),
+        marc_field(tag: '346', subfields: { a: 'VHS', b: 'NTSC', '3': 'original videocassette' }),
+        marc_field(tag: '347', subfields: { a: 'video file', b: 'DVD video', e: 'region', '3': 'DVD' }),
+        marc_field(tag: '880', subfields: { a: 'Alt system details', i: 'Alternative display text', u: 'Alt URI',
+                                            '3': 'Alt materials.', '6': '538' }),
+        marc_field(tag: '880', subfields: { a: 'Alt recording', b: 'Alt medium', c: 'Alt playing speed',
+                                            g: 'Alt channel',
+                                            h: 'Alt characteristic', '3': 'Alt materials.',
+                                            '6': '344' }),
+        marc_field(tag: '880', subfields: { a: 'Alt presentation format', b: 'Alt projection speed',
+                                            '3': 'Alt materials.', '6': '345' }),
+        marc_field(tag: '880', subfields: { a: 'Alt video format', b: 'Alt broadcast', '3': 'Alt materials.',
+                                            '6': '346' }),
+        marc_field(tag: '880', subfields: { a: 'Alt file type', b: 'Alt encoding', '3': 'Alt materials.',
+                                            '6': '347-02' })
 
-      it 'returns expected from 5xx and 3xx fields and their linked alternates' do
-        expect(values).to contain_exactly(
-          'Blu-ray disc: 2015 Blu-ray, region A, 1080p High Definition, full screen (1.33:1) display
+      ]
+    end
+    let(:values) { helper.system_details_show(record) }
+
+    it 'returns expected from 5xx and 3xx fields and their linked alternates' do
+      expect(values).to contain_exactly(
+        'Blu-ray disc: 2015 Blu-ray, region A, 1080p High Definition, full screen (1.33:1) display
 text for URI http://www.universal.resource/locator'.squish,
-          'audio disc digital optical 1.4 m/s stereo digital recording', 'Polyester print 1 film reel (25 min.) 24 fps',
-          'original videocassette VHS NTSC', 'DVD video file DVD video region',
-          'Alt materials Alt system details Alternative display text Alt URI',
-          'Alt materials Alt recording Alt medium Alt playing speed Alt channel Alt characteristic',
-          'Alt materials Alt presentation format Alt projection speed',
-          'Alt materials Alt video format Alt broadcast',
-          'Alt materials Alt file type Alt encoding'
-        )
-      end
+        'audio disc digital optical 1.4 m/s stereo digital recording sound Electrical capture',
+        'Polyester print 1 film reel (25 min.) 24 fps',
+        'original videocassette VHS NTSC', 'DVD video file DVD video region',
+        'Alt materials Alt system details Alternative display text Alt URI',
+        'Alt materials Alt recording Alt medium Alt playing speed Alt channel Alt characteristic',
+        'Alt materials Alt presentation format Alt projection speed',
+        'Alt materials Alt video format Alt broadcast',
+        'Alt materials Alt file type Alt encoding'
+      )
     end
+  end
 
-    describe '.bound_with_show' do
-      let(:record) { marc_record(fields: fields) }
+  describe '.bound_with_show' do
+    let(:record) { marc_record(fields: fields) }
 
-      let(:fields) do
-        [
-          marc_field(tag: '501', subfields: { a: 'With: Peer Gynt (Suite) no. 1-2 / Edvard Grieg' }),
-          marc_field(tag: '501', subfields: { a: 'With: Schumann, C. Romances, piano, op. 11. No. 2' })
-        ]
-      end
+    let(:fields) do
+      [
+        marc_field(tag: '501', subfields: { a: 'With: Peer Gynt (Suite) no. 1-2 / Edvard Grieg' }),
+        marc_field(tag: '501', subfields: { a: 'With: Schumann, C. Romances, piano, op. 11. No. 2' })
+      ]
+    end
 
-      let(:values) { helper.bound_with_show(record) }
+    let(:values) { helper.bound_with_show(record) }
 
-      it 'returns expected values' do
-        expect(values).to contain_exactly('With: Peer Gynt (Suite) no. 1-2 / Edvard Grieg',
-                                          'With: Schumann, C. Romances, piano, op. 11. No. 2')
-      end
+    it 'returns expected values' do
+      expect(values).to contain_exactly('With: Peer Gynt (Suite) no. 1-2 / Edvard Grieg',
+                                        'With: Schumann, C. Romances, piano, op. 11. No. 2')
     end
   end
 end

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -57,7 +57,8 @@ describe 'PennMARC::Title' do
     let(:fields) do
       [marc_field(tag: '130', subfields: { a: 'Uniform Title', c: '130 not included' }),
        marc_field(tag: '880', subfields: { '6': '130', a: 'Alternative Uniform Title' }),
-       marc_field(tag: '773', subfields: { a: 'Host Uniform Title', s: '773 not included' }),
+       marc_field(tag: '773', subfields: { a: 'Host Item - Main entry heading', s: 'Host Item - Uniform title',
+                                           t: 'Host Item - Title' }),
        marc_field(tag: '700', subfields: { t: 'Personal Entry Title', s: '700 not included' }),
        marc_field(tag: '505', subfields: { t: 'Invalid Formatted Contents Note Title' }, indicator1: 'invalid'),
        marc_field(tag: '505', subfields: { t: 'Formatted Contents Note Title', s: '505 not included' },
@@ -65,18 +66,18 @@ describe 'PennMARC::Title' do
     end
 
     it 'returns auxiliary titles' do
-      expect(helper.search_aux(record)).to contain_exactly('Uniform Title', 'Host Uniform Title',
-                                                           'Alternative Uniform Title', 'Personal Entry Title',
-                                                           'Formatted Contents Note Title')
+      expect(helper.search_aux(record)).to contain_exactly('Uniform Title', 'Alternative Uniform Title',
+                                                           'Host Item - Uniform title Host Item - Title',
+                                                           'Personal Entry Title', 'Formatted Contents Note Title')
     end
 
     context 'when the leader indicates the record is a serial' do
       let(:leader) { 'ZZZZZnasZa22ZZZZZzZZ4500' }
 
       it 'returns auxiliary titles' do
-        expect(helper.search_aux(record)).to contain_exactly('Uniform Title', 'Host Uniform Title',
-                                                             'Alternative Uniform Title', 'Personal Entry Title',
-                                                             'Formatted Contents Note Title')
+        expect(helper.search_aux(record)).to contain_exactly('Uniform Title', 'Alternative Uniform Title',
+                                                             'Host Item - Uniform title Host Item - Title',
+                                                             'Personal Entry Title', 'Formatted Contents Note Title')
       end
     end
   end
@@ -107,7 +108,8 @@ describe 'PennMARC::Title' do
     let(:fields) do
       [marc_field(tag: '130', subfields: { a: 'Uniform Title', c: '130 not included' }),
        marc_field(tag: '880', subfields: { '6': '130', a: 'Alternative Uniform Title' }),
-       marc_field(tag: '773', subfields: { a: 'Host Uniform Title', s: '773 not included' }),
+       marc_field(tag: '773', subfields: { a: 'Host Item - Main entry heading', s: 'Host Item - Uniform title',
+                                           t: 'Host Item - Title' }),
        marc_field(tag: '700', subfields: { t: 'Personal Entry Title', s: '700 not included' }),
        marc_field(tag: '505', subfields: { t: 'Invalid Formatted Contents Note Title' }, indicator1: 'invalid'),
        marc_field(tag: '505', subfields: { t: 'Formatted Contents Note Title', s: '505 not included' },
@@ -116,7 +118,8 @@ describe 'PennMARC::Title' do
 
     it 'returns auxiliary journal search titles' do
       expect(helper.journal_search_aux(record)).to contain_exactly('Uniform Title', 'Alternative Uniform Title',
-                                                                   'Host Uniform Title', 'Personal Entry Title',
+                                                                   'Host Item - Uniform title Host Item - Title',
+                                                                   'Personal Entry Title',
                                                                    'Formatted Contents Note Title')
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-31 00:00:00.000000000 Z
+date: 2025-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport