pennmarc 1.3.2 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b69f7173f51a48c0748bf1d537392c6bda0919312009c85bd70e603cf4cb0240
-  data.tar.gz: fa0e2d2c724e26734890fcc1fe4e20899a6141d0e0f0cdebe9e242b03070be35
+  metadata.gz: 3409e098b2447b1f3eb3295e8df39d2b3e5133a9594f93f0b017132700b3fdd6
+  data.tar.gz: 02a38f6ffff4ce8032b4f60e9bcc2de3945c14b8d249bf83e2ffff26cb8c1a60
 SHA512:
-  metadata.gz: 4ed0b2699d095d4f07483e38fd99d8bcc52d2fd69f8c6b94dfba410a8d6f42329dda379e7eb8809ec43687d8552cc38471f85859ff0d73c0888026845caed1e6
-  data.tar.gz: 62d4f90ff259a2188fc0cc5eee803cd18e9f1a83d15874de77ef956e6dd836ae6a822a433770c0e56e2f583c15f696919be30f7298c080b4404d27e3f247d245
+  metadata.gz: 7e3c34f9063ca03595f9e45adf23c4f8c4f27a369b874eaf9944ce11b60f16cf8298bfb7a169094c5fe9b6b1fc726eb68272b996085c5092a65d03bce9bde893
+  data.tar.gz: c304b6f45e769ecc13cb0b17230448a87d1f52b5fe496587663ed88383cc4a7288a4422dbca685c6229fee69fae8d6964ee9d332bb95c6aa0dd5e04ced5909b7

data/lib/pennmarc/helpers/access.rb

@@ -7,12 +7,15 @@ module PennMARC
     AT_THE_LIBRARY = 'At the library'
     HANDLE_BASE_URL = 'hdl.library.upenn.edu'
     COLENDA_BASE_URL = 'colenda.library.upenn.edu'
+    REQUIRED_ONLINE_MARC_INDICATOR_COUNT = 2
 
     class << self
       # Based on enhanced metadata fields added by Alma publishing process or API, determine if the record has
       # electronic access or has physical holdings, and is therefore "Online" or "At the library". If a record is "At
       # the library", but has a link to a finding aid in the 856 field (matching certain criteria), also add 'Online' as
       # an access method.
+      # Because Alma E-Collections don't return electronic inventory, check some MARC control fields and other fields
+      # for indicators of an online resource, but only if no other Online indicators are present.
       # @param record [MARC::Record]
       # @return [Array]
       def facet(record)
@@ -24,7 +27,7 @@ module PennMARC
         return values if values.size == 2 # return early if all values are already present
 
         # only check if ONLINE isn't already there
-        values << ONLINE if values.exclude?(ONLINE) && resource_link?(record)
+        values << ONLINE if values.exclude?(ONLINE) && marc_indicators?(record)
         values.uniq
       end
 
@@ -44,6 +47,24 @@ module PennMARC
         field.tag.in? [Enriched::Pub::PHYS_INVENTORY_TAG, Enriched::Api::PHYS_INVENTORY_TAG]
       end
 
+      # In order to determine if a record has Online access, we should also check some MARC fields. This is because the
+      # Alma inventory publishing process does not include tags for E-Collections associated with a record. Here we
+      # check for obvious indicators:
+      #  - a "Resource Link" matching certain criteria
+      #  - a field indicating that the record is part of our curated "Databases" collection
+      # If there's still no online access, check for at least two other positive indicators in other MARC control fields
+      # and other tags.
+      # @param record [MARC::Record]
+      # @return [Boolean]
+      def marc_indicators?(record)
+        return true if resource_link?(record) || electronic_database?(record)
+
+        [eresource_form?(record),
+         eresource_material_designation?(record),
+         online_computer_file_form?(record),
+         online_carrier_type?(record)].count(true) >= REQUIRED_ONLINE_MARC_INDICATOR_COUNT
+      end
+
       # Check if a record contains an 856 entry with a Penn Handle server link meeting these criteria:
       # 1. Indicator 1 is 4 (HTTP resource)
       # 2. Indicator 2 is NOT 2 (indicating the linkage is to a "related" thing)
@@ -58,6 +79,58 @@ module PennMARC
         record.fields('856').any? { |field| valid_resource_field?(field) }
       end
 
+      # Does the record have an 006 suggesting an electronic resource?
+      # Check position 6 "Form of item" for an `o` indicating "Online"
+      # @see https://www.loc.gov/marc/bibliographic/bd006.html
+      # @see https://www.loc.gov/marc/bibliographic/bd008c.html
+      # @param record [MARC::Record]
+      # @return [Boolean]
+      def eresource_form?(record)
+        return false unless field_defined?(record, '006')
+
+        record.fields('006').first.value[6] == 'o'
+      end
+
+      # Does the record have an 007 indicating an electronic resource?
+      # Check pos 0 for a `c` ("Electronic resource") and position 1 for an `r` ("Remote")
+      # @see https://www.loc.gov/marc/bibliographic/bd007c.html
+      # @param record [MARC::Record]
+      # @return [Boolean]
+      def eresource_material_designation?(record)
+        return false unless field_defined?(record, '007')
+
+        record.fields('007').first.value[0..1] == 'cr'
+      end
+
+      # Does the record have an 008 indicating an electronic resource?
+      # https://www.loc.gov/marc/bibliographic/bd008c.html
+      # @param record [MARC::Record]
+      # @return [Boolean]
+      def online_computer_file_form?(record)
+        return false unless field_defined?(record, '008')
+
+        record.fields('008').first.value[23] == 'o'
+      end
+
+      # Does the record have an 338 indicating an electronic resource?
+      # @see https://www.loc.gov/marc/bibliographic/bd338.html, https://www.loc.gov/standards/valuelist/rdacarrier.html
+      # @param record [MARC::Record]
+      # @return [Boolean]
+      def online_carrier_type?(record)
+        return false unless field_defined?(record, '338')
+
+        return false unless subfield_values_for(tag: '338', subfield: 'a', record: record).include?('online resource')
+
+        subfield_values_for(tag: '338', subfield: 'b', record: record).include?('cr')
+      end
+
+      # Databases are always electronic resources
+      # @param record [MARC::Record]
+      # @return [Boolean]
+      def electronic_database?(record)
+        Database.type_facet(record).any?
+      end
+
       # Check if a field contains valid resource
       # @param field [MARC::Field]
       # @return [Boolean]

data/lib/pennmarc/helpers/creator.rb

@@ -90,9 +90,10 @@ module PennMARC
       # @return [Array<String>] array of author/creator values for display
       def extended_show(record, relator_map: Mappers.relator)
         fields = record.fields(%w[100 700])
+        fields += record.fields('880').select { |field| subfield_value?(field, '6', /^(#{TAGS.join('|')})/) }
         fields.filter_map { |field|
-          # for 700 entries, only include ones with relator code ('4') = aut, or code 'e' = 'author'
-          next if field.tag == '700' && !(field['4']&.downcase == 'aut' || field['e']&.downcase&.start_with?('author'))
+          # for 700 and 880 entries, only include ones with relator code ('4') = aut, or code 'e' = 'author'
+          next if field.tag.in?(%w[700 880]) && !describes_author?(field)
 
           parse_show_value(field, relator_map: relator_map)
         }.uniq
@@ -106,7 +107,7 @@ module PennMARC
       def extended_show_facet_map(record, relator_map: Mappers.relator)
         creators = record.fields(%w[100 700]).filter_map do |field|
           # for 700 entries, only include ones with relator code ('4') = aut, or code 'e' = 'author'
-          next if field.tag == '700' && !(field['4']&.downcase == 'aut' || field['e']&.downcase&.start_with?('author'))
+          next if field.tag == '700' && !describes_author?(field)
 
           show = parse_show_value(field, relator_map: relator_map)
           facet = parse_facet_value(field, FACET_SOURCE_MAP[field.tag.to_i].chars)
@@ -313,6 +314,42 @@ module PennMARC
         }.uniq
       end
 
+      # Similar to contributor_show, excluding the authors included in extended_show
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
+      # @param name_only [Boolean]
+      # @param vernacular [Boolean]
+      # @return [Array<String>]
+      def contributor_noauthor_show(record, relator_map: Mappers.relator, name_only: false, vernacular: true)
+        contributor_fields = record.fields(CONTRIBUTOR_TAGS)
+
+        # Exclude the 700 authors and collect their linkages
+        excluded_linkages = []
+        filtered_fields = contributor_fields.reject do |f|
+          is_author = f.tag == '700' && (f['4']&.downcase == 'aut' || f['e']&.downcase&.start_with?('author'))
+          excluded_linkages << "700-#{f['6'].split('-').last}" if is_author && f['6']
+          is_author
+        end
+
+        # Add vernacular fields that are not excluded by checking the linkages
+        if vernacular
+          vernacular_fields = record.fields('880').select do |f|
+            CONTRIBUTOR_TAGS.any? { |tag| f['6']&.start_with?(tag) } && !excluded_linkages.include?(f['6'])
+          end
+          filtered_fields.concat(vernacular_fields)
+        end
+
+        sf = name_only ? %w[a] : CONTRIBUTOR_DISPLAY_SUBFIELDS
+
+        filtered_fields.filter_map { |field|
+          next if ['', ' ', '0'].exclude?(field.indicator2) && field.tag.in?(CONTRIBUTOR_TAGS)
+          next if subfield_defined? field, 'i'
+
+          contributor = join_subfields(field, &subfield_in?(sf))
+          append_relator(field: field, joined_subfields: contributor, relator_term_sf: 'e', relator_map: relator_map)
+        }.uniq
+      end
+
       private
 
       # @param record [MARC::Record]
@@ -429,6 +466,13 @@ module PennMARC
 
         append_relator(field: field, joined_subfields: conf, relator_term_sf: 'j', relator_map: relator_map)
       end
+
+      # Does the given field describe an author record, as indicated by the relator fields of sf 4 or sf e ?
+      # @param [MARC::Field] field
+      # @return [Boolean]
+      def describes_author?(field)
+        field['4']&.downcase == 'aut' || field['e']&.downcase&.start_with?('author')
+      end
     end
   end
 end

data/lib/pennmarc/mappings/locations.yml

@@ -66,10 +66,6 @@ carpco:
   library: Special Collections
   display: Carpenters' Company of the City and County of Philadelphia
   aeon: true
-catoffice:
-  specific_location: Athenaeum of Philadelphia - Cataloging Office
-  library: Athenaeum of Philadelphia
-  display: Athenaeum of Philadelphia - Cataloging Office
 circcoll:
   specific_location: Athenaeum of Philadelphia - Circulating Collection
   library: Athenaeum of Philadelphia
@@ -83,10 +79,6 @@ cidirbusrm:
   library: Athenaeum of Philadelphia
   display: Athenaeum of Philadelphia - City Directories Busch Room
   aeon: true
-collcare:
-  specific_location: Athenaeum of Philadelphia - Collections Care Manager
-  library: Athenaeum of Philadelphia
-  display: Athenaeum of Philadelphia - Collections Care Manager
 fic:
   specific_location: Athenaeum of Philadelphia - Fiction
   library: Athenaeum of Philadelphia
@@ -101,6 +93,10 @@ litaward:
   library: Athenaeum of Philadelphia
   display: Athenaeum of Philadelphia - Literary Award
   aeon: true
+lounge:
+  specific_location: Athenaeum of Philadelphia - Member Lounge
+  library: Athenaeum of Philadelphia
+  display: Athenaeum of Philadelphia - Member Lounge
 microfilm:
   specific_location: Athenaeum of Philadelphia - Microfilm
   library: Athenaeum of Philadelphia
@@ -124,11 +120,6 @@ rarecoll:
   library: Athenaeum of Philadelphia
   display: Athenaeum of Philadelphia - Rare Books Collection
   aeon: true
-reevecoll:
-  specific_location: Athenaeum of Philadelphia - Reeve Collection
-  library: Athenaeum of Philadelphia
-  display: Athenaeum of Philadelphia - Reeve Collection
-  aeon: true
 ref:
   specific_location: Athenaeum of Philadelphia - Reference
   library: Athenaeum of Philadelphia
@@ -289,13 +280,6 @@ cjsarcths:
     - Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Archives Thesis
   aeon: true
-cjsartif:
-  specific_location: Library at the Katz Center - Reading Room
-  library:
-    - Special Collections
-    - Library at the Katz Center for Advanced Judaic Studies
-  display: Library at the Katz Center - Artifacts
-  aeon: true
 cjsbox1:
   specific_location: Library at the Katz Center - Stacks
   library: Library at the Katz Center for Advanced Judaic Studies
@@ -308,22 +292,10 @@ cjsbox3:
   specific_location: Library at the Katz Center - Stacks
   library: Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Stacks Box 3
-cjsbox4:
-  specific_location: Library at the Katz Center - Stacks
-  library: Library at the Katz Center for Advanced Judaic Studies
-  display: Library at the Katz Center - Stacks Box 4
 cjscdrom:
   specific_location: Library at the Katz Center - Reading Room
   library: Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - CD-ROM
-cjscirc:
-  specific_location: Library at the Katz Center - Reading Room
-  library: Library at the Katz Center for Advanced Judaic Studies
-  display: Library at the Katz Center - Circulation
-cjscomp:
-  specific_location: Library at the Katz Center - Reading Room
-  library: Library at the Katz Center for Advanced Judaic Studies
-  display: Library at the Katz Center - Computer Room
 cjsdir:
   specific_location: Library at the Katz Center - Stacks
   library: Library at the Katz Center for Advanced Judaic Studies
@@ -434,10 +406,6 @@ cjspergal:
   specific_location: Library at the Katz Center - Reading Room
   library: Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Periodicals Gallery
-cjsperover:
-  specific_location: Library at the Katz Center - Stacks
-  library: Library at the Katz Center for Advanced Judaic Studies
-  display: Library at the Katz Center - Periodicals Oversize
 cjsrar:
   specific_location: Library at the Katz Center - Rare Book Room
   library:
@@ -527,12 +495,6 @@ cjsreffol+:
   specific_location: Library at the Katz Center - Reading Room
   library: Library at the Katz Center for Advanced Judaic Studies
   display: Library at the Katz Center - Reference Oversize
-cjsres:
-  specific_location: Library at the Katz Center - Reading Room
-  library:
-    - Library at the Katz Center for Advanced Judaic Studies
-    - Reserve
-  display: Library at the Katz Center - Reserves
 cjsspec:
   specific_location: Library at the Katz Center - Stacks
   library:
@@ -838,12 +800,7 @@ mideast:
   specific_location: Van Pelt - Stapleton Seminar Room
   library: Van Pelt-Dietrich Library Center
   display: Van Pelt - Stapleton Seminar Room (523)
-mideastres:
-  specific_location: Van Pelt - Middle East Seminar Reserve
-  library:
-    - Van Pelt-Dietrich Library Center
-    - Reserve
-  display: Van Pelt - Middle East Seminar Reserve
+
 mscirc:
   specific_location: Penn Museum Library - Circulation
   library: Penn Museum Library
@@ -970,12 +927,11 @@ newbofc:
     - 'Veterinary: du Pont Library (New Bolton)'
   display: 'Veterinary: du Pont Library (New Bolton) - Office'
 newbrare:
-  specific_location: Kislak Center for Special Collections - Fairman Rogers Collection
+  specific_location: LIBRA - Fairman Rogers Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Fairman Rogers Coll.
+    - LIBRA
+  display: LIBRA - Fairman Rogers Collection
   aeon: true
 newbrefe:
   specific_location: 'Veterinary: du Pont Library (New Bolton) - Reference'
@@ -1070,12 +1026,6 @@ sasiarefe:
   specific_location: Van Pelt - Govindaraju/Chandrasekhara South Asia Studies Seminar Room
   library: Van Pelt-Dietrich Library Center
   display: Van Pelt - Govindaraju/Chandrasekhara South Asia Studies Seminar Room (551)
-sasiarese:
-  specific_location: Van Pelt - South Asian Reserve
-  library:
-    - Van Pelt-Dietrich Library Center
-    - Reserve
-  display: Van Pelt - South Asia Reserve (551)
 scg123:
   specific_location: Kislak Center for Special Collections - Rare Book Collection
   library:
@@ -1085,20 +1035,18 @@ scg123:
   display: Kislak Center for Special Collections - Rare Book Collection 123
   aeon: true
 sc1100c:
-  specific_location: Kislak Center for Special Collections - 1100C Collection
+  specific_location: LIBRA - 1100C Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - 1100C Collection
+    - LIBRA
+  display: LIBRA - 1100C Collection
   aeon: true
 scadams:
-  specific_location: Kislak Center for Special Collections - Adams Collection
+  specific_location: LIBRA - Adams Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Adams Collection
+    - LIBRA
+  display: LIBRA - Adams Collection
   aeon: true
 scartbk:
   specific_location: Kislak Center for Special Collections - Artists' Books
@@ -1117,12 +1065,11 @@ scbanks:
   display: Kislak Center for Special Collections - Joanna Banks Collection
   aeon: true
 scblank:
-  specific_location: Kislak Center for Special Collections - Blank Collection
+  specific_location: LIBRA - Blank Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Blank Collection
+    - LIBRA
+  display: LIBRA - Blank Collection
   aeon: true
 scbyron:
   specific_location: Kislak Center for Special Collections - Byron Collection
@@ -1205,12 +1152,11 @@ scelz:
   display: Kislak Center for Special Collections - Elzevier Collection
   aeon: true
 scfast:
-  specific_location: Kislak Center for Special Collections - Fast Collection
+  specific_location: LIBRA - Fast Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Fast Collection
+    - LIBRA
+  display: LIBRA - Fast Collection
   aeon: true
 scforr:
   specific_location: Kislak Center for Special Collections - Forrest Collection
@@ -1253,20 +1199,18 @@ scfurnlib:
   display: Kislak Center for Special Collections - Furness Shakespeare Library (Van
     Pelt 628)
 scfurnst:
-  specific_location: Kislak Center for Special Collections - Furness Collection
+  specific_location: LIBRA - Furness Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Furness Storage
+    - LIBRA
+  display: LIBRA - Furness Storage
   aeon: true
 scgull:
-  specific_location: Kislak Center for Special Collections - Gulliver's Travels Collection
+  specific_location: LIBRA - Gulliver's Travels Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Gulliver's Travels Collection
+    - LIBRA
+  display: LIBRA - Gulliver's Travels Collection
   aeon: true
 scinc:
   specific_location: Kislak Center for Special Collections - Incunables
@@ -1309,12 +1253,11 @@ scmss:
   display: Kislak Center for Special Collections - Manuscripts
   aeon: true
 scmst:
-  specific_location: Kislak Center for Special Collections - Manuscripts Storage
+  specific_location: LIBRA - Manuscripts Storage
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Manuscripts Storage
+    - LIBRA
+  display: LIBRA - Manuscripts Storage
   aeon: true
 scmsw:
   specific_location: Kislak Center for Special Collections - Web
@@ -1367,12 +1310,11 @@ screfe:
   display: Kislak Center for Special Collections - Reference Collection
   aeon: true
 screfestor:
-  specific_location: Kislak Center for Special Collections - Reference Storage
+  specific_location: LIBRA - Reference Storage
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections Reference Storage
+    - LIBRA
+  display: LIBRA - Reference Storage
   aeon: true
 scschimmel:
   specific_location: Kislak Center for Special Collections - Schimmel Collection
@@ -1399,12 +1341,11 @@ scsmith:
   display: Kislak Center for Special Collections - E.F. Smith Collection
   aeon: true
 scsmithst:
-  specific_location: Kislak Center for Special Collections - E.F. Smith Collection
+  specific_location: LIBRA - E.F. Smith Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - E.F. Smith Collection Storage
+    - LIBRA
+  display: LIBRA - E.F. Smith Collection Storage
   aeon: true
 scsterne:
   specific_location: Kislak Center for Special Collections - Day Sterne Collection
@@ -1415,12 +1356,11 @@ scsterne:
   display: Kislak Center for Special Collections - Day Sterne Collection
   aeon: true
 scstor:
-  specific_location: Kislak Center for Special Collections - Rare Book Collection
+  specific_location: LIBRA - Rare Book Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Rare Book Collection Storage
+    - LIBRA
+  display: LIBRA - Rare Book Collection Storage
   aeon: true
 scstorvil:
   specific_location: LIBRA Vilain-Wieck Collection
@@ -1486,10 +1426,6 @@ stor:
   specific_location: LIBRA
   library: LIBRA
   display: LIBRA
-storcirc:
-  specific_location: LIBRA - Circulation
-  library: LIBRA
-  display: LIBRA - Circulation
 storcrstxt:
   specific_location: GIC Collection at Penn Libraries
   library:
@@ -1533,13 +1469,6 @@ scrunning:
     - LIBRA
   display: LIBRA Running Press Collection
   aeon: true
-storvilain:
-  specific_location: LIBRA Vilain-Wieck Collection
-  library: 
-    - Special Collections
-    - LIBRA
-  display: LIBRA Vilain-Wieck Collection
-  aeon: true
 univarch:
   specific_location: University Archives
   library: University Archives
@@ -1649,7 +1578,14 @@ veteresov:
     - 'Veterinary: Atwood Library (Campus)'
     - Reserve
   display: 'Veterinary: Atwood Library (Campus) - Reserve Oversize'
-vpexhibit:
+vetewellrm:
+  specific_location: 'Veterinary: Atwood Library (Campus)- Wellness Room'
+  library:
+    - Health Sciences Libraries
+    - Veterinary
+    - 'Veterinary: Atwood Library (Campus)'
+  display: 'Veterinary: Atwood Library (Campus)- Wellness Room'  
+vpexhibits:
   specific location: Van Pelt - Exhibits and Events
   library: Van Pelt-Dietrich Library Center
   display: Van Pelt - Exhibits and Events -- First Floor, Circulation Desk

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.3.2'
+  VERSION = '1.3.4'
 end

data/spec/lib/pennmarc/helpers/access_spec.rb

@@ -105,5 +105,64 @@ describe 'PennMARC::Access' do
         end
       end
     end
+
+    context 'with an electronic record but no electronic inventory provided' do
+      let(:record) { marc_record fields: fields }
+
+      context 'with physical inventory' do
+        let(:fields) do
+          [marc_field(tag: PennMARC::Enriched::Pub::PHYS_INVENTORY_TAG),
+           marc_field(tag: '944', subfields: { a: 'Database & Article Index',
+                                               b: 'Dictionaries and Thesauri (language based)' })]
+        end
+
+        it 'adds in additional Online access value' do
+          expect(helper.facet(record)).to contain_exactly PennMARC::Access::AT_THE_LIBRARY, PennMARC::Access::ONLINE
+        end
+      end
+
+      context 'with a 944 indicating an online database' do
+        let(:fields) do
+          [marc_field(tag: '944', subfields: { a: 'Database & Article Index',
+                                               b: 'Dictionaries and Thesauri (language based)' })]
+        end
+
+        it 'returns expected Online access value' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE)
+        end
+      end
+
+      context 'with a single MARC indicator check suggesting an online database' do
+        let(:fields) do
+          [marc_control_field(tag: '006', value: '      o    ')]
+        end
+
+        it 'does not return Online access value' do
+          expect(helper.facet(record)).not_to include PennMARC::Access::ONLINE
+        end
+      end
+
+      context 'with two MARC indicators suggesting an online database' do
+        let(:fields) do
+          [marc_control_field(tag: '006', value: '      o    '),
+           marc_control_field(tag: '007', value: 'cr')]
+        end
+
+        it 'returns expected Online access value' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE)
+        end
+      end
+
+      context 'with other two MARC indicators suggesting an online database' do
+        let(:fields) do
+          [marc_control_field(tag: '008', value: '970325c19959999nyuwr d o 0 2eng '),
+           marc_field(tag: '338', subfields: { a: 'online resource', b: 'cr' })]
+        end
+
+        it 'returns expected Online access value' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE)
+        end
+      end
+    end
   end
 end

data/spec/lib/pennmarc/helpers/creator_spec.rb

@@ -100,12 +100,12 @@ describe 'PennMARC::Creator' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Surname, Name', '0': 'http://cool.uri/12345', d: '1900-2000',
                                              e: 'author.', '4': 'http://cool.uri/vocabulary/relators/aut' }),
-         marc_field(tag: '880', subfields: { a: 'Surname, Alternative', '6': '100' })]
+         marc_field(tag: '880', subfields: { a: 'Surname, Alternative', e: 'author', '6': '100' })]
       end
 
-      it 'returns single author values with no URIs anywhere (the same as show)' do
+      it 'returns single author values and linked alternate with no URIs anywhere (the same as show)' do
         values = helper.extended_show(record)
-        expect(values).to contain_exactly 'Surname, Name 1900-2000, author.'
+        expect(values).to contain_exactly 'Surname, Name 1900-2000, author.', 'Surname, Alternative, author.'
         expect(values.join.downcase).not_to include 'http'
       end
     end
@@ -478,7 +478,7 @@ describe 'PennMARC::Creator' do
   describe '.contributor_show' do
     let(:record) { marc_record fields: fields }
 
-    context 'when idicator2 is "1"' do
+    context 'when indicator2 is "1"' do
       let(:fields) do
         [marc_field(tag: '700', subfields: { a: 'Ignore' }, indicator2: '1')]
       end
@@ -554,4 +554,184 @@ describe 'PennMARC::Creator' do
       end
     end
   end
+
+  describe '.contributor_noauthor_show' do
+    let(:record) { marc_record fields: fields }
+
+    context 'when indicator2 is "1"' do
+      let(:fields) do
+        [marc_field(tag: '700', subfields: { a: 'Ignore' }, indicator2: '1')]
+      end
+
+      it 'ignores the field' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to be_empty
+      end
+    end
+
+    context 'with subfield "i"' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { i: 'Ignore', e: 'author' }),
+          marc_field(tag: '880', subfields: { i: 'Ignore', '6': '700' })
+        ]
+      end
+
+      it 'ignores the field' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to be_empty
+      end
+    end
+
+    context 'with a single contributor and linked alternate' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { a: 'Name', b: 'I', c: 'laureate', d: '1968', e: 'author',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'aut' }),
+          marc_field(tag: '880', subfields: {  '6': '700', a: 'Alt Name', b: 'Alt num', c: 'Alt title',
+                                               d: 'Alt date', e: 'Alt relator', j: 'Alt qualifier',
+                                               q: 'Alt Fuller Name', u: 'Alt affiliation', '3': 'Alt material' })
+        ]
+      end
+
+      it 'returns the non-author contributor only' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to contain_exactly(
+          'Alt Name Alt num Alt title Alt date Alt qualifier Alt Fuller Name Alt affiliation Alt material, Alt relator.'
+        )
+      end
+
+      it 'returns the non-author contributor name only when called with name_only as true' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, name_only: true)
+        expect(values).to contain_exactly 'Alt Name, Alt relator.'
+      end
+
+      it 'returns empty when called with vernacular as false' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, vernacular: false)
+        expect(values).to be_empty
+      end
+    end
+
+    context 'with four contributors two of which are authors' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { a: '01 (Ignore)', b: 'I', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'aut', '6': '880-01' }),
+          marc_field(tag: '700', subfields: { a: '02 (Ignore)', d: '1968', e: 'author',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-02' }),
+          marc_field(tag: '700', subfields: { a: '03 (Show)', b: 'J', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'edt', '6': '880-03' }),
+          marc_field(tag: '700', subfields: { a: '04 (Show)', d: '1968', e: 'editor',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-04' })
+        ]
+      end
+
+      it 'returns two non-author contributors' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.'
+        )
+      end
+
+      it 'returns contributor name only when called with name_only as true' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, name_only: true)
+        expect(values).to contain_exactly('03 (Show)', '04 (Show), editor.')
+      end
+
+      it 'returns contributor values without alternatives when called with vernacular as false' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, vernacular: false)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.'
+        )
+      end
+    end
+
+    context 'with four contributors having respective alternatives, two of the contributors are authors' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { a: '01 (Ignore)', b: 'I', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'aut', '6': '880-01' }),
+          marc_field(tag: '700', subfields: { a: '02 (Ignore)', d: '1968', e: 'author',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-02' }),
+          marc_field(tag: '700', subfields: { a: '03 (Show)', b: 'J', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'edt', '6': '880-03' }),
+          marc_field(tag: '700', subfields: { a: '04 (Show)', d: '1968', e: 'editor',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-04' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 01 (Ignore)', '6': '700-01', b: 'Alt num 01',
+                                              c: 'Alt title 01', d: 'Alt date 01', e: 'Alt relator 01',
+                                              j: 'Alt qualifier 01', q: 'Alt Fuller Name 01', u: 'Alt affiliation 01',
+                                              '3': 'Alt material 01' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 02 (Ignore)', '6': '700-02', b: 'Alt num 02',
+                                              c: 'Alt title 02', d: 'Alt date 02', e: 'Alt relator 02',
+                                              j: 'Alt qualifier 02', q: 'Alt Fuller Name 02', u: 'Alt affiliation 02',
+                                              '3': 'Alt material 02' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 03 (Show)', '6': '700-03', b: 'Alt num 03',
+                                              c: 'Alt title 03', d: 'Alt date 03', e: 'Alt relator 03',
+                                              j: 'Alt qualifier 03', q: 'Alt Fuller Name 03', u: 'Alt affiliation 03',
+                                              '3': 'Alt material 03' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 04 (Show)', '6': '700-04', b: 'Alt num 04',
+                                              c: 'Alt title 04', d: 'Alt date 04', e: 'Alt relator 04',
+                                              j: 'Alt qualifier 04', q: 'Alt Fuller Name 04', u: 'Alt affiliation 04',
+                                              '3': 'Alt material 04' })
+        ]
+      end
+
+      it 'returns two non-author contributors with their alternatives' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.',
+          'Alt Name 03 (Show) Alt num 03 Alt title 03 Alt date 03 Alt qualifier 03 Alt Fuller Name 03 '\
+            'Alt affiliation 03 Alt material 03, Alt relator 03.',
+          'Alt Name 04 (Show) Alt num 04 Alt title 04 Alt date 04 Alt qualifier 04 Alt Fuller Name 04 '\
+            'Alt affiliation 04 Alt material 04, Alt relator 04.'
+        )
+      end
+
+      it 'returns two non-author contributors name and alternative names only when called with name_only as true' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, name_only: true)
+        expect(values).to contain_exactly('03 (Show)', 'Alt Name 03 (Show), Alt relator 03.',
+                                          '04 (Show), editor.', 'Alt Name 04 (Show), Alt relator 04.')
+      end
+
+      it 'returns two non-author contributors without alternatives when called with vernacular as false' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, vernacular: false)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.'
+        )
+      end
+    end
+
+    context 'with a corporate contributor and linked alternate' do
+      let(:fields) do
+        [
+          marc_field(tag: '710', subfields: { a: 'Corporation', b: 'A division', c: 'Office', d: '1968', e: 'author',
+                                              u: 'affiliation', '3': 'materials', '4': 'aut' }),
+          marc_field(tag: '880', subfields: { '6': '710', a: 'Alt Corp Name', b: 'Alt unit', c: 'Alt location',
+                                              d: 'Alt date', e: ['Alt relator', 'another'], u: 'Alt Affiliation',
+                                              '3': 'Alt materials' })
+        ]
+      end
+
+      it 'returns expected contributor values' do
+        values = helper.contributor_noauthor_show(record)
+        expect(values).to contain_exactly(
+          'Corporation A division Office 1968 affiliation materials, Author.',
+          'Alt Corp Name Alt unit Alt location Alt date Alt Affiliation Alt materials, Alt relator, another.'
+        )
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.4
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-22 00:00:00.000000000 Z
+date: 2025-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport