pennmarc 1.3.1 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce41a1f1d20b337d09c9efe7864702f2991fea918aadfaf2094e9a87c1291e47
-  data.tar.gz: 1b65ac76d70e6e9e6b9bf5c60d7bd9cfa3b352a2292486fb7e1668662bf81d9d
+  metadata.gz: cb5991760f2f82ed299e5602451881e8b71a88fec9cae1f570afe8e5c90d56f9
+  data.tar.gz: d0fa00068ed63eb1ea9de2127f706c4076b56eb567ac29fc0e88c77a74b5605d
 SHA512:
-  metadata.gz: 6c094891accf90519201927873b4e711b649efee1ab191118d541b9a733ecb573b1c0719306c1a958056f461947279312bed0b4950438bf23c91c437b7c251e7
-  data.tar.gz: c5578566958775705e86f5be697558468a061e089a361ab1629fa4aaa45758d1fb56970c6651a0bcbd5539c71e6802c61bc2b88b1ade7953ba06a395e2f9d442
+  metadata.gz: edff4fba2a3e3edf56b7e7fb79992f595becf46e588fa81cb4ed327153deacc6a4bf2c8b040808830f5963e2c64db8a6165bfbdcb04698884ac5ebe4b997d4f0
+  data.tar.gz: f3024891d0d48b13e18b3d25ec09e33c134cb77a152bb3849079589b893f99eef9489b8a81307cab14d941467d36242f829c0a9120d42b24064e862c9411fe80

data/lib/pennmarc/helpers/access.rb

@@ -5,7 +5,8 @@ module PennMARC
   class Access < Helper
     ONLINE = 'Online'
     AT_THE_LIBRARY = 'At the library'
-    RESOURCE_LINK_BASE_URL = 'hdl.library.upenn.edu'
+    HANDLE_BASE_URL = 'hdl.library.upenn.edu'
+    COLENDA_BASE_URL = 'colenda.library.upenn.edu'
 
     class << self
       # Based on enhanced metadata fields added by Alma publishing process or API, determine if the record has
@@ -46,7 +47,7 @@ module PennMARC
       # Check if a record contains an 856 entry with a Penn Handle server link meeting these criteria:
       # 1. Indicator 1 is 4 (HTTP resource)
       # 2. Indicator 2 is NOT 2 (indicating the linkage is to a "related" thing)
-      # 3. The URL specified in subfield u (URI) is a Penn Handle link
+      # 3. The URL specified in subfield u (URI) is a Penn Handle link or Penn Colenda link
       # 4. The subfield z does NOT include the string 'Finding aid'
       # See: https://www.loc.gov/marc/bibliographic/bd856.html
       # @note Some electronic records do not have Portfolios in Alma, so we rely upon the Resource Link in the 856 to
@@ -54,15 +55,19 @@ module PennMARC
       # @param record [MARC::Record]
       # @return [Boolean]
       def resource_link?(record)
-        record.fields('856').filter_map do |field|
-          next if field.indicator2 == '2' || field.indicator1 != '4'
+        record.fields('856').any? { |field| valid_resource_field?(field) }
+      end
+
+      # Check if a field contains valid resource
+      # @param field [MARC::Field]
+      # @return [Boolean]
+      def valid_resource_field?(field)
+        return false if field.indicator2 == '2' || field.indicator1 != '4'
+        return false if subfield_values(field, 'z')&.include?('Finding aid')
 
-          subz = subfield_values(field, 'z')
-          subfield_values(field, 'u').filter_map do |value|
-            return true if subz.exclude?('Finding aid') && value.include?(RESOURCE_LINK_BASE_URL)
-          end
+        subfield_values(field, 'u').any? do |value|
+          [HANDLE_BASE_URL, COLENDA_BASE_URL].any? { |url| value.include?(url) }
         end
-        false
       end
     end
   end

data/lib/pennmarc/helpers/creator.rb

@@ -85,28 +85,28 @@ module PennMARC
         creators.to_h { |h| [h[:show], h[:facet]] }
       end
 
-      # Show more credited authors - both 100 field and 700 entries where the relator term is aut
+      # Show more credited authors - both 100 field and 700 entries where the relator (codes e or 4) is author/aut
       # @param record [MARC::Record]
       # @return [Array<String>] array of author/creator values for display
       def extended_show(record, relator_map: Mappers.relator)
         fields = record.fields(%w[100 700])
         fields.filter_map { |field|
-          # for 700 entries, only include ones with relator code of aut
-          next if (field.tag == '700') && field['4']&.downcase != 'aut'
+          # for 700 entries, only include ones with relator code ('4') = aut, or code 'e' = 'author'
+          next if field.tag == '700' && !(field['4']&.downcase == 'aut' || field['e']&.downcase&.start_with?('author'))
 
           parse_show_value(field, relator_map: relator_map)
         }.uniq
       end
 
       # Hash with extended creators show values as the fields and the corresponding facet as the values.
-      # Only include 100, and 700 with relator of aut
+      # Only include 100, and 700 with relator (codes e or 4) of author/aut
       # @param record [MARC::Record]
       # @param relator_map [Hash]
       # @return [Hash]
       def extended_show_facet_map(record, relator_map: Mappers.relator)
         creators = record.fields(%w[100 700]).filter_map do |field|
-          # for 700 entries, only include ones with relator code of aut
-          next if (field.tag == '700') && field['4']&.downcase != 'aut'
+          # for 700 entries, only include ones with relator code ('4') = aut, or code 'e' = 'author'
+          next if field.tag == '700' && !(field['4']&.downcase == 'aut' || field['e']&.downcase&.start_with?('author'))
 
           show = parse_show_value(field, relator_map: relator_map)
           facet = parse_facet_value(field, FACET_SOURCE_MAP[field.tag.to_i].chars)
@@ -313,6 +313,42 @@ module PennMARC
         }.uniq
       end
 
+      # Similar to contributor_show, excluding the authors included in extended_show
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
+      # @param name_only [Boolean]
+      # @param vernacular [Boolean]
+      # @return [Array<String>]
+      def contributor_noauthor_show(record, relator_map: Mappers.relator, name_only: false, vernacular: true)
+        contributor_fields = record.fields(CONTRIBUTOR_TAGS)
+
+        # Exclude the 700 authors and collect their linkages
+        excluded_linkages = []
+        filtered_fields = contributor_fields.reject do |f|
+          is_author = f.tag == '700' && (f['4']&.downcase == 'aut' || f['e']&.downcase&.start_with?('author'))
+          excluded_linkages << "700-#{f['6'].split('-').last}" if is_author && f['6']
+          is_author
+        end
+
+        # Add vernacular fields that are not excluded by checking the linkages
+        if vernacular
+          vernacular_fields = record.fields('880').select do |f|
+            CONTRIBUTOR_TAGS.any? { |tag| f['6']&.start_with?(tag) } && !excluded_linkages.include?(f['6'])
+          end
+          filtered_fields.concat(vernacular_fields)
+        end
+
+        sf = name_only ? %w[a] : CONTRIBUTOR_DISPLAY_SUBFIELDS
+
+        filtered_fields.filter_map { |field|
+          next if ['', ' ', '0'].exclude?(field.indicator2) && field.tag.in?(CONTRIBUTOR_TAGS)
+          next if subfield_defined? field, 'i'
+
+          contributor = join_subfields(field, &subfield_in?(sf))
+          append_relator(field: field, joined_subfields: contributor, relator_term_sf: 'e', relator_map: relator_map)
+        }.uniq
+      end
+
       private
 
       # @param record [MARC::Record]

data/lib/pennmarc/mappings/locations.yml

@@ -101,6 +101,10 @@ litaward:
   library: Athenaeum of Philadelphia
   display: Athenaeum of Philadelphia - Literary Award
   aeon: true
+lounge:
+  specific_location: Athenaeum of Philadelphia - Member Lounge
+  library: Athenaeum of Philadelphia
+  display: Athenaeum of Philadelphia - Member Lounge
 microfilm:
   specific_location: Athenaeum of Philadelphia - Microfilm
   library: Athenaeum of Philadelphia
@@ -970,12 +974,11 @@ newbofc:
     - 'Veterinary: du Pont Library (New Bolton)'
   display: 'Veterinary: du Pont Library (New Bolton) - Office'
 newbrare:
-  specific_location: Kislak Center for Special Collections - Fairman Rogers Collection
+  specific_location: LIBRA - Fairman Rogers Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Fairman Rogers Coll.
+    - LIBRA
+  display: LIBRA - Fairman Rogers Collection
   aeon: true
 newbrefe:
   specific_location: 'Veterinary: du Pont Library (New Bolton) - Reference'
@@ -1085,20 +1088,18 @@ scg123:
   display: Kislak Center for Special Collections - Rare Book Collection 123
   aeon: true
 sc1100c:
-  specific_location: Kislak Center for Special Collections - 1100C Collection
+  specific_location: LIBRA - 1100C Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - 1100C Collection
+    - LIBRA
+  display: LIBRA - 1100C Collection
   aeon: true
 scadams:
-  specific_location: Kislak Center for Special Collections - Adams Collection
+  specific_location: LIBRA - Adams Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Adams Collection
+    - LIBRA
+  display: LIBRA - Adams Collection
   aeon: true
 scartbk:
   specific_location: Kislak Center for Special Collections - Artists' Books
@@ -1117,12 +1118,11 @@ scbanks:
   display: Kislak Center for Special Collections - Joanna Banks Collection
   aeon: true
 scblank:
-  specific_location: Kislak Center for Special Collections - Blank Collection
+  specific_location: LIBRA - Blank Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Blank Collection
+    - LIBRA
+  display: LIBRA - Blank Collection
   aeon: true
 scbyron:
   specific_location: Kislak Center for Special Collections - Byron Collection
@@ -1205,12 +1205,11 @@ scelz:
   display: Kislak Center for Special Collections - Elzevier Collection
   aeon: true
 scfast:
-  specific_location: Kislak Center for Special Collections - Fast Collection
+  specific_location: LIBRA - Fast Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Fast Collection
+    - LIBRA
+  display: LIBRA - Fast Collection
   aeon: true
 scforr:
   specific_location: Kislak Center for Special Collections - Forrest Collection
@@ -1253,20 +1252,18 @@ scfurnlib:
   display: Kislak Center for Special Collections - Furness Shakespeare Library (Van
     Pelt 628)
 scfurnst:
-  specific_location: Kislak Center for Special Collections - Furness Collection
+  specific_location: LIBRA - Furness Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Furness Storage
+    - LIBRA
+  display: LIBRA - Furness Storage
   aeon: true
 scgull:
-  specific_location: Kislak Center for Special Collections - Gulliver's Travels Collection
+  specific_location: LIBRA - Gulliver's Travels Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Gulliver's Travels Collection
+    - LIBRA
+  display: LIBRA - Gulliver's Travels Collection
   aeon: true
 scinc:
   specific_location: Kislak Center for Special Collections - Incunables
@@ -1309,12 +1306,11 @@ scmss:
   display: Kislak Center for Special Collections - Manuscripts
   aeon: true
 scmst:
-  specific_location: Kislak Center for Special Collections - Manuscripts Storage
+  specific_location: LIBRA - Manuscripts Storage
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Manuscripts Storage
+    - LIBRA
+  display: LIBRA - Manuscripts Storage
   aeon: true
 scmsw:
   specific_location: Kislak Center for Special Collections - Web
@@ -1367,12 +1363,11 @@ screfe:
   display: Kislak Center for Special Collections - Reference Collection
   aeon: true
 screfestor:
-  specific_location: Kislak Center for Special Collections - Reference Storage
+  specific_location: LIBRA - Reference Storage
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections Reference Storage
+    - LIBRA
+  display: LIBRA - Reference Storage
   aeon: true
 scschimmel:
   specific_location: Kislak Center for Special Collections - Schimmel Collection
@@ -1399,12 +1394,11 @@ scsmith:
   display: Kislak Center for Special Collections - E.F. Smith Collection
   aeon: true
 scsmithst:
-  specific_location: Kislak Center for Special Collections - E.F. Smith Collection
+  specific_location: LIBRA - E.F. Smith Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - E.F. Smith Collection Storage
+    - LIBRA
+  display: LIBRA - E.F. Smith Collection Storage
   aeon: true
 scsterne:
   specific_location: Kislak Center for Special Collections - Day Sterne Collection
@@ -1415,12 +1409,11 @@ scsterne:
   display: Kislak Center for Special Collections - Day Sterne Collection
   aeon: true
 scstor:
-  specific_location: Kislak Center for Special Collections - Rare Book Collection
+  specific_location: LIBRA - Rare Book Collection
   library:
     - Special Collections
-    - Kislak Center for Special Collections
-    - Van Pelt-Dietrich Library Center
-  display: Kislak Center for Special Collections - Rare Book Collection Storage
+    - LIBRA
+  display: LIBRA - Rare Book Collection Storage
   aeon: true
 scstorvil:
   specific_location: LIBRA Vilain-Wieck Collection
@@ -1649,6 +1642,13 @@ veteresov:
     - 'Veterinary: Atwood Library (Campus)'
     - Reserve
   display: 'Veterinary: Atwood Library (Campus) - Reserve Oversize'
+vetewellrm:
+  specific_location: 'Veterinary: Atwood Library (Campus)- Wellness Room'
+  library:
+    - Health Sciences Libraries
+    - Veterinary
+    - 'Veterinary: Atwood Library (Campus)'
+  display: 'Veterinary: Atwood Library (Campus)- Wellness Room'  
 vpexhibit:
   specific location: Van Pelt - Exhibits and Events
   library: Van Pelt-Dietrich Library Center

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.3.1'
+  VERSION = '1.3.3'
 end

data/spec/lib/pennmarc/helpers/access_spec.rb

@@ -44,7 +44,7 @@ describe 'PennMARC::Access' do
       end
     end
 
-    context 'with a record containing a link to a finding aid (as a handle link)' do
+    context 'with a record containing a link to an online resource' do
       let(:record) do
         marc_record fields: [marc_field(tag: PennMARC::Enriched::Pub::PHYS_INVENTORY_TAG),
                              marc_field(tag: '856', subfields: location_and_access_subfields, **indicators)]
@@ -72,7 +72,7 @@ describe 'PennMARC::Access' do
         end
       end
 
-      context 'with an 856 describing a resource link' do
+      context 'with an 856 describing a handle resource link' do
         let(:indicators) { { indicator1: '4', indicator2: '1' } }
         let(:location_and_access_subfields) do
           { z: 'Connect to resource', u: 'http://hdl.library.upenn.edu/1234' }
@@ -82,6 +82,28 @@ describe 'PennMARC::Access' do
           expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE, PennMARC::Access::AT_THE_LIBRARY)
         end
       end
+
+      context 'with an 856 describing a colenda resource link' do
+        let(:indicators) { { indicator1: '4', indicator2: '1' } }
+        let(:location_and_access_subfields) do
+          { z: 'Connect to resource', u: 'http://colenda.library.upenn.edu/1234' }
+        end
+
+        it 'includes online access' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE, PennMARC::Access::AT_THE_LIBRARY)
+        end
+      end
+
+      context 'with an 856 describing some other resource link' do
+        let(:indicators) { { indicator1: '4', indicator2: '1' } }
+        let(:location_and_access_subfields) do
+          { z: 'Connect to resource', u: 'http://vanpelt.upenn.edu/something' }
+        end
+
+        it 'does not includes online access' do
+          expect(helper.facet(record)).not_to include PennMARC::Access::ONLINE
+        end
+      end
     end
   end
 end

data/spec/lib/pennmarc/helpers/creator_spec.rb

@@ -114,13 +114,16 @@ describe 'PennMARC::Creator' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Surname, Name', '0': 'http://cool.uri/12345', d: '1900-2000',
                                              e: 'author.', '4': 'http://cool.uri/vocabulary/relators/aut' }),
-         marc_field(tag: '700', subfields: { a: 'Surname, Alternative', e: 'author', '6': '100', '4': 'aut' }),
+         marc_field(tag: '700', subfields: { a: 'Surname, Alternative', '6': '100', '4': 'aut' }),
+         marc_field(tag: '700', subfields: { a: 'Surname, Third', e: 'author.', '6': '100' }),
+         marc_field(tag: '700', subfields: { a: 'Surname, Ignore', e: 'editor.', '6': '100' }),
          marc_field(tag: '700', subfields: { a: 'Surname, Not Included', '6': '100', '4': 'edt' })]
       end
 
-      it 'returns two authors' do
+      it 'returns three authors' do
         values = helper.extended_show(record)
-        expect(values).to contain_exactly 'Surname, Name 1900-2000, author.', 'Surname, Alternative, Author.'
+        expect(values).to contain_exactly 'Surname, Name 1900-2000, author.',
+                                          'Surname, Alternative, Author.', 'Surname, Third, author.'
         expect(values.join.downcase).not_to include 'http'
       end
     end
@@ -475,7 +478,7 @@ describe 'PennMARC::Creator' do
   describe '.contributor_show' do
     let(:record) { marc_record fields: fields }
 
-    context 'when idicator2 is "1"' do
+    context 'when indicator2 is "1"' do
       let(:fields) do
         [marc_field(tag: '700', subfields: { a: 'Ignore' }, indicator2: '1')]
       end
@@ -551,4 +554,184 @@ describe 'PennMARC::Creator' do
       end
     end
   end
+
+  describe '.contributor_noauthor_show' do
+    let(:record) { marc_record fields: fields }
+
+    context 'when indicator2 is "1"' do
+      let(:fields) do
+        [marc_field(tag: '700', subfields: { a: 'Ignore' }, indicator2: '1')]
+      end
+
+      it 'ignores the field' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to be_empty
+      end
+    end
+
+    context 'with subfield "i"' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { i: 'Ignore', e: 'author' }),
+          marc_field(tag: '880', subfields: { i: 'Ignore', '6': '700' })
+        ]
+      end
+
+      it 'ignores the field' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to be_empty
+      end
+    end
+
+    context 'with a single contributor and linked alternate' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { a: 'Name', b: 'I', c: 'laureate', d: '1968', e: 'author',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'aut' }),
+          marc_field(tag: '880', subfields: {  '6': '700', a: 'Alt Name', b: 'Alt num', c: 'Alt title',
+                                               d: 'Alt date', e: 'Alt relator', j: 'Alt qualifier',
+                                               q: 'Alt Fuller Name', u: 'Alt affiliation', '3': 'Alt material' })
+        ]
+      end
+
+      it 'returns the non-author contributor only' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to contain_exactly(
+          'Alt Name Alt num Alt title Alt date Alt qualifier Alt Fuller Name Alt affiliation Alt material, Alt relator.'
+        )
+      end
+
+      it 'returns the non-author contributor name only when called with name_only as true' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, name_only: true)
+        expect(values).to contain_exactly 'Alt Name, Alt relator.'
+      end
+
+      it 'returns empty when called with vernacular as false' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, vernacular: false)
+        expect(values).to be_empty
+      end
+    end
+
+    context 'with four contributors two of which are authors' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { a: '01 (Ignore)', b: 'I', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'aut', '6': '880-01' }),
+          marc_field(tag: '700', subfields: { a: '02 (Ignore)', d: '1968', e: 'author',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-02' }),
+          marc_field(tag: '700', subfields: { a: '03 (Show)', b: 'J', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'edt', '6': '880-03' }),
+          marc_field(tag: '700', subfields: { a: '04 (Show)', d: '1968', e: 'editor',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-04' })
+        ]
+      end
+
+      it 'returns two non-author contributors' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.'
+        )
+      end
+
+      it 'returns contributor name only when called with name_only as true' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, name_only: true)
+        expect(values).to contain_exactly('03 (Show)', '04 (Show), editor.')
+      end
+
+      it 'returns contributor values without alternatives when called with vernacular as false' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, vernacular: false)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.'
+        )
+      end
+    end
+
+    context 'with four contributors having respective alternatives, two of the contributors are authors' do
+      let(:fields) do
+        [
+          marc_field(tag: '700', subfields: { a: '01 (Ignore)', b: 'I', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'aut', '6': '880-01' }),
+          marc_field(tag: '700', subfields: { a: '02 (Ignore)', d: '1968', e: 'author',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-02' }),
+          marc_field(tag: '700', subfields: { a: '03 (Show)', b: 'J', c: 'laureate',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '4': 'edt', '6': '880-03' }),
+          marc_field(tag: '700', subfields: { a: '04 (Show)', d: '1968', e: 'editor',
+                                              j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                              '6': '880-04' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 01 (Ignore)', '6': '700-01', b: 'Alt num 01',
+                                              c: 'Alt title 01', d: 'Alt date 01', e: 'Alt relator 01',
+                                              j: 'Alt qualifier 01', q: 'Alt Fuller Name 01', u: 'Alt affiliation 01',
+                                              '3': 'Alt material 01' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 02 (Ignore)', '6': '700-02', b: 'Alt num 02',
+                                              c: 'Alt title 02', d: 'Alt date 02', e: 'Alt relator 02',
+                                              j: 'Alt qualifier 02', q: 'Alt Fuller Name 02', u: 'Alt affiliation 02',
+                                              '3': 'Alt material 02' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 03 (Show)', '6': '700-03', b: 'Alt num 03',
+                                              c: 'Alt title 03', d: 'Alt date 03', e: 'Alt relator 03',
+                                              j: 'Alt qualifier 03', q: 'Alt Fuller Name 03', u: 'Alt affiliation 03',
+                                              '3': 'Alt material 03' }),
+          marc_field(tag: '880', subfields: { a: 'Alt Name 04 (Show)', '6': '700-04', b: 'Alt num 04',
+                                              c: 'Alt title 04', d: 'Alt date 04', e: 'Alt relator 04',
+                                              j: 'Alt qualifier 04', q: 'Alt Fuller Name 04', u: 'Alt affiliation 04',
+                                              '3': 'Alt material 04' })
+        ]
+      end
+
+      it 'returns two non-author contributors with their alternatives' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.',
+          'Alt Name 03 (Show) Alt num 03 Alt title 03 Alt date 03 Alt qualifier 03 Alt Fuller Name 03 '\
+            'Alt affiliation 03 Alt material 03, Alt relator 03.',
+          'Alt Name 04 (Show) Alt num 04 Alt title 04 Alt date 04 Alt qualifier 04 Alt Fuller Name 04 '\
+            'Alt affiliation 04 Alt material 04, Alt relator 04.'
+        )
+      end
+
+      it 'returns two non-author contributors name and alternative names only when called with name_only as true' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, name_only: true)
+        expect(values).to contain_exactly('03 (Show)', 'Alt Name 03 (Show), Alt relator 03.',
+                                          '04 (Show), editor.', 'Alt Name 04 (Show), Alt relator 04.')
+      end
+
+      it 'returns two non-author contributors without alternatives when called with vernacular as false' do
+        values = helper.contributor_noauthor_show(record, relator_map: mapping, vernacular: false)
+        expect(values).to contain_exactly(
+          '03 (Show) J laureate pseud Fuller Name affiliation materials',
+          '04 (Show) 1968 pseud Fuller Name affiliation materials, editor.'
+        )
+      end
+    end
+
+    context 'with a corporate contributor and linked alternate' do
+      let(:fields) do
+        [
+          marc_field(tag: '710', subfields: { a: 'Corporation', b: 'A division', c: 'Office', d: '1968', e: 'author',
+                                              u: 'affiliation', '3': 'materials', '4': 'aut' }),
+          marc_field(tag: '880', subfields: { '6': '710', a: 'Alt Corp Name', b: 'Alt unit', c: 'Alt location',
+                                              d: 'Alt date', e: ['Alt relator', 'another'], u: 'Alt Affiliation',
+                                              '3': 'Alt materials' })
+        ]
+      end
+
+      it 'returns expected contributor values' do
+        values = helper.contributor_noauthor_show(record)
+        expect(values).to contain_exactly(
+          'Corporation A division Office 1968 affiliation materials, Author.',
+          'Alt Corp Name Alt unit Alt location Alt date Alt Affiliation Alt materials, Alt relator, another.'
+        )
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.3
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-21 00:00:00.000000000 Z
+date: 2025-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport