pennmarc 1.2.10 → 1.2.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc38a9c6a1409bc4aaaec31b6b0b8384dbc1d4e3895e593d024ff941f6cbe518
-  data.tar.gz: 20ffa419ce3ed488e4b3ba57936ea4adda09b16582fccd1143b7bb9d0509e210
+  metadata.gz: ae49ee72edbf272cad930745a43e21b914e38d742478b7b63a6f37b8ee470389
+  data.tar.gz: c510b96f00fac2417444b504761fc8e9fa3d276f0f4493fd5c5f5fe225ae1ed6
 SHA512:
-  metadata.gz: a986b89add634ed795d3a2bac887618f1413f5d56f160b42134ca39d56626d5c159f8679dda9296ed7db2ae7e971d1383f9b414a61b654b6ca98e547835c6a0d
-  data.tar.gz: 3abd5a6471041195c79edf56454ff98530ece759d30a210688ed1894b42dcc986fe56dab672ee4e92df893d6ec81d06cd47dc1cc6daf6f542ad0dd4872cf1d90
+  metadata.gz: 6b669865747c50de240f48b528fefb6b81c9415706cb9ea899eca9310e21d71f80c29d76fbffa2875124f5818398c41cce0bd7afac336d3633844fc3e0447387
+  data.tar.gz: 5688fb5ea959c7438f8448e4073854dc98684118d01c825fa56fd613d4eea15be95d69b441c9c294f98b1606defcea85a52886f871e5bf692b91bd3b2232c383

data/lib/pennmarc/helpers/creator.rb

@@ -131,11 +131,7 @@ module PennMARC
           relator = trim_punctuation(relator).capitalize
 
           name = trim_trailing(:comma, field['a'])
-          name = if name_only
-                   name
-                 else
-                   "#{name} #{join_subfields(field, &subfield_in?(%w[b c d j q u 3]))}, #{relator}"
-                 end
+          name = "#{name} #{join_subfields(field, &subfield_in?(%w[b c d j q u 3]))}, #{relator}" unless name_only
 
           if contributors.key?(relator)
             contributors[relator].push(name)
@@ -274,19 +270,23 @@ module PennMARC
       # 'a', 'b', 'c', 'd', 'j', and 'q', 'u', and '3'. Then appends resulting string with any encoded relationships
       # found in $4. If there are no valid encoded relationships, uses the value found in $e.
       # @note legacy version returns array of hash objects including data for display link
-      # @todo is it okay to include 880 $4 here? Legacy includes $4 in main author display 880 but not here.
       # @param record [MARC::Record]
       # @param relator_map [Hash]
+      # @param name_only [Boolean]
+      # @param vernacular [Boolean]
       # @return [Array<String>]
-      def contributor_show(record, relator_map: Mappers.relator)
+      def contributor_show(record, relator_map: Mappers.relator, name_only: false, vernacular: true)
         indicator_2_options = ['', ' ', '0']
         fields = record.fields(CONTRIBUTOR_TAGS)
-        fields += record.fields('880').select { |f| subfield_value?(f, '6', /^(#{CONTRIBUTOR_TAGS.join('|')})/) }
+        if vernacular
+          fields += record.fields('880').select { |f| subfield_value?(f, '6', /^(#{CONTRIBUTOR_TAGS.join('|')})/) }
+        end
+        sf = name_only ? %w[a] : %w[a b c d j q u 3]
         fields.filter_map { |field|
           next if indicator_2_options.exclude?(field.indicator2) && field.tag.in?(CONTRIBUTOR_TAGS)
           next if subfield_defined? field, 'i'
 
-          contributor = join_subfields(field, &subfield_in?(%w[a b c d j q u 3]))
+          contributor = join_subfields(field, &subfield_in?(sf))
           append_relator(field: field, joined_subfields: contributor, relator_term_sf: 'e', relator_map: relator_map)
         }.uniq
       end

data/lib/pennmarc/mappings/locations.yml

@@ -1422,6 +1422,13 @@ scstor:
     - Van Pelt-Dietrich Library Center
   display: Kislak Center for Special Collections - Rare Book Collection Storage
   aeon: true
+scstorvil:
+  specific_location: LIBRA Vilain-Wieck Collection
+  library: 
+    - Special Collections
+    - LIBRA
+  display: LIBRA Vilain-Wieck Collection
+  aeon: true
 scteer:
   specific_location: Kislak Center for Special Collections - Teerink Collection
   library:
@@ -1522,6 +1529,13 @@ scrunning:
     - LIBRA
   display: LIBRA Running Press Collection
   aeon: true
+storvilain:
+  specific_location: LIBRA Vilain-Wieck Collection
+  library: 
+    - Special Collections
+    - LIBRA
+  display: LIBRA Vilain-Wieck Collection
+  aeon: true
 univarch:
   specific_location: University Archives
   library: University Archives

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.2.10'
+  VERSION = '1.2.11'
 end

data/spec/lib/pennmarc/helpers/creator_spec.rb

@@ -453,6 +453,16 @@ describe 'PennMARC::Creator' do
           'Alt Name Alt num Alt title Alt date Alt qualifier Alt Fuller Name Alt affiliation Alt material, Alt relator.'
         )
       end
+
+      it 'returns contributor name only when called with name_only as true' do
+        values = helper.contributor_show(record, relator_map: mapping, name_only: true)
+        expect(values).to contain_exactly('Name, Author.', 'Alt Name, Alt relator.')
+      end
+
+      it 'returns contributor values without alternatives when called with vernacular as false' do
+        values = helper.contributor_show(record, relator_map: mapping, vernacular: false)
+        expect(values).to contain_exactly('Name I laureate 1968 pseud Fuller Name affiliation materials, Author.')
+      end
     end
 
     context 'with a corporate contributor and linked alternate' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.2.10
+  version: 1.2.11
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-30 00:00:00.000000000 Z
+date: 2025-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport