pennmarc 1.2.1 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7c380943acc4f69a8a7555260d122aa77046b2ab62a2f73e1b3559740bd409b
-  data.tar.gz: 0cc7fb1a1860265fb9bb2fcd637966d0d2972e6496a79545328649fa27fc1445
+  metadata.gz: 96396e62916d963919d655e236402c3ae40386dc9ac6078e135f2d9c41481375
+  data.tar.gz: 554416ba78ce36f00e15b240e988421096349966edc5617b6c5b1f3d573d19f8
 SHA512:
-  metadata.gz: 0265623f80ef1573fdf1d5c2a6a62636291a8edc4e7d06350238b3133071b30cd01a58a9679047578546e856f166ac6df9a9e413c562fafff60eecfc6eb12b93
-  data.tar.gz: aea9b53a26a97e7ff018fda2aacb6101bfb1c21585ac663fcbbdfba7084235de148643b9b03cc1478e230944ce3d45be641189f9852c6b88d7017da00c652bbc
+  metadata.gz: 7b64b529c5929690130cce0480a0e7fd99d32c435e5cf37daa058ab55838c28f246c8cb250f0ee9a4c2c243a118a6815add56f16df6c8bd54edd4b08022b7e36
+  data.tar.gz: fcb648bce5413f48f719050e528ed9f329618cbb5ca0af5e15aa02abd40f35fedb81e64d4614e8fcea2f32a6c6b5784ac7559c44a4771a1ef17321fc56d2b220

data/lib/pennmarc/helpers/subject.rb

@@ -39,7 +39,7 @@ module PennMARC
             # TODO: use term hash here? pro/chr would be rejected...
             # TODO: should we care about punctuation in a search field? relator mapping?
             case subfield.code
-            when '5', '6', '8' then next
+            when '5', '6', '8', '7' then next
             when 'a'
               # remove %PRO or PRO or %CHR or CHR
               # remove any ? at the end
@@ -249,7 +249,7 @@ module PennMARC
                       vernacular: field.tag == '880' }
         field.each do |subfield|
           case subfield.code
-          when '0', '6', '8', '5'
+          when '0', '6', '8', '5', '7'
             # explicitly ignore these subfields
             next
           when '1'

data/lib/pennmarc/helpers/title.rb

@@ -132,6 +132,8 @@ module PennMARC
       # @return [String] title value for sorting
       def sort(record)
         title_field = record.fields('245').first
+        return unless title_field.present?
+
         # attempt to get number of non-filing characters present, default to 0
         offset = if /^[0-9]$/.match?(title_field.indicator2)
                    title_field.indicator2.to_i

data/lib/pennmarc/mappings/locations.yml

@@ -1597,7 +1597,7 @@ vpfeatdvd:
 vpfolio:
   specific_location: Van Pelt - Folios
   library: Van Pelt-Dietrich Library Center
-  display: Van Pelt Library
+  display: Van Pelt - Folios
 vpjuv:
   specific_location: Van Pelt - Notable Juvenile Books
   library: Van Pelt-Dietrich Library Center

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.2.1'
+  VERSION = '1.2.3'
 end

data/spec/lib/pennmarc/helpers/subject_spec.rb

@@ -14,7 +14,8 @@ describe 'PennMARC::Subject' do
       let(:fields) do
         [marc_field(tag: '600', indicator2: '5', subfields: { a: 'Excluded Canadian' }),
          marc_field(tag: '610', indicator2: '0', subfields: { a: 'University of Pennsylvania', b: 'Libraries' }),
-         marc_field(tag: '691', indicator2: '7', subfields: { a: 'Van Pelt Library', '2': 'local' }),
+         marc_field(tag: '691', indicator2: '7', subfields: { a: 'Van Pelt Library', '2': 'local',
+                                                              '7': 'Heading derived magically.' }),
          marc_field(tag: '696', indicator2: '4', subfields: { a: 'A Developer' }),
          marc_field(tag: '880', indicator2: '0', subfields: { a: 'Alt. Name', '6': '610' })]
       end
@@ -100,7 +101,7 @@ describe 'PennMARC::Subject' do
         [marc_field(tag: '650', indicator2: '7',
                     subfields: {
                       a: 'Libraries,', d: '22nd Century,', x: 'History.', e: 'relator',
-                      '2': 'fast', '0': 'http://fast.org/libraries'
+                      '2': 'fast', '0': 'http://fast.org/libraries', '7': 'Heading derived magically.'
                     })]
       end
 
@@ -117,6 +118,10 @@ describe 'PennMARC::Subject' do
         expect(values.first).not_to include 'relator'
       end
 
+      it 'excludes any values from ǂ7' do
+        expect(values.first).not_to include 'magically'
+      end
+
       it 'includes active dates from ǂd' do
         expect(values.first).to include '22nd Century'
       end

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -209,6 +209,18 @@ describe 'PennMARC::Title' do
   end
 
   describe '.sort' do
+    context 'with no 245' do
+      let(:record) do
+        # Simulate a miscoded record
+        marc_record fields: [marc_field(tag: '246', indicator1: '1', indicator2: '4',
+                                        subfields: { a: 'The horn concertos', c: 'Mozart' })]
+      end
+
+      it 'returns nil' do
+        expect(helper.sort(record)).to be_nil
+      end
+    end
+
     context 'with a record with a valid indicator2 value' do
       let(:record) do
         marc_record fields: [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.3
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-17 00:00:00.000000000 Z
+date: 2024-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport