pennmarc 1.2.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b87c66becc36828ec6331d7261d0b71472a74f4af26f2b7a145ed54316ed11a
-  data.tar.gz: 0de62b7492b92ebe0902081aee1da5e5bcabac9e8d9042bab88db7887adda62e
+  metadata.gz: c48634bf726b824f79d9682b82973af5223035ff6e0a999ffb0a83d26f338893
+  data.tar.gz: 4b874bd557519dd16a898faaa4c74ef6415b0b489fbf1ed2082fb1956c4cfaa4
 SHA512:
-  metadata.gz: 0ffced7042a0c00a09c1a2b465e0d17506e55bf0a77255e8f1bce1acabdfabe8faa819864cb0376d7ac6a10285c1a810bd1ede17210829326d342998ed908aa4
-  data.tar.gz: 7aac0315dda59416fdd5b5ed6409b1ddc9a3f881bc75a5aa08c07d299d9824ed9c12a6f6cbe7cacc39a45980f36bcfb97e9ed6b42c379a3aa6364b56f397a244
+  metadata.gz: 88c102ca50391a3f48076c626bdca735612ddc0ca33eb93c11b4268de1c896c90e12d342080c5a254a07267659f7855cc4ef2dc4ed03a329b57e313754cb6589
+  data.tar.gz: 3c02ea8c8e60fb51b89cdc55f4f7329602cf3d5af20434dda37b181f0db527bce20d4fdaf6fe0383d2f26c9a910d49935ffa0173c832d35c57837e446bca82b4

data/lib/pennmarc/helpers/title.rb

@@ -132,6 +132,8 @@ module PennMARC
       # @return [String] title value for sorting
       def sort(record)
         title_field = record.fields('245').first
+        return unless title_field.present?
+
         # attempt to get number of non-filing characters present, default to 0
         offset = if /^[0-9]$/.match?(title_field.indicator2)
                    title_field.indicator2.to_i

data/lib/pennmarc/mappings/locations.yml

@@ -62,9 +62,9 @@ britimp:
   display: Athenaeum of Philadelphia - British Imprints
   aeon: true
 carpco:
-  specific_location: Athenaeum of Philadelphia - Carpenters' Company
-  library: Athenaeum of Philadelphia
-  display: Athenaeum of Philadelphia - Carpenters' Company
+  specific_location: Carpenters' Company of the City and County of Philadelphia
+  library: Special Collections
+  display: Carpenters' Company of the City and County of Philadelphia
   aeon: true
 catoffice:
   specific_location: Athenaeum of Philadelphia - Cataloging Office
@@ -160,12 +160,16 @@ vismatl:
   aeon: true
 athstor:
   specific_location: LIBRA - Athenaeum of Philadelphia
-  library: LIBRA
+  library: 
+    - LIBRA
+    - Athenaeum of Philadelphia
   display: LIBRA - Athenaeum of Philadelphia
   aeon: true
 athstorcir:
   specific_location: LIBRA - Athenaeum of Philadelphia Circulating
-  library: LIBRA
+  library: 
+    - LIBRA
+    - Athenaeum of Philadelphia
   display: LIBRA - Athenaeum of Philadelphia Circulating
 biom:
   specific_location: Holman Biotech Commons
@@ -594,10 +598,6 @@ dncirc:
     - Health Sciences Libraries
     - Levy Dental Medicine Library
   display: Levy Dental Medicine Library - Circulation
-easiacmx:
-  specific_location: Van Pelt - East Asia Comics
-  library: Van Pelt-Dietrich Library Center
-  display: Van Pelt - East Asia Comics
 easiaover:
   specific_location: Van Pelt - East Asia Oversize
   library: Van Pelt-Dietrich Library Center
@@ -1597,7 +1597,7 @@ vpfeatdvd:
 vpfolio:
   specific_location: Van Pelt - Folios
   library: Van Pelt-Dietrich Library Center
-  display: Van Pelt Library
+  display: Van Pelt - Folios
 vpjuv:
   specific_location: Van Pelt - Notable Juvenile Books
   library: Van Pelt-Dietrich Library Center

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.2.0'
+  VERSION = '1.2.2'
 end

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -209,6 +209,18 @@ describe 'PennMARC::Title' do
   end
 
   describe '.sort' do
+    context 'with no 245' do
+      let(:record) do
+        # Simulate a miscoded record
+        marc_record fields: [marc_field(tag: '246', indicator1: '1', indicator2: '4',
+                                        subfields: { a: 'The horn concertos', c: 'Mozart' })]
+      end
+
+      it 'returns nil' do
+        expect(helper.sort(record)).to be_nil
+      end
+    end
+
     context 'with a record with a valid indicator2 value' do
       let(:record) do
         marc_record fields: [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.2
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-30 00:00:00.000000000 Z
+date: 2024-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport