pennmarc 1.1.1 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9003d5a58efd2cbef83a220bd0d609edfdc2bfb883378c003d0bafa2d85e520e
-  data.tar.gz: d8f841dbba9e412848b31a7a11284b14e2bbb772fbb98762b827ab9e2baf6355
+  metadata.gz: b7c380943acc4f69a8a7555260d122aa77046b2ab62a2f73e1b3559740bd409b
+  data.tar.gz: 0cc7fb1a1860265fb9bb2fcd637966d0d2972e6496a79545328649fa27fc1445
 SHA512:
-  metadata.gz: a45d1e909a7a9efad1aec8047d79f3358b1ee3b523958661459c27b397f3a0f33c00deffeae2bdd30fad14156b8f348171639375677e6f600086e1b592fe2c51
-  data.tar.gz: ba609fef49f12f9341328fc292cc510fab6ab298174791afc99ec802ecd1c62448c9ccc009a7f01c6aefef7be2c56d794cc5f2e0bddf01c72fc4e9db11ce6961
+  metadata.gz: 0265623f80ef1573fdf1d5c2a6a62636291a8edc4e7d06350238b3133071b30cd01a58a9679047578546e856f166ac6df9a9e413c562fafff60eecfc6eb12b93
+  data.tar.gz: aea9b53a26a97e7ff018fda2aacb6101bfb1c21585ac663fcbbdfba7084235de148643b9b03cc1478e230944ce3d45be641189f9852c6b88d7017da00c652bbc

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 10000`
-# on 2024-08-20 20:46:53 UTC using RuboCop version 1.51.0.
+# on 2024-08-30 16:12:14 UTC using RuboCop version 1.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -138,7 +138,7 @@ RSpec/FilePath:
   Exclude:
     - 'spec/lib/pennmarc/parser_spec.rb'
 
-# Offense count: 26
+# Offense count: 27
 # Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
   Exclude:

data/lib/pennmarc/helpers/series.rb

@@ -35,6 +35,23 @@ module PennMARC
         series_values.uniq
       end
 
+      # Hash that associates {https://www.loc.gov/marc/bibliographic/bd830.html 830} and
+      # {https://www.loc.gov/marc/bibliographic/bd440.html 440} show values to query values to make building fielded
+      # search links easier in the downstream app.
+      # @param record [MARC::Record]
+      # @return [Hash]
+      def show_query_map(record)
+        record.fields(%w[830 440]).each_with_object({}) do |field, hash|
+          show_values = title_show_entries(record, field.tag) + [remaining_show_value(field)]
+
+          query_value = trim_punctuation(join_subfields(field, &subfield_in?(%w[a n p])))
+
+          show_values.each do |show_value|
+            hash[show_value] = query_value
+          end
+        end
+      end
+
       # Values from series fields for display.
       # @param record [MARC::Record]
       # @param relator_map [Hash]
@@ -141,10 +158,10 @@ module PennMARC
       # @note added 2017/04/10: filter out 0 (authority record numbers) added by Alma
       # @param record [MARC::Record]
       # @param tags_present [Array<String>]
-      # @return [Array<Hash>] array of remaining show entry hashes
+      # @return [Array<String>] array of remaining show entry hashes
       def remaining_show_entries(record, tags_present)
         record.fields(tags_present.drop(1)).map do |field|
-          join_subfields(field, &subfield_not_in?(%w[0 5 6 8]))
+          remaining_show_value(field)
         end || []
       end
 
@@ -200,6 +217,13 @@ module PennMARC
           join_subfields(field, &subfield_in?(%w[i a s t n d]))
         end
       end
+
+      # Parse the value for a given remaining show field
+      # @param field [MARC::Field]
+      # @return [String]
+      def remaining_show_value(field)
+        join_subfields(field, &subfield_not_in?(%w[0 5 6 8]))
+      end
     end
   end
 end

data/lib/pennmarc/helpers/title.rb

@@ -88,7 +88,6 @@ module PennMARC
       # Single-valued Title, for use in headings. Takes the first {https://www.oclc.org/bibformats/en/2xx/245.html 245}
       # value. Special consideration for
       # {https://www.oclc.org/bibformats/en/2xx/245.html#punctuation punctuation practices}.
-      # @todo still consider ǂh? medium, which OCLC doc says DO NOT USE...but that is OCLC...
       # @todo is punctuation handling still as desired? treatment here is described in spreadsheet from 2011
       # @param record [MARC::Record]
       # @return [String] single title for display
@@ -98,15 +97,14 @@ module PennMARC
         [format_title(values[:title_or_form]), values[:punctuation], values[:other_info]].compact_blank.join(' ')
       end
 
-      # Same as show, but with inclusive dates appended. For use on show page.
+      # Same as show, but with all subfields included as found - except for subfield c.
       # @param record [MARC::Record]
       # @return [String] detailed title for display
       def detailed_show(record)
         field = record.fields('245')&.first
-        values = title_values(field)
-        title = [format_title(values[:title_or_form]), values[:punctuation],
-                 trim_trailing(:period, values[:other_info])].compact_blank.join(' ')
-        values[:inclusive_dates].present? ? [title, values[:inclusive_dates]].compact_blank.join(', ') : title
+        return unless field
+
+        join_subfields(field, &subfield_not_in?(%w[6 8]))
       end
 
       # Same structure as show, but linked alternate title.
@@ -124,17 +122,6 @@ module PennMARC
         [format_title(values[:title_or_form]), values[:punctuation], values[:other_info]].compact_blank.join(' ')
       end
 
-      # Title statement of responsibility (field 245, subfield c) and linked alternate for display.
-      # See https://www.oclc.org/bibformats/en/2xx/245.html#subfieldc for examples
-      # @param [MARC::Record] record
-      # @return [Array<String>] statement of responsibility and linked alternate
-      def statement_of_responsibility_show(record)
-        field = record.fields('245').first
-        statement = field&.find { |sf| sf.code == 'c' }&.value
-        alternate_statement = linked_alternate(record, '245', &subfield_in?(%w[c]))&.first
-        [statement, alternate_statement].compact_blank
-      end
-
       # Canonical title with non-filing characters relocated to the end.
       #
       # @note Currently we index two "title sort" fields: title_nssort (ssort type - regex token filter applied) and
@@ -269,7 +256,6 @@ module PennMARC
         title_or_form = field.find_all(&subfield_in?(%w[a k]))
                              .map { |sf| trim_trailing(:comma, trim_trailing(:slash, sf.value).rstrip) }
                              .first || ''
-        inclusive_dates = field.find { |sf| sf.code == 'f' }&.value
         other_info = field.find_all(&subfield_in?(%w[b n p]))
                           .map { |sf| trim_trailing(:slash, sf.value) }
                           .join(' ')
@@ -283,7 +269,6 @@ module PennMARC
                         [title_punctuation, medium_punctuation].include?(':') ? ':' : nil
                       end
         { title_or_form: title_or_form,
-          inclusive_dates: inclusive_dates,
           other_info: other_info,
           punctuation: punctuation }
       end

data/lib/pennmarc/mappings/locations.yml

@@ -62,9 +62,9 @@ britimp:
   display: Athenaeum of Philadelphia - British Imprints
   aeon: true
 carpco:
-  specific_location: Athenaeum of Philadelphia - Carpenters' Company
-  library: Athenaeum of Philadelphia
-  display: Athenaeum of Philadelphia - Carpenters' Company
+  specific_location: Carpenters' Company of the City and County of Philadelphia
+  library: Special Collections
+  display: Carpenters' Company of the City and County of Philadelphia
   aeon: true
 catoffice:
   specific_location: Athenaeum of Philadelphia - Cataloging Office
@@ -160,12 +160,16 @@ vismatl:
   aeon: true
 athstor:
   specific_location: LIBRA - Athenaeum of Philadelphia
-  library: LIBRA
+  library: 
+    - LIBRA
+    - Athenaeum of Philadelphia
   display: LIBRA - Athenaeum of Philadelphia
   aeon: true
 athstorcir:
   specific_location: LIBRA - Athenaeum of Philadelphia Circulating
-  library: LIBRA
+  library: 
+    - LIBRA
+    - Athenaeum of Philadelphia
   display: LIBRA - Athenaeum of Philadelphia Circulating
 biom:
   specific_location: Holman Biotech Commons
@@ -594,10 +598,6 @@ dncirc:
     - Health Sciences Libraries
     - Levy Dental Medicine Library
   display: Levy Dental Medicine Library - Circulation
-easiacmx:
-  specific_location: Van Pelt - East Asia Comics
-  library: Van Pelt-Dietrich Library Center
-  display: Van Pelt - East Asia Comics
 easiaover:
   specific_location: Van Pelt - East Asia Oversize
   library: Van Pelt-Dietrich Library Center

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.1.1'
+  VERSION = '1.2.1'
 end

data/spec/lib/pennmarc/helpers/series_spec.rb

@@ -15,6 +15,24 @@ describe 'PennMARC::Series' do
     marc_record fields: [marc_field(tag: '666', subfields: { a: 'test' })]
   end
 
+  describe '.show_query_map' do
+    let(:record) do
+      marc_record fields: [
+        marc_field(tag: '440', subfields: { a: 'Teachings of the feathered pillow', n: 'number', p: 'section' }),
+        marc_field(tag: '490', subfields: { a: 'Ignored' }),
+        marc_field(tag: '830', subfields: { a: 'International litigation in practice', v: 'volume 13.' })
+      ]
+    end
+
+    it 'returns expected hash' do
+      expect(helper.show_query_map(record)).to eq(
+        { 'Teachings of the feathered pillow number section' => 'Teachings of the feathered pillow number section',
+          'Teachings of the feathered pillow section number' => 'Teachings of the feathered pillow number section',
+          'International litigation in practice volume 13.' => 'International litigation in practice' }
+      )
+    end
+  end
+
   describe '.show' do
     it 'returns the series values for display' do
       expect(helper.show(record, relator_map: mapping)).to contain_exactly(

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -139,15 +139,44 @@ describe 'PennMARC::Title' do
   end
 
   describe '.detailed_show' do
-    let(:record) do
-      marc_record fields: [
-        marc_field(tag: '245', subfields: { k: 'Letters', f: '1972-1982', b: 'to Lewis Mumford.' })
-      ]
-    end
-
     context 'with subfields ǂk, ǂf and ǂc' do
+      let(:record) do
+        marc_record fields: [
+          marc_field(tag: '245', subfields: { k: 'Letters,', f: '1972-1982,', b: 'to Lewis Mumford.' })
+        ]
+      end
+
       it 'returns detailed title values' do
-        expect(helper.detailed_show(record)).to eq 'Letters to Lewis Mumford, 1972-1982'
+        expect(helper.detailed_show(record)).to eq 'Letters, 1972-1982, to Lewis Mumford.'
+      end
+    end
+
+    context 'with subfields ǂk and ǂb' do
+      let(:record) do
+        marc_record fields: [
+          marc_field(tag: '245', subfields: { k: 'Letters', b: 'to Lewis Mumford.' })
+        ]
+      end
+
+      it 'returns title value without dates' do
+        expect(helper.detailed_show(record)).to eq 'Letters to Lewis Mumford.'
+      end
+    end
+
+    # e.g., 9977704838303681
+    context 'with ǂa containing an " : " as well as inclusive dates' do
+      let(:record) do
+        marc_record fields: [
+          marc_field(tag: '245', subfields: { a: 'The frugal housewife : ',
+                                              b: 'dedicated to those who are not ashamed of economy, ',
+                                              f: '1830 / ', c: 'by the author of Hobomok.' })
+        ]
+      end
+
+      it 'returns single title value with text from ǂa and ǂn' do
+        expect(helper.detailed_show(record)).to eq(
+          'The frugal housewife : dedicated to those who are not ashamed of economy, 1830 / by the author of Hobomok.'
+        )
       end
     end
   end
@@ -179,25 +208,6 @@ describe 'PennMARC::Title' do
     end
   end
 
-  describe '.statement_of_responsibility_show' do
-    let(:record) do
-      marc_record fields: [marc_field(tag: '245', subfields: { c: 'statement of responsibility' }),
-                           marc_field(tag: '880', subfields: { '6': '245', c: 'déclaration de responsabilité' })]
-    end
-
-    context 'with ǂc defined' do
-      it 'returns statement of responsibility' do
-        expect(helper.statement_of_responsibility_show(record)).to include 'statement of responsibility'
-      end
-    end
-
-    context 'with linked alternate of 245 ǂc defined' do
-      it 'returns alternate statement of responsibility' do
-        expect(helper.statement_of_responsibility_show(record)).to include 'déclaration de responsabilité'
-      end
-    end
-  end
-
   describe '.sort' do
     context 'with a record with a valid indicator2 value' do
       let(:record) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.1
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-23 00:00:00.000000000 Z
+date: 2024-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport