pennmarc 1.0.33 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3f26c7e473bed7b22bd7aa63257b9647dd808f79a02aa1aab21e965f264d545a
-  data.tar.gz: f793a9945291b9b66ee6c4155446c9270fc6e2f994c0754fa6dc0b4ba887cebc
+  metadata.gz: 9003d5a58efd2cbef83a220bd0d609edfdc2bfb883378c003d0bafa2d85e520e
+  data.tar.gz: d8f841dbba9e412848b31a7a11284b14e2bbb772fbb98762b827ab9e2baf6355
 SHA512:
-  metadata.gz: b3b5296a1f285562ed9c2fd88e5f06f3c3127fd988ad7066298fcbc3cbb3b143678ac1da9c2e63e1fcf5df3075ea763197928712db0221042164525a6191a635
-  data.tar.gz: 3201a8f615d58871620081112eb663d7526911a68f1eae4a561e3216d77ada399cc10164be0532fdf7d2992a9cc964a829abfeb9272d64fabaa263ddb8f2f31c
+  metadata.gz: a45d1e909a7a9efad1aec8047d79f3358b1ee3b523958661459c27b397f3a0f33c00deffeae2bdd30fad14156b8f348171639375677e6f600086e1b592fe2c51
+  data.tar.gz: ba609fef49f12f9341328fc292cc510fab6ab298174791afc99ec802ecd1c62448c9ccc009a7f01c6aefef7be2c56d794cc5f2e0bddf01c72fc4e9db11ce6961

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 10000`
-# on 2024-07-02 15:41:46 UTC using RuboCop version 1.51.0.
+# on 2024-08-20 20:46:53 UTC using RuboCop version 1.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,7 +14,7 @@ Gemspec/RequireMFA:
   Exclude:
     - 'pennmarc.gemspec'
 
-# Offense count: 25
+# Offense count: 26
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Exclude:
@@ -31,7 +31,7 @@ Metrics/AbcSize:
     - 'lib/pennmarc/helpers/title.rb'
     - 'lib/pennmarc/util.rb'
 
-# Offense count: 8
+# Offense count: 9
 # Configuration parameters: CountComments, Max, CountAsOne.
 Metrics/ClassLength:
   Exclude:
@@ -138,9 +138,10 @@ RSpec/FilePath:
   Exclude:
     - 'spec/lib/pennmarc/parser_spec.rb'
 
-# Offense count: 23
+# Offense count: 26
 # Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
   Exclude:
     - 'spec/lib/pennmarc/helpers/access_spec.rb'
     - 'spec/lib/pennmarc/helpers/format_spec.rb'
+    - 'spec/lib/pennmarc/helpers/location_spec.rb'

data/lib/pennmarc/helpers/classification.rb

@@ -42,6 +42,24 @@ module PennMARC
         }.uniq
       end
 
+      # Parse call number values from inventory fields, including both hld and itm fields from publishing enrichment.
+      # Return only unique values.
+      # @param record [MARC::Record]
+      # @return [Array<String>] array of call numbers from inventory fields
+      def call_number_search(record)
+        call_nums = record.fields(TAGS).filter_map do |field|
+          subfield_values(field, call_number_sf(field))
+        end
+
+        # Ensure we get call numbers for records with no `itm` tags by also checking `hld` and de-duping
+        call_nums += record.fields([Enriched::Pub::PHYS_INVENTORY_TAG]).filter_map do |field|
+          first = subfield_values(field, Enriched::Pub::HOLDING_CLASSIFICATION_PART)&.first
+          last = subfield_values(field, Enriched::Pub::HOLDING_ITEM_PART)&.first
+          "#{first} #{last}".squish.presence
+        end
+        call_nums.flatten.uniq
+      end
+
       private
 
       # Retrieve subfield code that stores the call number on enriched marc field

data/lib/pennmarc/helpers/location.rb

@@ -3,7 +3,6 @@
 module PennMARC
   # Methods that return Library and Location values from Alma enhanced MARC fields
   class Location < Helper
-    ONLINE_LIBRARY = 'Online library'
     WEB_LOCATION_CODE = 'web'
 
     class << self
@@ -38,14 +37,14 @@ module PennMARC
       # @see https://developers.exlibrisgroup.com/alma/apis/docs/bibs/R0VUIC9hbG1hd3MvdjEvYmlicy97bW1zX2lkfQ==/
       #   Alma documentation for these added fields
       # @param record [MARC::Record]
-      # @param display_value [Symbol | String] field in location hash to retrieve
+      # @param display_value [Symbol,String] field in location hash to retrieve
       # @param location_map [Hash] hash with location_code as key and location hash as value
       # @return [Array<String>]
       def location(record:, display_value:, location_map:)
         # get enriched marc location tag and relevant subfields
-        enriched_location_tag_and_subfields(record) => {tag:, location_code_sf:, call_num_sf:}
+        enriched_location_tag_and_subfields(record) => {tag:, location_code_sf:, call_num_sf:, call_num_type_sf:}
 
-        locations = record.fields(tag).flat_map { |field|
+        record.fields(tag).flat_map { |field|
           field.filter_map { |subfield|
             # skip unless subfield matches enriched marc tag subfield code
             next unless subfield.code == location_code_sf
@@ -54,28 +53,27 @@ module PennMARC
 
             next if location_code_to_ignore?(location_map, location_code)
 
-            override = specific_location_override(display_value: display_value, location_code: location_code,
-                                                  field: field, call_num_sf: call_num_sf)
+            override = if display_value.to_sym == :specific_location
+                         specific_location_override(location_code: location_code, field: field,
+                                                    call_num_sf: call_num_sf, call_num_type_sf: call_num_type_sf)
+                       end
 
             override || location_map[location_code.to_sym][display_value.to_sym]
           }.flatten.compact_blank
         }.uniq
-        if record.tags.intersect?([Enriched::Pub::ELEC_INVENTORY_TAG, Enriched::Api::ELEC_INVENTORY_TAG])
-          locations << ONLINE_LIBRARY
-        end
-
-        locations
       end
 
       private
 
       # Determine enriched marc location tag, location code subfield, and call number subfield,
-      # giving priority to using 'itm', 'AVA', or 'AVE' fields.
+      # giving priority to using 'itm', 'AVA', or 'hld' fields.
       # @param record [MARC::Record]
       # @return [Hash<String, String>] containing location tag and subfield code
       # - `:tag` (String): The enriched marc location tag
       # - `:location_code_sf` (String): The subfield code where location code is stored
       # - `:call_num_sf` (String): The subfield code where call number is stored
+      # - `:call_num_type_sf` (String, nil): The subfield code where call number type is stored. nil if unavailable in a
+      #                                   MARC field and we need to look for an indicator.
       def enriched_location_tag_and_subfields(record)
         # in holdings records, the shelving location is always the permanent location.
         # in item records, the current location takes into account
@@ -90,19 +88,22 @@ module PennMARC
           tag = Enriched::Pub::ITEM_TAG
           location_code_sf = Enriched::Pub::ITEM_CURRENT_LOCATION
           call_num_sf = Enriched::Pub::ITEM_CALL_NUMBER
+          call_num_type_sf = Enriched::Pub::ITEM_CALL_NUMBER_TYPE
           # if the record has API inventory tags, use them
         elsif field_defined?(record, Enriched::Api::PHYS_INVENTORY_TAG)
           tag = Enriched::Api::PHYS_INVENTORY_TAG
           location_code_sf = Enriched::Api::PHYS_LOCATION_CODE
           call_num_sf = Enriched::Api::PHYS_CALL_NUMBER
+          call_num_type_sf = Enriched::Api::PHYS_CALL_NUMBER_TYPE
           # otherwise use Pub holding tags
         else
           tag = Enriched::Pub::PHYS_INVENTORY_TAG
           location_code_sf = Enriched::Pub::PHYS_LOCATION_CODE
           call_num_sf = Enriched::Pub::HOLDING_CLASSIFICATION_PART
+          call_num_type_sf = nil # for hld tags, the call num type is indicator0
         end
 
-        { tag: tag, location_code_sf: location_code_sf, call_num_sf: call_num_sf }
+        { tag: tag, location_code_sf: location_code_sf, call_num_sf: call_num_sf, call_num_type_sf: call_num_type_sf }
       end
 
       # Determines whether to ignore a location code.
@@ -111,32 +112,55 @@ module PennMARC
       # map, we ignore it, for faceting purposes. We also ignore the location code 'web'. We don't facet for 'web'
       # which is the 'Penn Library Web' location used in Voyager. This location should eventually go away completely
       # with data cleanup in Alma.
-      # @param location_map [location_map] hash with location_code as key and location hash as value
-      # @param location_code [location_code] retrieved from record
+      # @param location_map [Hash] hash with location_code as key and location hash as value
+      # @param location_code [String] retrieved from record
       # @return [Boolean]
       def location_code_to_ignore?(location_map, location_code)
-        location_map.key?(location_code.to_sym) == false || location_code == WEB_LOCATION_CODE
+        !location_map.key?(location_code.to_sym) || location_code == WEB_LOCATION_CODE
       end
 
       # Retrieves a specific location override based on location code and call number. Specific location overrides are
       # located in `location_overrides.yml`.
-      # @param display_value [String | Symbol]
       # @param location_code [String]
       # @param field [MARC::Field]
       # @param call_num_sf [String]
+      # @param call_num_type_sf [String, nil]
       # @return [String, Nil]
-      def specific_location_override(display_value:, location_code:, field:, call_num_sf:)
-        return unless display_value.to_sym == :specific_location
+      def specific_location_override(location_code:, field:, call_num_sf:, call_num_type_sf:)
+        callnum_type = callnum_type(field: field, call_num_type_sf: call_num_type_sf)
+        return unless callnum_type
 
-        locations_overrides = Mappers.location_overrides
+        override = Mappers.location_overrides.find do |_key, override_data|
+          override_matching?(override_data: override_data, location_code: location_code, callnum_type: callnum_type,
+                             call_numbers: subfield_values(field, call_num_sf))
+        end
 
-        call_numbers = subfield_values(field, call_num_sf)
+        override&.last&.dig(:specific_location)
+      end
 
-        override = locations_overrides.find do |_key, value|
-          value[:location_code] == location_code && call_numbers.any? { |num| num.match?(value[:call_num_pattern]) }
+      # Check override_data hash for a matching location name override
+      # @param override_data [Hash]
+      # @param location_code [String]
+      # @param call_numbers [Array]
+      # @param callnum_type [String]
+      # @return [Boolean]
+      def override_matching?(override_data:, location_code:, call_numbers:, callnum_type:)
+        call_numbers.any? do |call_number|
+          override_data[:location_code] == location_code &&
+            override_data[:call_num_type] == callnum_type &&
+            call_number.match?(override_data[:call_num_pattern])
         end
+      end
 
-        override&.last&.dig(:specific_location)
+      # Return call num type value for a given field. If no call number subfield is expected (publishing holding
+      # inventory case), the first indicator is checked.
+      # @param field [MARC::Field]
+      # @param call_num_type_sf [String, nil]
+      # @return [String, nil]
+      def callnum_type(field:, call_num_type_sf:)
+        return field.indicator1 if call_num_type_sf.nil?
+
+        subfield_values(field, call_num_type_sf).first
       end
     end
   end

data/lib/pennmarc/helpers/note.rb

@@ -90,7 +90,7 @@ module PennMARC
       # @return [Array<String>]
       def access_restriction_show(record)
         record.fields('506').filter_map { |field|
-          join_subfields(field, &subfield_not_in?(%w[5 6]))
+          join_subfields(field, &subfield_not_in?(%w[2 5 6]))
         }.uniq
       end
 

data/lib/pennmarc/helpers/title.rb

@@ -93,22 +93,46 @@ module PennMARC
       # @param record [MARC::Record]
       # @return [String] single title for display
       def show(record)
+        field = record.fields('245')&.first
+        values = title_values(field)
+        [format_title(values[:title_or_form]), values[:punctuation], values[:other_info]].compact_blank.join(' ')
+      end
+
+      # Same as show, but with inclusive dates appended. For use on show page.
+      # @param record [MARC::Record]
+      # @return [String] detailed title for display
+      def detailed_show(record)
+        field = record.fields('245')&.first
+        values = title_values(field)
+        title = [format_title(values[:title_or_form]), values[:punctuation],
+                 trim_trailing(:period, values[:other_info])].compact_blank.join(' ')
+        values[:inclusive_dates].present? ? [title, values[:inclusive_dates]].compact_blank.join(', ') : title
+      end
+
+      # Same structure as show, but linked alternate title.
+      # @param record [MARC::Record]
+      # @return [String, nil] alternate title for display
+      def alternate_show(record)
+        field = record.fields('880').filter_map { |alternate_field|
+          next unless subfield_value?(alternate_field, '6', /^245/)
+
+          alternate_field
+        }.first
+        return unless field
+
+        values = title_values(field)
+        [format_title(values[:title_or_form]), values[:punctuation], values[:other_info]].compact_blank.join(' ')
+      end
+
+      # Title statement of responsibility (field 245, subfield c) and linked alternate for display.
+      # See https://www.oclc.org/bibformats/en/2xx/245.html#subfieldc for examples
+      # @param [MARC::Record] record
+      # @return [Array<String>] statement of responsibility and linked alternate
+      def statement_of_responsibility_show(record)
         field = record.fields('245').first
-        title_or_form = field.find_all(&subfield_in?(%w[a k]))
-                             .map { |sf| trim_trailing(:comma, trim_trailing(:slash, sf.value).rstrip) }
-                             .first || ''
-        other_info = field.find_all(&subfield_in?(%w[b n p]))
-                          .map { |sf| trim_trailing(:slash, sf.value) }
-                          .join(' ')
-        hpunct = field.find_all { |sf| sf.code == 'h' }.map { |sf| sf.value.last }.first
-        punctuation = if [title_or_form.last, hpunct].include?('=')
-                        '='
-                      else
-                        [title_or_form.last, hpunct].include?(':') ? ':' : nil
-                      end
-        [trim_trailing(:colon, trim_trailing(:equal, title_or_form)).strip,
-         punctuation,
-         other_info].compact_blank.join(' ')
+        statement = field&.find { |sf| sf.code == 'c' }&.value
+        alternate_statement = linked_alternate(record, '245', &subfield_in?(%w[c]))&.first
+        [statement, alternate_statement].compact_blank
       end
 
       # Canonical title with non-filing characters relocated to the end.
@@ -212,12 +236,13 @@ module PennMARC
       def former_show(record)
         record.fields
               .filter_map { |field|
-          next unless field.tag == '247' || (field.tag == '880' && subfield_value?(field, '6', /^247/))
+                next unless field.tag == '247' || (field.tag == '880' && subfield_value?(field, '6', /^247/))
 
-          former_title = join_subfields field, &subfield_not_in?(%w[6 8 e w]) # 6 and 8 are not meaningful for display
-          former_title_append = join_subfields field, &subfield_in?(%w[e w])
-          "#{former_title} #{former_title_append}".strip
-        }.uniq
+                # 6 and 8 are not meaningful for display
+                former_title = join_subfields field, &subfield_not_in?(%w[6 8 e w])
+                former_title_append = join_subfields field, &subfield_in?(%w[e w])
+                "#{former_title} #{former_title_append}".strip
+              }.uniq
       end
 
       # Determine if the record is a "Host" bibliographic record for other bib records ("bound-withs")
@@ -232,6 +257,44 @@ module PennMARC
 
       private
 
+      # Extract title values from provided 245 subfields. Main title components are the following:
+      # - title_or_form: subfields a and k
+      # - inclusive_dates: subfield c
+      # - other_info: subfields b, n, and p
+      # https://www.oclc.org/bibformats/en/2xx/245.html
+      #
+      # @param field [MARC::Field]
+      # @return [Hash] title values
+      def title_values(field)
+        title_or_form = field.find_all(&subfield_in?(%w[a k]))
+                             .map { |sf| trim_trailing(:comma, trim_trailing(:slash, sf.value).rstrip) }
+                             .first || ''
+        inclusive_dates = field.find { |sf| sf.code == 'f' }&.value
+        other_info = field.find_all(&subfield_in?(%w[b n p]))
+                          .map { |sf| trim_trailing(:slash, sf.value) }
+                          .join(' ')
+        title_punctuation = title_or_form.last
+        medium_punctuation = field.find_all { |sf| sf.code == 'h' }
+                                  .map { |sf| sf.value.last }
+                                  .first
+        punctuation = if [title_punctuation, medium_punctuation].include?('=')
+                        '='
+                      else
+                        [title_punctuation, medium_punctuation].include?(':') ? ':' : nil
+                      end
+        { title_or_form: title_or_form,
+          inclusive_dates: inclusive_dates,
+          other_info: other_info,
+          punctuation: punctuation }
+      end
+
+      # Remove trailing equal from title, then remove trailing colon.
+      # @param title [String]
+      # @return [String]
+      def format_title(title)
+        trim_trailing(:colon, trim_trailing(:equal, title)).strip
+      end
+
       # Create prefix/filing hash for representing a title value with filing characters removed, with special
       # consideration for bracketed titles
       # @todo Is this still useful?

data/lib/pennmarc/mappings/location_overrides.yml

@@ -1,5 +1,6 @@
 albrecht:
   location_code: 'vanp'
   call_num_pattern: '^M.*'
+  call_num_type: '0'
   specific_location: 'Van Pelt - Albrecht Music Library'
 

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.0.33'
+  VERSION = '1.1.1'
 end

data/spec/lib/pennmarc/helpers/classification_spec.rb

@@ -2,22 +2,26 @@
 
 describe 'PennMARC::Classification' do
   let(:helper) { PennMARC::Classification }
-  let(:record) do
-    marc_record fields: [marc_field(tag: tag,
-                                    subfields: { call_number_type_sf => '0', call_number_sf => 'TA683 .B3 1909b' }),
-                         marc_field(tag: tag,
-                                    subfields: { call_number_type_sf => '0', call_number_sf => 'QL756 .S643' }),
-                         marc_field(tag: tag,
-                                    subfields: { call_number_type_sf => '1', call_number_sf => '691.3 B2141' }),
-                         marc_field(tag: tag,
-                                    subfields: { call_number_type_sf => '1', call_number_sf => '378.748 POS1952.29' })]
-  end
+  let(:record) { marc_record fields: fields }
 
   describe '.facet' do
-    context 'with enrichment via the Alma publishing process' do
-      let(:tag) { PennMARC::Enriched::Pub::ITEM_TAG }
-      let(:call_number_type_sf) { PennMARC::Enriched::Pub::ITEM_CALL_NUMBER_TYPE }
-      let(:call_number_sf) { PennMARC::Enriched::Pub::ITEM_CALL_NUMBER }
+    let(:fields) do
+      [marc_field(tag: config[:tag],
+                  subfields: { config[:call_number_type_sf] => '0', config[:call_number_sf] => 'TA683 .B3 1909b' }),
+       marc_field(tag: config[:tag],
+                  subfields: { config[:call_number_type_sf] => '0', config[:call_number_sf] => 'QL756 .S643' }),
+       marc_field(tag: config[:tag],
+                  subfields: { config[:call_number_type_sf] => '1', config[:call_number_sf] => '691.3 B2141' }),
+       marc_field(tag: config[:tag],
+                  subfields: { config[:call_number_type_sf] => '1', config[:call_number_sf] => '378.748 POS1952.29' })]
+    end
+
+    context 'with enrichment via the Alma publishing process and itm fields' do
+      let(:config) do
+        { tag: PennMARC::Enriched::Pub::ITEM_TAG,
+          call_number_type_sf: PennMARC::Enriched::Pub::ITEM_CALL_NUMBER_TYPE,
+          call_number_sf: PennMARC::Enriched::Pub::ITEM_CALL_NUMBER }
+      end
 
       it 'returns expected values' do
         expect(helper.facet(record)).to contain_exactly('T - Technology', '600 - Technology',
@@ -26,9 +30,11 @@ describe 'PennMARC::Classification' do
     end
 
     context 'with enrichment with availability info via Alma Api' do
-      let(:tag) { PennMARC::Enriched::Api::PHYS_INVENTORY_TAG }
-      let(:call_number_type_sf) { PennMARC::Enriched::Api::PHYS_CALL_NUMBER_TYPE }
-      let(:call_number_sf) { PennMARC::Enriched::Api::PHYS_CALL_NUMBER }
+      let(:config) do
+        { tag: PennMARC::Enriched::Api::PHYS_INVENTORY_TAG,
+          call_number_type_sf: PennMARC::Enriched::Api::PHYS_CALL_NUMBER_TYPE,
+          call_number_sf: PennMARC::Enriched::Api::PHYS_CALL_NUMBER }
+      end
 
       it 'returns expected values' do
         expect(helper.facet(record)).to contain_exactly('T - Technology', '600 - Technology',
@@ -36,4 +42,63 @@ describe 'PennMARC::Classification' do
       end
     end
   end
+
+  describe '.call_number_search' do
+    let(:fields) do
+      [marc_field(tag: config[:tag],
+                  subfields: { config[:call_number_type_sf] => '0', config[:call_number_sf] => 'QL756 .S643' }),
+       marc_field(tag: config[:tag],
+                  subfields: { config[:call_number_type_sf] => '1', config[:call_number_sf] => '691.3 B2141' })]
+    end
+
+    context 'with enrichment via the Alma publishing process' do
+      let(:config) do
+        { tag: PennMARC::Enriched::Pub::ITEM_TAG,
+          call_number_type_sf: PennMARC::Enriched::Pub::ITEM_CALL_NUMBER_TYPE,
+          call_number_sf: PennMARC::Enriched::Pub::ITEM_CALL_NUMBER }
+      end
+
+      it 'returns expected values' do
+        expect(helper.call_number_search(record)).to contain_exactly '691.3 B2141', 'QL756 .S643'
+      end
+    end
+
+    context 'with enrichment via the Alma publishing process and no itm fields' do
+      let(:fields) do
+        [marc_field(tag: PennMARC::Enriched::Pub::PHYS_INVENTORY_TAG,
+                    subfields: { PennMARC::Enriched::Pub::HOLDING_CLASSIFICATION_PART => 'KF6450',
+                                 PennMARC::Enriched::Pub::HOLDING_ITEM_PART => '.C59 1989' })]
+      end
+
+      it 'returns expected values from the hld tag' do
+        expect(helper.call_number_search(record)).to contain_exactly('KF6450 .C59 1989')
+      end
+    end
+
+    context 'with enrichment via the Alma publishing process and values from both hld and itm fields' do
+      let(:fields) do
+        [marc_field(tag: PennMARC::Enriched::Pub::PHYS_INVENTORY_TAG,
+                    subfields: { PennMARC::Enriched::Pub::HOLDING_CLASSIFICATION_PART => 'KF6450',
+                                 PennMARC::Enriched::Pub::HOLDING_ITEM_PART => '.C59 1989' }),
+         marc_field(tag: PennMARC::Enriched::Pub::ITEM_TAG,
+                    subfields: { PennMARC::Enriched::Pub::ITEM_CALL_NUMBER => 'KF6450 .C59 1989' })]
+      end
+
+      it 'returns a single call number' do
+        expect(helper.call_number_search(record)).to contain_exactly('KF6450 .C59 1989')
+      end
+    end
+
+    context 'with enrichment with availability info via Alma Api' do
+      let(:config) do
+        { tag: PennMARC::Enriched::Api::PHYS_INVENTORY_TAG,
+          call_number_type_sf: PennMARC::Enriched::Api::PHYS_CALL_NUMBER_TYPE,
+          call_number_sf: PennMARC::Enriched::Api::PHYS_CALL_NUMBER }
+      end
+
+      it 'returns expected values' do
+        expect(helper.call_number_search(record)).to contain_exactly '691.3 B2141', 'QL756 .S643'
+      end
+    end
+  end
 end

data/spec/lib/pennmarc/helpers/location_spec.rb

@@ -4,12 +4,13 @@ describe 'PennMARC::Location' do
   let(:helper) { PennMARC::Location }
   let(:enriched_marc) { PennMARC::Enriched }
   let(:mapping) { location_map }
+  let(:record) { marc_record(fields: fields) }
 
   describe 'location' do
     context "with only 'itm' field present" do
-      let(:record) do
-        marc_record(fields: [marc_field(tag: enriched_marc::Pub::ITEM_TAG,
-                                        subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'stor' })])
+      let(:fields) do
+        [marc_field(tag: enriched_marc::Pub::ITEM_TAG,
+                    subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'stor' })]
       end
 
       it 'returns expected value' do
@@ -21,9 +22,9 @@ describe 'PennMARC::Location' do
     end
 
     context "with only 'hld' field present" do
-      let(:record) do
-        marc_record(fields: [marc_field(tag: enriched_marc::Pub::PHYS_INVENTORY_TAG,
-                                        subfields: { enriched_marc::Pub::PHYS_LOCATION_CODE => 'stor' })])
+      let(:fields) do
+        [marc_field(tag: enriched_marc::Pub::PHYS_INVENTORY_TAG,
+                    subfields: { enriched_marc::Pub::PHYS_LOCATION_CODE => 'stor' })]
       end
 
       it 'returns expected value' do
@@ -35,11 +36,11 @@ describe 'PennMARC::Location' do
     end
 
     context 'with both holding and item tag fields present=' do
-      let(:record) do
-        marc_record(fields: [marc_field(tag: enriched_marc::Pub::ITEM_TAG,
-                                        subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'stor' }),
-                             marc_field(tag: enriched_marc::Pub::PHYS_INVENTORY_TAG,
-                                        subfields: { enriched_marc::Pub::PHYS_LOCATION_CODE => 'dent' })])
+      let(:fields) do
+        [marc_field(tag: enriched_marc::Pub::ITEM_TAG,
+                    subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'stor' }),
+         marc_field(tag: enriched_marc::Pub::PHYS_INVENTORY_TAG,
+                    subfields: { enriched_marc::Pub::PHYS_LOCATION_CODE => 'dent' })]
       end
 
       it 'returns item location' do
@@ -49,7 +50,7 @@ describe 'PennMARC::Location' do
     end
 
     context 'with multiple library locations' do
-      let(:record) { marc_record(fields: [marc_field(tag: enriched_marc::Pub::ITEM_TAG, subfields: { g: %w[dent] })]) }
+      let(:fields) { [marc_field(tag: enriched_marc::Pub::ITEM_TAG, subfields: { g: %w[dent] })] }
 
       it 'returns expected value' do
         expect(helper.location(record: record, location_map: mapping,
@@ -59,34 +60,19 @@ describe 'PennMARC::Location' do
     end
 
     context 'without enriched marc location tag' do
-      let(:record) { marc_record(fields: [marc_field(tag: '852', subfields: { g: 'stor' })]) }
+      let(:fields) { [marc_field(tag: '852', subfields: { g: 'stor' })] }
 
       it 'returns expected value' do
         expect(helper.location(record: record, location_map: mapping, display_value: :library)).to be_empty
       end
     end
 
-    context 'with electronic inventory tag' do
-      let(:record) do
-        marc_record(fields: [marc_field(tag: enriched_marc::Pub::ITEM_TAG,
-                                        subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'stor' }),
-                             marc_field(tag: enriched_marc::Pub::ELEC_INVENTORY_TAG)])
-      end
-
-      it 'returns expected value' do
-        expect(helper.location(record: record, location_map: mapping,
-                               display_value: :library)).to contain_exactly('LIBRA', helper::ONLINE_LIBRARY)
-      end
-    end
-
     context 'with AVA fields' do
-      let(:record) do
-        marc_record(fields: [marc_field(tag: enriched_marc::Api::PHYS_INVENTORY_TAG,
-                                        subfields: {
-                                          enriched_marc::Api::PHYS_LIBRARY_CODE => 'Libra',
-                                          enriched_marc::Api::PHYS_LOCATION_NAME => 'LIBRA',
-                                          enriched_marc::Api::PHYS_LOCATION_CODE => 'stor'
-                                        })])
+      let(:fields) do
+        [marc_field(tag: enriched_marc::Api::PHYS_INVENTORY_TAG,
+                    subfields: { enriched_marc::Api::PHYS_LIBRARY_CODE => 'Libra',
+                                 enriched_marc::Api::PHYS_LOCATION_NAME => 'LIBRA',
+                                 enriched_marc::Api::PHYS_LOCATION_CODE => 'stor' })]
       end
 
       it 'returns expected values' do
@@ -96,37 +82,83 @@ describe 'PennMARC::Location' do
       end
     end
 
-    context 'with AVE fields' do
-      let(:record) do
-        marc_record(fields: [marc_field(tag: enriched_marc::Api::ELEC_INVENTORY_TAG,
-                                        subfields: { enriched_marc::Api::ELEC_COLLECTION_NAME => 'Nature' })])
-      end
-
-      it 'returns expected values' do
-        expect(helper.location(record: record, location_map: mapping, display_value: :library)).to(
-          contain_exactly(helper::ONLINE_LIBRARY)
-        )
-      end
-    end
-
     context 'with a specific location override' do
-      let(:record) do
-        marc_record(fields: [marc_field(tag: enriched_marc::Pub::ITEM_TAG,
-                                        subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'vanp',
-                                                     enriched_marc::Pub::ITEM_CALL_NUMBER => 'ML3534 .D85 1984' }),
-                             marc_field(tag: enriched_marc::Pub::ITEM_TAG,
-                                        subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'stor',
-                                                     enriched_marc::Pub::ITEM_CALL_NUMBER => 'L3534 .D85 1984' })])
-      end
-
-      it 'returns expected values' do
-        expect(helper.location(record: record, display_value: :specific_location, location_map: mapping))
-          .to(contain_exactly(PennMARC::Mappers.location_overrides[:albrecht][:specific_location], 'LIBRA'))
-      end
-
-      it 'returns expected values when receiving a string for display_value' do
-        expect(helper.location(record: record, display_value: 'specific_location', location_map: mapping))
-          .to(contain_exactly(PennMARC::Mappers.location_overrides[:albrecht][:specific_location], 'LIBRA'))
+      context 'with item fields and LC call nums' do
+        let(:fields) do
+          [marc_field(tag: enriched_marc::Pub::ITEM_TAG,
+                      subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'vanp',
+                                   enriched_marc::Pub::ITEM_CALL_NUMBER_TYPE =>
+                                     PennMARC::Classification::LOC_CALL_NUMBER_TYPE,
+                                   enriched_marc::Pub::ITEM_CALL_NUMBER => 'ML3534 .D85 1984' }),
+           marc_field(tag: enriched_marc::Pub::ITEM_TAG,
+                      subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'stor',
+                                   enriched_marc::Pub::ITEM_CALL_NUMBER_TYPE => '8',
+                                   enriched_marc::Pub::ITEM_CALL_NUMBER => 'L3534 .D85 1984' })]
+        end
+
+        it 'returns expected values' do
+          expect(helper.location(record: record, display_value: :specific_location, location_map: mapping))
+            .to(contain_exactly(PennMARC::Mappers.location_overrides[:albrecht][:specific_location], 'LIBRA'))
+        end
+
+        it 'returns expected values when receiving a string for display_value' do
+          expect(helper.location(record: record, display_value: 'specific_location', location_map: mapping))
+            .to(contain_exactly(PennMARC::Mappers.location_overrides[:albrecht][:specific_location], 'LIBRA'))
+        end
+      end
+
+      context 'with item fields and microfilm call nums' do
+        let(:fields) do
+          [marc_field(tag: enriched_marc::Pub::ITEM_TAG, indicator1: ' ',
+                      subfields: { enriched_marc::Pub::ITEM_CURRENT_LOCATION => 'vanp',
+                                   enriched_marc::Pub::ITEM_CALL_NUMBER_TYPE => '8',
+                                   enriched_marc::Pub::ITEM_CALL_NUMBER => 'Microfilm 3140 item 8' })]
+        end
+
+        it 'returns expected values' do
+          expect(helper.location(record: record, display_value: :specific_location, location_map: mapping))
+            .to(contain_exactly(PennMARC::Mappers.location[:vanp][:specific_location]))
+        end
+      end
+
+      context 'with holding fields and both LC and non-LC call num type' do
+        let(:fields) do
+          [marc_field(indicator1: '8', tag: enriched_marc::Pub::PHYS_INVENTORY_TAG,
+                      subfields: { enriched_marc::Pub::PHYS_LOCATION_CODE => 'vanp' }),
+           marc_field(indicator1: '0', tag: enriched_marc::Pub::PHYS_INVENTORY_TAG,
+                      subfields: { enriched_marc::Pub::PHYS_LOCATION_CODE => 'vanp',
+                                   enriched_marc::Pub::HOLDING_CLASSIFICATION_PART => 'ML3534' })]
+        end
+
+        it 'returns expected values' do
+          expect(helper.location(record: record, display_value: :specific_location, location_map: mapping))
+            .to(contain_exactly(PennMARC::Mappers.location[:vanp][:specific_location],
+                                PennMARC::Mappers.location_overrides[:albrecht][:specific_location]))
+        end
+      end
+
+      context 'with a variety of holding fields from the Alma API enrichment' do
+        let(:fields) do
+          [marc_field(tag: enriched_marc::Api::PHYS_INVENTORY_TAG,
+                      subfields: { enriched_marc::Api::PHYS_CALL_NUMBER => 'Locked Closet Floor',
+                                   enriched_marc::Api::PHYS_CALL_NUMBER_TYPE => '8' }),
+           marc_field(tag: enriched_marc::Api::PHYS_INVENTORY_TAG,
+                      subfields: { enriched_marc::Api::PHYS_LOCATION_CODE => 'vanp',
+                                   enriched_marc::Api::PHYS_CALL_NUMBER => ['ML123 .P567 1875', 'ML123'],
+                                   enriched_marc::Api::PHYS_CALL_NUMBER_TYPE =>
+                                     PennMARC::Classification::LOC_CALL_NUMBER_TYPE }),
+           marc_field(tag: enriched_marc::Api::PHYS_INVENTORY_TAG,
+                      subfields: { enriched_marc::Api::PHYS_LOCATION_CODE => 'vanp',
+                                   enriched_marc::Api::PHYS_CALL_NUMBER => 'P789 .D123 2012',
+                                   enriched_marc::Api::PHYS_CALL_NUMBER_TYPE =>
+                                     PennMARC::Classification::LOC_CALL_NUMBER_TYPE })]
+        end
+
+        it 'returns expected values' do
+          expect(helper.location(record: record, display_value: :specific_location, location_map: mapping))
+            .to(contain_exactly(PennMARC::Mappers.location[:vanp][:specific_location],
+                                PennMARC::Mappers.location_overrides[:albrecht][:specific_location]))
+        end
       end
     end
   end

data/spec/lib/pennmarc/helpers/note_spec.rb

@@ -136,7 +136,7 @@ describe 'PennMARC::Note' do
     it 'returns expected values from 506' do
       expect(values).to contain_exactly(
         'Open to users with valid PennKey Donor Appointment Only estate executors Some Policy No online access
-20300101 Van Pelt URI star'.squish
+20300101 Van Pelt URI'.squish
       )
     end
   end

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -138,6 +138,66 @@ describe 'PennMARC::Title' do
     end
   end
 
+  describe '.detailed_show' do
+    let(:record) do
+      marc_record fields: [
+        marc_field(tag: '245', subfields: { k: 'Letters', f: '1972-1982', b: 'to Lewis Mumford.' })
+      ]
+    end
+
+    context 'with subfields ǂk, ǂf and ǂc' do
+      it 'returns detailed title values' do
+        expect(helper.detailed_show(record)).to eq 'Letters to Lewis Mumford, 1972-1982'
+      end
+    end
+  end
+
+  describe '.alternate_show' do
+    let(:record) do
+      marc_record fields: [
+        marc_field(tag: '245', subfields: { k: 'Letters', b: 'to Lewis Mumford. ' }),
+        marc_field(tag: '880', subfields: { '6': '245', k: 'Lettres', b: 'à Lewis Mumford.' })
+      ]
+    end
+
+    context 'with subfields ǂk and ǂb' do
+      it 'returns alternate title values' do
+        expect(helper.alternate_show(record)).to eq 'Lettres à Lewis Mumford.'
+      end
+    end
+
+    context 'when 880 field is not present' do
+      let(:record) do
+        marc_record fields: [
+          marc_field(tag: '245', subfields: { k: 'Letters', b: 'to Lewis Mumford. ' })
+        ]
+      end
+
+      it 'returns nil' do
+        expect(helper.alternate_show(record)).to be_nil
+      end
+    end
+  end
+
+  describe '.statement_of_responsibility_show' do
+    let(:record) do
+      marc_record fields: [marc_field(tag: '245', subfields: { c: 'statement of responsibility' }),
+                           marc_field(tag: '880', subfields: { '6': '245', c: 'déclaration de responsabilité' })]
+    end
+
+    context 'with ǂc defined' do
+      it 'returns statement of responsibility' do
+        expect(helper.statement_of_responsibility_show(record)).to include 'statement of responsibility'
+      end
+    end
+
+    context 'with linked alternate of 245 ǂc defined' do
+      it 'returns alternate statement of responsibility' do
+        expect(helper.statement_of_responsibility_show(record)).to include 'déclaration de responsabilité'
+      end
+    end
+  end
+
   describe '.sort' do
     context 'with a record with a valid indicator2 value' do
       let(:record) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.0.33
+  version: 1.1.1
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-12 00:00:00.000000000 Z
+date: 2024-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport