pennmarc 1.0.0 → 1.0.2

data/spec/lib/pennmarc/helpers/location_spec.rb

@@ -11,9 +11,9 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'itm', subfields: { g: 'stor' })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_mapping: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')
-        expect(helper.location(record: record, location_mapping: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: 'specific_location')).to contain_exactly('LIBRA')
       end
     end
@@ -22,9 +22,9 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'hld', subfields: { c: 'stor' })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_mapping: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')
-        expect(helper.location(record: record, location_mapping: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: 'specific_location')).to contain_exactly('LIBRA')
       end
     end
@@ -36,7 +36,7 @@ describe 'PennMARC::Location' do
       end
 
       it 'returns item location' do
-        expect(helper.location(record: record, location_mapping: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')
       end
     end
@@ -45,7 +45,7 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'itm', subfields: { g: %w[dent] })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_mapping: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: :library)).to contain_exactly('Health Sciences Libraries',
                                                                             'Levy Dental Medicine Library')
       end
@@ -55,7 +55,7 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: '852', subfields: { g: 'stor' })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_mapping: mapping, display_value: :library)).to be_empty
+        expect(helper.location(record: record, location_map: mapping, display_value: :library)).to be_empty
       end
     end
 
@@ -63,7 +63,7 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'itm', subfields: { g: 'stor' }), marc_field(tag: 'prt')]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_mapping: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: :library)).to contain_exactly('LIBRA', 'Online library')
       end
     end

data/spec/lib/pennmarc/helpers/relation_spec.rb

@@ -65,7 +65,7 @@ describe 'PennMARC::Relation' do
     end
 
     it 'returns specified subfield values from specified field with blank indicator2' do
-      values = helper.related_work_show record, relator_map
+      values = helper.related_work_show record, relator_map: relator_map
       expect(values).to contain_exactly 'Translation of: Some Author Aphorisms, Translator',
                                         'Alt. Prefix: Alt. Author Alt. Aphorisms'
       expect(values).not_to include 'Ignored'
@@ -81,7 +81,7 @@ describe 'PennMARC::Relation' do
     end
 
     it "returns specified subfield values from specified field with '2' in indicator2" do
-      values = helper.contains_show record, relator_map
+      values = helper.contains_show record, relator_map: relator_map
       expect(values).to contain_exactly 'Alt. Prefix: Alt. Name', 'Container of: Some Author Works, Author'
       expect(values).not_to include 'Ignored'
     end

data/spec/lib/pennmarc/helpers/series_spec.rb

@@ -6,7 +6,8 @@ describe 'PennMARC::Series' do
   let(:helper) { PennMARC::Series }
   let(:mapping) { { aut: 'Author' } }
   let(:record) do
-    marc_record fields: [marc_field(tag: '490', subfields: { a: 'Teachings of the feathered pillow' }),
+    marc_record fields: [marc_field(tag: '410', subfields: { a: 'Evil Giant Megacorp' }),
+                         marc_field(tag: '490', subfields: { a: 'Teachings of the feathered pillow' }),
                          marc_field(tag: '880', subfields: { '6': '490', a: 'Учения пернатой подушки' }),
                          marc_field(tag: '800', subfields: { a: 'Bean Bagatolvski', d: '1997-', v: 'bk. 1' }),
                          marc_field(tag: '780', subfields: { a: 'National Comfort Association' }),
@@ -18,21 +19,21 @@ describe 'PennMARC::Series' do
 
   describe '.show' do
     it 'returns the series' do
-      expect(helper.show(record, mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1',
+      expect(helper.show(record, relator_map: mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1',
                                                               'Teachings of the feathered pillow',
-                                                              'Учения пернатой подушки')
+                                                              'Учения пернатой подушки', 'Evil Giant Megacorp')
     end
   end
 
   describe '.values' do
     it 'returns the values' do
-      expect(helper.values(record, mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1.')
+      expect(helper.values(record, relator_map: mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1.')
     end
   end
 
   describe '.search' do
     it 'returns the search values' do
-      expect(helper.search(record)).to contain_exactly('Bean Bagatolvski 1997- bk. 1')
+      expect(helper.search(record)).to contain_exactly('Bean Bagatolvski 1997- bk. 1', 'Evil Giant Megacorp')
     end
 
     it 'returns an empty array if no values are found' do

data/spec/lib/pennmarc/helpers/subject_spec.rb

@@ -10,7 +10,7 @@ describe 'PennMARC::Subject' do
 
   describe '.search' do
     let(:record) { marc_record fields: fields }
-    let(:values) { helper.search(record, relator_map) }
+    let(:values) { helper.search(record, relator_map: relator_map) }
 
     context 'with a mix of included and excluded tags' do
       let(:fields) do

data/spec/lib/pennmarc/parser_spec.rb

@@ -8,6 +8,27 @@ describe PennMARC::Parser do
   let(:record) { record_from 'test.xml' }
 
   it 'delegates to helper modules properly' do
-    expect { parser.title_show(record) }.not_to raise_exception
+    expect(parser.language_search(record)).to eq 'English'
+  end
+
+  it 'delegates to helper modules properly with extra params' do
+    bogus_map = { eng: 'American' }
+    expect(parser.language_search(record, language_map: bogus_map)).to eq 'American'
+  end
+
+  it 'raises an exception if the method call is invalid' do
+    expect { parser.title(record) }.to raise_error NoMethodError
+    expect { parser.title_nope(record) }.to raise_error NoMethodError
+  end
+
+  describe '#respond_to?' do
+    it 'returns true if a helper has the expected method' do
+      expect(parser).to respond_to :language_search
+    end
+
+    it 'returns false if a helper does not have the expected method' do
+      expect(parser).not_to respond_to :language_nope
+      expect(parser).not_to respond_to :nope
+    end
   end
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
 platform: ruby
 authors:
 - Mike Kanning
 - Amrey Mathurin
 - Patrick Perkins
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-07-28 00:00:00.000000000 Z
+date: 2023-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -84,9 +84,6 @@ files:
 - Gemfile
 - Gemfile.lock
 - README.md
-- legacy/indexer.rb
-- legacy/marc.rb
-- legacy/test_file_output.json
 - lib/pennmarc.rb
 - lib/pennmarc/encoding_level.rb
 - lib/pennmarc/enriched_marc.rb
@@ -109,11 +106,13 @@ files:
 - lib/pennmarc/helpers/series.rb
 - lib/pennmarc/helpers/subject.rb
 - lib/pennmarc/helpers/title.rb
+- lib/pennmarc/mappers.rb
 - lib/pennmarc/mappings/language.yml
 - lib/pennmarc/mappings/locations.yml
 - lib/pennmarc/mappings/relator.yml
 - lib/pennmarc/parser.rb
 - lib/pennmarc/util.rb
+- lib/pennmarc/version.rb
 - pennmarc.gemspec
 - spec/fixtures/marcxml/test.xml
 - spec/lib/pennmarc/helpers/citation_spec.rb
@@ -141,7 +140,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -157,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.10
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Penn Libraries Catalog MARC parsing wisdom for cross-project usage
 test_files: []