pelusa 0.1.1 → 0.2.0

data/Gemfile

@@ -3,3 +3,5 @@ source "http://rubygems.org"
 # Specify your gem's dependencies in pelusa.gemspec
 gemspec
 gem 'rake'
+
+gem 'minitest'

data/lib/pelusa.rb

@@ -3,7 +3,7 @@ module Pelusa
   #
   # Returns an Array of results of a given Reporter
   def self.run(files=[], reporter=StdoutReporter)
-    lints = configuration.enabled_lints
+    lints  = configuration.enabled_lints
     runner = Runner.new(lints, reporter)
     runner.run(files)
   end

data/lib/pelusa/cli.rb

@@ -14,7 +14,16 @@ module Pelusa
         _files = Dir["**/*.rb"]
       end
 
-      Pelusa.run(_files)
+      reporters = Pelusa.run(_files)
+
+      reporters.first.class.print_banner unless reporters.empty?
+
+      exit_code = 0
+      reporters.each do |reporter|
+        reporter.report
+        exit_code = 1 unless reporter.successful?
+      end
+      exit_code
     end
 
     def files

data/lib/pelusa/configuration.rb

@@ -4,28 +4,20 @@ module Pelusa
   # Examples
   #
   #   configuration = Pelusa::Configuration.new('my_pelusa_config.yml')
-  #   configuration.present? # => true
   #
   class Configuration
-    YAML_PATH = './.pelusa.yml'
+    YAML_PATH       = './.pelusa.yml'
+    DEFAULT_SOURCES = 'lib/**/*.rb'
 
     # Public: Initializes a configuration instance
     #
     # yaml_path - optional path to the configuration file
     def initialize(yaml_path = YAML_PATH)
-      if File.exist?(yaml_path)
-        @_configuration = YAML.load_file(yaml_path).freeze
-      end
-    end
-
-    # Public: Returns if a custom configuration is present
-    #
-    # Examples
-    #
-    #   Pelusa.configuration.present? # => true
-    #
-    def present?
-      not @_configuration.nil?
+      @_configuration = if File.exist?(yaml_path)
+        YAML.load_file(yaml_path)
+      else
+        {}
+      end.freeze
     end
 
     # Public: Returns custom configuration for the given lint
@@ -46,12 +38,7 @@ module Pelusa
     #   Pelusa.configuration.sources # => lib/**/*.rb
     #
     def sources
-      default = "lib/**/*.rb"
-      if present?
-        @_configuration.fetch('sources') { default }
-      else
-        default
-      end
+      @_configuration.fetch('sources') { DEFAULT_SOURCES }
     end
 
     # Public: Returns an Array of enabled lints

data/lib/pelusa/lint/demeter_law.rb

@@ -25,11 +25,17 @@ module Pelusa
       def iterate_lines!(klass)
         iterator = Iterator.new do |node|
           if node.is_a?(Rubinius::AST::Send) && node.receiver.is_a?(Rubinius::AST::Send)
-            @violations << node.line
+            @violations << node.line unless white_listed?(node.receiver.name)
           end
         end
         Array(klass).each(&iterator)
       end
+
+      def white_listed? method
+        [Class, Fixnum, Enumerable].any? do |enclosing_module|
+          enclosing_module.instance_methods.any? {|instance_method| instance_method == method }
+        end
+      end
     end
   end
 end

data/lib/pelusa/runner.rb

@@ -14,18 +14,9 @@ module Pelusa
     #
     # Returns an Array of Reports of those file runs.
     def run(files)
-      reporters = Array(files).map do |file|
+      Array(files).map do |file|
         run_file(file)
       end
-      @reporter.print_banner
-
-      exit_code = 0
-
-      reporters.each do |reporter|
-        reporter.report
-        exit_code = 1 unless reporter.successful?
-      end
-      exit_code
     end
 
     # Public: Runs the analyzer on a single file.

data/lib/pelusa/version.rb

@@ -1,3 +1,3 @@
 module Pelusa
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/test/pelusa/cli_test.rb

@@ -0,0 +1,24 @@
+require 'test_helper'
+
+module Pelusa
+  describe Cli do
+    describe "#run" do
+      before do
+        @report = stub(empty?: false, report: true, class: Reporter)
+        Pelusa.stubs(:run).returns [@report]
+      end
+      describe 'when the reports are successful' do
+        it 'returns 0' do
+          @report.stubs(successful?: true)
+          Cli.new.run().must_equal 0
+        end
+      end
+      describe 'when the reports have failed' do
+        it 'returns 1' do
+          @report.stubs(successful?: false)
+          Cli.new.run().must_equal 1
+        end
+      end
+    end
+  end
+end

data/test/pelusa/configuration_test.rb

@@ -6,17 +6,6 @@ module Pelusa
       Pelusa::Configuration.new("#{FIXTURES_PATH}/sample_config_one.yml")
     end
 
-    describe "#present?" do
-      it "returns false when configuration doesn't file exists" do
-        configuration = Pelusa::Configuration.new("#{FIXTURES_PATH}/not_here.yml")
-        configuration.present?.must_equal(false)
-      end
-
-      it "returns false when configuration file exists" do
-        configuration.present?.must_equal(true)
-      end
-    end
-
     describe '#sources' do
       it 'returns path to sources' do
         configuration.sources.must_equal 'lib/**/*.rb'
@@ -25,7 +14,7 @@ module Pelusa
       describe 'by default' do
         it 'returns lib/**/*.rb' do
           empty_configuration = Pelusa::Configuration.new("unexistent_yml")
-          empty_configuration.sources.must_equal 'lib/**/*.rb'
+          empty_configuration.sources.must_equal Pelusa::Configuration::DEFAULT_SOURCES
         end
       end
     end

data/test/pelusa/lint/demeter_law_test.rb

@@ -36,6 +36,48 @@ module Pelusa
             analysis.failed?.must_equal true
           end
         end
+
+        describe 'when instantiating a class' do
+          it 'returns a SuccessAnalysis' do
+            klass = """
+            class Foo
+              def execute
+                Bar.new.execute
+              end
+            end""".to_ast
+
+            analysis = @lint.check(klass)
+            analysis.successful?.must_equal true              
+          end
+        end
+
+        describe 'when chaining operations on an Enumerable' do
+          it 'returns a SuccessAnalysis' do
+            klass = """
+            class Foo
+              def execute
+                [1,2,3].map(&:object_id).map(&:object_id)
+              end
+            end""".to_ast
+
+            analysis = @lint.check(klass)
+            analysis.successful?.must_equal true              
+          end
+        end
+      end
+
+      describe 'when chaining Fixnum operations' do
+        it 'returns a SuccessAnalysis' do
+          klass = """
+          class Foo
+            def execute
+              1 + 2 + 3 + 4
+            end
+          end""".to_ast
+
+          analysis = @lint.check(klass)
+          analysis.successful?.must_equal true              
+        end
       end
     end
   end

data/test/pelusa/runner_test.rb

@@ -9,18 +9,12 @@ module Pelusa
         Analyzer.stubs(:new).returns analyzer
       end
 
-      describe 'when the reports are successful' do
-        it 'returns 0' do
-          @report.stubs(successful?: true)
-          Pelusa.run(__FILE__).must_equal 0
-        end
+      it 'runs a single file' do
+        Pelusa.run(__FILE__).must_equal [@report]
       end
 
-      describe 'when the reports have failed' do
-        it 'returns 1' do
-          @report.stubs(successful?: false)
-          Pelusa.run(__FILE__).must_equal 1
-        end
+      it 'runs multiple files' do
+        Pelusa.run([__FILE__, __FILE__]).must_equal [@report, @report]
       end
     end
   end

metadata

@@ -1,35 +1,46 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: pelusa
-version: !ruby/object:Gem::Version
+version: !ruby/object:Gem::Version 
+  hash: 2380615109590600174
   prerelease: 
-  version: 0.1.1
+  segments: 
+  - 0
+  - 2
+  - 0
+  version: 0.2.0
 platform: ruby
-authors:
+authors: 
 - Josep M. Bach
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-05 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  version_requirements: &6620 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  prerelease: false
-  requirement: *6620
+
+date: 2012-03-23 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: mocha
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 2002549777813010636
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id001
 description: Static analysis Lint-type tool to improve your OO Ruby code
-email:
+email: 
 - josep.m.bach@gmail.com
-executables:
+executables: 
 - pelusa
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - .pelusa.yml
 - .rvmrc
@@ -67,6 +78,7 @@ files:
 - test/pelusa/analysis_test.rb
 - test/pelusa/analyzer_test.rb
 - test/pelusa/class_analyzer_test.rb
+- test/pelusa/cli_test.rb
 - test/pelusa/configuration_test.rb
 - test/pelusa/iterator_test.rb
 - test/pelusa/lint/case_statements_test.rb
@@ -85,34 +97,44 @@ files:
 - test/test_helper.rb
 homepage: http://github.com/codegram/pelusa
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 2002549777813010636
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 2002549777813010636
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: pelusa
 rubygems_version: 1.8.12
 signing_key: 
 specification_version: 3
 summary: Static analysis Lint-type tool to improve your OO Ruby code
-test_files:
+test_files: 
 - test/pelusa_test.rb
 - test/test_helper.rb
 - test/pelusa/analysis_test.rb
 - test/pelusa/analyzer_test.rb
 - test/pelusa/class_analyzer_test.rb
+- test/pelusa/cli_test.rb
 - test/pelusa/configuration_test.rb
 - test/pelusa/iterator_test.rb
 - test/pelusa/runner_test.rb