peddler 1.6.7 → 2.0.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: peddler
 version: !ruby/object:Gem::Version
-  version: 1.6.7
+  version: 2.0.0
 platform: ruby
 authors:
 - Hakan Ensari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-02 00:00:00.000000000 Z
+date: 2018-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
@@ -90,10 +90,9 @@ files:
 - lib/mws/subscriptions/client.rb
 - lib/peddler.rb
 - lib/peddler/client.rb
-- lib/peddler/errors.rb
 - lib/peddler/errors/builder.rb
+- lib/peddler/errors/class_generator.rb
 - lib/peddler/errors/error.rb
-- lib/peddler/errors/handler.rb
 - lib/peddler/errors/parser.rb
 - lib/peddler/flat_file_parser.rb
 - lib/peddler/headers.rb
@@ -123,6 +122,7 @@ files:
 - test/integration/test_sellers.rb
 - test/integration/test_subscriptions.rb
 - test/integration_helper.rb
+- test/mws.yml
 - test/mws.yml.example
 - test/null_client.rb
 - test/recorder.rb
@@ -140,11 +140,10 @@ files:
 - test/unit/mws/test_sellers_client.rb
 - test/unit/mws/test_subscriptions_client.rb
 - test/unit/peddler/errors/test_builder.rb
+- test/unit/peddler/errors/test_class_generator.rb
 - test/unit/peddler/errors/test_error.rb
-- test/unit/peddler/errors/test_handler.rb
 - test/unit/peddler/errors/test_parser.rb
 - test/unit/peddler/test_client.rb
-- test/unit/peddler/test_errors.rb
 - test/unit/peddler/test_flat_file_parser.rb
 - test/unit/peddler/test_headers.rb
 - test/unit/peddler/test_marketplace.rb
@@ -185,7 +184,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -207,10 +206,9 @@ test_files:
 - test/unit/peddler/test_xml_response_parser.rb
 - test/unit/peddler/test_xml_parser.rb
 - test/unit/peddler/test_flat_file_parser.rb
-- test/unit/peddler/test_errors.rb
 - test/unit/peddler/errors/test_error.rb
 - test/unit/peddler/errors/test_builder.rb
-- test/unit/peddler/errors/test_handler.rb
+- test/unit/peddler/errors/test_class_generator.rb
 - test/unit/peddler/errors/test_parser.rb
 - test/unit/peddler/test_parser.rb
 - test/unit/mws/test_finances_client.rb
@@ -246,6 +244,7 @@ test_files:
 - test/integration/test_off_amazon_payments.rb
 - test/integration/test_fulfillment_inventory.rb
 - test/integration_helper.rb
+- test/mws.yml
 - test/vcr_cassettes/Products.yml
 - test/vcr_cassettes/MerchantFulfillment.yml
 - test/vcr_cassettes/CustomerInformation.yml

data/lib/peddler/errors.rb

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-require 'peddler/errors/handler'
-
-module Peddler
-  # @api private
-  module Errors
-    MWS.constants.each do |klass|
-      MWS.const_get(klass).const_get(:Client).error_handler = Handler
-    end
-  end
-end

data/lib/peddler/errors/handler.rb

@@ -1,59 +0,0 @@
-# frozen_string_literal: true
-
-require 'excon'
-require 'peddler/errors/builder'
-
-module Peddler
-  module Errors
-    # @api private
-    class Handler
-      DIGIT_AS_FIRST_CHAR = /^\d/
-      private_constant :DIGIT_AS_FIRST_CHAR
-
-      def self.call(exception)
-        new(exception).handle
-      end
-
-      def self.parameters
-        1
-      end
-
-      attr_reader :exception
-
-      def initialize(exception)
-        @exception = exception
-      end
-
-      def handle
-        raise exception unless http_status_error?
-        raise exception if bad_name_for_error_class?
-
-        raise error_class.new(error_message, exception)
-      end
-
-      private
-
-      def error_class
-        Errors.const_get(error_name)
-      rescue NameError
-        Builder.build(error_name)
-      end
-
-      def http_status_error?
-        exception.is_a?(::Excon::Error::HTTPStatus)
-      end
-
-      def bad_name_for_error_class?
-        error_name =~ DIGIT_AS_FIRST_CHAR
-      end
-
-      def error_name
-        exception.response.code
-      end
-
-      def error_message
-        exception.response.message
-      end
-    end
-  end
-end

data/test/unit/peddler/errors/test_handler.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-require 'helper'
-require 'peddler/errors/handler'
-
-class TestPeddlerErrorsHandler < MiniTest::Test
-  def setup
-    @error = Peddler::Errors::Handler.call(@cause)
-  rescue StandardError => @error
-  end
-
-  class CausedByHTTPStatusError < TestPeddlerErrorsHandler
-    def setup
-      @code = 'FeedProcessingResultNotReady'
-      @message = 'Feed Submission Result is not ready for Feed 123'
-      @cause = Excon::Error::NotFound.new(
-        'Expected(200) <=> Actual(404 Not Found)',
-        nil,
-        OpenStruct.new(code: @code, message: @message)
-      )
-      super
-    end
-
-    def test_generates_custom_error
-      assert_includes @error.class.name, @code
-    end
-
-    def test_provides_message
-      assert_equal @message, @error.message
-    end
-
-    def test_provides_cause
-      assert_equal @cause, @error.cause
-    end
-  end
-
-  class CausedByAnotherError < TestPeddlerErrorsHandler
-    def setup
-      @cause = StandardError.new
-      super
-    end
-
-    def test_returns_original_error
-      assert_equal @cause, @error
-    end
-  end
-
-  class CausedByInternalServerError < TestPeddlerErrorsHandler
-    def setup
-      @cause = Excon::Error::InternalServerError.new(
-        nil,
-        nil,
-        OpenStruct.new(code: '500', message: nil)
-      )
-      super
-    end
-
-    def test_returns_original_error
-      assert_equal @cause, @error
-    end
-  end
-end

data/test/unit/peddler/test_errors.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-require 'helper'
-require 'peddler/errors'
-
-class TestPeddlerErrors < MiniTest::Test
-  def teardown
-    clients.each do |client|
-      client.error_handler = proc { raise }
-    end
-  end
-
-  def test_enables_new_error_handler
-    clients.each do |client|
-      assert_equal Peddler::Errors::Handler, client.error_handler
-    end
-  end
-
-  private
-
-  def clients
-    MWS.constants.map do |klass|
-      MWS.const_get(klass).const_get(:Client)
-    end
-  end
-end