peddler 1.6.3 → 1.6.4

data/lib/mws/orders.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'mws/orders/client'

data/lib/mws/orders/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/client'
 
 module MWS
@@ -106,9 +108,10 @@ module MWS
       private
 
       def require_start_time!
-        if operation.values_at('CreatedAfter', 'LastUpdatedAfter').compact.empty?
-          raise ArgumentError, 'specify created_after or last_updated_after'
-        end
+        return if operation.key?('CreatedAfter')
+        return if operation.key?('LastUpdatedAfter')
+
+        raise ArgumentError, 'specify created_after or last_updated_after'
       end
     end
   end

data/lib/mws/products.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'mws/products/client'

data/lib/mws/products/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/client'
 
 module MWS
@@ -13,7 +15,8 @@ module MWS
       # Lists products and their attributes, based on a search query
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_ListMatchingProducts.html
-      # @overload list_matching_products(query, opts = { marketplace_id: primary_marketplace_id })
+      # @overload list_matching_products(query, opts = { marketplace_id:
+      #   primary_marketplace_id })
       #   @param [String] query
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -30,7 +33,8 @@ module MWS
       #   SellerSKU, UPC, EAN, ISBN, and JAN values
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetMatchingProduct.html
-      # @overload get_matching_product_for_id(id_type, *ids, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_matching_product_for_id(id_type, *ids, opts = {
+      #   marketplace_id: primary_marketplace_id })
       #   @param [String] id_type
       #   @param [String] id one or more ids
       #   @param [Hash] opts
@@ -49,7 +53,8 @@ module MWS
       # Lists products and their attributes, based on a list of ASIN values
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetMatchingProductForId.html
-      # @overload get_matching_product(*asins, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_matching_product(*asins, opts = { marketplace_id:
+      #   primary_marketplace_id })
       #   @param [String] asin one or more asins
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -67,7 +72,8 @@ module MWS
       # Gets the current competitive price of a product, based on Seller SKU
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetCompetitivePricingForSKU.html
-      # @overload get_competitive_pricing_for_sku(*seller_skus, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_competitive_pricing_for_sku(*seller_skus, opts = {
+      #   marketplace_id: primary_marketplace_id })
       #   @param [String] seller_sku one or more seller_skus
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -85,7 +91,8 @@ module MWS
       # Gets the current competitive price of a product, identified by its ASIN
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetCompetitivePricingForASIN.html
-      # @overload get_competitive_pricing_for_asin(*asins, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_competitive_pricing_for_asin(*asins, opts = {
+      #   marketplace_id: primary_marketplace_id })
       #   @param [String] asin one or more asins
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -104,7 +111,8 @@ module MWS
       # a product, based on Seller SKU
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetLowestOfferListingsForSKU.html
-      # @overload get_lowest_offer_listings_for_sku(*seller_skus, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_lowest_offer_listings_for_sku(*seller_skus, opts = {
+      #   marketplace_id: primary_marketplace_id })
       #   @param [String] seller_sku one or more seller_skus
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -125,7 +133,8 @@ module MWS
       # a product, identified by its ASIN
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetLowestOfferListingsForASIN.html
-      # @overload get_lowest_offer_listings_for_asin(*asins, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_lowest_offer_listings_for_asin(*asins, opts = {
+      #   marketplace_id: primary_marketplace_id })
       #   @param [String] asin one or more asins
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -145,13 +154,15 @@ module MWS
       # Gets lowest priced offers for a single product, based on SellerSKU
       #
       # @see http://docs.developer.amazonservices.com/en_MX/products/Products_GetLowestPricedOffersForSKU.html
-      # @overload get_lowest_priced_offers_for_sku(seller_sku, item_condition, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_lowest_priced_offers_for_sku(seller_sku, item_condition,
+      #   opts = { marketplace_id: primary_marketplace_id })
       #   @param [String] seller_sku
       #   @param [String] item_condition
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
       # @return [Peddler::XMLParser]
-      def get_lowest_priced_offers_for_sku(seller_sku, item_condition, opts = {})
+      def get_lowest_priced_offers_for_sku(seller_sku, item_condition,
+                                           opts = {})
         opts.update(
           'SellerSKU' => seller_sku,
           'ItemCondition' => item_condition
@@ -165,7 +176,8 @@ module MWS
       # Gets lowest priced offers for a single product, based on ASIN
       #
       # @see http://docs.developer.amazonservices.com/en_MX/products/Products_GetLowestPricedOffersForASIN.html
-      # @overload get_lowest_priced_offers_for_asin(asin, item_condition, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_lowest_priced_offers_for_asin(asin, item_condition, opts =
+      #   { marketplace_id: primary_marketplace_id })
       #   @param [String] asin
       #   @param [String] item_condition
       #   @param [Hash] opts
@@ -200,7 +212,8 @@ module MWS
       # Seller SKU
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetMyPriceForSKU.html
-      # @overload get_my_price_for_sku(*seller_skus, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_my_price_for_sku(*seller_skus, opts = { marketplace_id:
+      #   primary_marketplace_id })
       #   @param [String] seller_sku one or more seller_skus
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -220,7 +233,8 @@ module MWS
       # its ASIN
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetMyPriceForASIN.html
-      # @overload get_my_price_for_asin(*asins, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_my_price_for_asin(*asins, opts = { marketplace_id:
+      #   primary_marketplace_id })
       #   @param [String] asin one or more asins
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -240,7 +254,8 @@ module MWS
       # Seller`SKU
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetProductCategoriesForSKU.html
-      # @overload get_product_categories_for_sku(sku, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_product_categories_for_sku(sku, opts = { marketplace_id:
+      #   primary_marketplace_id })
       #   @param [String] seller_sku
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
@@ -255,7 +270,8 @@ module MWS
       # Gets parent product categories that a product belongs to, based on ASIN
       #
       # @see http://docs.developer.amazonservices.com/en_US/products/Products_GetProductCategoriesForASIN.html
-      # @overload get_product_categories_for_asin(asin, opts = { marketplace_id: primary_marketplace_id })
+      # @overload get_product_categories_for_asin(asin, opts = { marketplace_id:
+      #   primary_marketplace_id })
       #   @param [String] asin
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id

data/lib/mws/recommendations.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'mws/recommendations/client'

data/lib/mws/recommendations/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/client'
 
 module MWS
@@ -17,7 +19,8 @@ module MWS
       # @see http://docs.developer.amazonservices.com/en_US/recommendations/Recommendations_GetLastUpdatedTimeForRecommendations.html
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def get_last_updated_time_for_recommendations(marketplace_id = primary_marketplace_id)
+      def get_last_updated_time_for_recommendations(marketplace_id =
+                                                      primary_marketplace_id)
         operation('GetLastUpdatedTimeForRecommendations')
           .add('MarketplaceId' => marketplace_id)
 
@@ -28,7 +31,8 @@ module MWS
       # categories for a specific marketplace
       #
       # @see http://docs.developer.amazonservices.com/en_US/recommendations/Recommendations_ListRecommendations.html
-      # @overload list_recommendations(opts = { marketplace_id: primary_marketplace_id })
+      # @overload list_recommendations(opts = { marketplace_id:
+      #   primary_marketplace_id })
       #   @param [Hash] opts
       #   @option opts [String] :marketplace_id
       #   @option opts [String] :recommendation_category

data/lib/mws/reports.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'mws/reports/client'

data/lib/mws/reports/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/client'
 
 module MWS

data/lib/mws/sellers.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'mws/sellers/client'

data/lib/mws/sellers/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/client'
 
 module MWS

data/lib/mws/subscriptions.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'mws/subscriptions/client'

data/lib/mws/subscriptions/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/client'
 
 module MWS
@@ -18,7 +20,8 @@ module MWS
       # @param [String] sqs_queue_url
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def register_destination(sqs_queue_url, marketplace_id = primary_marketplace_id)
+      def register_destination(sqs_queue_url,
+                               marketplace_id = primary_marketplace_id)
         operation('RegisterDestination')
           .add('MarketplaceId' => marketplace_id)
           .add(build_destination(sqs_queue_url))
@@ -32,7 +35,8 @@ module MWS
       # @param [String] sqs_queue_url
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def deregister_destination(sqs_queue_url, marketplace_id = primary_marketplace_id)
+      def deregister_destination(sqs_queue_url,
+                                 marketplace_id = primary_marketplace_id)
         operation('DeregisterDestination')
           .add('MarketplaceId' => marketplace_id)
           .add(build_destination(sqs_queue_url))
@@ -58,7 +62,9 @@ module MWS
       # @param [String] sqs_queue_url
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def send_test_notification_to_destination(sqs_queue_url, marketplace_id = primary_marketplace_id)
+      def send_test_notification_to_destination(sqs_queue_url,
+                                                marketplace_id =
+                                                  primary_marketplace_id)
         operation('SendTestNotificationToDestination')
           .add('MarketplaceId' => marketplace_id)
           .add(build_destination(sqs_queue_url))
@@ -73,7 +79,8 @@ module MWS
       # @param [String] sqs_queue_url
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def create_subscription(notification_type, sqs_queue_url, marketplace_id = primary_marketplace_id)
+      def create_subscription(notification_type, sqs_queue_url,
+                              marketplace_id = primary_marketplace_id)
         operation('CreateSubscription')
           .add('MarketplaceId' => marketplace_id)
           .add(build_subscription(notification_type, sqs_queue_url))
@@ -88,7 +95,8 @@ module MWS
       # @param [String] sqs_queue_url
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def get_subscription(notification_type, sqs_queue_url, marketplace_id = primary_marketplace_id)
+      def get_subscription(notification_type, sqs_queue_url,
+                           marketplace_id = primary_marketplace_id)
         operation('GetSubscription')
           .add(
             'MarketplaceId' => marketplace_id,
@@ -106,7 +114,8 @@ module MWS
       # @param [String] sqs_queue_url
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def delete_subscription(notification_type, sqs_queue_url, marketplace_id = primary_marketplace_id)
+      def delete_subscription(notification_type, sqs_queue_url,
+                              marketplace_id = primary_marketplace_id)
         operation('DeleteSubscription')
           .add(
             'MarketplaceId' => marketplace_id,
@@ -137,7 +146,8 @@ module MWS
       # @param [Boolean] enabled
       # @param [String] marketplace_id
       # @return [Peddler::XMLParser]
-      def update_subscription(notification_type, sqs_queue_url, enabled, marketplace_id = primary_marketplace_id)
+      def update_subscription(notification_type, sqs_queue_url, enabled,
+                              marketplace_id = primary_marketplace_id)
         operation('UpdateSubscription')
           .add('MarketplaceId' => marketplace_id)
           .add(build_subscription(notification_type, sqs_queue_url, enabled))
@@ -169,8 +179,10 @@ module MWS
           'Subscription.IsEnabled' => enabled,
           'Subscription.NotificationType' => notification_type,
           'Subscription.Destination.DeliveryChannel' => 'SQS',
-          'Subscription.Destination.AttributeList.member.1.Key' => 'sqsQueueUrl',
-          'Subscription.Destination.AttributeList.member.1.Value' => sqs_queue_url
+          'Subscription.Destination.AttributeList.member.1.Key' =>
+            'sqsQueueUrl',
+          'Subscription.Destination.AttributeList.member.1.Value' =>
+            sqs_queue_url
         }
       end
     end

data/lib/peddler.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'mws'

data/lib/peddler/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 require 'jeff'
 require 'peddler/errors/parser'

data/lib/peddler/errors/builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'singleton'
 require 'peddler/errors/error'
 

data/lib/peddler/errors/error.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 module Peddler
   # @api private
   module Errors
     # Known codes
     CODES = %w[
       AccessDenied
+      InternalError
+      InvalidAccessKeyId
       InvalidMarketplace
       InvalidParameterValue
       InvalidRequest

data/lib/peddler/errors/handler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'excon'
 require 'peddler/errors/builder'
 

data/lib/peddler/errors/parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/xml_parser'
 
 module Peddler

data/lib/peddler/flat_file_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'delegate'
 require 'csv'
 require 'digest/md5'
@@ -34,7 +36,8 @@ module Peddler
     private
 
     def scrub_body!(encoding)
-      body.force_encoding(encoding) unless body.encoding == Encoding::UTF_8
+      return if body.encoding == Encoding::UTF_8
+      self.body = body.dup.force_encoding(encoding)
     end
 
     def extract_content_and_summary

data/lib/peddler/headers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peddler
   # Parses MWS-specific headers
   module Headers

data/lib/peddler/marketplace.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peddler
   # @api private
   # @see https://docs.developer.amazonservices.com/en_US/dev_guide/DG_Endpoints.html

data/lib/peddler/operation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'delegate'
 require 'time'
 require 'peddler/structured_list'

data/lib/peddler/parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/flat_file_parser'
 require 'peddler/xml_response_parser'
 

data/lib/peddler/structured_list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peddler
   # @api private
   class StructuredList

data/lib/peddler/vcr_matcher.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peddler
   # A custom matcher that can be used to record MWS interactions when
   # integration-testing

data/lib/peddler/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Peddler
-  VERSION = '1.6.3'.freeze
+  VERSION = '1.6.4'
 end

data/lib/peddler/xml_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'delegate'
 require 'dig_rb'
 require 'forwardable'

data/lib/peddler/xml_response_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'peddler/xml_parser'
 
 module Peddler

data/test/credentials.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'forwardable'
+require 'yaml'
+
+module Credentials
+  class <<self
+    extend Forwardable
+    include Enumerable
+
+    attr_reader :all
+
+    def_delegators :all, :each
+  end
+
+  %w[mws.yml mws.yml.example].each do |path|
+    file = File.expand_path("../#{path}", __FILE__)
+    if File.exist?(file)
+      @all = YAML.load_file(file)
+      break
+    end
+  end
+end