pechkinrb 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b12560dec83e2cc81e6e2767488f07ca6f136742
-  data.tar.gz: 5fd46487c190259b0e508f7343ce42ac5651821c
+  metadata.gz: 68527ebfa26c7cbe361089e24f07a45b124e2c02
+  data.tar.gz: 30e61fa6e4cd727c1d0fd9190b1b7df40df890d3
 SHA512:
-  metadata.gz: c231c3a005e5f9ce01f5042ba7c4949080a0969490fe2cd33a25d88f29d499689ea1411b023d99b3c1ce96cfa54f5442c8aec1c6356b091c18954a08136325f2
-  data.tar.gz: 0c9198aac51848c50e261658547482f9a3d085899812bbe77016bb37a87da33d94614a115d5a842e54bd87076be9ef5ffdab6efe7f892d7682758386b17db175
+  metadata.gz: 8cc21827802e78eec2978c54d5ddc06e352a5332197fe3b0445a659fe0ff27ddac1862336961bd3483727545614900a8717b75668aefef04dfe8dacf09324d13
+  data.tar.gz: a36d6be6d8a2aa52cc572a629e3ae42b38c13a1c7ecfa9f80ef9cb2e95bda3897ecb7eb118fbf9fd85151c816bf1c8610b23ab391454ec0a45e893367b4c4208

data/README.md

@@ -2,10 +2,14 @@
 
 [![Code Climate](https://codeclimate.com/github/crsde/PechkinRb/badges/gpa.svg)](https://codeclimate.com/github/crsde/PechkinRb)
 
-This gem provides you with easy Ruby interface for pechkin-mail.ru mail service.
+This gem provides you with simple Ruby interface for pechkin-mail.ru mail service.
 
 Documentation available at http://www.rubydoc.info/github/crsde/PechkinRb
 
+Original API documentation https://pechkin-mail.ru/api/
+
+At this moment, mainly list management features implemented, but there are common way to call any API method, using *#call_method*
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -22,10 +26,15 @@ Or install it yourself as:
 
 ## Usage
 
+PechkinRb declares some classes for API objects, like *List*, *Member*, etc
+
     require "pechkinrb"
     conn = Pechkin::Connection.new('login', 'password')
     conn.lists # => Array of Pechkin::List instances
 
+Also, you can use universal invocation method with *#call_method*
+
+    conn.call_method('lists.get_members', list_id: 1)
 
 ## Contributing
 

data/lib/pechkinrb/api_exception.rb

@@ -1,4 +1,7 @@
 module Pechkin
-  class ApiException < StandardError      
+  class ApiException < StandardError
+  end
+
+  class NoDataException < ApiException
   end
 end

data/lib/pechkinrb/list.rb

@@ -49,7 +49,7 @@ module Pechkin
     #
     # @param params [Hash] Params to be passed
     # @return [Pechkin::Member] New member instance
-    def add_member
+    def add_member(params)
       added = connection.call_method('lists.add_member', params.merge(id_params))
       get_members(added).first
     end

data/lib/pechkinrb/pechkin.rb

@@ -32,10 +32,15 @@ module Pechkin
     def call_method(method, params = {})
       response = connection.post '/', {method: method}.merge(credentials).merge(params)
       err_code = response.body["response"]["msg"]["err_code"]
-      unless err_code == 0
+
+      case err_code
+      when 0
+        response.body["response"]["data"]
+      when 4
+        raise Pechkin::NoDataException.new(response.body["response"]["msg"]["text"])
+      else
         raise Pechkin::ApiException.new(response.body["response"]["msg"]["text"])
       end
-      response.body["response"]["data"]
     end
 
     # Invokes 'lists.get' API method

data/lib/pechkinrb/version.rb

@@ -1,3 +1,3 @@
 module Pechkinrb
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/pechkinrb.gemspec

@@ -19,9 +19,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rake", "~> 10.4"
+  spec.add_development_dependency "rspec", "~> 3.0"
 
-  spec.add_runtime_dependency 'faraday'
-  spec.add_runtime_dependency 'faraday_middleware'
+  spec.add_runtime_dependency 'faraday', "~> 0.9"
+  spec.add_runtime_dependency 'faraday_middleware', "~> 0.9"
 end

data/spec/connection_spec.rb

@@ -28,6 +28,16 @@ describe Pechkin::Connection do
               }
           }]
         end
+
+        stubs.post("/", {username: '1', password: '2', method: 'get_none', param: 'value'} ) do
+          [200, {}, {
+            'response' =>
+              {
+                'msg' => { 'text' => "Error", 'err_code' => 4 },
+                'data' => { 'ok' => "ok" }
+              }
+          }]
+        end
       end
     end
 
@@ -42,5 +52,9 @@ describe Pechkin::Connection do
     it "raises error when bad response received" do
       expect { connection.call_method('get_bad', {param: 'value'}) }.to raise_error(Pechkin::ApiException)
     end
+
+    it "raises no_data error when bad response received" do
+      expect { connection.call_method('get_none', {param: 'value'}) }.to raise_error(Pechkin::NoDataException)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pechkinrb
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Alexandr Prokopenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-02 00:00:00.000000000 Z
+date: 2015-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,58 +28,58 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 description: Interface for pechkin-mail.ru service API
 email:
 - prokopenko@igc.ru