pec_calc_client 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f8e024637ff9ea194e3506a0c4136ee40f4925c
-  data.tar.gz: ed9b333c2e543865d30173cc07145ca1c41b0e0b
+  metadata.gz: f1649565b1eb9a909a3317eefd280cc6b77c436c
+  data.tar.gz: 9aafc336b1a3c22e01278971e3c50a28dd8c75d2
 SHA512:
-  metadata.gz: a2e2c8563ef730037e0f96f39e4929723cc444d1dbf2791ec75d6f757333dba1295a99eedc10ce8189d376bd60c46918aa0f169ca8898c113bde45498820bb09
-  data.tar.gz: 8efe7beee275daa3df819d053f26ec30b632b0d2a53ead28c40eb2552a0a8adbab3067e9f9908ba7cf54f0320427e0a3ed964ed53fa3be9b7310e1cf2bf158a9
+  metadata.gz: b5a19004f6e6267cc2f96f096c5b8fc16199fe27df1d82a600ffa7ff3c036071ac2708e590d2e854218c431e66d5e5de1132cec25b5d82bf7ebc691c0441fc1b
+  data.tar.gz: 910a1abf359bdc9b343c9c9981204f70f4d8f0c6b8175fac3cae28679fa29ee996f7f965d27f756e2e377cd141a3dbe8b7e18d68ef75a12542ec1ff3d6dc224a

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    pec_calc_client (0.1.2)
+    pec_calc_client (1.0.0)
       json (~> 1.8)
+      rack (~> 1.6)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -23,14 +23,14 @@ Or install it yourself as:
 
 ## Usage
 
-Get Delivery Regions: 
+Get Delivery Regions:
 
 ```ruby
 require 'pec_calc_client'
 
 PecCalcClient::Region.all
 ```
-Extract Delivery Cities by region: 
+Extract Delivery Cities by region:
 
 ```ruby
 require 'pec_calc_client'

data/Rakefile

@@ -1 +1 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

data/bin/console

@@ -1,14 +1,14 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "pec/calc/client"
+require 'bundler/setup'
+require 'pec/calc/client'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
+# require 'pry'
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/lib/pec_calc_client/calc.rb

@@ -1,19 +1,19 @@
 module PecCalcClient
+  # Calculator container
   class Calc
-
     extend RequestClass
     include RequestObject
 
     URL = 'http://pecom.ru/bitrix/components/pecom/calc/ajax.php'
 
-    PARAMS = %w{ plombir strah ashan night pal pallets }
+    PARAMS = %w( plombir strah ashan night pal pallets )
 
     set_readers
 
     attr_accessor :delivery, :take, :places
 
     def initialize(params)
-      set_params params
+      init_params params
     end
 
     def calc
@@ -25,7 +25,9 @@ module PecCalcClient
       out = to_h
       out[:deliver] = @delivery.to_h
       out[:take] = @take.to_h
-      out[:places] = @places.each_with_index.map{ |place, i| [ i, place.to_a ] }.to_h
+      out[:places] = @places.each_with_index.map do |place, i|
+        [i, place.to_a]
+      end.to_h
       out
     end
 
@@ -34,6 +36,5 @@ module PecCalcClient
     def prepare_result(result)
       CalcResult.new result.to_hash
     end
-
   end
 end

data/lib/pec_calc_client/calc_result.rb

@@ -1,11 +1,10 @@
 module PecCalcClient
+  # Result of delivery calculation
   class CalcResult
-
     attr_reader :result
 
     def initialize(params)
       @result = params
     end
-
   end
 end

data/lib/pec_calc_client/connector.rb

@@ -2,6 +2,7 @@ require 'net/http'
 require 'rack/utils'
 
 module PecCalcClient
+  # HTTP Connector
   class Connector
     def initialize(url)
       @url = url.to_s
@@ -20,7 +21,10 @@ module PecCalcClient
     private
 
     def prepare_params(params)
-      @params_string = Rack::Utils.build_nested_query(params).gsub(/[\[\]\.\-]/, '[' => '%5B', ']' => '%5D', '.' => '%2E', '-' => '%2D')
+      @params_string = Rack::Utils.build_nested_query(params).gsub(
+        /[\[\]\.\-]/,
+        '[' => '%5B', ']' => '%5D', '.' => '%2E', '-' => '%2D'
+      )
     end
 
     def url_with_params

data/lib/pec_calc_client/delivery.rb

@@ -1,15 +1,15 @@
 module PecCalcClient
+  # Delivery
   class Delivery
-
     extend RequestClass
     include RequestObject
 
-    PARAMS = %w{ town tent gidro manip speed moscow }
+    PARAMS = %w( town tent gidro manip speed moscow )
 
     set_readers
 
     def initialize(params)
-      set_params params
+      init_params params
     end
   end
 end

data/lib/pec_calc_client/place.rb

@@ -1,16 +1,26 @@
 module PecCalcClient
+  # Delivery Place
   class Place
+    PLACE_PARAMS = %w(
+      width
+      length
+      height
+      volume
+      weight
+      oversized
+      sturdy_packaging
+    )
 
-    PLACE_PARAMS = %w{ width length height volume weight oversized sturdy_packaging }
-
-    PLACE_PARAMS.each{ |param_name| attr_reader param_name }
+    PLACE_PARAMS.each { |param_name| attr_reader param_name }
 
     def initialize(params)
-      params.each{ |k, v| instance_variable_set("@#{ k }", v) if PLACE_PARAMS.include? k.to_s }
+      params.each do |k, v|
+        instance_variable_set("@#{k}", v) if PLACE_PARAMS.include? k.to_s
+      end
     end
 
     def to_a
-      PLACE_PARAMS.map{ |k| instance_variable_get("@#{ k }") }
+      PLACE_PARAMS.map { |k| instance_variable_get("@#{k}") }
     end
   end
 end

data/lib/pec_calc_client/region.rb

@@ -1,17 +1,19 @@
 module PecCalcClient
+  # Delivery region
   class Region
-
     URL = 'http://pecom.ru/ru/calc/towns.php'
 
     attr_reader :name, :towns
 
-    def initialize name, towns
+    def initialize(name, towns)
       @name = name
-      @towns = towns.collect{ |id, name| Town.new id, name }
+      @towns = towns.collect { |id, town_name| Town.new id, town_name }
     end
 
     def self.all
-      Connector.new(self::URL).request.to_hash.collect{ |name, towns| self.new name, towns }
+      Connector.new(self::URL).request.to_hash.collect do |name, towns|
+        new name, towns
+      end
     end
   end
 end

data/lib/pec_calc_client/response.rb

@@ -1,10 +1,11 @@
 require 'json'
 
 module PecCalcClient
+  # Response from api server
   class Response
     def initialize(response)
       @response = response
-      raise BadResponse, 'Respons Code not 200' if @response.code != '200'
+      fail BadResponse, 'Respons Code not 200' if @response.code != '200'
     end
 
     def to_hash

data/lib/pec_calc_client/take.rb

@@ -1,16 +1,15 @@
 module PecCalcClient
+  # Take from sender
   class Take
-
     extend RequestClass
     include RequestObject
 
-    PARAMS = %w{ town tent gidro manip speed moscow }
+    PARAMS = %w( town tent gidro manip speed moscow )
 
     set_readers
 
     def initialize(params)
-      set_params params
+      init_params params
     end
-
   end
 end

data/lib/pec_calc_client/town.rb

@@ -1,15 +1,16 @@
 module PecCalcClient
+  # Delivery town
   class Town
-
     attr_reader :id, :name
 
-    def initialize id, name
-      @id, @name = id, name
+    def initialize(id, name)
+      @id = id
+      @name = name
     end
 
     def self.all
       Connector.new(URL).request.to_json.collect do |town|
-        self.new town
+        new town
       end
     end
   end

data/lib/pec_calc_client.rb

@@ -1,22 +1,31 @@
+# Main container
 module PecCalcClient
+  # Error of connection
   class ConnectionError < Exception; end
+  # Exception for non 200 HTTP code
   class BadResponse < Exception; end
 
+  # Methods for request class
   module RequestClass
     def set_readers
-      self::PARAMS.each{ |param_name| attr_reader param_name }
+      self::PARAMS.each { |param_name| attr_reader param_name }
     end
   end
 
+  # Methods for request instance
   module RequestObject
-    def set_params(params)
-      params.each{ |k, v| instance_variable_set("@#{ k }", v) if self.class::PARAMS.include? k.to_s }
+    def init_params(params)
+      params.each do |k, v|
+        instance_variable_set("@#{k}", v) if self.class::PARAMS.include?(k.to_s)
+      end
     end
 
     def to_h
-      self.class::PARAMS.map{ |k| [k, instance_variable_get("@#{ k }") ] }.to_h
+      self.class::PARAMS.map { |k| [k, instance_variable_get("@#{k}")] }.to_h
     end
   end
 end
 
-Dir["#{ File.dirname(__FILE__) }/pec_calc_client/*.rb"].each {|file| require file }
+Dir["#{File.dirname(__FILE__)}/pec_calc_client/*.rb"].each do |file|
+  require file
+end

data/spec/pec_calc_client/calc_result_spec.rb

@@ -1,7 +1,7 @@
 describe 'CalcResult' do
   describe '#initialize' do
     it 'Should be initialized' do
-      calc_result = PecCalcClient::CalcResult.new(Hash.new)
+      calc_result = PecCalcClient::CalcResult.new({})
       expect(calc_result.result.class).to eq Hash
     end
   end

data/spec/pec_calc_client/calc_spec.rb

@@ -1,13 +1,41 @@
 describe 'Calc' do
-
-  calc_params = { plombir: 12, strah: 33, ashan: 1, night: 1, pal: 3, pallets: 4 }
-  place_params = { width: 0.5, length: 0.3,height: 0.5, volume: 0.2, weight: 0.03, oversized: true, sturdy_packaging: true }
-  delivery_params = { town: 134104, tent: 1, gidro: 1, manip: 1, speed: 0, moscow: 0 }
-  take_params = { town: 175004, tent: 1, gidro: 1, manip: 1, speed: 1, moscow: 1 }
+  calc_params = {
+    plombir: 12,
+    strah: 33,
+    ashan: 1,
+    night: 1,
+    pal: 3,
+    pallets: 4
+  }
+  place_params = {
+    width: 0.5,
+    length: 0.3,
+    height: 0.5,
+    volume: 0.2,
+    weight: 0.03,
+    oversized: true,
+    sturdy_packaging: true
+  }
+  delivery_params = {
+    town: 134_104,
+    tent: 1,
+    gidro: 1,
+    manip: 1,
+    speed: 0,
+    moscow: 0
+  }
+  take_params = {
+    town: 175_004,
+    tent: 1,
+    gidro: 1,
+    manip: 1,
+    speed: 1,
+    moscow: 1
+  }
 
   let! :calc do
     calc = PecCalcClient::Calc.new calc_params
-    calc.places = (1..3).map{ PecCalcClient::Place.new place_params }
+    calc.places = (1..3).map { PecCalcClient::Place.new place_params }
     calc.delivery = PecCalcClient::Delivery.new delivery_params
     calc.take = PecCalcClient::Take.new take_params
     calc
@@ -16,7 +44,9 @@ describe 'Calc' do
   describe '#initialize' do
     it 'Should be initialized' do
       calc = PecCalcClient::Calc.new(calc_params)
-      hash_of_params = PecCalcClient::Calc::PARAMS.map{ |k| [ k.to_sym, calc.send(k) ] }.to_h
+      hash_of_params = PecCalcClient::Calc::PARAMS.map do |k|
+        [k.to_sym, calc.send(k)]
+      end.to_h
       expect(hash_of_params).to eq calc_params
     end
   end

data/spec/pec_calc_client/connector_spec.rb

@@ -1,10 +1,9 @@
 describe 'Connector' do
-
   url = 'http://pecom.ru/ru/calc/towns.php'
   bad_url = 'http://1.ru'
 
-  let!(:connector){ PecCalcClient::Connector.new(url) }
-  let!(:bad_connector){ PecCalcClient::Connector.new(bad_url) }
+  let!(:connector) { PecCalcClient::Connector.new(url) }
+  let!(:bad_connector) { PecCalcClient::Connector.new(bad_url) }
 
   describe '#initialize' do
     it 'Should be object' do
@@ -19,8 +18,8 @@ describe 'Connector' do
     end
 
     it 'Raise Exception' do
-      expect(lambda { bad_connector.request }).to raise_error(PecCalcClient::ConnectionError)
+      expect(-> { bad_connector.request })
+        .to raise_error(PecCalcClient::ConnectionError)
     end
   end
-
 end

data/spec/pec_calc_client/delivery_spec.rb

@@ -1,11 +1,19 @@
 describe 'Delivery' do
-
-  delivery_params = { town: 64883, tent: 1, gidro: 1, manip: 1, speed: 0, moscow: 0 }
+  delivery_params = {
+    town: 64_883,
+    tent: 1,
+    gidro: 1,
+    manip: 1,
+    speed: 0,
+    moscow: 0
+  }
 
   describe '#initialize' do
     it 'Should be initialized' do
       delivery = PecCalcClient::Delivery.new(delivery_params)
-      hash_of_params = PecCalcClient::Delivery::PARAMS.map{ |k| [ k.to_sym, delivery.send(k) ] }.to_h
+      hash_of_params = PecCalcClient::Delivery::PARAMS.map do |k|
+        [k.to_sym, delivery.send(k)]
+      end.to_h
       expect(hash_of_params).to eq delivery_params
     end
   end

data/spec/pec_calc_client/place_spec.rb

@@ -1,12 +1,27 @@
-describe do 'Place'
-
-  place_params = { width: 0.5, length: 0.3,height: 0.5, volume: 0.2, weight: 0.03, oversized: 1, sturdy_packaging: 1 }
-  let!(:place){ PecCalcClient::Place.new place_params }
+describe 'Place' do
+  place_params = {
+    width: 0.5,
+    length: 0.3,
+    height: 0.5,
+    volume: 0.2,
+    weight: 0.03,
+    oversized: 1,
+    sturdy_packaging: 1
+  }
+  let!(:place) { PecCalcClient::Place.new place_params }
 
   describe '#initialize' do
     it 'Should be initialized' do
       place = PecCalcClient::Place.new(place_params)
-      expect([place.width, place.length, place.height, place.volume, place.weight, place.oversized, place.sturdy_packaging]).to eq place_params.values
+      expect([
+        place.width,
+        place.length,
+        place.height,
+        place.volume,
+        place.weight,
+        place.oversized,
+        place.sturdy_packaging
+      ]).to eq place_params.values
     end
   end
 

data/spec/pec_calc_client/region_spec.rb

@@ -1,8 +1,10 @@
-
 describe 'Region' do
   describe '#initialize' do
     it 'Should initialize' do
-      region = PecCalcClient::Region.new('RegionName', [{ id: 14, name: 'Name1' }, { id: 11, name: 'Name' }] )
+      region = PecCalcClient::Region.new(
+        'RegionName',
+        [{ id: 14, name: 'Name1' }, { id: 11, name: 'Name' }]
+      )
       expect(region.name).to eq 'RegionName'
       expect(region.towns.first.class.to_s).to eq 'PecCalcClient::Town'
     end

data/spec/pec_calc_client/response_spec.rb

@@ -1,10 +1,9 @@
 describe 'Response' do
-
   url = 'http://pecom.ru/ru/calc/towns.php'
   not_found_url = 'http://pecom.ru/not_this_url'
-  let!(:connector){ PecCalcClient::Connector.new(url) }
-  let!(:not_found_connector){ PecCalcClient::Connector.new(not_found_url) }
-  let!(:response){ connector.request }
+  let!(:connector) { PecCalcClient::Connector.new(url) }
+  let!(:not_found_connector) { PecCalcClient::Connector.new(not_found_url) }
+  let!(:response) { connector.request }
 
   describe '#initialize' do
     it 'Should be 200' do
@@ -13,7 +12,8 @@ describe 'Response' do
     end
 
     it 'Raise Exception BadResponse' do
-      expect( lambda{ not_found_connector.request } ).to raise_error(PecCalcClient::BadResponse)
+      expect(-> { not_found_connector.request })
+        .to raise_error(PecCalcClient::BadResponse)
     end
   end
 

data/spec/pec_calc_client/take_spec.rb

@@ -1,11 +1,12 @@
 describe 'Take' do
-
   take_params = { town: -457, tent: 1, gidro: 1, manip: 1, speed: 1, moscow: 1 }
 
   describe '#initialize' do
     it 'Should be initialized' do
       take = PecCalcClient::Take.new(take_params)
-      hash_of_params = PecCalcClient::Take::PARAMS.map{ |k| [ k.to_sym, take.send(k) ] }.to_h
+      hash_of_params = PecCalcClient::Take::PARAMS.map do |k|
+        [k.to_sym, take.send(k)]
+      end.to_h
       expect(hash_of_params).to eq take_params
     end
   end

data/spec/pec_calc_client/town_spec.rb

@@ -1,7 +1,7 @@
 describe 'Town' do
   describe '#initialize' do
     it 'Return Town' do
-      town = PecCalcClient::Town.new( 13, 'Town' )
+      town = PecCalcClient::Town.new(13, 'Town')
       expect(town.id).to eq 13
       expect(town.name).to eq 'Town'
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pec_calc_client
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - MAXOPKA
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-11 00:00:00.000000000 Z
+date: 2015-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -38,7 +38,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
-description: Gem for working with public API http://pecom.ru/business/developers/api_public/
+description: |-
+  Gem for working with public API http://pecom.ru/business/dev
+                      elopers/api_public/
 email: d.n.krivenko@gmail.com
 executables: []
 extensions: []