pebbles-river 0.0.6 → 0.0.7

data/lib/pebbles/river/message.rb

@@ -53,7 +53,9 @@ module Pebbles
       end
 
       def nack
-        @queue.nack(delivery_tag: delivery_tag)
+        # TODO: This requires Bunny 0.9+. We therefore don't nack at all, but
+        #   let messages simply expire, since pre-0.9 doesn't have a way to nack.
+        #@channel.nack(delivery_tag, false)
       end
 
     end

data/lib/pebbles/river/version.rb

@@ -1,5 +1,5 @@
 module Pebbles
   module River
-    VERSION = '0.0.6'
+    VERSION = '0.0.7'
   end
 end

data/spec/lib/worker_spec.rb

@@ -152,15 +152,27 @@ describe Worker do
     end
 
     context 'when handler returns false' do
-      it 'nacks the message' do
-        expect(queue).to receive(:nack).at_least(1).times
-        expect(queue).to_not receive(:ack)
-        expect(queue).to_not receive(:close)
+      if false  # Needs Bunny 0.9+
+        it 'nacks the message' do
+          expect(queue).to receive(:nack).at_least(1).times
+          expect(queue).to_not receive(:ack)
+          expect(queue).to_not receive(:close)
 
-        expect(river).to receive(:connected?).with(no_args).at_least(1).times
-        expect(river).to_not receive(:connect)
+          expect(river).to receive(:connected?).with(no_args).at_least(1).times
+          expect(river).to_not receive(:connect)
+
+          subject.new(false_handler, queue: {name: 'foo'}).run_once
+        end
+      else
+        it 'leaves the message un-acked' do
+          expect(queue).to_not receive(:ack)
+          expect(queue).to_not receive(:close)
 
-        subject.new(false_handler, queue: {name: 'foo'}).run_once
+          expect(river).to receive(:connected?).with(no_args).at_least(1).times
+          expect(river).to_not receive(:connect)
+
+          subject.new(false_handler, queue: {name: 'foo'}).run_once
+        end
       end
     end
 
@@ -172,11 +184,20 @@ describe Worker do
         on_exception_callback
       end
 
-      it 'nacks the message' do
-        expect(queue).to receive(:nack).at_least(1).times
-        expect(queue).to_not receive(:close)
+      if false  # Needs Bunny 0.9+
+        it 'nacks the message' do
+          expect(queue).to receive(:nack).at_least(1).times
+          expect(queue).to_not receive(:close)
 
-        subject.new(io_error_raising_handler, queue: {name: 'foo'}).run_once
+          subject.new(io_error_raising_handler, queue: {name: 'foo'}).run_once
+        end
+      else
+        it 'leaves the message un-acked' do
+          expect(queue).to_not receive(:ack)
+          expect(queue).to_not receive(:close)
+
+          subject.new(io_error_raising_handler, queue: {name: 'foo'}).run_once
+        end
       end
 
       [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pebbles-river
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-29 00:00:00.000000000 Z
+date: 2014-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pebblebed