peaty 0.4.5 → 0.4.6

data/VERSION

@@ -1 +1 @@
-0.4.5
+0.4.6

data/lib/peaty/base.rb

@@ -1,7 +1,7 @@
 module Peaty
   
   class Base
-    attr_accessor :attributes, :connection
+    attr_accessor :attributes, :connection, :error
     
     FILTERS = [
       :id, :type, :state, :label, :has_attachment,
@@ -50,9 +50,17 @@ module Peaty
       id.nil? or id.to_i.zero?
     end
     
+    def error?
+      !!@error
+    end
+    
     def save
-      query_string = @attributes.map{ |k,v| "#{CGI.escape("%s[%s]" % [self.class.element, k.to_s])}=#{CGI.escape(v.to_s)}" }.join('&')
-      @attributes.replace self.class.parse(self.connection["%s?%s" % [self.class.collection_path(@attributes), query_string]].post(:params => @attributes).body, self.class.element).first.attributes
+      @error = nil # reset error
+      @attributes.delete_if{ |(k,v)| v.nil? } # ignore nil attributes
+      @attributes.replace self.class.parse(self.connection[self.class.collection_path(@attributes)].post(self.class.element => @attributes).body, self.class.element).first.attributes
+    rescue RestClient::UnprocessableEntity => e
+      @error = JSON.parse(XmlToJson.transform(e.response.body))["message"]
+      false
     end
     
     class << self

data/lib/peaty.rb

@@ -26,7 +26,7 @@ require 'peaty/user'
 
 module Peaty
   
-  VERSION = "0.4.0"
+  VERSION = "0.4.6"
   
   def self.root
     @root ||= Pathname.new(__FILE__).dirname.parent

data/peaty.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{peaty}
-  s.version = "0.4.5"
+  s.version = "0.4.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Matt Todd"]
-  s.date = %q{2011-03-09}
+  s.date = %q{2011-03-15}
   s.description = %q{Just another Pivotal Tracker API Implementation}
   s.email = %q{chiology@gmail.com}
   s.files = [
@@ -31,6 +31,7 @@ Gem::Specification.new do |s|
     "test/fixtures/bugs.xml",
     "test/fixtures/chores.xml",
     "test/fixtures/create_story.xml",
+    "test/fixtures/create_story_error.xml",
     "test/fixtures/features.xml",
     "test/fixtures/iterations.xml",
     "test/fixtures/iterations_done.xml",

data/test/fixtures/create_story_error.xml

@@ -0,0 +1,2 @@
+<?xml version=\"1.0\" encoding=\"UTF-8\"?>
+<message>unknown attribute: title</message>

data/test/peaty_test.rb

@@ -79,6 +79,10 @@ class PeatyTest < Test::Unit::TestCase
   end
   
   def test_user_can_create_a_new_story_for_a_project
+    FakeWeb.register_uri(:post, Regexp.new(PT_BASE_URI + "/projects/#{PROJECT_ID}/stories"),
+                                :body => File.read(File.join(File.dirname(__FILE__), "fixtures", "create_story.xml")))
+                                # http://www.pivotaltracker.com/services/v3/projects/153937/stories?story%5Bname%5D=Test&story%5Bproject_id%5D=153937&story%5Bestimate%5D=3
+    
     story = @user.pivotal_tracker_projects.find(PROJECT_ID).stories.build(:name => name = "Test")
     assert story.is_a?(Peaty::Story)
     assert story.new_record?
@@ -90,6 +94,17 @@ class PeatyTest < Test::Unit::TestCase
     assert !story.new_record?
   end
   
+  def test_user_can_get_error_messages_when_trying_to_create_a_new_story_for_a_project_that_fails
+    FakeWeb.register_uri(:post, Regexp.new(PT_BASE_URI + "/projects/#{PROJECT_ID}/stories"),
+                                :body => File.read(File.join(File.dirname(__FILE__), "fixtures", "create_story_error.xml")),
+                                :status => 422)
+    
+    story = @user.pivotal_tracker_projects.find(PROJECT_ID).stories.build(:title => "Title Doesn't Exist")
+    assert !story.save
+    assert story.new_record?
+    assert_equal "unknown attribute: title", story.error
+  end
+  
   # Tests for Iterations
   def test_user_can_fetch_a_projects_iterations
     project = @user.pivotal_tracker_projects.find(PROJECT_ID)

data/test/test_helper.rb

@@ -16,7 +16,7 @@ PROJECT_ID  = 153937
 STORY_ID    = 6821071
 RELEASE_ID  = 6821121
 
-uri = "https://www.pivotaltracker.com/services/v3"
+PT_BASE_URI = "https://www.pivotaltracker.com/services/v3"
 { "/projects"                                             => "projects",
   "/projects/#{PROJECT_ID}"                               => "project",
   "/projects/#{PROJECT_ID}/stories"                       => "stories",
@@ -30,13 +30,9 @@ uri = "https://www.pivotaltracker.com/services/v3"
   "/projects/#{PROJECT_ID}/stories?filter=type%3Abug"     => "bugs",
   "/projects/#{PROJECT_ID}/stories?filter=includedone%3Atrue" => "stories_with_done",
 }.each do |(path, fixture)|
-  FakeWeb.register_uri(:get, uri + path, :body => File.read(File.join(File.dirname(__FILE__), "fixtures", "%s.xml" % fixture)))
+  FakeWeb.register_uri(:get, PT_BASE_URI + path, :body => File.read(File.join(File.dirname(__FILE__), "fixtures", "%s.xml" % fixture)))
 end
 
-FakeWeb.register_uri(:post, Regexp.new(uri + "/projects/#{PROJECT_ID}/stories"),
-                            :body => File.read(File.join(File.dirname(__FILE__), "fixtures", "create_story.xml")))
-                            # http://www.pivotaltracker.com/services/v3/projects/153937/stories?story%5Bname%5D=Test&story%5Bproject_id%5D=153937&story%5Bestimate%5D=3
-
 class User < Struct.new(:pivotal_tracker_api_key)
   pivotal_tracker_for :pivotal_tracker_api_key
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: peaty
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 3
   prerelease: 
   segments: 
   - 0
   - 4
-  - 5
-  version: 0.4.5
+  - 6
+  version: 0.4.6
 platform: ruby
 authors: 
 - Matt Todd
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-09 00:00:00 -05:00
+date: 2011-03-15 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -227,6 +227,7 @@ files:
 - test/fixtures/bugs.xml
 - test/fixtures/chores.xml
 - test/fixtures/create_story.xml
+- test/fixtures/create_story_error.xml
 - test/fixtures/features.xml
 - test/fixtures/iterations.xml
 - test/fixtures/iterations_done.xml