pdk 0.6.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6dcde45f10e3958c18de937239e90bdd7f4a4b50
-  data.tar.gz: ed1a5dafcf13c2b7a40a028caf59625a4694b967
+  metadata.gz: 12446b239a4b17f9ed1845579d087414bdacbd77
+  data.tar.gz: 2779afaa6e16fb2476fe9a3a8b914c8767f26aeb
 SHA512:
-  metadata.gz: 4addbf8f2b767b3a5774b142acabf289710d6cb5eb7c0e32ef199dc352fe853b6e1291236ce3535ebf99f1c2173ef89d0643c0a489b90ad6a39aef315c9f99cb
-  data.tar.gz: 78ce8ece339647fbcbeda887b3a3e5af7fabd59a90afb7640bb638d5432a43841307cd079ba39a25874c7e02b4f5d3b8ddbd358ebf0ec322d1e79e1a90cec966
+  metadata.gz: 79144605c521beafd6e98ce924b114f69ed1c0c662c5896846e248ea54d80061973ec557efc829dfc8ec054ee21ff744279bb1cf037a244cdaa1cdac73d93baa
+  data.tar.gz: ec55661f0d0d7a15a96b7049c22f201ac4b55af5732ec99d56decadafef1fccd18a0b5888ba80a18c3352c7a52ea7fb57ee83062aaf890c58d216f8561d47d37

data/CHANGELOG.md

@@ -3,6 +3,29 @@
 All notable changes to this project will be documented in this file.
 
 
+## [v1.0.0](https://github.com/puppetlabs/pdk/tree/v1.0.0) (2017-08-15)
+
+[Full Changelog](https://github.com/puppetlabs/pdk/compare/v0.6.0...v1.0.0)
+
+**Implemented enhancements:**
+
+- \(PDK-395\) Use vendored pdk-module-template repo when available [\#255](https://github.com/puppetlabs/pdk/pull/255) ([scotje](https://github.com/scotje))
+- Move content from README to official docs site [\#252](https://github.com/puppetlabs/pdk/pull/252) ([jbondpdx](https://github.com/jbondpdx))
+- \(PDK-367\) Update questionnaire wording [\#251](https://github.com/puppetlabs/pdk/pull/251) ([DavidS](https://github.com/DavidS))
+- \(PDK-406\) Add GEM\_HOME and GEM\_PATH bin dirs to PATH when executing commands [\#249](https://github.com/puppetlabs/pdk/pull/249) ([rodjek](https://github.com/rodjek))
+- \(PDK-401, PDK-402, PDK-403, PDK-404\) Update validators to handle targets better [\#248](https://github.com/puppetlabs/pdk/pull/248) ([bmjen](https://github.com/bmjen))
+- \(maint\) Allow bundler to install gems in parallel [\#245](https://github.com/puppetlabs/pdk/pull/245) ([james-stocks](https://github.com/james-stocks))
+- \(PDK-397\) Log output of bundler commands at appropriate levels [\#243](https://github.com/puppetlabs/pdk/pull/243) ([scotje](https://github.com/scotje))
+- \(PDK-396\) Disable spinners in debug mode [\#233](https://github.com/puppetlabs/pdk/pull/233) ([rodjek](https://github.com/rodjek))
+- \(PDK-388, PDK-392\) Add README, CHANGELOG, and puppet requirement to module generation [\#232](https://github.com/puppetlabs/pdk/pull/232) ([bmjen](https://github.com/bmjen))
+- \(SDK-144\) Add option to run validate in parallel [\#144](https://github.com/puppetlabs/pdk/pull/144) ([austb](https://github.com/austb))
+
+**Fixed bugs:**
+
+- Running PDK native packages on Windows under ConEmu fails [\#220](https://github.com/puppetlabs/pdk/issues/220)
+- \(PDK-407\) Validate module interview confirmation answer [\#237](https://github.com/puppetlabs/pdk/pull/237) ([rodjek](https://github.com/rodjek))
+- \(PDK-386\) Remove parameter options from 'new class' [\#236](https://github.com/puppetlabs/pdk/pull/236) ([austb](https://github.com/austb))
+
 ## [v0.6.0](https://github.com/puppetlabs/pdk/tree/v0.6.0) (2017-08-08)
 
 [Full Changelog](https://github.com/puppetlabs/pdk/compare/v0.5.0...v0.6.0)
@@ -10,6 +33,7 @@ All notable changes to this project will be documented in this file.
 **Implemented enhancements:**
 
 - \(MAINT\) Improve moduleroot error message [\#224](https://github.com/puppetlabs/pdk/pull/224) ([DavidS](https://github.com/DavidS))
+- \(MAINT\) workaround rspec-puppt-facts being case-sensitive for operatingsystem filters [\#222](https://github.com/puppetlabs/pdk/pull/222) ([DavidS](https://github.com/DavidS))
 - \(PDK-354\) Change PDK::Logger to write to STDERR [\#217](https://github.com/puppetlabs/pdk/pull/217) ([scotje](https://github.com/scotje))
 - \(SDK-331\) Use vendored Gemfile.lock when available and needed [\#215](https://github.com/puppetlabs/pdk/pull/215) ([scotje](https://github.com/scotje))
 - \(maint\) Expose message when FileUtils.mkdir\_p fails during module generation [\#209](https://github.com/puppetlabs/pdk/pull/209) ([rodjek](https://github.com/rodjek))

data/README.md

@@ -1,57 +1,41 @@
 # pdk [![Build Status](https://travis-ci.org/puppetlabs/pdk.svg?branch=master)](https://travis-ci.org/puppetlabs/pdk) [![Appveyor Build Status](https://ci.appveyor.com/api/projects/status/x70e2fqllbaootpd?svg=true)](https://ci.appveyor.com/project/puppetlabs/pdk) [![Coverage Status](https://coveralls.io/repos/github/puppetlabs/pdk/badge.svg?branch=master)](https://coveralls.io/github/puppetlabs/pdk?branch=master)
 
+* [Installation](#installation)
+* [Basic usage](#basic-usage)
+* [Experimental features](#experimental-features)
+* [Module compatibility](#module-compatibility)
+* [Contributing](#contributing)
 
-A CLI to facilitate easy, unified development workflows for Puppet modules. `pdk` is a key part of the Puppet Development Kit, the shortest path to better modules.
+The Puppet Development Kit (PDK) includes key Puppet code development and testing tools for Linux, Windows, and OS X workstations, so you can install one package with the tools you need to create and validate new modules.
 
-## Installation
-
-Download and install the newest package matching your platform from [here](https://drive.google.com/drive/folders/0Bz0tCHSb1u41alR4MmZfRHBTV1k?usp=sharing). If you are using Windows, please remember to close any open PowerShell windows.
-
-### Windows
-
-On Windows you should run PDK from PowerShell and `pdk` will be available in your PowerShell prompt after installation.
+PDK includes testing tools, a complete module skeleton, and command line tools to help you create, validate, and run tests on Puppet modules. PDK also includes all dependencies needed for its use.
 
-If the `pdk` command does not appear, check that the `PuppetDevelopmentKit` PowerShell module is loaded in your PowerShell prompt:
+PDK includes the following tools:
 
-```
-Get-Module -Name PuppetDevelopmentKit
-```
+Tool   | Description
+----------------|-------------------------
+metadata-json-lint | Validates and lints `metadata.json` files in modules against  Puppet's module metadatastyle guidelines.
+pdk | Command line tool for generating and testing modules
+puppet-lint | Checks your Puppet code against the recommendations in the Puppet Language style guide.
+puppet-syntax | Checks for correct syntax in Puppet manifests, templates, and Hiera YAML.
+puppetlabs_spec_helper | Provides classes, methods, and Rake tasks to help with spec testing Puppet code.
+rspec-puppet | Tests the behavior of Puppet when it compiles your manifests into a catalog of Puppet resources.
+rspec-puppet-facts | Adds support for running rspec-puppet tests against the facts for your supported operating systems.
 
-If no output is returned, load the `PuppetDevelopmentKit` module by running the following command:
-
-```
-Import-Module -Name PuppetDevelopmentKit
-```
-
-> Note: On PowerShell version 3 and above, PowerShell modules are loaded automatically so this step shouldn't be necessary.
-
-You should set your script execution policy to at least [RemoteSigned](https://msdn.microsoft.com/en-us/powershell/reference/5.1/microsoft.powershell.security/set-executionpolicy), if it's not already, to allow the PowerShell integration to work.
-
-You can check your ExecutionPolicy by running the following command from a PowerShell prompt:
-
-```
-Get-ExecutionPolicy
-```
 
-To set the `ExecutionPolicy`, run the following command:
+## Installation
 
-```
-Set-ExecutionPolicy -ExecutionPolicy RemoteSigned
-```
+Download and install the newest package matching your platform from the [download](https://puppet.com/download-puppet-development-kit) page. If you are using Windows, remember to close any open PowerShell windows.
 
-If you can't change the system `ExecutionPolicy`, you can change the `ExecutionPolicy` for just the current session by using the `Scope` paramter:
+For complete installation information, see the [PDK documentation](https://docs.puppet.com/pdk/latest/pdk_install.html).
 
-```
-Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser
-```
-
-For more information about PowerShell `ExecutionPolicies` or how to change them, see [about_Execution_Policies](http://go.microsoft.com/fwlink/?LinkID=135170).
+## Basic usage
 
-## Usage
+PDK can generate modules and classes, validate module metadata, style, and syntax, and run unit tests. This README contains very basic usage information---for complete usage information, see the [PDK documentation](https://docs.puppet.com/pdk/).
 
-### Generate a new module
+### Generate a module
 
-To get started, generate a new module from the default template.
+Generates the basic components of a module and set up an infrastructure for testing it with PDK.
 
 1. Run the `pdk new module` command, specifying the name of the new module:
 
@@ -59,232 +43,49 @@ To get started, generate a new module from the default template.
 pdk new module my_module
 ```
 
-This generates the basic components of a new module. The `pdk new module` command sets some default metadata values based on your environment. Check the `metadata.json` to make sure that these values are correct. The new module now contains all the infrastructure to use the other capabilities of `pdk`.
+This command asks a series of metadata questions and then generates the basic components of a new module.
 
-### Running validations
+### Generate a class
 
-The default template provides tools for running static validations of your new module. Validations run quickly, but they provide only a basic check of the well-formedness of the module and syntax of its files.
+To generate a class in your module, use the `pdk new class` command, specifying the name of your new class. To generate the main class of the module, which is defined in an `init.pp` file, give the class the same name as the module.
 
-```
-pdk validate
-```
+1. From the command line, in your module's directory, run `pdk new class class_name`. 
+   ```
 
-This displays results in the console:
+PDK creates the new class manifest and a test file (as `class_name_spec.rb`) in your module's `/spec/classes` directory. 
 
-```
-pdk (INFO): Running all available validators...
-[✔] Checking for missing Gemfile dependencies
-[✔] Checking metadata.json
-[✔] Checking Ruby code style
-[...]
-```
 
-Specific validators can be run by providing the validator name (or a comma
-separated list of names) as an argument to `pdk validate`.
+### Validating a module
 
-```
-$ pdk validate metadata
-[✔] Checking for missing Gemfile dependencies
-[✔] Checking metadata.json
-```
+PDK can validate the well-formedness of the module and style and syntax of its files.
 
-By default each validator will automatically determine which files in the
-module that it should validate, however validations can be run on specific
-files or directories by providing them as arguments to `pdk validate`
+1. In the module's directory, run:
 
 ```
-$ pdk validate lib/
-[✔] Checking for missing Gemfile dependencies
-[✔] Checking Ruby code style
+pdk validate
 ```
 
-Some validators support automatic correction of detected problems (for example,
-both rubocop and puppet-lint can automatically correct many common code style
-problems). To enable this functionality, run `pdk validate` with the
-`--auto-correct` option.
-
-```
-$ pdk validate --auto-correct
-pdk (INFO): Running all available validators...
-[✔] Checking for missing Gemfile dependencies
-[✔] Checking metadata.json
-[✔] Checking Puppet manifest style
-[✔] Checking Puppet manifest syntax
-[✔] Checking Ruby code style
-manifests/init.pp:1:10: corrected: double quoted string containing no variables
-```
+This command validates the metadata, Puppet code syntax and style, and Ruby syntax and style for the entire module.
 
 ### Run unit tests
 
-The default template sets up [rspec](http://rspec.info/) for Ruby-level unit testing, and [rspec-puppet](https://github.com/rodjek/rspec-puppet/) for catalog-level unit testing.
+PDK's default template sets up [rspec](http://rspec.info/) for Ruby-level unit testing, and [rspec-puppet](https://github.com/rodjek/rspec-puppet/) for catalog-level unit testing.
 
-1. In the module's directory, run all unit tests with:
+In the module's directory, run unit tests with:
 
 ```
 pdk test unit
 ```
 
-<!-- // TODO: git hosting services (integration); code manager workflow integration; CI/CD Integration -->
-
-
-## Reference
-
-### `pdk new module` command
-
-Generates a new module.
-
-Usage:
-
-```
-pdk new module [--template-url=git_url] [--license=spdx_identifier] module_name [target_dir]
-```
-
-The `pdk new module` command accepts the following arguments and options. Arguments are optional unless otherwise specified.
-
-#### `--template-url=git_url`
+This command runs all available unit tests.
 
-Overrides the template to use for this module. If possible, please contribute your improvements back to the default template at [puppetlabs/pdk-module-template](https://github.com/puppetlabs/pdk-module-template).
-
-#### `--license=spdx_identifier`
-
-Specifies the license this module is written under. See https://spdx.org/licenses/ for a list of open source licenses, or use `proprietary`. Defaults to `Apache-2.0`.
-
-#### `--skip-interview`
-
-Suppress interactive queries for initial values. All questions will use the default values.
-
-#### `module_name`
-
-**Required**. Specifies the name of the module being created. e.g.: `my_module`
-
-#### `target_dir`
-
-Specifies the directory that the new module will be created in. Defaults to creating a new directory with the given `module_name` inside the current directory.
-
-### `pdk new class` command
-
-Generates a new class and skeleton test for it in the current module.
-
-Usage:
-
-```
-pdk new class [--template-url=git_url] <class_name> [parameter_name[:parameter_type]] [parameter_name[:parameter_type]] ...
-```
-
-e.g.
-
-```
-cd my_module
-pdk new class my_class "ensure:Enum['absent', 'present']" version:String
-```
-
-#### `--template-url`
-
-Overrides the template to use when generating this class. If this is not
-specified, the template used to generate the module will be used instead. If
-that template is not available, the default template at
-[puppetlabs/pdk-module-template](https://github.com/puppetlabs/pdk-module-template)
-will be used.
-
-#### `class_name`
-
-The name of the class to generate. If the class name is not inside the module
-namespace (e.g. module name is `apt` and the class name is `source`, then the
-module name will automatically be prepended to the class name (e.g.
-`apt::source`).
-
-#### `parameter_name[:parameter_type]`
-
-If the class should take parameters, they can be specified on the command line
-to be added to the generated class. Optionally, the data type of the parameter
-can be specified along with the parameter name, separated by a colon. Any
-number of parameters can be provided on the command line.
-
-### `pdk validate` command
-
-Runs all static validations. Any errors are reported to the console in the format requested. The exit code is non-zero when errors occur.
-
-Usage:
-
-```
-pdk validate --list
-```
-
-```
-pdk validate [--format=format[:target]] [validations] [targets*]
-```
-
-#### `--list`
-
-Displays a list of available validations and their descriptions. Using this option lists the tests without running them.
-
-#### `--format=format[:target]`
-
-Specifies the format of the output. Valid values: `junit`, `text`. Default: `text`.
-
-Optionally, you can specify a target file for the given output format with the syntax: `--format=junit:report.xml`
-
-Multiple `--format` options can be specified as long as they all have distinct output targets.
-
-#### `validations`
-
-Specifies a comma separated list of validations to run (or `all`). See the `--list` output for a list of available validations. Defaults to `all` if not supplied.
-
-#### `targets`
-
-Specifies a list of directories or individual files to validate. Validations which are not applicable to individual files will be skipped for those files. Defaults to validating everything.
-
-#### Additional Examples
-
-```
-$ pdk validate metadata
-Running 'metadata' validation on `new_module`: OK!
-```
-
-```
-$ pdk validate all lib/
-Running validations on `new_module/lib`:
-* ruby syntax: OK!
-* puppet syntax: (no puppet manifests found)
-```
-
-### `pdk test unit` command
-
-Runs unit tests. Any errors are displayed to the console and reported in the report-file, if requested. The exitcode is non-zero when errors occur.
-
-Usage:
-
-```
-pdk test unit [--list] [--tests=test_list] [--format=format[:target]] [runner_options]
-```
-
-#### `--list`
-
-Displays a list of unit tests and their descriptions. Using this option lists the tests without running them.
-
-#### `--tests=test_list`
-
-A comma-separated list of tests to run. Use this during development to pinpoint a single failing test. See the `--list` output for allowed values.
-
-#### `--format=format[:target]`
-
-Specifies the format of the output. Valid values: `junit`, `text`. Default: `text`.
-
-Optionally, you can specify a target file for the given output format with the syntax: `--format=junit:report.xml`
-
-Multiple `--format` options can be specified as long as they all have distinct output targets.
-
-#### `runner_options`
-
-<!-- this is a cop-out; alternatives are surfacing the real runner to advanced users, or completely wrapping the runner's interface -->
-
-Specifies options to pass through to the actual test-runner. In the default template (and most commonly across modules), this is [rspec](https://relishapp.com/rspec/rspec-core/docs/command-line).
+## Experimental features
 
 ### `pdk bundle` command
 
-This experimental command allows advanced users to execute arbitrary commands in a bundler context within the module you're currently working on. Arguments to this command are passed straight through to bundler. Careless use of this command can lead to errors later which can't be recovered by the pdk itself.
+This command executes arbitrary commands in a bundler context within the module you're currently working on. Arguments to this command are passed straight through to bundler. This command is experimental  and can lead to errors that can't be resolved by the pdk itself.
 
-Note that for most advanced uses it is required to use the `--` to separate bundler options from pdk options. Compare the following two commands:
+Note that for most uses, you must use the `--` to separate bundler options from pdk options. Compare the following two commands:
 
 ```
 $ pdk bundle exec rake -T
@@ -303,21 +104,20 @@ rake build                 # Build puppet module package
 [...]
 ```
 
-## Module Compatibility
+#### Known issues
+
+* `pdk bundle` command on Windows doesn't allow usage suggested by pdk help [PDK-408](https://tickets.puppetlabs.com/browse/PDK-408)
 
-**PDK Version Compatibility:** modules created with a specific PDK version should validate against and run on all Puppet andRuby version combinations currently under maintenance (see https://docs.puppet.com/puppet/latest/about_agent.html and https://puppet.com/misc/puppet-enterprise-lifecycle)
+On Windows, the `pdk bundle` command doesn't allow `--` as a separator between pdk option flags and bundler option flags as suggested by `pdk help bundle`.
 
-**Module Template Compatibility:** Modules created with a specific version of the PDK will remain compatible to newer versions of the PDK with the following exceptions:
-* access to new PDK functionality might require an update of the module to the current Template version
-* access to a new major PDK version might require an update of the module to the current Template version, after a one year deprecation cycle
-* validation against new Puppet versions might require new PDK functionality, a new major PDK version, and changes to the module itself.
+The issue is that PDK is consuming command line options meant for the subcommand. To work around this, run `pdk bundle exec` with a string specifying the command you want to run with its command line options.
 
-## Upgrading
-* In the common case, Puppet and the PDK will be forward-compatible so that minor Puppet updates will not require a new version of the PDK.
-* Some new Puppet versions will require changes to the PDK. In that case, upgrading the PDK for validation prior to roll-out of Puppet is strongly recommended.
+For example: `pdk bundle exec "bundle install --binstubs"`
 
+## Module Compatibility
 
+**PDK Version Compatibility:** Modules created with PDK version validate against and run on all Puppet and Ruby version combinations currently under maintenance (see https://docs.puppet.com/puppet/latest/about_agent.html and https://puppet.com/misc/puppet-enterprise-lifecycle)
 
 ## Contributing
 
-See the [CONTRIBUTING.md](CONTRIBUTING.md) file for development notes.
+PDK encourages community contributions. See the [CONTRIBUTING.md](CONTRIBUTING.md) file for development notes.

data/lib/pdk/cli.rb

@@ -4,6 +4,7 @@ require 'pdk/cli/errors'
 require 'pdk/cli/util'
 require 'pdk/cli/util/option_normalizer'
 require 'pdk/cli/util/option_validator'
+require 'pdk/cli/exec_group'
 require 'pdk/generators/module'
 require 'pdk/i18n'
 require 'pdk/logger'
@@ -32,7 +33,7 @@ module PDK::CLI
   end
 
   def self.template_url_option(dsl)
-    dsl.option nil, 'template-url', _('Specifies the URL to the template to use when creating new modules, and other parts.'), argument: :required, default: PDK::Generate::Module::DEFAULT_TEMPLATE
+    dsl.option nil, 'template-url', _('Specifies the URL to the template to use when creating new modules, and other parts.'), argument: :required, default: PDK::Generate::Module.default_template_url
   end
 
   @base_cmd = Cri::Command.define do

data/lib/pdk/cli/exec.rb

@@ -73,6 +73,7 @@ module PDK
         attr_reader :context
         attr_accessor :timeout
         attr_accessor :environment
+        attr_writer :exec_group
 
         def initialize(*argv)
           @argv = argv
@@ -91,21 +92,33 @@ module PDK
 
           # Extra environment vars to add to base set.
           @environment = {}
+
+          # Register the ExecGroup when running in parallel
+          @exec_group = nil
         end
 
         def context=(new_context)
           unless [:system, :module].include?(new_context)
-            raise ArgumentError, _("Expected execution context to be :system or :module but got '%{context}'") % { context: new_contenxt }
+            raise ArgumentError, _("Expected execution context to be :system or :module but got '%{context}'") % { context: new_context }
           end
 
           @context = new_context
         end
 
+        def register_spinner(spinner, opts = {})
+          return if PDK.logger.debug?
+          @success_message = opts.delete(:success)
+          @failure_message = opts.delete(:failure)
+
+          @spinner = spinner
+        end
+
         def add_spinner(message, opts = {})
+          return if PDK.logger.debug?
           @success_message = opts.delete(:success)
           @failure_message = opts.delete(:failure)
 
-          @spinner = Gem.win_platform? ? WindowsSpinner.new(message, opts) : TTY::Spinner.new("[:spinner] #{message}", opts)
+          @spinner = TTY::Spinner.new("[:spinner] #{message}", opts.merge(PDK::CLI::Util.spinner_opts_for_platform))
         end
 
         def execute!
@@ -135,19 +148,26 @@ module PDK
             end
 
             # Make sure invocation of Ruby prefers our private installation.
-            @process.environment['PATH'] = [RbConfig::CONFIG['bindir'], ENV['PATH']].compact.join(File::PATH_SEPARATOR)
+            @process.environment['PATH'] = [
+              RbConfig::CONFIG['bindir'],
+              File.join(@process.environment['GEM_HOME'], 'bin'),
+              File.join(@process.environment['GEM_PATH'], 'bin'),
+              ENV['PATH'],
+            ].compact.join(File::PATH_SEPARATOR)
 
             mod_root = PDK::Util.module_root
 
             unless mod_root
-              @spinner.error
+              @spinner.error if @spinner
 
               raise PDK::CLI::FatalError, _('Current working directory is not part of a module. (No metadata.json was found.)')
             end
 
-            Dir.chdir(mod_root) do
-              ::Bundler.with_clean_env do
-                run_process!
+            if Dir.pwd == mod_root
+              run_process_in_clean_env!
+            else
+              Dir.chdir(mod_root) do
+                run_process_in_clean_env!
               end
             end
           else
@@ -155,13 +175,7 @@ module PDK
           end
 
           # Stop spinning when done (if configured).
-          if @spinner
-            if @process.exit_code.zero?
-              @spinner.success(@success_message || '')
-            else
-              @spinner.error(@failure_message || '')
-            end
-          end
+          stop_spinner
 
           @stdout.rewind
           @stderr.rewind
@@ -181,6 +195,23 @@ module PDK
 
         protected
 
+        def stop_spinner
+          return unless @spinner
+
+          # If it is a single spinner, we need to send it a success/error message
+          if @process.exit_code.zero?
+            @spinner.success(@success_message || '')
+          else
+            @spinner.error(@failure_message || '')
+          end
+        end
+
+        def run_process_in_clean_env!
+          ::Bundler.with_clean_env do
+            run_process!
+          end
+        end
+
         def run_process!
           command_string = argv.join(' ')
           PDK.logger.debug(_("Executing '%{command}'") % { command: command_string })
@@ -202,30 +233,8 @@ module PDK
             @process.wait
           end
           @duration = Time.now - start_time
-        end
-      end
-
-      # This is a placeholder until we integrate ansicon into Windows packaging
-      # or come up with some other progress indicator for Windows.
-      class WindowsSpinner
-        def initialize(message, _opts = {})
-          @message = message
-        end
-
-        def auto_spin
-          $stderr.print @message << '...'
-        end
-
-        def success(message = '')
-          message = 'done.' if message.nil? || message.empty?
-
-          $stderr.print message << "\n"
-        end
-
-        def error(message = '')
-          message = 'FAILED' if message.nil? || message.empty?
-
-          $stderr.print message << "\n"
+          PDK.logger.debug(_("Execution of '%{command}' complete (duration: %{duration_in_seconds}s; exit code: %{exit_code})") %
+            { command: command_string, duration_in_seconds: @duration, exit_code: @process.exit_code })
         end
       end
     end