pdk 2.6.0 → 2.7.0

data/lib/pdk/util/filesystem.rb

@@ -5,8 +5,8 @@ module PDK
   module Util
     module Filesystem
       def write_file(path, content)
-        raise ArgumentError, _('content must be a String') unless content.is_a?(String)
-        raise ArgumentError, _('path must be a String or Pathname') unless path.is_a?(String) || path.respond_to?(:to_path)
+        raise ArgumentError, 'content must be a String' unless content.is_a?(String)
+        raise ArgumentError, 'path must be a String or Pathname' unless path.is_a?(String) || path.respond_to?(:to_path)
 
         # Harmonize newlines across platforms.
         content = content.encode(universal_newline: true)

data/lib/pdk/util/git.rb

@@ -14,7 +14,7 @@ module PDK
         @stderr = result[:stderr]
         @exit_code = result[:exit_code]
 
-        super(_('Git command failed: git %{args}' % { args: args.join(' ') }))
+        super('Git command failed: git %{args}' % { args: args.join(' ') })
       end
     end
 
@@ -100,8 +100,8 @@ module PDK
       end
 
       def self.work_dir_clean?(repo)
-        raise PDK::CLI::ExitWithError, _('Unable to locate git work dir "%{workdir}"') % { workdir: repo } unless PDK::Util::Filesystem.directory?(repo)
-        raise PDK::CLI::ExitWithError, _('Unable to locate git dir "%{gitdir}"') % { gitdir: repo } unless PDK::Util::Filesystem.directory?(File.join(repo, '.git'))
+        raise PDK::CLI::ExitWithError, 'Unable to locate git work dir "%{workdir}"' % { workdir: repo } unless PDK::Util::Filesystem.directory?(repo)
+        raise PDK::CLI::ExitWithError, 'Unable to locate git dir "%{gitdir}"' % { gitdir: repo } unless PDK::Util::Filesystem.directory?(File.join(repo, '.git'))
 
         git('--work-tree', repo, '--git-dir', File.join(repo, '.git'), 'status', '--untracked-files=no', '--porcelain', repo)[:stdout].empty?
       end
@@ -116,14 +116,14 @@ module PDK
         unless output[:exit_code].zero?
           PDK.logger.error output[:stdout]
           PDK.logger.error output[:stderr]
-          raise PDK::CLI::ExitWithError, _('Unable to access the template repository "%{repository}"') % {
+          raise PDK::CLI::ExitWithError, 'Unable to access the template repository "%{repository}"' % {
             repository: repo,
           }
         end
 
         matching_refs = output[:stdout].split(%r{\r?\n}).map { |r| r.split("\t") }
         matching_ref = matching_refs.find { |_sha, remote_ref| remote_ref == "refs/tags/#{ref}" || remote_ref == "refs/remotes/origin/#{ref}" || remote_ref == "refs/heads/#{ref}" }
-        raise PDK::CLI::ExitWithError, _('Unable to find a branch or tag named "%{ref}" in %{repo}') % { ref: ref, repo: repo } if matching_ref.nil?
+        raise PDK::CLI::ExitWithError, 'Unable to find a branch or tag named "%{ref}" in %{repo}' % { ref: ref, repo: repo } if matching_ref.nil?
         matching_ref.first
       end
 

data/lib/pdk/util/puppet_strings.rb

@@ -22,7 +22,7 @@ module PDK
 
         command = PDK::CLI::Exec::Command.new(*argv).tap do |c|
           c.context = :module
-          c.add_spinner(_('Examining module contents'))
+          c.add_spinner('Examining module contents')
         end
 
         command.execute!
@@ -44,7 +44,7 @@ module PDK
         JSON.parse(result[:stdout])
       rescue JSON::ParserError => e
         PDK.logger.debug(e)
-        raise RunError, _('Unable to parse puppet-strings output')
+        raise RunError, 'Unable to parse puppet-strings output'
       end
 
       # Searches the puppet-strings result to find the definition of the named

data/lib/pdk/util/puppet_version.rb

@@ -1,4 +1,6 @@
 require 'pdk'
+require 'json'
+require 'forwardable'
 
 module PDK
   module Util
@@ -38,7 +40,7 @@ module PDK
         latest = find_gem(Gem::Requirement.create('>= 0'))
 
         if latest.nil?
-          raise ArgumentError, _('Unable to find a Puppet gem in current Ruby environment or from Rubygems.org.')
+          raise ArgumentError, 'Unable to find a Puppet gem in current Ruby environment or from Rubygems.org.'
         end
 
         latest
@@ -67,7 +69,7 @@ module PDK
 
           PDK.logger.error clone_result[:stdout]
           PDK.logger.error clone_result[:stderr]
-          raise PDK::CLI::FatalError, _("Unable to clone git repository from '%{repo}'.") % { repo: DEFAULT_PUPPET_DEV_URL }
+          raise PDK::CLI::FatalError, "Unable to clone git repository from '%{repo}'." % { repo: DEFAULT_PUPPET_DEV_URL }
         end
 
         # Fetch Updates from remote repository
@@ -76,7 +78,7 @@ module PDK
         unless fetch_result[:exit_code].zero?
           PDK.logger.error fetch_result[:stdout]
           PDK.logger.error fetch_result[:stderr]
-          raise PDK::CLI::FatalError, _("Unable to fetch from git remote at '%{repo}'.") % { repo: DEFAULT_PUPPET_DEV_URL }
+          raise PDK::CLI::FatalError, "Unable to fetch from git remote at '%{repo}'." % { repo: DEFAULT_PUPPET_DEV_URL }
         end
 
         # Reset local repo to latest
@@ -87,7 +89,7 @@ module PDK
 
         PDK.logger.error reset_result[:stdout]
         PDK.logger.error reset_result[:stderr]
-        raise PDK::CLI::FatalError, _("Unable to update git repository at '%{cachedir}'.") % { repo: puppet_dev_path }
+        raise PDK::CLI::FatalError, "Unable to update git repository at '%{cachedir}'." % { cachedir: puppet_dev_path }
       end
 
       def find_gem_for(version_str)
@@ -104,18 +106,17 @@ module PDK
         requirement_string = version.approximate_recommendation
         requirement_string += '.0' unless version.segments.length == 1
         latest_requirement = Gem::Requirement.create(requirement_string)
-
         latest_available_gem = find_gem(latest_requirement)
 
         if latest_available_gem.nil?
-          raise ArgumentError, _('Unable to find a Puppet gem matching %{requirement}.') % {
+          raise ArgumentError, 'Unable to find a Puppet gem matching %{requirement}.' % {
             requirement: latest_requirement,
           }
         end
 
         # Only issue this warning if they requested an exact version that isn't available.
         if version.segments.length == 3
-          PDK.logger.warn(_('Puppet %{requested_version} is not available, activating %{found_version} instead.') % {
+          PDK.logger.warn('Puppet %{requested_version} is not available, activating %{found_version} instead.' % {
             requested_version: version_str,
             found_version:     latest_available_gem[:gem_version].version,
           })
@@ -127,22 +128,28 @@ module PDK
       def from_pe_version(version_str)
         version = parse_specified_version(version_str)
 
-        gem_version = pe_version_map.find do |version_map|
-          version_map[:requirement].satisfied_by?(version)
-        end
+        # Due to the issue with concurrent ruby in older puppet gems
+        # we are locking the pe to puppet version mapping to the latest
+        # puppet version that is compatible with the pe version.
+        safe_versions = {
+          2023 => '7.23.0',
+          2021 => '7.23.0',
+          2019 => '6.29.0',
+        }
 
+        gem_version = safe_versions[version.segments[0]]
         if gem_version.nil?
-          raise ArgumentError, _('Unable to map Puppet Enterprise version %{pe_version} to a Puppet version.') % {
+          raise ArgumentError, 'Unable to map Puppet Enterprise version %{pe_version} to a Puppet version.' % {
             pe_version: version_str,
           }
         end
 
-        PDK.logger.info _('Puppet Enterprise %{pe_version} maps to Puppet %{puppet_version}.') % {
+        PDK.logger.info 'Puppet Enterprise %{pe_version} maps to Puppet %{puppet_version}.' % {
           pe_version:     version_str,
-          puppet_version: gem_version[:gem_version],
+          puppet_version: gem_version,
         }
 
-        find_gem_for(gem_version[:gem_version])
+        find_gem_for(gem_version)
       end
 
       def from_module_metadata(metadata = nil)
@@ -153,7 +160,7 @@ module PDK
           metadata_file = PDK::Util.find_upwards('metadata.json')
 
           unless metadata_file
-            PDK.logger.warn _('Unable to determine Puppet version for module: no metadata.json present in module.')
+            PDK.logger.warn 'Unable to determine Puppet version for module: no metadata.json present in module.'
             return
           end
 
@@ -179,7 +186,7 @@ module PDK
       def parse_specified_version(version_str)
         Gem::Version.new(version_str)
       rescue ArgumentError
-        raise ArgumentError, _('%{version} is not a valid version number.') % {
+        raise ArgumentError, '%{version} is not a valid version number.' % {
           version: version_str,
         }
       end
@@ -215,7 +222,7 @@ module PDK
       rescue PDK::Util::VendoredFile::DownloadError => e
         raise PDK::CLI::FatalError, e.message
       rescue JSON::ParserError
-        raise PDK::CLI::FatalError, _('Failed to parse Puppet Enterprise version map file.')
+        raise PDK::CLI::FatalError, 'Failed to parse Puppet Enterprise version map file.'
       end
 
       def requirement_from_forge_range(range_str)

data/lib/pdk/util/ruby_version.rb

@@ -34,7 +34,7 @@ module PDK
           if versions.key?(version)
             @active_ruby_version = version
           else
-            raise ArgumentError, _('Unknown Ruby version "%{ruby_version}"') % {
+            raise ArgumentError, 'Unknown Ruby version "%{ruby_version}"' % {
               ruby_version: version,
             }
           end
@@ -61,10 +61,7 @@ module PDK
                                       # PDK::Util::PuppetVersion.find_gem_for('5.5.10')[:ruby_version]
                                       #
                                       # For using the latest puppet gem:
-                                      # PDK::Util::PuppetVersion.latest_available[:ruby_version]
-                                      #
-                                      # Temporarily lock to Ruby 2.5.x as default until 2.7.x ecosystem is sorted
-                                      versions.keys.detect { |v| v =~ %r{^2\.5} }
+                                      PDK::Util::PuppetVersion.latest_available[:ruby_version]
                                     else
                                       # TODO: may not be a safe assumption that highest available version should be default
                                       # WARNING Do NOT use PDK::Util::PuppetVersion.*** methods as it can recurse into this

data/lib/pdk/util/template_uri.rb

@@ -48,7 +48,7 @@ module PDK
                      Addressable::URI.parse(opts_or_uri)
                    end
                  rescue Addressable::URI::InvalidURIError
-                   raise PDK::CLI::FatalError, _('PDK::Util::TemplateURI attempted initialization with a non-uri string: {string}') % { string: opts_or_uri }
+                   raise PDK::CLI::FatalError, 'PDK::Util::TemplateURI attempted initialization with a non-uri string: {string}' % { string: opts_or_uri }
                  end
                elsif opts_or_uri.is_a?(Addressable::URI)
                  opts_or_uri.dup
@@ -178,7 +178,7 @@ module PDK
         return url unless Pathname.new(url).relative? && scp_url
 
         uri = Addressable::URI.new(scheme: 'ssh', user: scp_url[:user], host: scp_url[:host], path: scp_url[:path])
-        PDK.logger.warn _('%{scp_uri} appears to be an SCP style URL; it will be converted to an RFC compliant URI: %{rfc_uri}') % {
+        PDK.logger.warn '%{scp_uri} appears to be an SCP style URL; it will be converted to an RFC compliant URI: %{rfc_uri}' % {
           scp_uri: url,
           rfc_uri: uri.to_s,
         }
@@ -229,10 +229,10 @@ module PDK
         default_uri.fragment = default_template_ref(default_template_uri)
 
         ary = []
-        ary << { type: _('--template-url'), uri: explicit_uri, allow_fallback: false } if explicit_url
-        ary << { type: _('metadata.json'), uri: metadata_uri, allow_fallback: true } if metadata_uri
-        ary << { type: _('PDK answers'), uri: answers_uri, allow_fallback: true } if answers_uri
-        ary << { type: _('default'), uri: default_uri, allow_fallback: false }
+        ary << { type: '--template-url', uri: explicit_uri, allow_fallback: false } if explicit_url
+        ary << { type: 'metadata.json', uri: metadata_uri, allow_fallback: true } if metadata_uri
+        ary << { type: 'PDK answers', uri: answers_uri, allow_fallback: true } if answers_uri
+        ary << { type: 'default', uri: default_uri, allow_fallback: false }
         ary
       end
 
@@ -256,7 +256,7 @@ module PDK
         # 4. Leave updating answers/metadata to other code
         found_template = templates_array.find { |t| valid_template?(t) }
 
-        raise PDK::CLI::FatalError, _('Unable to find a valid module template to use.') if found_template.nil?
+        raise PDK::CLI::FatalError, 'Unable to find a valid module template to use.' if found_template.nil?
         found_template[:uri]
       end
 
@@ -279,7 +279,7 @@ module PDK
         end
 
         unless template[:allow_fallback]
-          raise PDK::CLI::FatalError, _('Unable to find a valid template at %{uri}') % {
+          raise PDK::CLI::FatalError, 'Unable to find a valid template at %{uri}' % {
             uri: template[:uri].to_s,
           }
         end

data/lib/pdk/util/vendored_file.rb

@@ -47,7 +47,7 @@ module PDK
           Timeout::Error,
         ]
 
-        PDK.logger.debug _('%{file_name} was not found in the cache, downloading it from %{url}.') % {
+        PDK.logger.debug '%{file_name} was not found in the cache, downloading it from %{url}.' % {
           file_name: file_name,
           url:       url,
         }
@@ -61,7 +61,7 @@ module PDK
         response = http.request(request)
 
         unless response.code == '200'
-          raise DownloadError, _('Unable to download %{url}. %{code}: %{message}.') % {
+          raise DownloadError, 'Unable to download %{url}. %{code}: %{message}.' % {
             url:     url,
             code:    response.code,
             message: response.message,
@@ -70,7 +70,7 @@ module PDK
 
         response.body
       rescue *http_errors => e
-        raise DownloadError, _('Unable to download %{url}. Check internet connectivity and try again. %{error}') % {
+        raise DownloadError, 'Unable to download %{url}. Check internet connectivity and try again. %{error}' % {
           url: url,
           error: e,
         }

data/lib/pdk/util/windows/api_types.rb

@@ -28,7 +28,7 @@ module PDK::Util::Windows::APITypes
       str = get_bytes(0, char_length * 2).force_encoding('UTF-16LE')
       str.encode(dst_encoding, str.encoding, **encode_options)
     rescue StandardError => e
-      PDK.logger.debug _('Unable to convert value %{string} to encoding %{encoding} due to %{error}') % {
+      PDK.logger.debug 'Unable to convert value %{string} to encoding %{encoding} due to %{error}' % {
         string:   str.dump,
         encoding: dst_encoding,
         error:    e.inspect,
@@ -38,9 +38,8 @@ module PDK::Util::Windows::APITypes
 
     def read_arbitrary_wide_string_up_to(max_char_length = 512, null_terminator = :single_null, encode_options = {})
       unless [:single_null, :double_null].include?(null_terminator)
-        raise ArgumentError, _(
-          'Unable to read wide strings with %{null_terminator} terminal nulls',
-        ) % { null_terminator: null_terminator }
+        raise ArgumentError,
+              'Unable to read wide strings with %{null_terminator} terminal nulls' % { null_terminator: null_terminator }
       end
 
       terminator_width = (null_terminator == :single_null) ? 1 : 2

data/lib/pdk/util/windows/file.rb

@@ -12,7 +12,7 @@ module PDK::Util::Windows::File
       buffer_size = GetLongPathNameW(path_ptr, FFI::Pointer::NULL, 0)
       FFI::MemoryPointer.new(:wchar, buffer_size) do |converted_ptr|
         if GetLongPathNameW(path_ptr, converted_ptr, buffer_size) == PDK::Util::Windows::WIN32_FALSE
-          raise _('Failed to call GetLongPathName')
+          raise 'Failed to call GetLongPathName'
         end
 
         converted = converted_ptr.read_wide_string(buffer_size - 1)

data/lib/pdk/util/windows/process.rb

@@ -11,10 +11,7 @@ module PDK::Util::Windows::Process
     contains_unicode_replacement = ->(string) do
       return false unless string.include?("\uFFFD")
 
-      PDK.logger.warning _(
-        'Discarding environment variable %{string} which contains invalid ' \
-        'bytes',
-      ) % { string: string }
+      PDK.logger.warning "Discarding environment variable #{string} which contains invalid bytes"
       true
     end
 
@@ -29,24 +26,24 @@ module PDK::Util::Windows::Process
   ensure
     if env_ptr && !env_ptr.null?
       if FreeEnvironmentStringsW(env_ptr) == PDK::Util::Windows::WIN32_FALSE
-        PDK.logger.debug _('FreeEnvironmentStringsW memory leak')
+        PDK.logger.debug 'FreeEnvironmentStringsW memory leak'
       end
     end
   end
   module_function :environment_hash
 
   def set_environment_variable(name, val)
-    raise ArgumentError, _('Environment variable name must not be nil or empty') if name.nil? || name.empty?
+    raise ArgumentError, 'Environment variable name must not be nil or empty' if name.nil? || name.empty?
 
     FFI::MemoryPointer.from_string_to_wide_string(name) do |name_ptr|
       if val.nil?
         if SetEnvironmentVariableW(name_ptr, FFI::MemoryPointer::NULL) == PDK::Util::Windows::WIN32_FALSE
-          raise _('Failed to remove environment variable: %{name}') % { name: name }
+          raise 'Failed to remove environment variable: %{name}' % { name: name }
         end
       else
         FFI::MemoryPointer.from_string_to_wide_string(val) do |val_ptr|
           if SetEnvironmentVariableW(name_ptr, val_ptr) == PDK::Util::Windows::WIN32_FALSE
-            raise _('Failed to set environment variaible: %{name}') % { name: name }
+            raise 'Failed to set environment variaible: %{name}' % { name: name }
           end
         end
       end

data/lib/pdk/util.rb

@@ -85,7 +85,7 @@ module PDK
     def canonical_path(path)
       if Gem.win_platform?
         unless PDK::Util::Filesystem.exist?(path)
-          raise PDK::CLI::FatalError, _("Cannot resolve a full path to '%{path}', as it does not currently exist.") % { path: path }
+          raise PDK::CLI::FatalError, "Cannot resolve a full path to '%{path}', as it does not currently exist." % { path: path }
         end
         PDK::Util::Windows::File.get_long_pathname(path)
       else
@@ -114,7 +114,7 @@ module PDK
     module_function :gem_install?
 
     def pdk_package_basedir
-      raise PDK::CLI::FatalError, _('Package basedir requested for non-package install.') unless package_install?
+      raise PDK::CLI::FatalError, 'Package basedir requested for non-package install.' unless package_install?
       require 'pdk/util/version'
 
       File.dirname(PDK::Util::Version.version_file)

data/lib/pdk/validate/control_repo/environment_conf_validator.rb

@@ -19,7 +19,7 @@ module PDK
         end
 
         def spinner_text
-          _('Checking Puppet Environment settings (%{patterns}).') % {
+          'Checking Puppet Environment settings (%{patterns}).' % {
             patterns: pattern.join(' '),
           }
         end
@@ -31,7 +31,7 @@ module PDK
               source: name,
               state: :failure,
               severity: 'error',
-              message: _('Could not be read.'),
+              message: 'Could not be read.',
             )
             return 1
           end
@@ -46,9 +46,9 @@ module PDK
               next if ALLOWED_SETTINGS.include?(setting_name)
               # A hash indicates that the ini file has a section in it.
               message = if setting_value.is_a?(Hash)
-                          _("Invalid section '%{name}'") % { name: setting_name }
+                          "Invalid section '%{name}'" % { name: setting_name }
                         else
-                          _("Invalid setting '%{name}'") % { name: setting_name }
+                          "Invalid setting '%{name}'" % { name: setting_name }
                         end
 
               report.add_event(
@@ -68,7 +68,7 @@ module PDK
                 source:   name,
                 state:    :failure,
                 severity: 'error',
-                message:  _("environment_timeout is set to '%{timeout}' but should be 0, 'unlimited' or not set.") % { timeout: timeout },
+                message:  "environment_timeout is set to '%{timeout}' but should be 0, 'unlimited' or not set." % { timeout: timeout },
               )
               is_valid = false
             end

data/lib/pdk/validate/invokable_validator.rb

@@ -87,7 +87,7 @@ module PDK
               target_list = target_list.reject { |file| ignore_list.match(file) }
 
               if target_list.flatten.empty?
-                PDK.logger.info(_('Validator \'%{validator}\' skipped for \'%{target}\'. No files matching \'%{pattern}\' found to validate.') % { validator: name, target: target, pattern: pattern })
+                PDK.logger.info('Validator \'%{validator}\' skipped for \'%{target}\'. No files matching \'%{pattern}\' found to validate.' % { validator: name, target: target, pattern: pattern })
 
                 skipped << target
               end
@@ -121,7 +121,7 @@ module PDK
       # @see PDK::Validate::Validator.spinner_text
       # @abstract
       def spinner_text
-        _('Running %{name} validator ...') % { name: name }
+        'Running %{name} validator ...' % { name: name }
       end
 
       # @see PDK::Validate::Validator.spinner
@@ -138,11 +138,11 @@ module PDK
       # @param skipped [Array[String]] The list of skipped targets
       def process_skipped(report, skipped = [])
         skipped.each do |skipped_target|
-          PDK.logger.debug(_('%{validator}: Skipped \'%{target}\'. Target does not contain any files to validate (%{pattern}).') % { validator: name, target: skipped_target, pattern: pattern })
+          PDK.logger.debug('%{validator}: Skipped \'%{target}\'. Target does not contain any files to validate (%{pattern}).' % { validator: name, target: skipped_target, pattern: pattern })
           report.add_event(
             file:     skipped_target,
             source:   name,
-            message:  _('Target does not contain any files to validate (%{pattern}).') % { pattern: pattern },
+            message:  'Target does not contain any files to validate (%{pattern}).' % { pattern: pattern },
             severity: :info,
             state:    :skipped,
           )
@@ -154,11 +154,11 @@ module PDK
       # @param invalid [Array[String]] The list of invalid targets
       def process_invalid(report, invalid = [])
         invalid.each do |invalid_target|
-          PDK.logger.debug(_('%{validator}: Skipped \'%{target}\'. Target file not found.') % { validator: name, target: invalid_target })
+          PDK.logger.debug('%{validator}: Skipped \'%{target}\'. Target file not found.' % { validator: name, target: invalid_target })
           report.add_event(
             file:     invalid_target,
             source:   name,
-            message:  _('File does not exist.'),
+            message:  'File does not exist.',
             severity: :error,
             state:    :error,
           )

data/lib/pdk/validate/metadata/metadata_json_lint_validator.rb

@@ -19,7 +19,7 @@ module PDK
         end
 
         def spinner_text_for_targets(targets)
-          _('Checking module metadata style (%{targets}).') % {
+          'Checking module metadata style (%{targets}).' % {
             targets: PDK::Util.targets_relative_to_pwd(targets.flatten).join(' '),
           }
         end
@@ -36,7 +36,7 @@ module PDK
         end
 
         def parse_output(report, result, targets)
-          raise ArgumentError, _('More than 1 target provided to PDK::Validate::MetadataJSONLintValidator.') if targets.count > 1
+          raise ArgumentError, 'More than 1 target provided to PDK::Validate::MetadataJSONLintValidator.' if targets.count > 1
 
           if result[:stdout].strip.empty?
             # metadata-json-lint will print nothing if there are no problems with

data/lib/pdk/validate/metadata/metadata_syntax_validator.rb

@@ -13,7 +13,7 @@ module PDK
         end
 
         def spinner_text
-          _('Checking metadata syntax (%{patterns}).') % {
+          'Checking metadata syntax (%{patterns}).' % {
             patterns: pattern.join(' '),
           }
         end
@@ -40,7 +40,7 @@ module PDK
               source: name,
               state: :failure,
               severity: 'error',
-              message: _('Could not be read.'),
+              message: 'Could not be read.',
             )
             return 1
           end

data/lib/pdk/validate/puppet/puppet_epp_validator.rb

@@ -37,7 +37,7 @@ module PDK
         end
 
         def spinner_text_for_targets(_targets)
-          _('Checking Puppet EPP syntax (%{pattern}).') % { pattern: pattern.join(' ') }
+          'Checking Puppet EPP syntax (%{pattern}).' % { pattern: pattern.join(' ') }
         end
 
         def parse_options(targets)

data/lib/pdk/validate/puppet/puppet_lint_validator.rb

@@ -17,7 +17,7 @@ module PDK
         end
 
         def spinner_text_for_targets(_targets)
-          _('Checking Puppet manifest style (%{pattern}).') % { pattern: pattern.join(' ') }
+          'Checking Puppet manifest style (%{pattern}).' % { pattern: pattern.join(' ') }
         end
 
         def parse_options(targets)

data/lib/pdk/validate/puppet/puppet_plan_syntax_validator.rb

@@ -0,0 +1,38 @@
+require 'pdk'
+
+module PDK
+  module Validate
+    module Puppet
+      class PuppetPlanSyntaxValidator < PuppetSyntaxValidator
+        def name
+          'puppet-plan-syntax'
+        end
+
+        def pattern
+          contextual_pattern('plans/**/*.pp')
+        end
+
+        def pattern_ignore; end
+
+        def spinner_text_for_targets(_targets)
+          'Checking Puppet plan syntax (%{pattern}).' % { pattern: pattern.join(' ') }
+        end
+
+        def parse_options(targets)
+          # Due to PDK-1266 we need to run `puppet parser validate` with an empty
+          # modulepath. On *nix, Ruby treats `/dev/null` as an empty directory
+          # however it doesn't do so with `NUL` on Windows. The workaround for
+          # this to ensure consistent behaviour is to create an empty temporary
+          # directory and use that as the modulepath.
+          ['parser', 'validate', '--tasks', '--config', null_file, '--modulepath', validate_tmpdir].concat(targets)
+        end
+
+        def validate_tmpdir
+          require 'tmpdir'
+
+          @validate_tmpdir ||= Dir.mktmpdir('puppet-plan-parser-validate')
+        end
+      end
+    end
+  end
+end

data/lib/pdk/validate/puppet/puppet_syntax_validator.rb

@@ -41,7 +41,7 @@ module PDK
         end
 
         def spinner_text_for_targets(_targets)
-          _('Checking Puppet manifest syntax (%{pattern}).') % { pattern: pattern.join(' ') }
+          'Checking Puppet manifest syntax (%{pattern}).' % { pattern: pattern.join(' ') }
         end
 
         def parse_options(targets)

data/lib/pdk/validate/puppet/puppet_validator_group.rb

@@ -11,6 +11,7 @@ module PDK
         def validators
           [
             PuppetSyntaxValidator,
+            PuppetPlanSyntaxValidator,
             PuppetLintValidator,
             PuppetEPPValidator,
           ].freeze

data/lib/pdk/validate/ruby/ruby_rubocop_validator.rb

@@ -25,7 +25,7 @@ module PDK
         end
 
         def spinner_text_for_targets(_targets)
-          _('Checking Ruby code style (%{pattern}).') % { pattern: pattern }
+          'Checking Ruby code style (%{pattern}).' % { pattern: pattern }
         end
 
         def parse_options(targets)

data/lib/pdk/validate/tasks/tasks_metadata_lint_validator.rb

@@ -15,7 +15,7 @@ module PDK
         end
 
         def spinner_text
-          _('Checking task metadata style (%{pattern}).') % {
+          'Checking task metadata style (%{pattern}).' % {
             pattern: pattern.join(' '),
           }
         end
@@ -29,7 +29,7 @@ module PDK
         rescue PDK::Util::VendoredFile::DownloadError => e
           raise PDK::CLI::FatalError, e.message
         rescue JSON::ParserError
-          raise PDK::CLI::FatalError, _('Failed to parse Task Metadata Schema file.')
+          raise PDK::CLI::FatalError, 'Failed to parse Task Metadata Schema file.'
         end
 
         def validate_target(report, target)
@@ -39,7 +39,7 @@ module PDK
               source:   name,
               state:    :failure,
               severity: 'error',
-              message:  _('Could not be read.'),
+              message: 'Could not be read.',
             )
             return 1
           end
@@ -54,7 +54,7 @@ module PDK
             begin
               errors = JSON::Validator.fully_validate(schema_file, PDK::Util::Filesystem.read_file(target)) || []
             rescue JSON::Schema::SchemaError => e
-              raise PDK::CLI::FatalError, _('Unable to validate Task Metadata. %{error}.') % { error: e.message }
+              raise PDK::CLI::FatalError, 'Unable to validate Task Metadata. %{error}.' % { error: e.message }
             end
 
             if errors.empty?

data/lib/pdk/validate/tasks/tasks_name_validator.rb

@@ -4,10 +4,7 @@ module PDK
   module Validate
     module Tasks
       class TasksNameValidator < InternalRubyValidator
-        INVALID_TASK_MSG = _(
-          'Invalid task name. Task names must start with a lowercase letter ' \
-          'and can only contain lowercase letters, numbers, and underscores.',
-        )
+        INVALID_TASK_MSG = 'Invalid task name. Task names must start with a lowercase letter and can only contain lowercase letters, numbers, and underscores.'.freeze
 
         def name
           'task-name'
@@ -18,7 +15,7 @@ module PDK
         end
 
         def spinner_text
-          _('Checking task names (%{pattern}).') % {
+          'Checking task names (%{pattern}).' % {
             pattern: pattern.join(' '),
           }
         end