pdk 1.7.1 → 1.8.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pdk
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.8.0
 platform: ruby
 authors:
 - Puppet, Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-08 00:00:00.000000000 Z
+date: 2018-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -240,6 +240,7 @@ files:
 - lib/pdk/generate/task.rb
 - lib/pdk/i18n.rb
 - lib/pdk/logger.rb
+- lib/pdk/module.rb
 - lib/pdk/module/build.rb
 - lib/pdk/module/convert.rb
 - lib/pdk/module/metadata.rb
@@ -252,6 +253,7 @@ files:
 - lib/pdk/tests/unit.rb
 - lib/pdk/util.rb
 - lib/pdk/util/bundler.rb
+- lib/pdk/util/filesystem.rb
 - lib/pdk/util/git.rb
 - lib/pdk/util/puppet_version.rb
 - lib/pdk/util/ruby_version.rb
@@ -265,13 +267,15 @@ files:
 - lib/pdk/validate/base_validator.rb
 - lib/pdk/validate/metadata/metadata_json_lint.rb
 - lib/pdk/validate/metadata/metadata_syntax.rb
-- lib/pdk/validate/metadata/task_metadata_lint.rb
 - lib/pdk/validate/metadata_validator.rb
 - lib/pdk/validate/puppet/puppet_lint.rb
 - lib/pdk/validate/puppet/puppet_syntax.rb
 - lib/pdk/validate/puppet_validator.rb
 - lib/pdk/validate/ruby/rubocop.rb
 - lib/pdk/validate/ruby_validator.rb
+- lib/pdk/validate/tasks/metadata_lint.rb
+- lib/pdk/validate/tasks/name.rb
+- lib/pdk/validate/tasks_validator.rb
 - lib/pdk/version.rb
 - locales/config.yaml
 - locales/pdk.pot

data/lib/pdk/validate/metadata/task_metadata_lint.rb

@@ -1,124 +0,0 @@
-require 'pdk'
-require 'pdk/cli/exec'
-require 'pdk/validate/base_validator'
-require 'pdk/util'
-require 'pathname'
-require 'json-schema'
-
-module PDK
-  module Validate
-    class TaskMetadataLint < BaseValidator
-      FORGE_SCHEMA_URL = 'https://forgeapi.puppet.com/schemas/task.json'.freeze
-
-      def self.name
-        'task-metadata-lint'
-      end
-
-      def self.pattern
-        'tasks/*.json'
-      end
-
-      def self.spinner_text(_targets = [])
-        _('Checking task metadata style (%{targets}).') % {
-          targets: pattern,
-        }
-      end
-
-      def self.create_spinner(targets = [], options = {})
-        return unless PDK::CLI::Util.interactive?
-        options = options.merge(PDK::CLI::Util.spinner_opts_for_platform)
-
-        exec_group = options[:exec_group]
-        @spinner = if exec_group
-                     exec_group.add_spinner(spinner_text(targets), options)
-                   else
-                     TTY::Spinner.new("[:spinner] #{spinner_text(targets)}", options)
-                   end
-        @spinner.auto_spin
-      end
-
-      def self.stop_spinner(exit_code)
-        if exit_code.zero? && @spinner
-          @spinner.success
-        elsif @spinner
-          @spinner.error
-        end
-      end
-
-      def self.schema_file
-        schema = PDK::Util::VendoredFile.new('task.json', FORGE_SCHEMA_URL).read
-
-        JSON.parse(schema)
-      rescue PDK::Util::VendoredFile::DownloadError => e
-        raise PDK::CLI::FatalError, e.message
-      rescue JSON::ParserError
-        raise PDK::CLI::FatalError, _('Failed to parse Task Metadata Schema file.')
-      end
-
-      def self.invoke(report, options = {})
-        targets, skipped, invalid = parse_targets(options)
-
-        process_skipped(report, skipped)
-        process_invalid(report, invalid)
-
-        return 0 if targets.empty?
-
-        return_val = 0
-        create_spinner(targets, options)
-
-        targets.each do |target|
-          unless File.readable?(target)
-            report.add_event(
-              file:     target,
-              source:   name,
-              state:    :failure,
-              severity: 'error',
-              message:  _('Could not be read.'),
-            )
-            return_val = 1
-            next
-          end
-
-          begin
-            # Need to set the JSON Parser and State Generator to the Native one to be
-            # compatible with the multi_json adapter.
-            JSON.parser = JSON::Ext::Parser if defined?(JSON::Ext::Parser)
-            JSON.generator = JSON::Ext::Generator
-
-            begin
-              errors = JSON::Validator.fully_validate(schema_file, File.read(target)) || []
-            rescue JSON::Schema::SchemaError => e
-              raise PDK::CLI::FatalError, _('Unable to validate Task Metadata. %{error}.') % { error: e.message }
-            end
-
-            if errors.empty?
-              report.add_event(
-                file:     target,
-                source:   name,
-                state:    :passed,
-                severity: 'ok',
-              )
-            else
-              errors.each do |error|
-                # strip off the trailing parts that aren't relevant
-                error = error.split('in schema').first if error.include? 'in schema'
-
-                report.add_event(
-                  file:     target,
-                  source:   name,
-                  state:    :failure,
-                  severity: 'error',
-                  message:  error,
-                )
-              end
-              return_val = 1
-            end
-          end
-        end
-
-        stop_spinner(return_val)
-        return_val
-      end
-    end
-  end
-end