pdd 0.7 → 0.7.1

data/features/catches_broken_puzzles.feature

@@ -33,3 +33,19 @@ Feature: Catches Broken Puzzles
     }
     """
     When I run pdd it fails with "Too many spaces"
+
+  Scenario: Throwing exception on yet another broken puzzle
+    Given I have a "Sample.java" file with content:
+    """
+    public class Main {
+      //
+      // @todo #13 This puzzle has an incorrect format
+      // because there is no space character in the
+      // second and third lines
+      //
+      public void main(String[] args) {
+        // later
+      }
+    }
+    """
+    When I run pdd it fails with "Space expected"

data/lib/pdd/source.rb

@@ -92,4 +92,22 @@ module PDD
         .map { |txt| txt[1, txt.length] }
     end
   end
+
+  # Verbose Source.
+  class VerboseSource
+    # Ctor.
+    # +file+:: Absolute file name with source code
+    # +source+:: Instance of source
+    def initialize(file, source)
+      @file = file
+      @source = source
+    end
+
+    # Fetch all puzzles.
+    def puzzles
+      @source.puzzles
+    rescue Error => ex
+      raise Error, "#{ex.message} in #{@file}"
+    end
+  end
 end

data/lib/pdd/sources.rb

@@ -50,7 +50,10 @@ module PDD
       files
         .select { |f| types.index { |re| @magic.file(f) =~ re } }
         .map do |file|
-          Source.new(file, file[@dir.length + 1, file.length])
+          VerboseSource.new(
+            file,
+            Source.new(file, file[@dir.length + 1, file.length])
+          )
         end
     end
 

data/lib/pdd/version.rb

@@ -26,5 +26,5 @@
 # Copyright:: Copyright (c) 2014 Yegor Bugayenko
 # License:: MIT
 module PDD
-  VERSION = '0.7'
+  VERSION = '0.7.1'
 end

data/test/test_source.rb

@@ -43,7 +43,7 @@ class TestSources < Minitest::Test
         ~~  and it also has to work
         '
       )
-      list = PDD::Source.new(file, 'hey').puzzles
+      list = PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
       assert_equal 2, list.size
       puzzle = list.first
       assert_equal '2-3', puzzle.props[:lines]
@@ -51,4 +51,21 @@ class TestSources < Minitest::Test
       assert_equal '44', puzzle.props[:ticket]
     end
   end
+
+  def test_failing_on_invalid_puzzle
+    Dir.mktmpdir 'test' do |dir|
+      file = File.join(dir, 'a.txt')
+      File.write(
+        file,
+        '
+        * @todo #44 this is an incorrectly formatted puzzle,
+        * with a second line without a leading space
+        '
+      )
+      error = assert_raises PDD::Error do
+        PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
+      end
+      assert !error.message.index('Space expected').nil?
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pdd
 version: !ruby/object:Gem::Version
-  version: '0.7'
+  version: 0.7.1
   prerelease: 
 platform: ruby
 authors: