pdd 0.21.2 → 0.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c76649118dbe4b4884f07d453b611ca05da5845e753357fcb98cd0e6e8324b64
-  data.tar.gz: 4b85d7b84b62f8d695d2e8b95a92bc03cb87d5e6acbef283723ac353a43c42cd
+  metadata.gz: 1c97d7f2451c60abeae2fa0374b8578c852b6c2e42a78568c5fff8c7b5c3acc1
+  data.tar.gz: 5353eec5dea5875dc31a7655e694fc41c3585ff176f849db8122b777ee38a25a
 SHA512:
-  metadata.gz: 1a54147d056c4593c20142e9c45497308bc57c0ec34a63e84fc0f025e1722ed406102f9383196cec51a084baffe17d2de4174060c93173328605089410a48dff
-  data.tar.gz: 4270c5b9ec6e8b63ca371b2c6c5905b13394d5078943f1c66b8c8ec9ccc30ae25026efd375f3fd2d5bd8c2a1fd29080c86755935d5c91bc6d47baceda89e6edd
+  metadata.gz: ecded4d1f191fb5ab36eb237add8d46ca48430371a8c6ab9758a159ebfc796ac276a7327c4f9b33a3186ebd104c95e0255af12def22ccbcfaf0e3239decb67d7
+  data.tar.gz: 0fe7422e26da6f53561a3e51c597cb779f39f39828b9af55f8b2cd0fc8b1b359c919a0b82f3d39f26d487f5ac31a50020494f5fc1048cedf7b64545096847b22

data/.github/workflows/codecov.yml

@@ -6,7 +6,7 @@ on:
       - master
 jobs:
   codecov:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-ruby@v1

data/.github/workflows/pdd.yml

@@ -0,0 +1,15 @@
+---
+name: pdd
+"on":
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  pdd:
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: actions/checkout@v2
+      - uses: g4s8/pdd-action@master

data/.github/workflows/rake.yml

@@ -12,7 +12,7 @@ jobs:
     name: test
     strategy:
       matrix:
-        os: [ubuntu-latest]
+        os: [ubuntu-20.04]
         ruby: [2.7]
     runs-on: ${{ matrix.os }}
     steps:

data/.github/workflows/xcop.yml

@@ -0,0 +1,15 @@
+---
+name: xcop
+"on":
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  xcop:
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: actions/checkout@v2
+      - uses: g4s8/xcop-action@master

data/.pdd

@@ -9,6 +9,7 @@
 --exclude features/cli.feature
 --exclude features/parsing.feature
 --exclude features/catches_broken_puzzles.feature
+--exclude features/remove.feature
 --exclude features/uses_config.feature
 --exclude features/html_output.feature
 --exclude features/avoiding_duplicates.feature

data/.rubocop.yml

@@ -3,12 +3,20 @@ AllCops:
     - "assets/**/*"
   DisplayCopNames: true
   TargetRubyVersion: 2.3
+  NewCops: enable
+  SuggestExtensions: false
 
+Layout/EmptyLineAfterGuardClause:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Max: 10
+Metrics/PerceivedComplexity:
+  Max: 15
 Layout/EndOfLine:
   EnforcedStyle: lf
 Metrics/ClassLength:
   Max: 360
-Metrics/LineLength:
+Layout/LineLength:
   Max: 90
 Metrics/MethodLength:
   Max: 35

data/.rultor.yml

@@ -19,7 +19,3 @@ release:
 merge:
   script: |-
     LC_ALL=US-ASCII bundle exec rake
-deploy:
-  script: |-
-    echo "There is nothing to deploy"
-    exit -1

data/README.md

@@ -4,15 +4,16 @@
 [![DevOps By Rultor.com](http://www.rultor.com/b/cqfn/pdd)](http://www.rultor.com/p/cqfn/pdd)
 [![We recommend RubyMine](https://www.elegantobjects.org/rubymine.svg)](https://www.jetbrains.com/ruby/)
 
+[![rake](https://github.com/cqfn/pdd/actions/workflows/rake.yml/badge.svg)](https://github.com/cqfn/pdd/actions/workflows/rake.yml)
 [![PDD status](http://www.0pdd.com/svg?name=cqfn/pdd)](http://www.0pdd.com/p?name=cqfn/pdd)
 [![codecov](https://codecov.io/gh/cqfn/pdd/branch/master/graph/badge.svg)](https://codecov.io/gh/cqfn/pdd)
 ![Lines of code](https://img.shields.io/tokei/lines/github/cqfn/pdd)
 [![Hits-of-Code](https://hitsofcode.com/github/cqfn/pdd)](https://hitsofcode.com/view/github/cqfn/pdd)
 [![License](https://img.shields.io/badge/license-MIT-green.svg)](https://github.com/cqfn/pdd/blob/master/LICENSE.txt)
-
 [![Gem Version](https://badge.fury.io/rb/pdd.svg)](http://badge.fury.io/rb/pdd)
 [![Maintainability](https://api.codeclimate.com/v1/badges/c8e46256fdd8ddc817e5/maintainability)](https://codeclimate.com/github/cqfn/pdd/maintainability)
 [![Yard Docs](http://img.shields.io/badge/yard-docs-blue.svg)](http://rubydoc.info/github/cqfn/pdd/master/frames)
+[![Codacy Badge](https://app.codacy.com/project/badge/Grade/1792d42f96fb45448e8d495ebc4348aa)](https://www.codacy.com/gh/cqfn/pdd/dashboard?utm_source=github.com&utm_medium=referral&utm_content=cqfn/pdd&utm_campaign=Badge_Grade)
 
 Read this article about
 [_Puzzle Driven Development_](http://www.yegor256.com/2009/03/04/pdd.html).
@@ -235,3 +236,9 @@ This is how you run the tool locally to test how it works:
 ```bash
 $ ./bin/pdd --help
 ```
+
+To run a single unit test:
+
+```bash
+$ bundle exec ruby test/test_many.rb
+```

data/bin/pdd

@@ -50,6 +50,7 @@ begin
       o.bool '-h', '--help', 'Show these instructions'
       o.bool '-v', '--verbose', 'Enable verbose mode (a lot of logging)'
       o.bool '-q', '--quiet', 'Enable quiet mode (almost no logging)'
+      o.bool '--remove', 'Remove all found puzzles from the source code'
       o.bool '--skip-gitignore', 'Don\'t look into .gitignore for excludes'
       o.bool '--skip-errors', 'Suppress error as warning and skip badly
                       formatted puzzles'
@@ -89,31 +90,52 @@ https://github.com/cqfn/pdd/blob/master/README.md"
     body = File.read(cfg)
     extra = body.split(/\s+/).map(&:strip)
     opts['skip-gitignore'] = extra
-    puts "Found #{body.split(/\n/).length} lines in #{File.absolute_path(cfg)}"
+    PDD.log.info "Found #{body.split(/\n/).length} lines in #{File.absolute_path(cfg)}"
   end
 
   Encoding.default_external = Encoding::UTF_8
   Encoding.default_internal = Encoding::UTF_8
   file = opts.file? ? File.new(opts[:file], 'w') : $stdout
-  output = PDD::Base.new(opts).xml
+  xml = PDD::Base.new(opts).xml
+  output = xml
   if opts[:format]
     if opts[:format] == 'html'
       xslt = File.join(
         File.dirname(File.dirname(__FILE__)),
         'assets', 'puzzles.xsl'
       )
-      output = Nokogiri::XSLT(File.read(xslt)).transform(Nokogiri::XML(output))
+      output = Nokogiri::XSLT(File.read(xslt)).transform(Nokogiri::XML(xml))
     elsif opts[:format] != 'xml'
       raise 'Invalid format, use html or xml'
     end
   end
   file << output
+  if opts.remove?
+    home = opts[:source] || Dir.pwd
+    PDD.log.info "Removing puzzles from #{home}..."
+    files = {}
+    Nokogiri::XML(xml).xpath('/puzzles/puzzle').each do |p|
+      file = p.xpath('file/text()').to_s
+      files[file] = [] if files[file].nil?
+      files[file] << p.xpath('lines/text()').to_s.split('-').map(&:to_i)
+    end
+    files.each do |src, all|
+      f = File.join(home, src)
+      File.write(
+        f,
+        File.readlines(f).reject.each_with_index do |_t, i|
+          all.any? { |pair| i + 1 >= pair[0] && i + 1 <= pair[1] }
+        end.join
+      )
+      PDD.log.info "#{all.count} puzzles removed from #{src}"
+    end
+  end
 rescue SystemExit => e
   puts e.message unless e.success?
   PDD.log.info "Exit code is #{e.status}"
   exit(e.status)
 rescue PDD::Error => e
-  puts "#{Rainbow('ERROR').red}: #{e.message}
+  PDD.log.error "#{Rainbow('ERROR').red}: #{e.message}
 If you can't understand the cause of this issue or you don't know \
 how to fix it, please submit a GitHub issue, we will try to help you: \
 https://github.com/cqfn/pdd/issues. This tool is still in its beta \
@@ -122,7 +144,7 @@ more documentation: https://github.com/cqfn/pdd/blob/master/README.md."
   PDD.log.info 'Exit code is 1'
   exit(1)
 rescue StandardError => e
-  puts "#{Rainbow('ERROR').red} (#{e.class.name}): #{e.message}"
+  PDD.log.error "#{Rainbow('ERROR').red} (#{e.class.name}): #{e.message}"
   PDD.log.info 'Exit code is 255'
   exit(255)
 end

data/features/remove.feature

@@ -0,0 +1,15 @@
+Feature: Removing Puzzles
+  As a source code writer I want to be able to
+  remove PDD puzzles from source code
+
+  Scenario: Removing puzzles from code
+    Given I have a "a/test.txt" file with content:
+    """
+    Hello,
+    # @todo #42 Bye!
+    #  Bye!
+    The End.
+    """
+    When I run bin/pdd with "-v --remove -f /dev/null"
+    Then Exit code is zero
+    And Stdout contains "1 puzzles removed from a/test.txt"

data/features/step_definitions/steps.rb

@@ -27,7 +27,7 @@ require_relative '../../lib/pdd'
 Before do
   @cwd = Dir.pwd
   @dir = Dir.mktmpdir('test')
-  FileUtils.mkdir_p(@dir) unless File.exist?(@dir)
+  FileUtils.mkdir_p(@dir)
   Dir.chdir(@dir)
   @opts = Slop.parse ['-q', '-s', @dir] do |o|
     o.bool '-v', '--verbose'
@@ -38,7 +38,7 @@ end
 
 After do
   Dir.chdir(@cwd)
-  FileUtils.rm_rf(@dir) if File.exist?(@dir)
+  FileUtils.rm_rf(@dir)
 end
 
 Given(/skip/) do
@@ -79,6 +79,7 @@ When(%r{^I run bin/pdd with "([^"]*)"$}) do |arg|
 end
 
 Then(/^Stdout contains "([^"]*)"$/) do |txt|
+  raise 'STDOUT is empty!' if @stdout.empty?
   raise "STDOUT doesn't contain '#{txt}':\n#{@stdout}" unless @stdout.include?(txt)
 end
 

data/lib/pdd/rake_task.rb

@@ -13,6 +13,7 @@ module PDD
     attr_accessor :name, :fail_on_error, :includes, :license, :quiet
 
     def initialize(*args, &task_block)
+      super()
       @name = args.shift || :pdd
       @includes = []
       @excludes = []

data/lib/pdd/rule/estimates.rb

@@ -32,9 +32,9 @@ module PDD
 
         def errors
           @xml.xpath("//puzzle[number(estimate) < #{@min}]").map do |p|
-            "Puzzle #{p.xpath('file/text()')}:#{p.xpath('lines/text()')}"\
-            " has an estimate of #{p.xpath('estimate/text()')} minutes,"\
-            " which is lower than #{@min} minutes"
+            "Puzzle #{p.xpath('file/text()')}:#{p.xpath('lines/text()')} " \
+              "has an estimate of #{p.xpath('estimate/text()')} minutes, " \
+              "which is lower than #{@min} minutes"
           end
         end
       end
@@ -50,9 +50,9 @@ module PDD
 
         def errors
           @xml.xpath("//puzzle[number(estimate) > #{@min}]").map do |p|
-            "Puzzle #{p.xpath('file/text()')}:#{p.xpath('lines/text()')}"\
-            " has an estimate of #{p.xpath('estimate/text()')} minutes,"\
-            " which is bigger than #{@min} minutes"
+            "Puzzle #{p.xpath('file/text()')}:#{p.xpath('lines/text()')} " \
+              "has an estimate of #{p.xpath('estimate/text()')} minutes, " \
+              "which is bigger than #{@min} minutes"
           end
         end
       end

data/lib/pdd/rule/roles.rb

@@ -37,11 +37,11 @@ module PDD
 
             "puzzle #{p.xpath('file/text()')}:#{p.xpath('lines/text()')}" +
               if role.empty?
-                " doesn't define any role"\
-                ", while one of these roles is required: #{@roles}"
+                " doesn't define any role" \
+                  ", while one of these roles is required: #{@roles}"
               else
-                " defines role #{role}"\
-                ", while only these roles are allowed: #{@roles}"
+                " defines role #{role}" \
+                  ", while only these roles are allowed: #{@roles}"
               end
           end.compact
         end

data/lib/pdd/rule/text.rb

@@ -35,9 +35,9 @@ module PDD
             words = p.xpath('body/text()').to_s.split.size
             next nil if words >= @min
 
-            "Puzzle #{p.xpath('file/text()')}:#{p.xpath('lines/text()')}"\
-            " has a very short description of just #{words} words while"\
-            " a minimum of #{@min} is required"
+            "Puzzle #{p.xpath('file/text()')}:#{p.xpath('lines/text()')} " \
+              "has a very short description of just #{words} words while " \
+              "a minimum of #{@min} is required"
           end.compact
         end
       end

data/lib/pdd/source.rb

@@ -37,27 +37,27 @@ module PDD
       @path = path
     end
 
-    def match_markers(l)
-      if l.downcase.include? 'todo'
-        /[^\s]\x40todo/.match(l) do |_|
+    def match_markers(line)
+      if line.downcase.include? 'todo'
+        /[^\s]\x40todo/.match(line) do |_|
           raise Error, get_no_leading_space_error("\x40todo")
         end
-        /\x40todo(?!\s+#)/.match(l) do |_|
+        /\x40todo(?!\s+#)/.match(line) do |_|
           raise Error, get_no_puzzle_marker_error("\x40todo")
         end
-        /\x40todo\s+#\s/.match(l) do |_|
+        /\x40todo\s+#\s/.match(line) do |_|
           raise Error, get_space_after_hash_error("\x40todo")
         end
-        /[^\s]TODO:?/.match(l) do |_|
+        /[^\s]TODO:?/.match(line) do |_|
           raise Error, get_no_leading_space_error('TODO')
         end
-        /TODO(?!:?\s+#)/.match(l) do |_|
+        /TODO(?!:?\s+#)/.match(line) do |_|
           raise Error, get_no_puzzle_marker_error('TODO')
         end
-        /TODO:?\s+#\s/.match(l) do |_|
+        /TODO:?\s+#\s/.match(line) do |_|
           raise Error, get_space_after_hash_error('TODO')
         end
-        a = [%r{(.*(?:^|\s))(?:\x40todo|TODO:|TODO)\s+#([\w\-.:/]+)\s+(.+)}.match(l)]
+        a = [%r{(.*(?:^|\s))(?:\x40todo|TODO:|TODO)\s+#([\w\-.:/]+)\s+(.+)}.match(line)]
         a.compact
       else
         []
@@ -74,10 +74,9 @@ module PDD
           match_markers(line).each do |m|
             puzzles << puzzle(lines.drop(idx + 1), m, idx)
           end
-        rescue Error, ArgumentError => ex
-          message = "#{@path}:#{idx + 1} #{ex.message}"
+        rescue Error, ArgumentError => e
+          message = "#{e.class} at #{@path}:#{idx + 1}: #{e.message}"
           raise Error, message unless PDD.opts && PDD.opts['skip-errors']
-          PDD.log.warn message
         end
       end
       puzzles
@@ -147,22 +146,18 @@ against the rules explained here: https://github.com/cqfn/pdd#how-to-format"
     #
     # Fetch puzzle tail (all lines after the first one)
     def tail(lines, prefix, start)
-      prefix = prefix.rstrip
       prefix = " #{' ' * start}" if prefix.empty? # fallback to space indentation
-      line = lines[0][prefix.length + 1, lines[0].length] if lines[0]
+      line = lines[0][prefix.length, lines[0].length] if lines[0]
       is_indented = line&.start_with?(' ')
       lines
-        .take_while { |t| match_markers(t).none? && t.start_with?(prefix) }
         .take_while do |t|
-          !is_indented || t[prefix.length + 1, t.length].start_with?(' ')
+          start = t.length > prefix.length ? prefix : prefix.rstrip
+          match_markers(t).none? && t.start_with?(start)
         end
         .take_while do |t|
-          # account for carriage return in line endings
-          t_len = t.length - 1
-          t_len <= prefix.length || t_len > prefix.length + 2
+          !is_indented || t[prefix.length, t.length].start_with?(' ')
         end
-        .map { |t| t[prefix.length, t.length] }
-        .map { |t| t.start_with?(' ') ? t[1, t.length] : t }
+        .map { |t| t[prefix.length, t.length]&.lstrip }
     end
     # rubocop:enable Metrics/CyclomaticComplexity
 
@@ -177,23 +172,22 @@ against the rules explained here: https://github.com/cqfn/pdd#how-to-format"
       git = "cd #{dir} && git"
       if `#{git} rev-parse --is-inside-work-tree 2>/dev/null`.strip == 'true'
         cmd = "#{git} blame -L #{pos},#{pos} --porcelain #{name}"
-        add_github_login(Hash[
-                           `#{cmd}`.split("\n").map do |line|
-                             case line
-                             when /^author /
-                               [:author, line.sub(/^author /, '')]
-                             when /^author-mail [^@]+@[^.]+\..+/
-                               [:email, line.sub(/^author-mail <(.+)>$/, '\1')]
-                             when /^author-time /
-                               [
-                                 :time,
-                                 Time.at(
-                                   line.sub(/^author-time ([0-9]+)$/, '\1').to_i
-                                 ).utc.iso8601
-                               ]
-                             end
-                           end.compact
-                         ])
+        login = `#{cmd}`.split("\n").map do |line|
+          case line
+          when /^author /
+            [:author, line.sub(/^author /, '')]
+          when /^author-mail [^@]+@[^.]+\..+/
+            [:email, line.sub(/^author-mail <(.+)>$/, '\1')]
+          when /^author-time /
+            [
+              :time,
+              Time.at(
+                line.sub(/^author-time ([0-9]+)$/, '\1').to_i
+              ).utc.iso8601
+            ]
+          end
+        end.compact.to_h
+        add_github_login(login)
       else
         {}
       end

data/lib/pdd/sources.rb

@@ -56,8 +56,8 @@ module PDD
     end
 
     def exclude(paths)
-      paths = paths.nil? ? [] : paths
-      paths = paths.is_a?(Array) ? paths : [paths]
+      paths = [] if paths.nil?
+      paths = [paths] unless paths.is_a?(Array)
       @exclude.push(*paths)
       paths&.each do |path|
         PDD.log.info "#{Rainbow('Excluding').orange} #{path}"
@@ -66,8 +66,8 @@ module PDD
     end
 
     def include(paths)
-      paths = paths.nil? ? [] : paths
-      paths = paths.is_a?(Array) ? paths : [paths]
+      paths = [] if paths.nil?
+      paths = [paths] unless paths.is_a?(Array)
       @include.push(*paths)
       paths&.each do |path|
         PDD.log.info "#{Rainbow('Including').blue} #{path}"

data/lib/pdd/version.rb

@@ -23,5 +23,5 @@
 # Copyright:: Copyright (c) 2014-2022 Yegor Bugayenko
 # License:: MIT
 module PDD
-  VERSION = '0.21.2'.freeze
+  VERSION = '0.22.0'.freeze
 end

data/lib/pdd.rb

@@ -102,8 +102,8 @@ module PDD
               sources.fetch.each do |source|
                 source.puzzles.each do |puzzle|
                   PDD.log.info "Puzzle #{puzzle.props[:id]} " \
-                    "#{puzzle.props[:estimate]}/#{puzzle.props[:role]}" \
-                    " at #{puzzle.props[:file]}"
+                               "#{puzzle.props[:estimate]}/#{puzzle.props[:role]} " \
+                               "at #{puzzle.props[:file]}"
                   render puzzle, xml
                 end
               end

data/pdd.gemspec

@@ -25,12 +25,10 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require_relative 'lib/pdd/version'
 
 Gem::Specification.new do |s|
-  s.specification_version = 2 if s.respond_to? :specification_version=
   if s.respond_to? :required_rubygems_version=
     s.required_rubygems_version =
       Gem::Requirement.new('>= 0')
   end
-  s.rubygems_version = '2.3'
   s.required_ruby_version = '~> 2.3'
   s.name = 'pdd'
   s.version = PDD::VERSION
@@ -42,7 +40,6 @@ Gem::Specification.new do |s|
   s.homepage = 'http://github.com/cqfn/pdd'
   s.files = `git ls-files`.split($RS)
   s.executables = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  s.test_files = s.files.grep(%r{^(test|spec|features)/})
   s.rdoc_options = ['--charset=UTF-8']
   s.extra_rdoc_files = ['README.md', 'LICENSE.txt']
   s.add_runtime_dependency 'nokogiri', '~> 1.10'
@@ -50,14 +47,15 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'ruby-filemagic', '~> 0.7.2'
   s.add_runtime_dependency 'slop', '~> 4.6'
   s.add_development_dependency 'aruba', '~> 0.14.1'
-  s.add_development_dependency 'codecov', '0.2.12'
-  s.add_development_dependency 'cucumber', '3.1.0'
-  s.add_development_dependency 'minitest', '5.5.0'
-  s.add_development_dependency 'rake', '12.0.0'
-  s.add_development_dependency 'rdoc', '4.2.0'
-  s.add_development_dependency 'rspec-rails', '3.1.0'
-  s.add_development_dependency 'rubocop', '0.52.1'
-  s.add_development_dependency 'rubocop-rspec', '1.15.1'
-  s.add_development_dependency 'slop', '4.9.1'
-  s.add_development_dependency 'xcop', '0.5.8'
+  s.add_development_dependency 'codecov', '0.6.0'
+  s.add_development_dependency 'cucumber', '8.0.0'
+  s.add_development_dependency 'minitest', '5.16.2'
+  s.add_development_dependency 'rake', '13.0.6'
+  s.add_development_dependency 'rdoc', '6.4.0'
+  s.add_development_dependency 'rspec-rails', '5.1.2'
+  s.add_development_dependency 'rubocop', '1.32.0'
+  s.add_development_dependency 'rubocop-rspec', '2.12.1'
+  s.add_development_dependency 'slop', '4.9.2'
+  s.add_development_dependency 'xcop', '0.7.1'
+  s.metadata['rubygems_mfa_required'] = 'true'
 end

data/test/test_many.rb

@@ -0,0 +1,42 @@
+# Copyright (c) 2014-2022 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+require 'minitest/autorun'
+require 'tmpdir'
+require_relative '../lib/pdd'
+require_relative '../lib/pdd/sources'
+
+# Test many puzzles to make sure their IDs are correct.
+# Author:: Yegor Bugayenko (yegor256@gmail.com)
+# Copyright:: Copyright (c) 2014-2022 Yegor Bugayenko
+# License:: MIT
+class TestMany < Minitest::Test
+  def test_parsing
+    Dir['./test_assets/puzzles/**'].each do |p|
+      name = File.basename(p)
+      list = PDD::Source.new("./test_assets/puzzles/#{name}", 'hey').puzzles
+      assert_equal 1, list.size
+      puzzle = list.first
+      puts "#{name}: \"#{puzzle.props[:body]}\""
+      next if name.start_with?('_')
+      assert_equal name, puzzle.props[:id]
+    end
+  end
+end

data/test_assets/puzzles/1-04e35eb3

@@ -0,0 +1,3 @@
+/**
+ * @todo #1:30min How are you?
+ */

data/test_assets/puzzles/132-bc1dfafe

@@ -0,0 +1,8 @@
+//
+//
+// @todo #132 Just a few lines
+//  before another comment
+// @comment This is not a puzzle,
+// but another bloc of text
+//
+//

data/test_assets/puzzles/1425-59819ae3

@@ -0,0 +1,9 @@
+/**
+ *
+ *
+ * @todo #1425:30min Continue replacing usage of MatcherAssert.assertThat with 
+ *  Assertion from cactoos-matchers. Keep PR short and limit the changes to 
+ *  single package. Update this puzzle for the next package. 
+ *  After all packages are done, add MatcherAssert to forbidden-apis.txt 
+ *
+ */

data/test_assets/puzzles/42-0d933cc0

@@ -0,0 +1,7 @@
+#
+# @todo #42 This is a very
+# long puzzle     of many lines    and not always
+# well formatted...
+#
+#
+#

data/test_assets/puzzles/44-660e9d6f

@@ -0,0 +1,9 @@
+
+// @todo #44 This puzzle
+// consists
+// of
+//
+// two
+// paragraphs
+
+// This text doesn't belong to the puzzle

data/test_assets/puzzles/55-947a180a

@@ -0,0 +1,9 @@
+
+Some text goes before
+In a few lines
+
+     // @todo #55 This is the puzzle;
+     //           Indented this way.
+
+Another piece of text after
+Again in a few lines

data/test_assets/puzzles/71-8097fa26

@@ -0,0 +1,6 @@
+
+// @todo #71 This puzzle
+//    consists
+//    of just one paragraph
+//
+// this piece doesn't belong to the puzzle

data/test_assets/puzzles/91-ecb9aa47

@@ -0,0 +1,9 @@
+# Text before
+
+#     @todo #91    This puzzle
+#        Looks weird
+#           But it has to work
+#               Even though
+#                   It's weird
+
+# Here is the text after

data/test_assets/puzzles/93-641fe341

@@ -0,0 +1,4 @@
+#
+#    @todo #93:30min    This puzzle is very simple. It is indented right by more spaces than the other text.
+# This is the other text here,
+# which doesn't belong to the puzzle

data/utils/glob.rb

@@ -28,7 +28,7 @@ class Glob
 
   # rubocop:disable Metrics/CyclomaticComplexity
   def to_regexp
-    chars = @glob_string.gsub(%r{(\*\*\/\*)|(\*\*)}, '*').split('')
+    chars = @glob_string.gsub(%r{(\*\*/\*)|(\*\*)}, '*').chars
     in_curlies = 0, escaping = false
     chars.map do |char|
       if escaping

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pdd
 version: !ruby/object:Gem::Version
-  version: 0.21.2
+  version: 0.22.0
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-12 00:00:00.000000000 Z
+date: 2022-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -86,140 +86,140 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.2.12
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.2.12
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 8.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.5.0
+        version: 5.16.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.5.0
+        version: 5.16.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 13.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 13.0.6
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 6.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 6.4.0
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 5.1.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 5.1.2
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 1.32.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 1.32.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.15.1
+        version: 2.12.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.15.1
+        version: 2.12.1
 - !ruby/object:Gem::Dependency
   name: slop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.9.1
+        version: 4.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.9.1
+        version: 4.9.2
 - !ruby/object:Gem::Dependency
   name: xcop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.8
+        version: 0.7.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.8
+        version: 0.7.1
 description: Collects PDD puzzles from a source code base
 email: yegor256@gmail.com
 executables:
@@ -231,10 +231,10 @@ extra_rdoc_files:
 files:
 - ".0pdd.yml"
 - ".gitattributes"
-- ".github/ISSUE_TEMPLATE.md"
-- ".github/PULL_REQUEST_TEMPLATE.md"
 - ".github/workflows/codecov.yml"
+- ".github/workflows/pdd.yml"
 - ".github/workflows/rake.yml"
+- ".github/workflows/xcop.yml"
 - ".gitignore"
 - ".overcommit.yml"
 - ".pdd"
@@ -258,6 +258,7 @@ files:
 - features/html_output.feature
 - features/parsing.feature
 - features/rake.feature
+- features/remove.feature
 - features/step_definitions/steps.rb
 - features/support/env.rb
 - features/unicode.feature
@@ -276,6 +277,7 @@ files:
 - test/test__helper.rb
 - test/test_duplicates.rb
 - test/test_estimates.rb
+- test/test_many.rb
 - test/test_pdd.rb
 - test/test_rake_task.rb
 - test/test_roles.rb
@@ -288,11 +290,21 @@ files:
 - test_assets/cambria.woff
 - test_assets/elegant-objects.png
 - test_assets/favicon.ico
+- test_assets/puzzles/1-04e35eb3
+- test_assets/puzzles/132-bc1dfafe
+- test_assets/puzzles/1425-59819ae3
+- test_assets/puzzles/42-0d933cc0
+- test_assets/puzzles/44-660e9d6f
+- test_assets/puzzles/55-947a180a
+- test_assets/puzzles/71-8097fa26
+- test_assets/puzzles/91-ecb9aa47
+- test_assets/puzzles/93-641fe341
 - utils/glob.rb
 homepage: http://github.com/cqfn/pdd
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options:
 - "--charset=UTF-8"
@@ -311,28 +323,6 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 3.1.2
 signing_key: 
-specification_version: 2
+specification_version: 4
 summary: Puzzle Driven Development collector
-test_files:
-- features/applies_rules.feature
-- features/avoiding_duplicates.feature
-- features/catches_broken_puzzles.feature
-- features/cli.feature
-- features/gem_package.feature
-- features/html_output.feature
-- features/parsing.feature
-- features/rake.feature
-- features/step_definitions/steps.rb
-- features/support/env.rb
-- features/unicode.feature
-- features/uses_config.feature
-- test/test__helper.rb
-- test/test_duplicates.rb
-- test/test_estimates.rb
-- test/test_pdd.rb
-- test/test_rake_task.rb
-- test/test_roles.rb
-- test/test_source.rb
-- test/test_source_todo.rb
-- test/test_sources.rb
-- test/test_text.rb
+test_files: []

data/.github/ISSUE_TEMPLATE.md

@@ -1,12 +0,0 @@
-Make sure the title of the issue explains the problem you are having. Also, the description of the issue must clearly explain what is broken, not what you want us to implement. Go through this checklist and make sure you answer "YES" to all points:
-
-  - You have all pre-requisites listed in README.md installed
-  - You are sure that you are not reporting a duplicate (search all issues)
-  - You say "is broken" or "doesn't work" in the title
-  - You tell us what you are trying to do
-  - You explain the results you are getting
-  - You suggest an alternative result you would like to see
-
-This article will help you understand what we are looking for: http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html
-
-Thank you for your contribution!

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -1,11 +0,0 @@
-Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:
-
-  - You made a small amount of changes (less than 100 lines, less than 10 files)
-  - You made changes related to only one bug (create separate PRs for separate problems)
-  - You are ready to defend your changes (there will be a code review)
-  - You don't touch what you don't understand
-  - You ran the build locally and it passed
-
-This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html
-
-Thank you for your contribution!