pdd 0.20.6 → 0.21.0

data/test/test_source.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright (c) 2014-2022 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
@@ -25,7 +25,7 @@ require_relative '../lib/pdd/sources'
 
 # Source test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
-# Copyright:: Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright:: Copyright (c) 2014-2022 Yegor Bugayenko
 # License:: MIT
 class TestSource < Minitest::Test
   def test_parsing
@@ -42,32 +42,112 @@ class TestSource < Minitest::Test
         ~~  and it also has to work
         "
       )
-      list = PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
-      assert_equal 2, list.size
-      puzzle = list.first
-      assert_equal '2-3', puzzle.props[:lines]
-      assert_equal 'привет, how are you doing?', puzzle.props[:body]
-      assert_equal '44', puzzle.props[:ticket]
-      assert puzzle.props[:author].nil?
-      assert puzzle.props[:email].nil?
-      assert puzzle.props[:time].nil?
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        assert_equal 2, list.size
+        puzzle = list.first
+        assert_equal '2-4', puzzle.props[:lines]
+        assert_equal 'привет, how are you doing? -something else', \
+                     puzzle.props[:body]
+        assert_equal '44', puzzle.props[:ticket]
+        assert puzzle.props[:author].nil?
+        assert puzzle.props[:email].nil?
+        assert puzzle.props[:time].nil?
+      end
+    end
+  end
+
+  def test_parsing_leading_spaces
+    Dir.mktmpdir 'test' do |dir|
+      file = File.join(dir, 'a.txt')
+      File.write(
+        file,
+        "
+        * \x40todo #56:30min this is a
+        *       multi-line
+        *     comment!
+        "
+      )
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '2-4', puzzle.props[:lines]
+        assert_equal 'this is a multi-line comment!', puzzle.props[:body]
+        assert_equal '56', puzzle.props[:ticket]
+      end
+    end
+  end
+
+  def test_multiple_puzzles_single_comment_block
+    Dir.mktmpdir 'test' do |dir|
+      file = File.join(dir, 'a.txt')
+      File.write(
+        file,
+        "
+        /*
+         * \x40todo #1 First one with
+         * a few lines
+         * \x40todo #1 Second one also
+         * with a few lines
+         */
+        "
+      )
+      stub_source_find_github_user(file, 'hey') do |source|
+        PDD.opts = nil
+        assert_equal 2, source.puzzles.size
+        puzzle = source.puzzles.last
+        assert_equal '5-6', puzzle.props[:lines]
+        assert_equal 'Second one also with a few lines', puzzle.props[:body]
+        assert_equal '1', puzzle.props[:ticket]
+      end
     end
   end
 
-  def test_failing_on_invalid_puzzle
+  def test_succeed_despite_bad_puzzles
     Dir.mktmpdir 'test' do |dir|
       file = File.join(dir, 'a.txt')
       File.write(
         file,
         "
-        * \x40todo #44 this is an incorrectly formatted puzzle,
+        * \x40todo #44 this is a correctly formatted puzzle,
         * with a second line without a leading space
+        Another badly formatted puzzle
+        * \x40todo this bad puzzle misses ticket name/number
+        Something else
+        * \x40todo #123 This puzzle is correctly formatted
         "
       )
-      error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
+      PDD.opts = { 'skip-errors' => true }
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        PDD.opts = nil
+        assert_equal 2, list.size
+        puzzle = list.first
+        assert_equal '2-3', puzzle.props[:lines]
+        assert_equal 'this is a correctly formatted puzzle, with a second ' \
+                     'line without a leading space', puzzle.props[:body]
+        assert_equal '44', puzzle.props[:ticket]
       end
-      assert !error.message.index('Space expected').nil?
+    end
+  end
+
+  def test_succeed_utf8_encoded_body
+    Dir.mktmpdir 'test' do |dir|
+      file = File.join(dir, 'a.txt')
+      File.write(
+        file,
+        "
+        * \x40todo #44 Привет, мир, мне кофе
+        *  вторая линия
+        "
+      )
+      list = PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
+      assert_equal 1, list.size
+      puzzle = list.first
+      assert_equal '2-3', puzzle.props[:lines]
+      assert_equal 'Привет, мир, мне кофе вторая линия', puzzle.props[:body]
+      assert_equal '44', puzzle.props[:ticket]
     end
   end
 
@@ -81,7 +161,7 @@ class TestSource < Minitest::Test
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'ff')).puzzles
+        stub_source_find_github_user(file, 'ff', &:puzzles)
       end
       assert !error.to_s.index("\x40todo is not followed by").nil?
     end
@@ -90,9 +170,9 @@ class TestSource < Minitest::Test
   def test_failing_on_broken_unicode
     Dir.mktmpdir 'test' do |dir|
       file = File.join(dir, 'xx.txt')
-      File.write(file, ' * \x40todo #44 this is a broken unicode: ' + 0x92.chr)
+      File.write(file, " * \\x40todo #44 this is a broken unicode: #{0x92.chr}")
       assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'xx')).puzzles
+        stub_source_find_github_user(file, 'xx', &:puzzles)
       end
     end
   end
@@ -107,7 +187,7 @@ class TestSource < Minitest::Test
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
+        stub_source_find_github_user(file, 'hey', &:puzzles)
       end
       assert !error.message.index('is not followed by a puzzle marker').nil?
     end
@@ -123,7 +203,7 @@ class TestSource < Minitest::Test
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'x')).puzzles
+        stub_source_find_github_user(file, 'x', &:puzzles)
       end
       assert !error.message.index("\x40todo must have a leading space").nil?
     end
@@ -139,7 +219,7 @@ class TestSource < Minitest::Test
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'x')).puzzles
+        stub_source_find_github_user(file, 'x', &:puzzles)
       end
       assert !error.message.index('an unexpected space').nil?
     end
@@ -153,20 +233,24 @@ class TestSource < Minitest::Test
         cd '#{dir}'
         git init --quiet .
         git config user.email test@teamed.io
-        git config user.name test
+        git config user.name test_unknown
         echo '\x40todo #1 this is the puzzle' > a.txt
         git add a.txt
         git commit --quiet -am 'first version'
       ")
-      list = PDD::Source.new(File.join(dir, 'a.txt'), '').puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '1-de87adc8', puzzle.props[:id]
-      assert_equal '1-1', puzzle.props[:lines]
-      assert_equal 'this is the puzzle', puzzle.props[:body]
-      assert_equal 'test', puzzle.props[:author]
-      assert_equal 'test@teamed.io', puzzle.props[:email]
-      assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/, puzzle.props[:time])
+
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '1-de87adc8', puzzle.props[:id]
+        assert_equal '1-1', puzzle.props[:lines]
+        assert_equal 'this is the puzzle', puzzle.props[:body]
+        assert_equal 'test_unknown', puzzle.props[:author]
+        assert_equal 'test@teamed.io', puzzle.props[:email]
+        assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/,
+                     puzzle.props[:time])
+      end
     end
   end
 
@@ -183,15 +267,19 @@ class TestSource < Minitest::Test
         git add a.txt
         git commit --quiet -am 'first version'
       ")
-      list = PDD::Source.new(File.join(dir, 'a.txt'), '').puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '1-de87adc8', puzzle.props[:id]
-      assert_equal '1-1', puzzle.props[:lines]
-      assert_equal 'this is the puzzle', puzzle.props[:body]
-      assert_equal 'test', puzzle.props[:author]
-      assert_nil puzzle.props[:email]
-      assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/, puzzle.props[:time])
+
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '1-de87adc8', puzzle.props[:id]
+        assert_equal '1-1', puzzle.props[:lines]
+        assert_equal 'this is the puzzle', puzzle.props[:body]
+        assert_equal 'test', puzzle.props[:author]
+        assert_nil puzzle.props[:email]
+        assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/,
+                     puzzle.props[:time])
+      end
     end
   end
 
@@ -207,10 +295,37 @@ class TestSource < Minitest::Test
         git add a.txt
         git commit --quiet -am 'first version'
       ")
-      list = PDD::Source.new(File.join(dir, 'a.txt'), '').puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '@yegor256', puzzle.props[:author]
+
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '@yegor256', puzzle.props[:author]
+      end
+    end
+  end
+
+  def test_skips_uncommitted_changes
+    skip if Gem.win_platform?
+    Dir.mktmpdir 'test' do |dir|
+      raise unless system("
+        cd '#{dir}'
+        git init --quiet .
+        git config user.email yegor256@gmail.com
+        git config user.name test
+        echo 'hi' > a.txt
+        git add a.txt
+        git commit --quiet -am 'first version'
+        echo '\x40todo #1 this is a puzzle uncommitted' > a.txt
+      ")
+
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_nil puzzle.props[:email]
+        assert_equal 'Not Committed Yet', puzzle.props[:author]
+      end
     end
   end
 
@@ -221,12 +336,14 @@ class TestSource < Minitest::Test
         file,
         '<!--/* @todo #123 puzzle info */-->'
       )
-      list = PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '1-1', puzzle.props[:lines]
-      assert_equal 'puzzle info', puzzle.props[:body]
-      assert_equal '123', puzzle.props[:ticket]
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '1-1', puzzle.props[:lines]
+        assert_equal 'puzzle info', puzzle.props[:body]
+        assert_equal '123', puzzle.props[:ticket]
+      end
     end
   end
 end

data/test/test_source_todo.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright (c) 2014-2022 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
@@ -24,16 +24,18 @@ require_relative '../lib/pdd'
 require_relative '../lib/pdd/sources'
 
 class TestSourceTodo < Minitest::Test
-  def check_valid_puzzle(text, lines, body, ticket)
+  def check_valid_puzzle(text, lines, body, ticket, count = 1)
     Dir.mktmpdir 'test' do |dir|
       file = File.join(dir, 'a.txt')
       File.write(file, text)
-      list = PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal lines, puzzle.props[:lines]
-      assert_equal body, puzzle.props[:body]
-      assert_equal ticket, puzzle.props[:ticket]
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        assert_equal count, list.size
+        puzzle = list.first
+        assert_equal lines, puzzle.props[:lines]
+        assert_equal body, puzzle.props[:body]
+        assert_equal ticket, puzzle.props[:ticket]
+      end
     end
   end
 
@@ -42,7 +44,7 @@ class TestSourceTodo < Minitest::Test
       file = File.join(dir, 'a.txt')
       File.write(file, text)
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
+        stub_source_find_github_user(file, 'hey', &:puzzles)
       end
       assert !error.message.index(error_msg).nil?
     end
@@ -51,7 +53,7 @@ class TestSourceTodo < Minitest::Test
   def test_todo_parsing
     check_valid_puzzle(
       "
-      // TODO #45 task description
+      // @todo #45 task description
       ",
       '2-2',
       'task description',
@@ -62,7 +64,7 @@ class TestSourceTodo < Minitest::Test
   def test_todo_parsing_multi_line
     check_valid_puzzle(
       "
-      // TODO #45 task description
+      // @todo #45 task description
       //  second line
       ",
       '2-3',
@@ -71,44 +73,51 @@ class TestSourceTodo < Minitest::Test
     )
   end
 
-  def test_todo_colon_parsing
+  def test_todo_utf8_encoded_body
     check_valid_puzzle(
       "
-      // TODO: #45 task description
+      // TODO #45 Привет, мир, мне кофе
+      //  вторая линия
       ",
-      '2-2',
-      'task description',
+      '2-3',
+      'Привет, мир, мне кофе вторая линия',
       '45'
     )
   end
 
-  def test_todo_colon_parsing_multi_line
+  def test_todo_colon_parsing
     check_valid_puzzle(
       "
       // TODO: #45 task description
-      //  second line
       ",
-      '2-3',
-      'task description second line',
+      '2-2',
+      'task description',
       '45'
     )
   end
 
-  def test_todo_failing_no_space_on_second_line
-    check_invalid_puzzle(
+  def test_multiple_todo_colon
+    check_valid_puzzle(
       "
-      * TODO #45 this puzzle
-      * has not space on second line",
-      'Space expected'
+      // TODO: #45 task description
+      // TODO: #46 another task description
+      ",
+      '2-2',
+      'task description',
+      '45',
+      2
     )
   end
 
-  def test_todo_colon_failing_no_space_on_second_line
-    check_invalid_puzzle(
+  def test_todo_colon_parsing_multi_line
+    check_valid_puzzle(
       "
-      * TODO: #45 this puzzle
-      * has not space on second line",
-      'Space expected'
+      // TODO: #45 task description
+      //  second line
+      ",
+      '2-3',
+      'task description second line',
+      '45'
     )
   end
 

data/test/test_sources.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright (c) 2014-2022 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
@@ -26,7 +26,7 @@ require_relative '../lib/pdd/sources'
 
 # Sources test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
-# Copyright:: Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright:: Copyright (c) 2014-2022 Yegor Bugayenko
 # License:: MIT
 class TestSources < Minitest::Test
   def test_iterator
@@ -37,7 +37,6 @@ class TestSources < Minitest::Test
   end
 
   def test_ignores_binary_files
-    skip if Gem.win_platform?
     in_temp([]) do |dir|
       [
         'README.md',
@@ -89,6 +88,22 @@ class TestSources < Minitest::Test
     end
   end
 
+  def test_includes_by_pattern
+    in_temp(['a/first.txt', 'b/c/d/second.txt']) do |dir|
+      list = PDD::Sources.new(dir).include('b/c/d/second.txt').fetch
+      assert_equal 2, list.size
+    end
+  end
+
+  def test_includes_recursively
+    in_temp(['a/first.txt', 'b/c/second.txt', 'b/c/d/third.txt']) do |dir|
+      sources = PDD::Sources.new(dir).exclude('b/c/**')
+      sources.include('b/c/d/third.txt')
+      list = sources.fetch
+      assert_equal 2, list.size
+    end
+  end
+
   def test_fails_with_verbose_output
     in_temp do |dir|
       File.write(File.join(dir, 'z1.txt'), "\x40todobroken\n")

data/test/test_text.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright (c) 2014-2022 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
@@ -24,7 +24,7 @@ require_relative '../lib/pdd/rule/text'
 
 # PDD::Rule::Text module tests.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
-# Copyright:: Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright:: Copyright (c) 2014-2022 Yegor Bugayenko
 # License:: MIT
 class TestText < Minitest::Test
   def test_min_words

data/utils/glob.rb

@@ -0,0 +1,65 @@
+# Copyright (c) 2014-2022 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+# Utility glob class
+class Glob
+  NO_LEADING_DOT = '(?=[^\.])'.freeze
+
+  def initialize(glob_string)
+    @glob_string = glob_string
+  end
+
+  # rubocop:disable Metrics/CyclomaticComplexity
+  def to_regexp
+    chars = @glob_string.gsub(%r{(\*\*\/\*)|(\*\*)}, '*').split('')
+    in_curlies = 0, escaping = false
+    chars.map do |char|
+      if escaping
+        escaping = false
+        return char
+      end
+      case char
+      when '*'
+        '.*'
+      when '?'
+        '.'
+      when '.'
+        '\\.'
+      when '{'
+        in_curlies += 1
+        '('
+      when '}'
+        if in_curlies.positive?
+          in_curlies -= 1
+          return ')'
+        end
+        return char
+      when ','
+        in_curlies.positive? ? '|' : char
+      when '\\'
+        escaping = true
+        '\\'
+      else
+        char
+      end
+    end.join
+  end
+  # rubocop:enable Metrics/CyclomaticComplexity
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pdd
 version: !ruby/object:Gem::Version
-  version: 0.20.6
+  version: 0.21.0
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-01 00:00:00.000000000 Z
+date: 2022-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: ruby-filemagic
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.7.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.7.2
 - !ruby/object:Gem::Dependency
   name: slop
   requirement: !ruby/object:Gem::Requirement
@@ -178,6 +192,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.15.1
+- !ruby/object:Gem::Dependency
+  name: slop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 4.9.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 4.9.1
 - !ruby/object:Gem::Dependency
   name: xcop
   requirement: !ruby/object:Gem::Requirement
@@ -205,17 +233,18 @@ files:
 - ".gitattributes"
 - ".github/ISSUE_TEMPLATE.md"
 - ".github/PULL_REQUEST_TEMPLATE.md"
+- ".github/workflows/codecov.yml"
+- ".github/workflows/rake.yml"
 - ".gitignore"
+- ".overcommit.yml"
 - ".pdd"
 - ".rubocop.yml"
 - ".rultor.yml"
 - ".simplecov"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- appveyor.yml
 - assets/puzzles.xsd
 - assets/puzzles.xsl
 - bin/pdd
@@ -258,7 +287,8 @@ files:
 - test_assets/cambria.woff
 - test_assets/elegant-objects.png
 - test_assets/favicon.ico
-homepage: http://github.com/yegor256/pdd
+- utils/glob.rb
+homepage: http://github.com/cqfn/pdd
 licenses:
 - MIT
 metadata: {}
@@ -269,7 +299,7 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
       version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
@@ -278,7 +308,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 2
 summary: Puzzle Driven Development collector