pcp-server-ruby-sdk 1.2.0 → 1.3.1

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pcp-serversdk-ruby",
-  "version": "1.2.0",
+  "version": "1.3.1",
   "type": "commonjs",
   "scripts": {
     "changelog": "conventional-changelog -i CHANGELOG.md -s --config ./changelog.config.js"

data/spec/communicator_configuration_spec.rb

@@ -19,5 +19,32 @@ RSpec.describe PCPServerSDK::CommunicatorConfiguration do
     it 'sets host' do
       expect(config.host).to eq(host)
     end
+
+    it 'sets http_client to nil by default' do
+      expect(config.http_client).to be_nil
+    end
+
+    context 'with custom http_client' do
+      let(:custom_http_client) { Net::HTTP.new('example.com', 80) }
+      let(:config_with_client) { PCPServerSDK::CommunicatorConfiguration.new(api_key, api_secret, host, custom_http_client) }
+
+      it 'sets the custom http_client' do
+        expect(config_with_client.http_client).to eq(custom_http_client)
+      end
+    end
+  end
+
+  describe '#http_client=' do
+    it 'allows setting http_client after initialization' do
+      custom_client = Net::HTTP.new('example.com', 80)
+      config.http_client = custom_client
+      expect(config.http_client).to eq(custom_client)
+    end
+
+    it 'allows setting http_client to a proc' do
+      client_factory = proc { |uri| Net::HTTP.new(uri.host, uri.port) }
+      config.http_client = client_factory
+      expect(config.http_client).to eq(client_factory)
+    end
   end
 end

data/spec/endpoints/authentication_api_client_spec.rb

@@ -0,0 +1,78 @@
+
+
+require 'spec_helper'
+require 'net/http'
+require 'json'
+require_relative '../../lib/PCP-server-Ruby-SDK.rb'
+
+
+RSpec.describe PCPServerSDK::Endpoints::AuthenticationApiClient do
+  let(:config) { mock_communicator_config }
+  let(:client) { PCPServerSDK::Endpoints::AuthenticationApiClient.new(config) }
+
+  describe '#get_authentication_tokens' do
+    let(:merchant_id) { 'merchant123' }
+    let(:request_id) { 'req-456' }
+    let(:success_response_body) {
+      {
+        token: 'jwt-token',
+        id: 'uuid-123',
+        creationDate: '2025-07-10T12:00:00Z',
+        expirationDate: '2025-07-10T12:10:00Z'
+      }.to_json
+    }
+    let(:error_body) {
+      PCPServerSDK::Models::ErrorResponse.new(
+        error_id: '1',
+        errors: [PCPServerSDK::Models::APIError.new(error_code: '1', message: 'Error 1')]
+      ).to_body.to_json
+    }
+
+    context 'when request is successful' do
+      let(:response) { double('Response', body: success_response_body, code: 200) }
+
+      before do
+        allow(client).to receive(:get_response).and_return(response)
+      end
+
+      it 'returns an AuthenticationToken' do
+        token = client.get_authentication_tokens(merchant_id, request_id)
+        expect(token).to be_a(PCPServerSDK::Models::AuthenticationToken)
+        expect(token.token).to eq('jwt-token')
+        expect(token.id).to eq('uuid-123')
+        expect(token.creation_date).to be_a(Time)
+        expect(token.expiration_date).to be_a(Time)
+      end
+    end
+
+    context 'when request is unsuccessful (400)' do
+      let(:response) { double('Response', body: error_body, code: 400) }
+
+      before do
+        allow(client).to receive(:get_response).and_return(response)
+      end
+
+      it 'raises an PCPServerSDK::Errors::ApiErrorResponseException' do
+        expect { client.get_authentication_tokens(merchant_id, request_id) }.to raise_error(PCPServerSDK::Errors::ApiErrorResponseException)
+      end
+    end
+
+    context 'when request is unsuccessful (500)' do
+      let(:response) { double('Response', body: '{}', code: 500) }
+
+      before do
+        allow(client).to receive(:get_response).and_return(response)
+      end
+
+      it 'raises an PCPServerSDK::Errors::ApiResponseRetrievalException' do
+        expect { client.get_authentication_tokens(merchant_id, request_id) }.to raise_error(PCPServerSDK::Errors::ApiResponseRetrievalException)
+      end
+    end
+
+    context 'when merchant_id is nil' do
+      it 'raises an ArgumentError' do
+        expect { client.get_authentication_tokens(nil, '2') }.to raise_error(TypeError, 'Merchant ID is required')
+      end
+    end
+  end
+end

data/spec/endpoints/base_api_client_spec.rb

@@ -0,0 +1,222 @@
+require 'spec_helper'
+require_relative '../../lib/PCP-server-Ruby-SDK.rb'
+
+RSpec.describe PCPServerSDK::Endpoints::BaseApiClient do
+  let(:api_key) { 'test_api_key' }
+  let(:api_secret) { 'test_api_secret' }
+  let(:host) { 'https://api.example.com' }
+  let(:config) { PCPServerSDK::CommunicatorConfiguration.new(api_key, api_secret, host) }
+  let(:client) { PCPServerSDK::Endpoints::BaseApiClient.new(config) }
+
+  describe '#initialize' do
+    it 'sets the config' do
+      expect(client.send(:get_config)).to eq(config)
+    end
+
+    it 'sets http_client to nil by default' do
+      expect(client.http_client).to be_nil
+    end
+
+    context 'with custom http_client' do
+      let(:custom_http_client) { Net::HTTP.new('example.com', 80) }
+      let(:client_with_custom) { PCPServerSDK::Endpoints::BaseApiClient.new(config, custom_http_client) }
+
+      it 'sets the custom http_client' do
+        expect(client_with_custom.http_client).to eq(custom_http_client)
+      end
+    end
+  end
+
+  describe '#http_client=' do
+    it 'allows setting http_client after initialization' do
+      custom_client = Net::HTTP.new('example.com', 80)
+      client.http_client = custom_client
+      expect(client.http_client).to eq(custom_client)
+    end
+  end
+
+  describe '#get_http_client (private method)' do
+    let(:uri) { URI.parse('https://api.example.com/test') }
+
+    context 'with client-specific http_client' do
+      let(:client_specific_http) { Net::HTTP.new('client.example.com', 443) }
+
+      before do
+        client.http_client = client_specific_http
+      end
+
+      it 'returns the client-specific http client' do
+        result = client.send(:get_http_client, uri)
+        expect(result).to eq(client_specific_http)
+      end
+
+      it 'prioritizes client-specific over global configuration' do
+        global_http = Net::HTTP.new('global.example.com', 443)
+        config.http_client = global_http
+        
+        result = client.send(:get_http_client, uri)
+        expect(result).to eq(client_specific_http)
+      end
+    end
+
+    context 'with global http_client in configuration' do
+      let(:global_http) { Net::HTTP.new('global.example.com', 443) }
+
+      before do
+        config.http_client = global_http
+      end
+
+      it 'returns the global http client when no client-specific client is set' do
+        result = client.send(:get_http_client, uri)
+        expect(result).to eq(global_http)
+      end
+    end
+
+    context 'with proc-based http_client factory' do
+      let(:http_factory) do
+        proc do |uri|
+          http = Net::HTTP.new(uri.host, uri.port)
+          http.use_ssl = uri.scheme == 'https'
+          http.read_timeout = 30
+          http
+        end
+      end
+
+      before do
+        client.http_client = http_factory
+      end
+
+      it 'calls the proc with the URI and returns the result' do
+        result = client.send(:get_http_client, uri)
+        expect(result).to be_a(Net::HTTP)
+        expect(result.address).to eq('api.example.com')
+        expect(result.port).to eq(443)
+        expect(result.use_ssl?).to be true
+        expect(result.read_timeout).to eq(30)
+      end
+    end
+
+    context 'with callable object as http_client factory' do
+      let(:http_factory) do
+        Class.new do
+          def call(uri)
+            http = Net::HTTP.new(uri.host, uri.port)
+            http.use_ssl = uri.scheme == 'https'
+            http.open_timeout = 10
+            http
+          end
+        end.new
+      end
+
+      before do
+        config.http_client = http_factory
+      end
+
+      it 'calls the callable object with the URI and returns the result' do
+        result = client.send(:get_http_client, uri)
+        expect(result).to be_a(Net::HTTP)
+        expect(result.address).to eq('api.example.com')
+        expect(result.port).to eq(443)
+        expect(result.use_ssl?).to be true
+        expect(result.open_timeout).to eq(10)
+      end
+    end
+
+    context 'with default http_client (no customization)' do
+      it 'creates a default Net::HTTP client' do
+        result = client.send(:get_http_client, uri)
+        expect(result).to be_a(Net::HTTP)
+        expect(result.address).to eq('api.example.com')
+        expect(result.port).to eq(443)
+        expect(result.use_ssl?).to be true
+      end
+    end
+
+    context 'with invalid http_client' do
+      before do
+        client.http_client = "invalid_client"
+      end
+
+      it 'raises an ArgumentError' do
+        expect {
+          client.send(:get_http_client, uri)
+        }.to raise_error(ArgumentError, /HTTP client must be a Net::HTTP instance, Proc, or respond to :call/)
+      end
+    end
+  end
+
+  describe '#resolve_http_client (private method)' do
+    let(:uri) { URI.parse('https://api.example.com/test') }
+
+    context 'with Net::HTTP instance' do
+      let(:http_instance) { Net::HTTP.new('example.com', 80) }
+
+      it 'returns the instance directly' do
+        result = client.send(:resolve_http_client, http_instance, uri)
+        expect(result).to eq(http_instance)
+      end
+    end
+
+    context 'with Proc' do
+      let(:http_proc) { proc { |uri| Net::HTTP.new(uri.host, uri.port) } }
+
+      it 'calls the proc with the URI' do
+        result = client.send(:resolve_http_client, http_proc, uri)
+        expect(result).to be_a(Net::HTTP)
+        expect(result.address).to eq('api.example.com')
+        expect(result.port).to eq(443)
+      end
+    end
+
+    context 'with callable object' do
+      let(:callable) do
+        Class.new do
+          def call(uri)
+            Net::HTTP.new(uri.host, uri.port)
+          end
+        end.new
+      end
+
+      it 'calls the object with the URI' do
+        result = client.send(:resolve_http_client, callable, uri)
+        expect(result).to be_a(Net::HTTP)
+        expect(result.address).to eq('api.example.com')
+        expect(result.port).to eq(443)
+      end
+    end
+
+    context 'with invalid object' do
+      it 'raises an ArgumentError' do
+        expect {
+          client.send(:resolve_http_client, "invalid", uri)
+        }.to raise_error(ArgumentError, /HTTP client must be a Net::HTTP instance, Proc, or respond to :call/)
+      end
+    end
+  end
+
+  describe '#create_default_http_client (private method)' do
+    context 'with HTTPS URI' do
+      let(:uri) { URI.parse('https://api.example.com/test') }
+
+      it 'creates an HTTPS-enabled client' do
+        result = client.send(:create_default_http_client, uri)
+        expect(result).to be_a(Net::HTTP)
+        expect(result.address).to eq('api.example.com')
+        expect(result.port).to eq(443)
+        expect(result.use_ssl?).to be true
+      end
+    end
+
+    context 'with HTTP URI' do
+      let(:uri) { URI.parse('http://api.example.com/test') }
+
+      it 'creates an HTTP client' do
+        result = client.send(:create_default_http_client, uri)
+        expect(result).to be_a(Net::HTTP)
+        expect(result.address).to eq('api.example.com')
+        expect(result.port).to eq(80)
+        expect(result.use_ssl?).to be false
+      end
+    end
+  end
+end

data/spec/endpoints/checkout_api_client_spec.rb

@@ -5,7 +5,7 @@ require_relative '../../lib/PCP-server-Ruby-SDK.rb'
 
 
 RSpec.describe PCPServerSDK::Endpoints::CheckoutApiClient do
-  let(:config) { double("PCPServerSDK::CommunicatorConfiguration", api_key: "", api_secret: "", host: 'https://api.example.com') }
+  let(:config) { mock_communicator_config }
   let(:client) { described_class.new(config) }
   let(:error_body) { PCPServerSDK::Models::ErrorResponse.new(
     error_id: '1',

data/spec/endpoints/commerce_case_api_client_spec.rb

@@ -5,7 +5,7 @@ require_relative '../../lib/PCP-server-Ruby-SDK.rb'
 
 
 RSpec.describe PCPServerSDK::Endpoints::CommerceCaseApiClient do
-  let(:config) { double("PCPServerSDK::CommunicatorConfiguration", api_key: "", api_secret: "", host: 'https://api.example.com') }
+  let(:config) { mock_communicator_config }
   let(:client) { described_class.new(config) }
   let(:error_body) {
     PCPServerSDK::Models::ErrorResponse.new(

data/spec/endpoints/order_management_checkout_actions_api_client_spec.rb

@@ -5,7 +5,7 @@ require_relative '../../lib/PCP-server-Ruby-SDK.rb'
 
 
 RSpec.describe PCPServerSDK::Endpoints::OrderManagementCheckoutActionsApiClient do
-  let(:config) { double("PCPServerSDK::CommunicatorConfiguration", api_key: "", api_secret: "", host: 'https://api.example.com') }
+  let(:config) { mock_communicator_config }
   let(:client) { described_class.new(config) }
   let(:error_body) {
     PCPServerSDK::Models::ErrorResponse.new(

data/spec/endpoints/payment_execution_api_client_spec.rb

@@ -5,7 +5,7 @@ require_relative '../../lib/PCP-server-Ruby-SDK.rb'
 
 
 RSpec.describe PCPServerSDK::Endpoints::PaymentExecutionApiClient do
-  let(:config) { double("PCPServerSDK::CommunicatorConfiguration", api_key: "", api_secret: "", host: 'https://api.example.com') }
+  let(:config) { mock_communicator_config }
   let(:client) { described_class.new(config) }
   let(:error_body) {
     PCPServerSDK::Models::ErrorResponse.new(

data/spec/endpoints/payment_information_api_client_spec.rb

@@ -5,7 +5,7 @@ require_relative '../../lib/PCP-server-Ruby-SDK.rb'
 
 
 RSpec.describe PCPServerSDK::Endpoints::PaymentInformationApiClient do
-  let(:config) { double("PCPServerSDK::CommunicatorConfiguration", api_key: "", api_secret: "", host: 'https://api.example.com') }
+  let(:config) { mock_communicator_config }
   let(:client) { described_class.new(config) }
   let(:error_body) {
     PCPServerSDK::Models::ErrorResponse.new(

data/spec/spec_helper.rb

@@ -25,4 +25,13 @@ RSpec.configure do |config|
   end
 end
 
+# Helper method to create properly mocked CommunicatorConfiguration
+def mock_communicator_config(api_key: '', api_secret: '', host: 'https://api.example.com', http_client: nil)
+  double('PCPServerSDK::CommunicatorConfiguration',
+         api_key: api_key,
+         api_secret: api_secret,
+         host: host,
+         http_client: http_client)
+end
+
 require 'rspec'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pcp-server-ruby-sdk
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.1
 platform: ruby
 authors:
 - PAYONE GmbH
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-05-26 00:00:00.000000000 Z
+date: 2025-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-http
@@ -102,6 +102,7 @@ files:
 - lefthook.yml
 - lib/PCP-server-Ruby-SDK.rb
 - lib/PCP-server-Ruby-SDK/communicator_configuration.rb
+- lib/PCP-server-Ruby-SDK/endpoints/authentication_api_client.rb
 - lib/PCP-server-Ruby-SDK/endpoints/base_api_client.rb
 - lib/PCP-server-Ruby-SDK/endpoints/checkout_api_client.rb
 - lib/PCP-server-Ruby-SDK/endpoints/commerce_case_api_client.rb
@@ -127,6 +128,7 @@ files:
 - lib/PCP-server-Ruby-SDK/models/applepay/apple_pay_payment_method.rb
 - lib/PCP-server-Ruby-SDK/models/applepay/apple_pay_payment_method_type.rb
 - lib/PCP-server-Ruby-SDK/models/applepay/apple_pay_payment_token.rb
+- lib/PCP-server-Ruby-SDK/models/authentication_token.rb
 - lib/PCP-server-Ruby-SDK/models/authorization_mode.rb
 - lib/PCP-server-Ruby-SDK/models/avs_result.rb
 - lib/PCP-server-Ruby-SDK/models/bank_account_information.rb
@@ -278,6 +280,8 @@ files:
 - scripts.sh
 - sonar-project.properties
 - spec/communicator_configuration_spec.rb
+- spec/endpoints/authentication_api_client_spec.rb
+- spec/endpoints/base_api_client_spec.rb
 - spec/endpoints/checkout_api_client_spec.rb
 - spec/endpoints/commerce_case_api_client_spec.rb
 - spec/endpoints/order_management_checkout_actions_api_client_spec.rb
@@ -315,4 +319,21 @@ rubygems_version: 3.4.20
 signing_key:
 specification_version: 4
 summary: Commerce Platform API Ruby Gem
-test_files: []
+test_files:
+- spec/communicator_configuration_spec.rb
+- spec/endpoints/authentication_api_client_spec.rb
+- spec/endpoints/commerce_case_api_client_spec.rb
+- spec/endpoints/payment_execution_api_client_spec.rb
+- spec/endpoints/checkout_api_client_spec.rb
+- spec/endpoints/payment_information_api_client_spec.rb
+- spec/endpoints/base_api_client_spec.rb
+- spec/endpoints/order_management_checkout_actions_api_client_spec.rb
+- spec/errors/api_error_response_exception_spec.rb
+- spec/errors/api_exception_spec.rb
+- spec/errors/api_response_retrieval_exception_spec.rb
+- spec/queries/get_checkouts_query_spec.rb
+- spec/queries/get_commerce_cases_query_spec.rb
+- spec/request_header_generator_spec.rb
+- spec/spec_helper.rb
+- spec/transformer/apple_pay_transformer_spec.rb
+- spec/utils/server_meta_info_spec.rb