pcbr 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 94c525ae292660782aa466569e23c274024e1220
-  data.tar.gz: 409faba010ccd426ad3f5cab17aa0f9470f680b7
+  metadata.gz: fb643a049750bf248970b7a81eb17a681421213d
+  data.tar.gz: d209e1311d679f5615746ea03fadc94207b40a7e
 SHA512:
-  metadata.gz: 4caa489706874b4ff8bf10d9a535485f083b5e8566d5ee97317541fc3d3f2193ffd8e557e23f50140482d0fa3200e9d5557cc7ec2719e11d5f683a8be01f77e7
-  data.tar.gz: 6390f836a93fc357aa7c184d6df9fbf1ac007077ebb4fc08d0312600798407abbd9136cb3d98da8ddcf5f506852e62dd85d531f33a1ac27e4358f5484f199a7e
+  metadata.gz: 6cdbb2fb68bbf2a0572a3cd71cd9b537819308e49df987d701923d17c584828dabd99726b3ed4d13bf7813d8874061b290e6a6a2446136df94be3b43d410a035
+  data.tar.gz: 0a47d2434ddc995fa20e72c36fd05ed5abf3bb5a43f2d758b205c692df9c3f92ad8f5ea675d3b982c8d5716f6ddd8decb857c7490bb93a777d93bfa6ade24133

data/lib/pcbr.rb

@@ -9,36 +9,30 @@ module PCBR
     Storage.new &block
   end
 
-  ARRAY_101 = [0, 0, 0]
   class Storage
     attr_reader :table
 
     def initialize &block
       @table = []
       @callback = block || lambda{ |a_, b_|
-        ARRAY_101.dup.tap do |array|
-          [*a_].zip([*b_]) do |a, b|
-            t = a <=> b and array[t] = t
-          end
-        end.inject :+
+        raise Error.new "comparison vectors are of the different length" unless a_.size == b_.size
+        tt = [0, 0, 0]
+        [*a_].zip([*b_]) do |a, b|
+          t = a <=> b and tt[t] = t
+        end
+        tt[0] + tt[1] + tt[2]
       }
     end
 
     def store key, vector = nil
       raise Error.new "duplicating key" if @table.assoc key
       key = [NilClass, FalseClass, TrueClass, Numeric, Symbol, Method].any?{ |c| key.is_a? c } ? key : key.dup
-      vector = if vector.nil?
-        Array key
-      else
-        vector
-      end
+      vector = Array key if vector.nil?
       score = 0
       @table.each do |item|
-        # TODO test of this exception
-        raise Error.new "comparison vectors are of the different length" unless vector.size == item[1].size
         point = @callback.call vector, item[1]
-        score += point
         item[2] -= point
+        score += point
       end
       @table.push [key, vector, score]
     end

data/pcbr.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "pcbr"
-  spec.version       = "0.4.0"
+  spec.version       = "0.4.1"
   spec.summary       = "Pair Comparison Based Rating"
 
   spec.author        = "Victor Maslov"

data/spec/_spec.rb

@@ -13,6 +13,12 @@ describe "basic specs" do
     expect(rating.sorted).to eq([2, 1])
   end
 
+  example "raises if vectors are of the different length" do
+    rating = PCBR.new
+    rating.store 1, [2]
+    expect{ rating.store 3, [4, 5] }.to raise_error PCBR::Error
+  end
+
   # example "#size" do
   #   rating = PCBR.new
   #   rating.store 1
@@ -43,6 +49,20 @@ describe "basic specs" do
     expect(n).to eq(6)
   end
 
+  example "the vector is not neccessary an Array" do
+    rating = PCBR.new do |a, b|
+      a <=> b
+    end
+    0.class.class_eval do
+      def size
+        fail
+      end
+    end
+    rating.store 1, 2
+    rating.store 2, 1
+    expect(rating.sorted).to eq([1, 2])
+  end
+
   example "#sorted and #score[key]" do
     rating = PCBR.new
     table = [

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pcbr
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Victor Maslov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-25 00:00:00.000000000 Z
+date: 2018-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler