pcbr 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2871f614f5c3e9fdf49297ebca1fc97e148eb3e3
-  data.tar.gz: 162ccfbbcaebf10c1e3a762f68ffcbc0b326888d
+  metadata.gz: 2ce39501eee28e4881d896c138a0049899912b8a
+  data.tar.gz: 68060e95d3921de4b105fd48227fc776d93ff744
 SHA512:
-  metadata.gz: 2f24b3e3e90bbde660ecd8c810e17f31cc949eefdb12b9d2b4a88746b9916023f16b6e379bc4f9fe9e7206b6741cdc4d489b07b6d768bb2ad7303973004867c7
-  data.tar.gz: 1702bac320df836e08bb1fef10195fa00b97ccd01a15b795cd8e082f6005c1c8f04233c9891eab78e4b392937fce1c4c73542de90e5f5812b9b4650899080d60
+  metadata.gz: b7c3edd47fd4012722dffd750833187b5951943543aca19b3b507409f787f5ec60ea1e08adb337967770a9d4494ec8e0cc7d18337a0ae68230f0b42f226101be
+  data.tar.gz: 93051d2392065a23d4cb2918c79771e11cb08a1c6df7a13489f6bc58fe2284beb5410b850eec86251f94eed3f28e015664c3bf9d93ea1e073965fcafd160003a

data/README.md

@@ -12,7 +12,9 @@ The first idea of rating items by one-to-one comparison was about QuakeLive play
 
 TODO: describe/illustrate algorithm?
 
-At the moment it's a "proof of concept" -- it needs huge optimisations for lookups, maybe using trees.
+~~At the moment it's a "proof of concept" -- it needs huge optimisations for lookups, maybe using trees.~~
+
+It worked fine in production for a project with huge computations where you can't find the best solution but have to find anything good in adequate time. Traversing the tree using this with a vector of `[leaf's quality, depth]` made things better than depth-first search with lots of ueristics.
 
 ### Installation
 

data/lib/pcbr.rb

@@ -1,47 +1,69 @@
-class PCBR
+require "deep_dup"
 
-  VERSION = "0.2.0"
+module PCBR
+  VERSION = "0.3.0"
 
-  attr_reader :table
+  class Error < RuntimeError
+    # def initialize body
+    #   super "#{Module.nesting[1]} error: #{body}"
+    # end
+  end
 
-  ARRAY_101 = [0, 0, 0]
-  def initialize &block
-    @table = []
-    @callback = block || ( lambda do |a_, b_|
-      array = ARRAY_101.dup
-      [*a_].zip([*b_]) do |a, b|
-        next unless t = a <=> b
-        array[t] = t
-      end
-      array.inject :+
-    end )
+  def self.new &block
+    Storage.new &block
   end
 
-  # def size
-  #   @table.size
-  # end
+  ARRAY_101 = [0, 0, 0]
+  class Storage
+    attr_reader :table
 
-  def store key, *vector
-    vector = vector.empty? ? key : vector.first
-    score = 0
-    @table.each do |item|
-      fail unless [*vector].size == [*item[1]].size
+    def initialize &block
+      @table = []
+      @callback = block || lambda{ |a_, b_|
+        ARRAY_101.dup.tap do |array|
+          [*a_].zip([*b_]) do |a, b|
+            t = a <=> b and array[t] = t
+          end
+        end.inject :+
+      }
+    end
 
-      point = @callback.call vector, item[1]
+    def store key, vector = nil
+      raise Error.new "duplicating key" if @table.assoc key
+      key = DeepDup.deep_dup key
+      vector = if vector
+        DeepDup.deep_dup vector
+      else
+        Array key
+      end
+      score = 0
+      @table.each do |item|
+        # TODO test of this exception
+        raise Error.new "comparison vectors are of the different length" unless vector.size == item[1].size
+        point = @callback.call vector, item[1]
+        score += point
+        item[2] -= point
+      end
+      @table.push [key, vector, score]
+    end
 
-      score += point
-      item[2] -= point
+    def score key
+      @table.assoc(key)[2]
     end
-    @table.push [key, vector, score]
-  end
 
-  def score key
-    @table.assoc(key)[2]
-  end
+    def sorted
+      # from the best to the worst
+      @table.sort_by.with_index{ |item, i| [-item[2], i] }.map(&:first)
+    end
 
-  def sorted
-    # from the best to the worst
-    @table.sort_by.with_index{ |item, i| [-item[2], i] }.map(&:first)
-  end
+    # def quality
+    #   factorial = ->x{ (1..x).inject(:*) }
+    #   (2...@table.size).each do |sublength|
+    #     combinations = factorial[@table.size] / factorial[sublength] / factorial[@table.size - sublength]
+    #     comparisons = sublength * (sublength - 1) / 2
+    #     p [sublength, combinations, comparisons, combinations * comparisons]
+    #   end
+    # end
 
+  end
 end

data/pcbr.gemspec

@@ -11,7 +11,9 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0")
   spec.test_files    = ["spec/"]
 
-  spec.add_development_dependency "bundler", "~> 1.12.0"
+  spec.add_dependency "deep_dup"
+
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rspec", "~> 3.3.0"
 
   spec.required_ruby_version = ">= 2.0.0"

data/spec/_spec.rb

@@ -13,12 +13,12 @@ describe "basic specs" do
     expect(rating.sorted).to eq([2, 1])
   end
 
-  example "#size", skip: :deprecated do
-    rating = PCBR.new
-    rating.store 1
-    rating.store 2
-    expect(rating.size).to eq(2)
-  end
+  # example "#size" do
+  #   rating = PCBR.new
+  #   rating.store 1
+  #   rating.store 2
+  #   expect(rating.size).to eq(2)
+  # end
 
   example "Nil elements in vector are ignored" do
     rating = PCBR.new
@@ -63,6 +63,38 @@ describe "basic specs" do
     expect(rating.table).to eq(table)
   end
 
+  # example "quality estimation" do
+  #   rating = PCBR.new
+  #   table = [
+  #     [1, [1, 1]],
+  #     [2, [2, 2]],
+  #     [3, [0, 0]],
+  #     [4, [1, 2]],
+  #     [6, [1, 1]],
+  #     [5, [0, 2]],
+  #   ].each do |key, vector, |
+  #     rating.store key, vector
+  #   end
+  # end
+
+  example "duplicating keys are forbidden" do
+    rating = PCBR.new
+    rating.store 0
+    expect{ rating.store 0 }.to raise_error PCBR::Error
+  end
+
+  example "keys and vectors are dupped" do
+    rating = PCBR.new
+    a = [[1]]
+    v = [0]
+    rating.store a, v
+    a[0][0] = 2
+    rating.store [[2]], [1]   # expect no PCBR::Error
+    v[0] = 3
+    rating.store [[3]], [2]
+    expect(rating.sorted).to eq [[[3]], [[2]], [[1]]]
+  end
+
 end
 
 

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: pcbr
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Victor Maslov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-07 00:00:00.000000000 Z
+date: 2017-12-06 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: deep_dup
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement