pcbr 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e17564130abbbb6ebddcf3a3302c5d1ab617f8a0
-  data.tar.gz: 6ba30f3821a168a951938aaf6d31671a1b632076
+  metadata.gz: 0ffebfcba7efed840c175df7f5bbc937193421a9
+  data.tar.gz: acee6ef464ff5ea9a4cbb2c09eb0786c11616b58
 SHA512:
-  metadata.gz: ce0bfae1f4db6f52806437cf2821b1e5325e6557de69e119829361c1f354eef205877a7f2a83fa220a31e4bbf777beae8db327f8304defd517d9415a22f7fc3b
-  data.tar.gz: 259c292b880fa28991baaa4359f3331b8e8683d61656eee4549ee12d62a65612433e936eadf512c1db4d844e0192508812e84f98a7ccda1fefc505d554a74fad
+  metadata.gz: 939b2a03b5c31a7ab328b5e06a17400d5b7e04b84aa5bba88c81943fa9bd4370122352975131e19a794a1e1052abe7c02688d340846dc42067361eefb24dc016
+  data.tar.gz: 32e71d883437a73ee6e3d5d9f7695b173a3024289e42892c2f020583d971e0a8b87d4ef8a48ca5a44b3f385e996c2d4bdd2a82085df30d73124183e3e586a07b

data/lib/pcbr.rb

@@ -1,6 +1,6 @@
 class PCBR
 
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 
   attr_reader :table
 
@@ -15,23 +15,24 @@ class PCBR
 
   def store key, *vector
     vector = vector.empty? ? [key] : vector.first
+    calculated = @callback[vector, key]
     score = @table.map do |item|
-      @callback[vector, key].zip(@callback[item[1], item[0]]).map do |a, b|
+      calculated.zip(item[3]).map do |a, b|
         a <=> b
       end.uniq.inject(0, :+).tap do |point|
         item[2] -= point
       end
     end.inject 0, :+
-    @table.push [key, vector, score]
+    @table.push [key, vector, score, calculated]
   end
 
   def score key
-    @table.assoc(key).last
+    @table.assoc(key)[-2]
   end
 
   def sorted
     # from the best to the worst
-    @table.sort_by.with_index{ |item, i| [-item.last, i] }.map(&:first)
+    @table.sort_by.with_index{ |item, i| [-item[2], i] }.map(&:first)
   end
 
 end

data/spec/_spec.rb

@@ -1,52 +1,61 @@
 require_relative "../lib/pcbr"
 
+
+require "pp"
+
+
 describe "basic specs" do
 
-  example "#size", skip: :deprecated do
+  example "scalar key without vector and without &block" do
     rating = PCBR.new
     rating.store 1
     rating.store 2
-    expect(rating.size).to eq(2)
+    expect(rating.sorted).to eq([2, 1])
   end
 
-  example "order and methods: #score[key], #sorted, #data" do
+  example "#size", skip: :deprecated do
     rating = PCBR.new
-    table = [
-      [1, [1, 1], -1],
-      [2, [2, 2],  5],
-      [3, [0, 0], -5],
-      [4, [1, 2],  3],
-      [6, [1, 1], -1],
-      [5, [0, 2], -1],
-    ].each do |key, vector, |
-      rating.store key, vector
-    end
-    expect(rating.sorted).to eq([2, 4, 1, 6, 5, 3])
-    expect(rating.table.map(&:last).inject(:+)).to be_zero
-    table.each do |key, _, score|
-      expect(rating.score(key)).to eq(score)
-    end
-    expect(rating.table ).to eq(table)
+    rating.store 1
+    rating.store 2
+    expect(rating.size).to eq(2)
   end
 
   example "&block" do
+    n = 0
     rating = PCBR.new do |item|
+      n += 1
       [item[:goodness], -item[:badness]]
     end
+    rating.store 3, {goodness: 0, badness: 2}
     rating.store 2, {goodness: 1, badness: 2}
     rating.store 1, {goodness: 1, badness: 1}
-    expect(rating.sorted).to eq([1, 2])
+    expect(rating.sorted).to eq([1, 2, 3])
+    expect(n).to eq(3)
   end
 
-  example "scalar key without vector and without &block" do
+  example "#sorted and #score[key]" do
     rating = PCBR.new
-    rating.store 1
-    rating.store 2
-    expect(rating.sorted).to eq([2, 1])
+    table = [
+      [1, [1, 1], -1, [1, 1]],
+      [2, [2, 2],  5, [2, 2]],
+      [3, [0, 0], -5, [0, 0]],
+      [4, [1, 2],  3, [1, 2]],
+      [6, [1, 1], -1, [1, 1]],
+      [5, [0, 2], -1, [0, 2]],
+    ].each do |key, vector, |
+      rating.store key, vector
+    end
+    expect(rating.sorted).to eq([2, 4, 1, 6, 5, 3])
+    expect(rating.table.map{ |i| i[2] }.inject(:+)).to be_zero
+    table.each do |key, _, score|
+      expect(rating.score(key)).to eq(score)
+    end
+    expect(rating.table).to eq(table)
   end
 
 end
 
+
 describe "examples" do
 
   example "github repos" do
@@ -72,13 +81,13 @@ describe "examples" do
       # Ruby Version Manager
       "RVM: rbenv/rbenv" => {issue: 24, pr: 12, watch: 301, star: 8257, fork: 769},
       "RVM: rvm/rvm" => {issue: 160, pr: 5, watch: 154, star: 3328, fork: 793},
-      # DevOps Tools
+      # DevOps Tool
       "DOT: ansible/ansible" => {issue: 1074, pr: 322, watch: 1339, star: 16926, fork: 5075},
       "DOT: chef/chef" => {issue: 422, pr: 52, watch: 387, star: 4265, fork: 1774},
       "DOT: capistrano/capistrano" => {issue: 38, pr: 6, watch: 339, star: 8392, fork: 1365},
     }
 
-    store_repos_to_rating = lambda do |rating|
+    push_repos = lambda do |rating|
       repos.each do |repo_name, repo_stats|
         rating.store repo_name, repo_stats
       end
@@ -87,17 +96,17 @@ describe "examples" do
     contribution_intensivity_rating = PCBR.new do |repo_stats| [
       repo_stats[:pr],
       -repo_stats[:fork],
-    ] end.tap &store_repos_to_rating
+    ] end.tap &push_repos
 
     quality_rating = PCBR.new do |repo_stats| [
       repo_stats[:star],
       -repo_stats[:issue],
-    ] end.tap &store_repos_to_rating
+    ] end.tap &push_repos
 
     resulting_rating = PCBR.new do |_, repo_name| [
       contribution_intensivity_rating.score(repo_name),
       quality_rating.score(repo_name),
-    ] end.tap &store_repos_to_rating
+    ] end.tap &push_repos
 
     aggregate_failures do
       expect(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pcbr
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Victor Maslov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-22 00:00:00.000000000 Z
+date: 2016-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -72,7 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: Pair Comparison Based Rating