pbbuilder 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe95820bf0015825b24715abe48a568f865affb04ec6c3db6261f33cd3e19829
-  data.tar.gz: 0de697e6e0970a49cf599cb764e1941e019b1b6e0dddcc86c862c070a34ec904
+  metadata.gz: 75cb2682f8933e0e8acb2b3bb6a525df5447dab8a65b2d8509f54a3c2b430c35
+  data.tar.gz: '0282cfeb404460224fd8cb2d32d134335b9d307d2edefc4af854368b9c8788e1'
 SHA512:
-  metadata.gz: fa06d08bee0e966095491d7b1d0956ff5c0f9a5d305fe66308c98883ddbe3c424d60b62ebf846fe25d2e7ec86181baf0666ec0d638648117188d1b17e3185784
-  data.tar.gz: dac52c94458493380247cba47db06e61ad29590ff8b09b51abbe870aca8381f553870c16604b8079653488c0acc76fa87bfa54cb6a652e3c9fd0538e09ed85d8
+  metadata.gz: d429891ca19333b9e626ccd9bf63462fbe61eea672c8ac14f427aafdc392a2f12e36370e63f1a4522c384b4375e81433d63d804f447d508346744aedca448fbf
+  data.tar.gz: 1af6634160780c84f93a99d9b6b282e90500da24d654bfa36f1220b48260bec074412da69f83267a2df8f935e33218b332a27cf102765e6eff7b3db853ec686e

data/README.md

@@ -4,6 +4,11 @@ PBBuilder generates [Protobuf](https://developers.google.com/protocol-buffers) M
 
 At least Rails 6.1 is required.
 
+> [!WARNING]  
+> There currently is a regression in ActionView (the part of Rails which renders) that forces rendered objects into strings. This is only present
+> in Rails 7.1, and is fixed in Rails. However, a 7.1 gem containing the fix hasn't been released yet. For the moment you should refrain
+> from using pbbuilder and rails-twirp with Rails 7.1 and wait for the next version to be released.
+
 ## Compatibility with jBuilder
 We don't aim to have 100% compitability and coverage with jbuilder gem, but we closely follow jbuilder's API design to maintain familiarity.
 

data/lib/pbbuilder.rb

@@ -82,14 +82,25 @@ class Pbbuilder
 
           @message[name].replace arg.to_ary
         elsif arg.respond_to?(:to_ary) && descriptor.type.eql?(:message)
-          # example syntax that should end up here:
-          #   pb.friends [Person.new(name: "Johnny Test"), Person.new(name: "Max Verstappen")]
-
-          args.flatten.each {|obj| @message[name].push descriptor.subtype.msgclass.new(obj)}
+          # pb.friends [Person.new(name: "Johnny Test"), Person.new(name: "Max Verstappen")]
+          #
+          # Accepts both objects that can be to_hash-translated into keyword arguments
+          # for creating a nested proto message object and actual proto message objects
+          # which can be assigned "as is". With "as-is" assignment the proto message can be stored
+          # in memory and reused
+          nested_messages = arg.map do |arg_member_message_or_hash|
+            # If the arg passed already is a proto message and is the same as the
+            # field expects - just use it as-is
+            if arg_member_message_or_hash.is_a?(descriptor.subtype.msgclass)
+              arg_member_message_or_hash
+            else
+              descriptor.subtype.msgclass.new(arg_member_message_or_hash)
+            end
+          end
+          @message[name].replace(nested_messages)
         else
           # example syntax that should end up here:
           #   pb.fields "one"
-
           @message[name].replace [arg]
         end
       else
@@ -222,4 +233,4 @@ class Pbbuilder
     message_class = message_descriptor.msgclass
     message_class.new
   end
-end
+end

data/pbbuilder.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name = "pbbuilder"
-  spec.version = "0.17.0"
+  spec.version = "0.18.0"
   spec.authors = ["Bouke van der Bijl"]
   spec.email = ["bouke@cheddar.me"]
   spec.homepage = "https://github.com/cheddar-me/pbbuilder"

data/test/pbbuilder_test.rb

@@ -30,6 +30,23 @@ class PbbuilderTest < ActiveSupport::TestCase
     assert_equal "Eggs", person.favourite_foods["Breakfast"]
   end
 
+  test "allows assignment of prefab nested proto messages" do
+    max_proto = API::Person.new(name: "Max Verstappen")
+    james_proto = API::Person.new(name: "James Hunt")
+    friend_protos = [max_proto, james_proto]
+
+    person = Pbbuilder.new(API::Person.new) do |pb|
+      pb.name "Niki Lauda"
+      pb.friends friend_protos
+      pb.best_friend james_proto
+    end.target!
+
+    assert_equal "Niki Lauda", person.name
+    assert_equal "Max Verstappen", person.friends[0].name
+    assert_equal "James Hunt", person.friends[1].name
+    assert_equal "James Hunt", person.best_friend.name
+  end
+
   test "replaces the repeated field's value with the last one set" do
     person = Pbbuilder.new(API::Person.new) do |pb|
       pb.field_mask do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pbbuilder
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Bouke van der Bijl
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-22 00:00:00.000000000 Z
+date: 2024-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-protobuf