payr 1.0.1 → 1.0.2

data/README.md

@@ -194,6 +194,16 @@ To finish, you need to add this to the application.js
 //= require payr/bills
 ```
 
+### Tests
+
+If you wanna test your own callbacks, you can mock up the filters like this :
+```ruby
+before { Payr::Client.any_instance.should_receive(:check_response).and_return(true) } 
+before { Payr::Client.any_instance.should_receive(:check_response_ipn).and_return(true) } 
+
+```
+
+
 # I Don't Care about your super CallbacksController and your Super Bill Model
 
 ## YEAH, I just want the backbone : form helpers, signature checker

data/lib/payr/client.rb

@@ -43,9 +43,10 @@ module Payr
 			signed? params, signature
 		end
 
+		# QQQ Improve to use re_build_ipn_query
 		def check_response_ipn params
-			signature = params[:signature]
-			query_params = re_build_ipn_query params
+			signature =  get_signature params
+			query_params = re_build_query params
 			signed? query_params, signature
 		end
 
@@ -55,7 +56,6 @@ module Payr
 			end
 		end
 		
-
   	protected
   	def check_server_availability server_url
 			uri = URI.parse(server_url)
@@ -75,8 +75,8 @@ module Payr
   	end
   	def re_build_ipn_query params
   		Payr.callback_values.keys.collect do |key|
-				"#{key}=#{params[key]}" unless key == :signature
-			end.compact.join("&")
+        "#{key}=#{params[key]}" unless key == :signature	
+      end.compact.join("&")
   	end
   	def re_build_query params
 			params[params.index("?")+1..params.index("&signature")-1]
@@ -91,9 +91,9 @@ module Payr
 			OpenSSL::HMAC.hexdigest(OpenSSL::Digest::Digest.new(Payr.hash.to_s), binary_key, base_params).upcase
 		end
 
-  	def to_base_params params={}  
+  	def to_base_params params={} 
   		params.to_a.collect do |pair|
-  			"#{pair[0].upcase}=#{pair[1]}"
+  		 	"#{pair[0].upcase}=#{pair[1]}"
   		end.join("&")
   	end
 

data/lib/payr/controllers/payr_filters.rb

@@ -8,9 +8,9 @@ module Payr
 				return
 			end
 		end
-
 		def check_ipn_response
-			unless Payr::Client.new.check_response_ipn(params)
+			# TODO use : unless Payr::Client.new.check_response_ipn(params) 
+			unless Payr::Client.new.check_response_ipn(request.url)
 				redirect_to payr_bills_failure_path
 				return
 			end

data/lib/payr/rails/routes.rb

@@ -8,7 +8,7 @@ module ActionDispatch::Routing
 					get "payr/bills/pay", as: "payr_bills_pay"
 					post "payr/bills/pay", as: "payr_bills_pay"
 				end
-			["paid", "refused", "cancelled", "ipn", "failure"].each do |action|
+			%w(paid refused cancelled ipn failure).each do |action|
 				if options && options[:callback_controller]
 					get "#{options[:callback_controller]}/#{action}", as: "payr_bills_#{action}"
 				else

data/lib/payr/version.rb

@@ -1,3 +1,3 @@
 module Payr
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: payr
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-24 00:00:00.000000000 Z
+date: 2012-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -138,7 +138,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2281109692306427172
+      hash: 3263532857104243643
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -147,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2281109692306427172
+      hash: 3263532857104243643
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24