paypoint-blue 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 196ba7d8670cc9b3596ef38f0c008f9097cdbf45
-  data.tar.gz: 43f721a154465801513512613976e36cb6d1067d
+  metadata.gz: 82b114473871861140e8796d61ac85a852a273d2
+  data.tar.gz: 1034d197286e603f13b8f5b409db165c89ce5edb
 SHA512:
-  metadata.gz: ff7818b94e3d54489c54b72371613c5529f4a2c6b9264bdedfc443d90c8705f2722840845de5f88173072447f7e923811ab7f4006126582b12b95f796bcc0a33
-  data.tar.gz: 5ce4939d65e3ed259f410e5cf4926151b06f9293601056cf948c62e9a2f4cdc96255c3a30d080fb320f8bccb575cc3ecd6e83bd65676c5cf88e840851f5b24f2
+  metadata.gz: 721d6ef451f97773e72f2fef33a9895d9a0c624ac527ffad46320e14928d23814f2a29a6ea30c33233b780a67f39b08161e59d9dfeaeb6c60f1141321af5f85d
+  data.tar.gz: 041fdf89fdf82280b6459a32f1d7a0992d28d3a4b2f2057b4ed316d01854fe8a9cfb598e1a0a201484382fe79ad531af1b15e376259f64dbbafce2259eaf40e9

data/lib/paypoint/blue/base.rb

@@ -60,11 +60,11 @@ module PayPoint
                      api_password: ENV['BLUE_API_PASSWORD'],
                      **options)
 
-        @endpoint = self.class.const_get('ENDPOINTS').fetch(endpoint, endpoint.to_s)
+        @endpoint = get_endpoint_or_override_with(endpoint)
 
-        @inst_id      = inst_id or raise ArgumentError, "missing inst_id"
-        @api_id       = api_id or raise ArgumentError, "missing api_id"
-        @api_password = api_password or raise ArgumentError, "missing api_password"
+        @inst_id      = inst_id or raise ArgumentError, 'missing inst_id'
+        @api_id       = api_id or raise ArgumentError, 'missing api_id'
+        @api_password = api_password or raise ArgumentError, 'missing api_password'
 
         options[:url] = @endpoint
         @options = options
@@ -78,8 +78,12 @@ module PayPoint
 
       attr_reader :inst_id, :options
 
+      def get_endpoint_or_override_with(endpoint)
+        self.class.const_get('ENDPOINTS').fetch(endpoint, endpoint.to_s)
+      end
+
       def client_options
-        options.select { |k,v| Faraday::ConnectionOptions.members.include?(k) }
+        options.select { |k, _| Faraday::ConnectionOptions.members.include?(k) }
       end
 
       def build_client
@@ -114,8 +118,6 @@ module PayPoint
           f.adapter Faraday.default_adapter
         end
       end
-
     end
-
   end
 end

data/lib/paypoint/blue/error.rb

@@ -36,6 +36,9 @@ module PayPoint
       # types of errors
       class Client < Error; end
 
+      # Specific error class for non existing sessions
+      class NotFound < Error; end
+
       # Specific error class for errors with a +'V'+ outcome code
       class Validation < Error; end
 

data/lib/paypoint/blue/hash_key_converter.rb

@@ -19,8 +19,6 @@ module PayPoint
           end
         end
       end
-
     end
-
   end
 end

data/lib/paypoint/blue/payload_builder.rb

@@ -11,7 +11,11 @@ module PayPoint
       end
 
       module ClassMethods
-        attr_accessor :shortcuts
+        def shortcuts
+          @shortcuts ||= {}
+        end
+
+        attr_writer :shortcuts
 
         # Define a payload shortcut
         #
@@ -27,11 +31,10 @@ module PayPoint
         # @param [Symbol] key the shortcut key
         # @param [String] path a path into the payload with segments
         #   separated by dots (e.g. +'transaction.money.amount.fixed'+)
-        def shortcut(key, path=nil)
+        def shortcut(key, path = nil)
           if path.nil?
-            shortcuts && shortcuts[key]
+            shortcuts[key]
           else
-            self.shortcuts ||= {}
             shortcuts[key] = path
           end
         end
@@ -83,8 +86,6 @@ module PayPoint
       def interpolate_values(value, payload)
         value.gsub(/%(\w+)%/) {|m| payload[$1.to_sym] || m}
       end
-
     end
-
   end
 end

data/lib/paypoint/blue/raise_errors.rb

@@ -28,13 +28,23 @@ module PayPoint
           else
             raise Error::Client, response_values(env)
           end
-        elsif env.status >= 400
+        elsif not_found?(env)
+          raise Error::NotFound, response_values(env)
+        elsif client_error?(env)
           raise Error::Client, response_values(env)
         end
       end
 
       private
 
+      def not_found?(env)
+        env.status == 404 && env.body[:reason_code] == "A400"
+      end
+
+      def client_error?(env)
+        env.status >= 400
+      end
+
       def fetch_outcome(env)
         env.body.is_a?(Hash) && env.body[:outcome]
       end
@@ -46,8 +56,6 @@ module PayPoint
           body:    env.body
         }
       end
-
     end
-
   end
 end

data/lib/paypoint/blue/version.rb

@@ -1,5 +1,5 @@
 module PayPoint
   module Blue
-    VERSION = "0.2.1"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paypoint-blue
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Laszlo Bacsi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2015-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday