paypalhttp 1.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e1d7486774ce1d1a9a52d214a00f3212196d0d1da58b599861056a0367753db
-  data.tar.gz: 18f0971f48707107899ed7cbd397384605b334e761ef33176c9b642742e8bf31
+  metadata.gz: e7b784f809b45daa88b7b605a078233f9d6d6389de4d22c58810ad904b1e6270
+  data.tar.gz: 83f24bf689519c48fb95474ffca65635b2c27eacecbabc4e4194761f88e2bceb
 SHA512:
-  metadata.gz: 219e4ffe88eeabfde09731075a2dfd92394568c14d64c0ac4d6f9ac2d2cfe7e24e36353150555fe922077b761e5b01678ae1d3df0435cb10a377bae99d223870
-  data.tar.gz: ed6ee01c152150c9df2d34b47cb1f620271e549c1f8e8953cdbc19eded34d83c7604c97ca6929db8ab9feb972ea03d8221c62758151a615de65b73ac915171e0
+  metadata.gz: f6ccd5a75ac2a07ef84c2cc55d4caacd529bd075315ec040066b1c5cdd625d5de048e11b483318eb7adc3065ceec1ac9d3aed568df4dbc1cba30bf390749cafb
+  data.tar.gz: cebe0720259ce83416259eed470253ba5ec716eb329216617fd79a4eabf16a576a4e5c54a9b967852c3a0009fe478a37910aacfff333bdf75b41fa2acdc1113e

data/lib/paypalhttp/encoder.rb

@@ -41,6 +41,7 @@ module PayPalHttp
       raise UnsupportedEncodingError.new('HttpResponse did not have Content-Type header set') unless headers && (headers['content-type'])
 
       content_type = _extract_header(headers, 'content-type')
+      content_type.downcase!
 
       enc = _encoder(content_type)
       raise UnsupportedEncodingError.new("Unable to deserialize response with Content-Type #{content_type}. Supported decodings are #{supported_encodings}") unless enc

data/lib/paypalhttp/http_client.rb

@@ -28,7 +28,13 @@ module PayPalHttp
     def format_headers(headers)
       formatted_headers = {}
       headers.each do |key, value|
-        formatted_headers[key.downcase] = value
+        # TODO: Since header is treated as a hash, val is in an array.
+        # Will this cause an issue when accessing and modifying val
+        # Ensure this is the case and will not propegate access issues/errors
+        if key.casecmp("content-type") == 0
+          value[0].downcase!
+        end
+          formatted_headers[key.downcase] = value
       end
       formatted_headers
     end

data/lib/paypalhttp/serializers/form_encoded.rb

@@ -2,10 +2,14 @@ require 'uri'
 
 module PayPalHttp
   class FormEncoded
+    def initialize
+      @parser = URI::Parser.new()
+    end
+
     def encode(request)
       encoded_params = []
       request.body.each do |k, v|
-        encoded_params.push("#{URI.escape(k.to_s)}=#{URI.escape(v.to_s)}")
+        encoded_params.push("#{@parser.escape(k.to_s)}=#{@parser.escape(v.to_s)}")
       end
 
       encoded_params.join("&")

data/lib/paypalhttp/version.rb

@@ -1 +1 @@
-VERSION = "1.0.0"
+VERSION = "2.0.1"

data/spec/paypalhttp/encoder_spec.rb

@@ -108,6 +108,39 @@ describe Encoder do
       expect(serialized).to eq("key=value%20with%20a%20space&another_key=1013")
     end
 
+    it 'encodes different special/unsafe characters when using a URI parser' do
+      req = OpenStruct.new({
+        :verb => "POST",
+        :path => "/v1/api",
+        :headers => {
+          "content-type" => "application/x-www-form-urlencoded; charset=utf8"
+        },
+        :body => {
+          :key => " ..<..>..%..{..}..|..^..`..!",
+          :another_key => 1013,
+        }
+      })
+      serialized = Encoder.new.serialize_request(req)
+
+      expect(serialized).to eq("key=%20..%3C..%3E..%25..%7B..%7D..%7C..%5E..%60..!&another_key=1013")
+    end
+
+    it 'does not encode links given certain special characters' do
+      req = OpenStruct.new({
+        :verb => "POST",
+        :path => "/v1/api",
+        :headers => {
+          "content-type" => "application/x-www-form-urlencoded; charset=utf8"
+        },
+        :body => {
+          :key => "https://localhost:3001/"
+        }
+      })
+      serialized = Encoder.new.serialize_request(req)
+
+      expect(serialized).to eq("key=https://localhost:3001/")
+    end
+
     it 'throws when content-type is unsupported' do
       req = OpenStruct.new({
         :headers  => {
@@ -205,6 +238,26 @@ describe Encoder do
       expect(deserialized).to eq(expected)
     end
 
+    it 'deserializes the response when content-type == application/json: case insensitive' do
+      expected = {
+        "string" => "value",
+        "number" => 1.23,
+        "bool" => true,
+        "array" => ["one", "two", "three"],
+        "nested" => {
+          "nested_string" => "nested_value",
+          "nested_array" => [1,2,3]
+        }
+      }
+
+      headers = {"content-type" => ["application/JSON; charset=utf8"]}
+      body = '{"string":"value","number":1.23,"bool":true,"array":["one","two","three"],"nested":{"nested_string":"nested_value","nested_array":[1,2,3]}}'
+
+      deserialized = Encoder.new.deserialize_response(body, headers)
+
+      expect(deserialized).to eq(expected)
+    end
+
     it 'deserializes the response when content-type == text/*' do
       headers = {"content-type" => ["text/plain; charset=utf8"]}
       body = 'some text'
@@ -212,6 +265,13 @@ describe Encoder do
       expect(Encoder.new.deserialize_response(body, headers)).to eq('some text')
     end
 
+    it 'deserializes the response when content-type == text/*: case insensitive' do
+      headers = {"content-type" => ["TEXT/plain; charset=utf8"]}
+      body = 'some text'
+
+      expect(Encoder.new.deserialize_response(body, headers)).to eq('some text')
+    end
+
     it 'throws when attempting to deserialize multipart/*' do
       headers = {"content-type" => ["multipart/form-data"]}
       body = 'some multipart encoded data here'

data/spec/paypalhttp/http_client_spec.rb

@@ -226,6 +226,57 @@ describe HttpClient do
     expect(resp.result).to eq(return_data)
   end
 
+  it 'handles json array result: case insensitive' do
+    WebMock.enable!
+
+    return_data = ["one", "two"]
+
+    http_client = HttpClient.new(@environment)
+
+    stub_request(:get, @environment.base_url + "/v1/api")
+      .to_return(body: JSON.generate(return_data), status: 200, headers: {"Content-Type" => "application/JSON"})
+
+    req = OpenStruct.new({:verb => "GET", :path => "/v1/api"})
+
+    resp = http_client.execute(req)
+
+    expect(resp.result).to eq(return_data)
+  end
+
+  it 'handles plain text result' do
+    WebMock.enable!
+
+    return_data = "value"
+
+    http_client = HttpClient.new(@environment)
+
+    stub_request(:get, @environment.base_url + "/v1/api")
+      .to_return(body: return_data, status: 200, headers: {"Content-Type" => "text/plain; charset=utf8"})
+
+    req = OpenStruct.new({:verb => "GET", :path => "/v1/api"})
+
+    resp = http_client.execute(req)
+
+    expect(resp.result).to eq(return_data)
+  end
+
+  it 'handles plain text result: case insensitive' do
+    WebMock.enable!
+
+    return_data = "value"
+
+    http_client = HttpClient.new(@environment)
+
+    stub_request(:get, @environment.base_url + "/v1/api")
+      .to_return(body: return_data, status: 200, headers: {"Content-Type" => "TEXT/plain; charset=utf8"})
+
+    req = OpenStruct.new({:verb => "GET", :path => "/v1/api"})
+
+    resp = http_client.execute(req)
+
+    expect(resp.result).to eq(return_data)
+  end
+
   it 'deserializes nested response object into nested openstruct response' do
     WebMock.enable!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paypalhttp
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - PayPal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-11 00:00:00.000000000 Z
+date: 2022-07-27 00:00:00.000000000 Z
 dependencies: []
 description: Used for generated API clients
 email: 
@@ -52,7 +52,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.3.1
 signing_key: 
 specification_version: 4
 summary: PayPalHttp Client Library