paypal_adaptive 0.3.5 → 0.3.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NGJlNjc4YTY2Y2Y2M2M4MzkwZDk5MWRiZmM3MGJkOGE0OWEzZWZjMg==
+    YWQ2Y2UzMTAzNWQzZmRjYWZjOGE0MTIwNjNlMzc0ZjYzNWVmMGU1MA==
   data.tar.gz: !binary |-
-    ZmE5NGRkMTI1ZTVkZTVkNjA1YWM1MmQ1NjkwZWE3ZTdkY2E3ZThhZg==
+    MzM5YTU4ZjMxMmVhYjYwMjk4NzUyYjJmMzdiYTM4MTc0YjRkYjY1Zg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    MzgxZmRhMzkxMTJlODk3MmExYjc0MmRiMDNhZGNlZWYxZmEyMDQ3NzU5MjFm
-    Nzg2MDNlODI2YmQ0ZGJiYmZhNGM4YzY2Mzk3NGRhODQyNjY3MmE5MGZkMzFj
-    NTQ5MTk4ZWYwODBiNjFiM2UyMzAwODFjZTFiMTQ0MTkyMDUyNjQ=
+    OTRhZDRkN2FjOWJmNjY1YTAyMjk1Yzg3ZmY5ODljYjAwMWIzZDk1ZjQwMzkw
+    NDBiNWIxOTNhZTdkODcxZTJmNDllZTAxOTA2MTY3OTNmMWIzNDFmMzdjYTg0
+    NWRhZWU3N2U3OGYyMGJiNWQ0MTI5MGFiYzVjMWU0NzBmMjkxMzg=
   data.tar.gz: !binary |-
-    ZGMwMjU1OTkxNWViNzc2ODc1ODdhY2QxOTJjOTgwZDhlMDYzNjdlZTk1MjNl
-    NmY0YjMzMDY4NGRiODEwNWE3MDZjMTBmY2NlMDU1YWIzOWQwYmYwMDk3Mjdl
-    YTM5OWZkMjMwN2QxNDRmMDU1MGUxM2JmNDEyZTI3NzllNjVlOTA=
+    ZDM3ODVmMmUzZjMxZmQ5NGIxOTllODI4MGY5MGI5MTEwM2EzYjVlZjk3NzVk
+    ZDBkOWUwZjA1NGQ1NzU5N2EyZjIwMWY5OWM0MWY3MWU3MDRmYjJhMzYwNWFm
+    MTc5ZDVmM2ViOWYyM2IzYzlmYjIwMmRkZjNhOTdkNjAyOTViYWE=

data/README.markdown

@@ -96,6 +96,9 @@ for each environment, e.g.:
 The api_cert_file should point to your cert_key_pem.txt that is downloaded through the paypal developer interface. It will contain a section that specifies the RSA private key and another section that specifies a certificate. If this is left empty, paypal_adaptive will attempt to use the signature method of validation with PayPal, so your signature config must not be nil.
 
 ## Changelog
+0.3.6
+Include more details in error in case the HTTP request doesn't return. thanks mreinsch
+
 0.3.5
 SSL verify mode set to none for sandbox testing. thanks @mikong
 

data/lib/paypal_adaptive/request.rb

@@ -81,8 +81,15 @@ module PaypalAdaptive
       PaypalAdaptive::Response.new(post(data, path), @env)
     end
 
-    def rescue_error_message(e, message = nil)
-      {"responseEnvelope" => {"ack" => "Failure"}, "error" => [{"message" => (message ||= e)}]}
+    def rescue_error_message(e, message = nil, response_data = nil)
+      error = {"message" => message || e}
+      if response_data
+        error["details"] = {
+          "httpCode" => response_data.code,
+          "httpMessage" => response_data.message.to_s,
+          "httpBody" => response_data.body }
+      end
+      {"responseEnvelope" => {"ack" => "Failure"}, "error" => [error]}
     end
 
     def post(data, path)
@@ -107,13 +114,13 @@ module PaypalAdaptive
       rescue Net::HTTPBadGateway => e
         rescue_error_message(e, "Error reading from remote server.")
       rescue JSON::ParserError => e
-        rescue_error_message(e, "Response is not in JSON format.")
+        rescue_error_message(e, "Response is not in JSON format.", response_data)
       rescue Exception => e
         case e
         when Errno::ECONNRESET
           rescue_error_message(e, "Connection Reset. Request invalid URL.")
         else
-          rescue_error_message(e)
+          rescue_error_message(e, response_data)
         end
       end
 

data/lib/paypal_adaptive/version.rb

@@ -1,4 +1,4 @@
 module PaypalAdaptive
-  VERSION = "0.3.5"
+  VERSION = "0.3.6"
 end
 

data/paypal_adaptive.gemspec

@@ -16,6 +16,7 @@ Gem::Specification.new do |s|
   s.add_dependency("jsonschema", "~>2.0.0")
   s.add_development_dependency("rake")
   s.add_development_dependency("activesupport", "~> 3.2.0")
+  s.add_development_dependency("webmock")
 
   s.rubyforge_project = "paypal_adaptive"
 

data/test/test_helper.rb

@@ -6,4 +6,7 @@ require "test/unit"
 require "json"
 require "jsonschema"
 require 'paypal_adaptive'
-require 'active_support/core_ext/string'
+require 'active_support/core_ext/string'
+require 'webmock/minitest'
+
+WebMock.allow_net_connect!

data/test/unit/request_test.rb

@@ -12,16 +12,27 @@ class RequestTest < Test::Unit::TestCase
     assert_instance_of Hash, response
   end
 
-  def test_post_should_return_hash_when_request_is_invalid
+  def test_post_should_return_error_message_when_request_is_invalid
     request = PaypalAdaptive::Request.new('test')
     response = request.post({:data => true}, '/some-random-url')
     assert_instance_of Hash, response
+    assert_equal "Connection Reset. Request invalid URL.", response["error"][0]["message"]
   end
 
-  def test_post_shoudl_return_error_message_when_request_is_invalid
+  def test_post_should_return_error_details_when_response_is_invalid
+    WebMock.disable_net_connect!
+    stub_request(:post, "https://svcs.sandbox.paypal.com/some-random-url").
+      to_return(:status => [500, "Internal Server Error"], :body => "Something went wrong")
     request = PaypalAdaptive::Request.new('test')
     response = request.post({:data => true}, '/some-random-url')
-    assert_not_nil response["error"][0]["message"]
+    assert_instance_of Hash, response
+    error = response["error"].first
+    assert_instance_of Hash, error
+    assert_equal "Response is not in JSON format.", error["message"]
+    assert_equal "500", error["details"]["httpCode"]
+    assert_equal "Internal Server Error", error["details"]["httpMessage"]
+    assert_equal "Something went wrong", error["details"]["httpBody"]
+  ensure
+    WebMock.allow_net_connect!
   end
-  
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paypal_adaptive
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Tommy Chheng
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-12 00:00:00.000000000 Z
+date: 2013-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -66,6 +66,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.2.0
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Lightweight wrapper for Paypal's Adaptive Payments API
 email:
 - tommy.chheng@gmail.com
@@ -133,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: paypal_adaptive
-rubygems_version: 2.0.2
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Lightweight wrapper for Paypal's Adaptive Payments API