paypal-sdk-rest 1.4.9 → 1.7.5

data/lib/paypal-sdk/rest/error_hash.rb

@@ -13,7 +13,7 @@ module PayPal
         def []=(key, value)
           value =
             if value.is_a? Hash
-              ErrorHash.convert(hash)
+              ErrorHash.convert(value)
             elsif value.is_a? Array and value[0].is_a? Hash
               value.map{|array_value| ErrorHash.convert(array_value) }
             else

data/lib/paypal-sdk/rest/version.rb

@@ -1,7 +1,7 @@
 module PayPal
   module SDK
     module REST
-      VERSION = "1.4.9"
+      VERSION = "1.7.4"
     end
   end
 end

data/spec/core/api/data_type_spec.rb

@@ -56,6 +56,106 @@ describe PayPal::SDK::Core::API::DataTypes::Base do
     expect(test_type.fromCurrency.amount).to  eql "50.0"
   end
 
+  it "invoice address loads all members of default address object" do
+    invoice_address = InvoiceAddress.new(:line1 => "line1", :line2 => "line2", :phone => { :country_code => "123", :national_number => "1231231234", :extension => "123" }, :status => "status" )
+    expect(invoice_address).to be_a InvoiceAddress
+    expect(invoice_address.phone).to be_a Phone
+    expect(invoice_address.line1).to eql "line1"
+    expect(invoice_address.line2).to eql "line2"
+    expect(invoice_address.status).to eql "status"
+    expect(invoice_address.phone.country_code).to eql "123"
+    expect(invoice_address.phone.national_number).to eql "1231231234"
+    expect(invoice_address.phone.extension).to eql "123"
+  end
+
+  it "billing info converts an address to invoiceaddress automatically" do
+    address = Address.new(:line1 => "line1", :line2 => "line2", :status => "status" )
+    billing_info = BillingInfo.new({
+      :first_name => "Sally",
+      :last_name => "Patient",
+      :business_name => "Not applicable",
+    })
+    billing_info.address = address
+    expect(billing_info.address).to be_a Address
+    expect(billing_info.invoice_address).to be_a InvoiceAddress
+  end
+
+  it "shipping info returns an Address even if set to InvoiceAddress for backwards compatibility" do
+    address = InvoiceAddress.new(:line1 => "line1", :line2 => "line2", :status => "status", :phone => { :national_number => "1234567890" } )
+    billing_info = BillingInfo.new({
+      :first_name => "Sally",
+      :last_name => "Patient",
+      :business_name => "Not applicable",
+    })
+    billing_info.address = address
+    expect(billing_info.address).to be_a Address
+    expect(billing_info.invoice_address).to be_a InvoiceAddress
+    expect(billing_info.invoice_address.phone.national_number).to eql "1234567890"
+  end
+
+  it "returns the address and invoice address types in the billing info" do
+    billing_info = BillingInfo.new({
+      "first_name" => "Sally",
+      "last_name" => "Patient",
+      "business_name" => "Not applicable",
+      "address" => {
+        "line1" => "line1Value",
+        "phone" => { "country_code" => "123", "national_number" => "1234567890", "extension" => "456" },
+      },
+    })
+    expect(billing_info.address).to be_a Address
+    expect(billing_info.address.line1).to eql "line1Value"
+    expect(billing_info.invoice_address).to be_a InvoiceAddress
+    expect(billing_info.invoice_address.line1).to eql "line1Value"
+    expect(billing_info.invoice_address.phone.country_code).to eql "123"
+    expect(billing_info.invoice_address.phone.national_number).to eql "1234567890"
+    expect(billing_info.invoice_address.phone.extension).to eql "456"
+  end
+
+  it "shipping info converts an address to invoiceaddress automatically" do
+    address = Address.new(:line1 => "line1", :line2 => "line2", :status => "status" )
+    shipping_info = ShippingInfo.new({
+      "first_name" => "Sally",
+      "last_name" => "Patient",
+      "business_name" => "Not applicable",
+    })
+    shipping_info.address = address
+    expect(shipping_info.address).to be_a Address
+    expect(shipping_info.invoice_address).to be_a InvoiceAddress
+  end
+
+  it "shipping info returns an Address even if set to InvoiceAddress for backwards compatibility" do
+    address = InvoiceAddress.new(:line1 => "line1", :line2 => "line2", :status => "status", :phone => { :national_number => "1234567890" } )
+    shipping_info = ShippingInfo.new({
+      "first_name" => "Sally",
+      "last_name" => "Patient",
+      "business_name" => "Not applicable",
+    })
+    shipping_info.address = address
+    expect(shipping_info.address).to be_a Address
+    expect(shipping_info.invoice_address).to be_a InvoiceAddress
+    expect(shipping_info.invoice_address.phone.national_number).to eql "1234567890"
+  end
+
+  it "returns the address and invoice address types in the shipping info" do
+    shipping_info = ShippingInfo.new({
+      "first_name" => "Sally",
+      "last_name" => "Patient",
+      "business_name" => "Not applicable",
+      "address" => {
+        "line1" => "line1Value",
+        "phone" => { "country_code" => "123", "national_number" => "1234567890", "extension" => "456" },
+      },
+    })
+    expect(shipping_info.address).to be_a Address
+    expect(shipping_info.address.line1).to eql "line1Value"
+    expect(shipping_info.invoice_address).to be_a InvoiceAddress
+    expect(shipping_info.invoice_address.line1).to eql "line1Value"
+    expect(shipping_info.invoice_address.phone.country_code).to eql "123"
+    expect(shipping_info.invoice_address.phone.national_number).to eql "1234567890"
+    expect(shipping_info.invoice_address.phone.extension).to eql "456"
+  end
+
   it "should allow block with initializer" do
     test_type = TestType.new do
       fromCurrency do

data/spec/core/api/rest_spec.rb

@@ -76,10 +76,11 @@ describe PayPal::SDK::Core::API::REST do
       }.to raise_error PayPal::SDK::Core::Exceptions::UnauthorizedAccess
     end
 
-    xit "Should handle expired token" do
+    it "Should handle expired token" do
       old_token = @api.token
       @api.token_hash[:expires_in] = 0
-      expect(@api.token).not_to eql old_token
+      new_token = @api.token
+      expect(@api.token_hash[:expires_in]).not_to eql 0
     end
 
     it "Get token" do
@@ -144,4 +145,67 @@ describe PayPal::SDK::Core::API::REST do
       expect(response["error"]["name"]).to eql "VALIDATION_ERROR"
     end
   end
+
+  describe "format response" do
+    before :each do
+      @response = instance_double(Net::HTTPResponse)
+      allow(@response).to receive(:code) { "200" }
+      allow(@response).to receive(:content_type) { "application/json" }
+    end
+
+    it "parses empty object JSON correctly" do
+      allow(@response).to receive(:body) { "{}" }
+      payload = {
+        :response => @response
+      }
+
+      formatted_response = @api.format_response(payload)
+      expect(formatted_response).to_not be_nil
+      expect(formatted_response[:data]).to eq({})
+    end
+
+    it "parses empty string JSON correctly" do
+      allow(@response).to receive(:body) { '""' }
+      payload = {
+        :response => @response
+      }
+
+      formatted_response = @api.format_response(payload)
+      expect(formatted_response).to_not be_nil
+      expect(formatted_response[:data]).to eq("")
+    end
+
+    it "parses whitespace body correctly" do
+      allow(@response).to receive(:body) { ' 	 ' }
+      payload = {
+        :response => @response
+      }
+
+      formatted_response = @api.format_response(payload)
+      expect(formatted_response).to_not be_nil
+      expect(formatted_response[:data]).to eq({})
+    end
+
+    it "parses nil body correctly" do
+      allow(@response).to receive(:body) { nil }
+      payload = {
+        :response => @response
+      }
+
+      formatted_response = @api.format_response(payload)
+      expect(formatted_response).to_not be_nil
+      expect(formatted_response[:data]).to eq({})
+    end
+
+    it "parses with whitespace around JSON correctly" do
+      allow(@response).to receive(:body) { '    { "test": "value"  } ' }
+      payload = {
+        :response => @response
+      }
+
+      formatted_response = @api.format_response(payload)
+      expect(formatted_response).to_not be_nil
+      expect(formatted_response[:data]).to eq({ "test" => "value" })
+    end
+  end
 end

data/spec/payments_examples_spec.rb

@@ -1,4 +1,6 @@
 require 'spec_helper'
+require 'json'
+require 'webmock/rspec'
 
 describe "Payments" do
 
@@ -49,6 +51,18 @@ describe "Payments" do
             "currency" =>  "USD" },
           "description" =>  "This is the payment transaction description." } ] }
 
+  ProcessorErrorResponse = {
+    "name" => "INSTRUMENT_DECLINED",
+    "message" => "The instrument presented was either declined by the processor or bank, or it can't be used for this payment.",
+    "information_link" => "https://developer.paypal.com/docs/api/#INSTRUMENT_DECLINED",
+    "debug_id" => "20dcd4f71107c",
+    "another_thing" => {
+      "avs_code" => "Y",
+      "cvv_code" => "N",
+      "response_code" => "0051"
+    }
+  }
+
   it "Validate user-agent", :unit => true do
     expect(PayPal::SDK::REST::API.user_agent).to match "PayPalSDK/PayPal-Ruby-SDK"
   end
@@ -62,6 +76,40 @@ describe "Payments" do
         PayPal::SDK::REST.set_config(backup_config)
         expect(PayPal::SDK::REST.api.config.client_id).not_to eql "XYZ"
       end
+
+      it "Create - does not return true when error not provided in response" do
+        oauth_response = {
+            :scope => "https://uri.paypal.com/services/subscriptions https://api.paypal.com/v1/payments/.* https://api.paypal.com/v1/vault/credit-card https://uri.paypal.com/services/applications/webhooks openid https://uri.paypal.com/payments/payouts https://api.paypal.com/v1/vault/credit-card/.*",
+            :nonce => "2016-10-04T18:00:00ZP3PcGAv5XAncoc8Zt4MF5cRLlaEBW3OAoLEhMIFk--g",
+            :access_token => "A101.tp_sF5GHqWnnqEQA13Ua5ABnIhRWgd-G9LhRnJdgOvJHc_L08zlfD9WgPF4I3kre.mShauuOGxWyw8ikViItmxkWmX78",
+            :token_type => "Bearer",
+            :app_id => "APP-80W284485P519543T",
+            :expires_in => 30695
+        }
+
+        response_headers = {
+            "date" => ["Fri, 09 Sep 2016 17:44:23 GMT"],
+            "server" => ["Apache"],
+            "proxy_server_info" => ["host=dcg12javapapi8768.dcg12.slc.paypalinc.com;threadId=1177"],
+            "paypal-debug-id" => ["20dcd4f71107c", "20dcd4f71107c"],
+            "correlation-id" => ["20dcd4f71107c"],
+            "content-language" => ["*"],
+            "connection" => ["close", "close"],
+            "set-cookie" => ["X-PP-SILOVER=name%3DLIVE3.API.1%26silo_version%3D880%26app%3Dplatformapiserv%26TIME%3D4160016983%26HTTP_X_PP_AZ_LOCATOR%3Ddcg12.slc; Expires=Fri, 09 Sep 2016 18:14:25 GMT; domain=.paypal.com; path=/; Secure; HttpOnly", "X-PP-SILOVER=; Expires=Thu, 01 Jan 1970 00:00:01 GMT"],
+            "vary" => ["Authorization"],
+            "content-length" => ["335"],
+            "content-type"=>["application/json"]
+        }
+
+        stub_request(:post, "https://api.sandbox.paypal.com/v1/oauth2/token")
+            .to_return(:body => oauth_response.to_json)
+
+        stub_request(:post, "https://api.sandbox.paypal.com/v1/payments/payment")
+            .to_return(:body => ProcessorErrorResponse.to_json, :status => 400, :headers => response_headers)
+
+        payment = Payment.new(PaymentAttributes)
+        expect(payment.create).to be_falsey
+      end
     end
 
     describe "Payment", :integration => true do
@@ -87,7 +135,6 @@ describe "Payments" do
         expect(new_payment.error).to be_nil
 
         expect(payment.id).to eql new_payment.id
-
       end
 
       it "Create with token" do

data/spec/payouts_examples_spec.rb

@@ -2,6 +2,25 @@ require "spec_helper"
 
 describe "Payouts", :integration => true do
 
+  PayoutVenmoAttributes = {
+      :sender_batch_header => {
+          :sender_batch_id => SecureRandom.hex(8)
+      },
+      :items => [
+          {
+              :recipient_type => 'PHONE',
+              :amount => {
+                  :value => '1.0',
+                  :currency => 'USD'
+              },
+              :note => 'Thanks for your patronage!',
+              :sender_item_id => '2014031400023',
+              :receiver => '5551232368',
+              :recipient_wallet => 'VENMO'
+          }
+      ]
+  }
+
   PayoutAttributes = {
       :sender_batch_header => {
           :sender_batch_id => SecureRandom.hex(8),
@@ -21,6 +40,12 @@ describe "Payouts", :integration => true do
       ]
   }
 
+  it "create venmo payout" do
+    $payout = PayPal::SDK::REST::Payout.new(PayoutVenmoAttributes)
+    $payout_batch = $payout.create
+    expect($payout_batch).to be_truthy
+  end
+
   it "create payout sync" do
     $payout = PayPal::SDK::REST::Payout.new(PayoutAttributes)
     $payout_batch = $payout.create(true)

data/spec/rest/error_hash_spec.rb

@@ -0,0 +1,83 @@
+module PayPal::SDK::REST
+  describe ErrorHash do
+    it 'converts Hashes to ErrorHashes' do
+      hash = ErrorHash.convert({
+        nested_hash: { bing: 'bong' },
+        empty_array: [],
+        array_with_hashes: [
+          { foo: 'boo' },
+          { biz: 'boz' }
+        ],
+        array_without_hashes: [1, 2, 3],
+        nilly: nil,
+        stringy: 'cheese'
+      })
+
+      expect(hash).to be_a(ErrorHash)
+      expect(hash.nested_hash).to be_a(ErrorHash)
+      expect(hash.empty_array).to eq([])
+      expect(hash.array_with_hashes[0]).to be_a(ErrorHash)
+      expect(hash.array_with_hashes[1]).to be_a(ErrorHash)
+      expect(hash.array_without_hashes).to eq([1, 2, 3])
+      expect(hash.nilly).to be_nil
+      expect(hash.stringy).to eq('cheese')
+    end
+
+    it 'can access string keys as properties, strings, or symbols' do
+      hash = ErrorHash.convert({ 'foo' => 5 })
+      hash['boo'] = 'grue'
+
+      expect(hash.foo).to eq(5)
+      expect(hash['foo']).to eq(5)
+      expect(hash[:foo]).to eq(5)
+      expect(hash.boo).to eq('grue')
+      expect(hash['boo']).to eq('grue')
+      expect(hash[:boo]).to eq('grue')
+    end
+
+    it 'can access symbol keys as properties, strings, or symbols' do
+      hash = ErrorHash.convert({ :foo => 5 })
+      hash[:boo] = 'grue'
+
+      expect(hash.foo).to eq(5)
+      expect(hash['foo']).to eq(5)
+      expect(hash[:foo]).to eq(5)
+      expect(hash.boo).to eq('grue')
+      expect(hash['boo']).to eq('grue')
+      expect(hash[:boo]).to eq('grue')
+    end
+
+    it 'converts Hashes to ErrorHashes on assignment' do
+      hash = ErrorHash.new
+      hash['foo'] = { bing: 'bong' }
+
+      expect(hash['foo']).to be_a(ErrorHash)
+      expect(hash['foo'].bing).to eq('bong')
+    end
+
+    it 'converts Hashes inside of Arrays to ErrorHashes on assignment' do
+      hash = ErrorHash.new
+      hash['foo'] = [{ bing: 'bong' }]
+
+      expect(hash['foo'][0]).to be_a(ErrorHash)
+      expect(hash['foo'][0].bing).to eq('bong')
+    end
+
+    it "doesn't convert Hashes inside of Arrays if the first element of the array isn't a Hash" do
+      hash = ErrorHash.new
+      hash['foo'] = [100, { bing: 'bong' }]
+
+      expect(hash['foo'][1]).to be_a(Hash)
+      expect(hash['foo'][1]).not_to be_a(ErrorHash)
+    end
+
+    it 'gets and sets numbers and strings' do
+      hash = ErrorHash.new
+      hash['foo'] = 123
+      hash['boo'] = 'baa'
+
+      expect(hash['foo']).to eq(123)
+      expect(hash['boo']).to eq('baa')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -33,3 +33,5 @@ RSpec.configure do |config|
   config.include SampleData
   # config.include PayPal::SDK::REST::DataTypes
 end
+
+WebMock.allow_net_connect!

data/spec/webhooks_examples_spec.rb

@@ -15,6 +15,14 @@ describe "Webhooks" do
     ]
   }
 
+  describe "PayPal::SDK::Core::API::DataTypes::WebhookEvent" do
+    describe "get event by id via .find" do
+      it "exists" do
+        expect(WebhookEvent).to respond_to(:find)
+      end
+    end
+  end
+
   describe "Notifications", :integration => true do
     it "create webhook" do
       $webhook = PayPal::SDK::REST::Webhook.new(webhookAttributes)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paypal-sdk-rest
 version: !ruby/object:Gem::Version
-  version: 1.4.9
+  version: 1.7.5
 platform: ruby
 authors:
 - PayPal
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-07-29 00:00:00.000000000 Z
+date: 2023-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls
@@ -52,22 +52,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: uuidtools
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.1'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.1'
-description: The PayPal REST SDK provides Ruby APIs to create, process and manage
-  payment.
+description: "[Deprecated] The PayPal REST SDK provides Ruby APIs to create, process
+  and manage payment."
 email:
 - DL-PP-RUBY-SDK@paypal.com
 executables: []
@@ -133,11 +119,10 @@ files:
 - spec/core/logging_spec.rb
 - spec/core/openid_connect_spec.rb
 - spec/invoice_examples_spec.rb
-- spec/log/http.log
-- spec/log/rest_http.log
 - spec/payments_examples_spec.rb
 - spec/payouts_examples_spec.rb
 - spec/rest/data_types_spec.rb
+- spec/rest/error_hash_spec.rb
 - spec/spec_helper.rb
 - spec/subscription_examples_spec.rb
 - spec/support/sample_data.rb
@@ -147,7 +132,7 @@ homepage: https://developer.paypal.com
 licenses:
 - PayPal SDK License
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -162,11 +147,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
-summary: The PayPal REST SDK provides Ruby APIs to create, process and manage payment.
+summary: Deprecated.
 test_files:
 - spec/README.md
 - spec/config/cacert.pem
@@ -179,11 +163,10 @@ test_files:
 - spec/core/logging_spec.rb
 - spec/core/openid_connect_spec.rb
 - spec/invoice_examples_spec.rb
-- spec/log/http.log
-- spec/log/rest_http.log
 - spec/payments_examples_spec.rb
 - spec/payouts_examples_spec.rb
 - spec/rest/data_types_spec.rb
+- spec/rest/error_hash_spec.rb
 - spec/spec_helper.rb
 - spec/subscription_examples_spec.rb
 - spec/support/sample_data.rb