paypal-sdk-rest 1.4.7 → 1.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6caede99d228cdad852593c3f30716e8655bb0b4
-  data.tar.gz: 60ed17097e21be9d538c49e60b93ed0af556c62f
+  metadata.gz: e01168b996d2cd17b84b6a61e05ae19af58d4691
+  data.tar.gz: 16f3f72b5c61e5c2b6745d7e2f43ec805b3a76d1
 SHA512:
-  metadata.gz: 1c5029ab40c1bc6d42ef395fdc6ac1900e7f6e52c2d8e468e3d936d420c38a141be2e2de8b958df56a37b91ed12ad62959cf7d1121054fcba4de120f0a8a4f57
-  data.tar.gz: bb6c7d3eead1be286fdf3c7d45dfd702ab52cc6a7b83cc89526a5769c69948ea72f0f4444ecb5905a33163b25bead559562d2aa19174339cddbbeee8ed61e00b
+  metadata.gz: 0452d37fb1b03f9b40ba21085567010cedab37451f74fc05217d4f76c5dd212aa96805a2d8718ec1eba81c6c720b4693a3b477e3d76dd0bfeaeaef1217edfb05
+  data.tar.gz: bc894c391a9e1eece74d1d43ed9032bede1a7065c2c88ba4564179ea0aacdc9235af17b5c295bef9cfbbccb4419eed6ddffe56744ed97ef84c83525e479d0241

data/Gemfile

@@ -11,4 +11,4 @@ group :test do
   gem 'rspec'
 end
 
-gem 'releasinator', '~> 0.4'
+gem 'releasinator', '~> 0.6'

data/README.md

@@ -1,4 +1,5 @@
-## PayPal REST API Ruby SDK [![Build Status](https://travis-ci.org/paypal/PayPal-Ruby-SDK.svg?branch=master)](https://travis-ci.org/paypal/PayPal-Ruby-SDK)
+## PayPal REST API Ruby SDK [![Build Status](https://travis-ci.org/paypal/PayPal-Ruby-SDK.svg?branch=master)](https://travis-ci.org/paypal/PayPal-Ruby-SDK) [![Coverage Status](https://coveralls.io/repos/github/paypal/PayPal-Ruby-SDK/badge.svg?branch=master)](https://coveralls.io/github/paypal/PayPal-Ruby-SDK?branch=master)
+
 
 The PayPal REST SDK provides Ruby APIs to create, process and manage payment.
 
@@ -276,4 +277,4 @@ end
 Code released under [SDK LICENSE](LICENSE)  
 
 ## Contributions 
- Pull requests and new issues are welcome. See [CONTRIBUTING.md](CONTRIBUTING.md) for details. 
+ Pull requests and new issues are welcome. See [CONTRIBUTING.md](CONTRIBUTING.md) for details. 

data/Rakefile

@@ -1,5 +1,11 @@
 require "bundler/gem_tasks"
 
+# release will instead be declared by the releasinator
+Rake::Task["release"].clear
+
+spec = Gem::Specification.find_by_name 'releasinator'
+load "#{spec.gem_dir}/lib/tasks/releasinator.rake"
+
 desc "Run tests"
 task :rspec do
   cmd = "bundle exec rspec -f d"
@@ -7,6 +13,3 @@ task :rspec do
 end
 
 task :default => :rspec
-
-spec = Gem::Specification.find_by_name 'releasinator'
-load "#{spec.gem_dir}/lib/tasks/releasinator.rake"

data/lib/paypal-sdk/core/exceptions.rb

@@ -94,5 +94,15 @@ module PayPal::SDK::Core
         @response['Allow'].split(',').map { |verb| verb.strip.downcase.to_sym }
       end
     end
+
+    # API error: returned as 200 + "error" key in response.
+    class UnsuccessfulApiCall < RuntimeError
+      attr_reader :api_error
+
+      def initialize(api_error)
+        super(api_error['message'])
+        @api_error = api_error
+      end
+    end
   end
 end

data/lib/paypal-sdk/rest/data_types.rb

@@ -33,9 +33,21 @@ module PayPal::SDK
           super
         end
 
+        def raise_error!
+          raise Core::Exceptions::UnsuccessfulApiCall, error if error
+        end
+
         def self.load_members
         end
 
+        def self.raise_on_api_error(*methods)
+          methods.each do |symbol|
+            define_method("#{symbol}!") {|*arg|
+              raise_error! unless send(symbol, *arg)
+            }
+          end
+        end
+
         class Number < Float
         end
       end
@@ -92,6 +104,20 @@ module PayPal::SDK
           success?
         end
 
+        raise_on_api_error :create, :update, :execute
+
+        def approval_url(immediate = false)
+          link = links.detect { |l| l.rel == 'approval_url' }
+          return nil unless link
+          link.href + (immediate ? '&useraction=commit' : '')
+        end
+
+        def token
+          url = approval_url
+          return nil unless url
+          CGI.parse(URI.parse(url).query)['token'].first
+        end
+
         class << self
           def find(resource_id)
             raise ArgumentError.new("id required") if resource_id.to_s.strip.empty?
@@ -245,6 +271,8 @@ module PayPal::SDK
           success?
         end
 
+        raise_on_api_error :create
+
         class << self
 
           def exch_token(auth_code)
@@ -334,6 +362,8 @@ module PayPal::SDK
           self.merge!(response)
           success?
         end
+
+        raise_on_api_error :create, :update, :delete
       end
 
       class Address < Base
@@ -446,6 +476,8 @@ module PayPal::SDK
           self.merge!(response)
           success?
         end
+
+        raise_on_api_error :create, :update, :delete
       end
 
       class ExtendedBankAccount < BankAccount
@@ -839,6 +871,8 @@ module PayPal::SDK
           self.merge!(response)
           success?
         end
+
+        raise_on_api_error :capture, :void, :reauthorize
       end
 
       class Order < Base
@@ -888,6 +922,8 @@ module PayPal::SDK
           response = api.post(path, self.to_hash, http_header)
           Authorization.new(response)
         end
+
+        raise_on_api_error :capture, :void, :authorize
       end
 
       class Capture < Base
@@ -1095,6 +1131,7 @@ module PayPal::SDK
           array_of  :items, InvoiceItem
           object_of :invoice_date, String
           object_of :payment_term, PaymentTerm
+          object_of :reference, String
           object_of :discount, Cost
           object_of :shipping_cost, ShippingCost
           object_of :custom, CustomAmount
@@ -1173,6 +1210,10 @@ module PayPal::SDK
           success?
         end
 
+        raise_on_api_error :create, :send_invoice, :remind, :cancel,
+                           :record_payment, :record_refund, :update, :delete
+
+
         #
         class << self
           def search(options, access_token = nil)
@@ -1287,7 +1328,8 @@ module PayPal::SDK
           end
 
           def get_expected_sig(transmission_id, timestamp, webhook_id, event_body)
-            crc = Zlib::crc32(event_body).to_s
+            utf8_encoded_event_body = event_body.encode("UTF-8")
+            crc = Zlib::crc32(utf8_encoded_event_body).to_s
             transmission_id + "|" + timestamp + "|" + webhook_id + "|" + crc
           end
 
@@ -1383,6 +1425,8 @@ module PayPal::SDK
           success?
         end
 
+        raise_on_api_error :update, :delete
+
         class << self
           def get(webhook_id)
             raise ArgumentError.new("webhook_id required") if webhook_id.to_s.strip.empty?
@@ -1772,6 +1816,8 @@ module PayPal::SDK
           success?
         end
 
+        raise_on_api_error :create, :update
+
         class << self
           def find(resource_id)
             raise ArgumentError.new("id required") if resource_id.to_s.strip.empty?
@@ -1989,6 +2035,9 @@ module PayPal::SDK
           success?
         end
 
+        raise_on_api_error :create, :execute, :update, :suspend, :re_activate,
+                           :cancel, :bill_balance, :set_balance
+
         class << self
           def transactions(agreement_id, start_date, end_date, options = {})
             path = "v1/payments/billing-agreements/#{agreement_id}/transactions" #?start-date=#{start_date}&end-date=#{end_date}"
@@ -2095,6 +2144,8 @@ module PayPal::SDK
           success?
         end
 
+        raise_on_api_error :update, :partial_update, :delete
+
         class << self
           def find(resource_id)
             raise ArgumentError.new("id required") if resource_id.to_s.strip.empty?

data/lib/paypal-sdk/rest/version.rb

@@ -1,7 +1,7 @@
 module PayPal
   module SDK
     module REST
-      VERSION = "1.4.7"
+      VERSION = "1.4.8"
     end
   end
 end

data/spec/payments_examples_spec.rb

@@ -24,6 +24,21 @@ describe "Payments" do
             "currency" =>  "USD" },
           "description" =>  "This is the payment transaction description." } ] }
 
+  PaymentAttributesPayPal = {
+        "intent" =>  "sale",
+        "payer" =>  {
+          "payment_method" =>  "paypal"
+        },
+        "redirect_urls" => {
+          "return_url" => 'https://localhost/return',
+          "cancel_url" => 'https://localhost/cancel',
+        },
+        "transactions" =>  [ {
+          "amount" =>  {
+            "total" =>  "1.00",
+            "currency" =>  "USD" },
+          "description" =>  "This is the payment transaction description." } ] }
+
   FuturePaymentAttributes = {
         "intent" =>  "authorize",
         "payer" =>  {
@@ -56,6 +71,8 @@ describe "Payments" do
         payment.create
         expect(payment.error).to be_nil
         expect(payment.id).not_to be_nil
+        expect(payment.approval_url).to be_nil
+        expect(payment.token).to be_nil
       end
 
       it "Create with request_id" do
@@ -91,6 +108,18 @@ describe "Payments" do
         expect(payment.id).not_to be_nil
       end
 
+      it "Create with redirect urls" do
+        payment = Payment.new(PaymentAttributesPayPal)
+        # Create
+        payment.create
+        expect(payment.error).to be_nil
+        expect(payment.id).not_to be_nil
+        expect(payment.approval_url).to include('webscr?cmd=_express-checkout')
+        expect(payment.approval_url).not_to include('useraction=commit')
+        expect(payment.approval_url(true)).to eq payment.approval_url + '&useraction=commit'
+        expect(payment.token).to match /^EC-[A-Z0-9]+$/
+      end
+
       it "List" do
         payment_history = Payment.all( "count" => 5 )
         expect(payment_history.error).to be_nil
@@ -163,7 +192,7 @@ describe "Payments" do
 
       it "Create a payment" do
         # put your PAYPAL-CLIENT-METADATA-ID
-        correlation_id = '' 
+        correlation_id = ''
         @future_payment = FuturePayment.new(FuturePaymentAttributes.merge( :token => access_token ))
         @future_payment.create(correlation_id)
         expect(@future_payment.error).to be_nil

data/spec/rest/data_types_spec.rb

@@ -0,0 +1,62 @@
+module PayPal::SDK::REST::DataTypes
+  describe Base do
+    let(:error_object) {
+      {
+        "name" => "INVALID_EXPERIENCE_PROFILE_ID",
+        "message" => "The requested experience profile ID was not found",
+        "information_link" => "https://developer.paypal.com/docs/api/#INVALID_EXPERIENCE_PROFILE_ID",
+        "debug_id" => "1562931a79fd2"
+      }
+    }
+
+    context '#raise_error!' do
+      context 'when there is error' do
+        subject { described_class.new(error: error_object) }
+
+        it 'raises error on request with all API information' do
+          expect { subject.raise_error! }
+            .to raise_error { |err|
+              expect(err).to be_a(PayPal::SDK::Core::Exceptions::UnsuccessfulApiCall)
+              expect(err.message).to eq("The requested experience profile ID was not found")
+              expect(err.api_error).to eq(error_object)
+            }
+        end
+      end
+
+      context 'when there is no error' do
+        subject { described_class.new(error: nil) }
+
+        it { expect { subject.raise_error! }.not_to raise_error }
+      end
+    end
+
+    context '.raise_on_api_error' do
+      let(:klass) {
+        Class.new(described_class) do
+          def some_call
+          end
+
+          raise_on_api_error :some_call
+        end
+      }
+
+      subject { klass.new }
+
+      context 'when call is successful' do
+        before {
+          expect(subject).to receive(:some_call).and_return(true)
+        }
+        it { expect { subject.some_call! }.not_to raise_error }
+      end
+
+      context 'when call is unsuccessful' do
+        before {
+          expect(subject).to receive(:some_call).and_return(false)
+          expect(subject).to receive(:error).twice.and_return(error_object)
+        }
+
+        it { expect { subject.some_call! }.to raise_error(PayPal::SDK::Core::Exceptions::UnsuccessfulApiCall) }
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -2,6 +2,8 @@ require 'bundler/setup'
 
 if ENV['COVERAGE']
   require 'simplecov'
+  require 'coveralls'
+  Coveralls.wear!
   SimpleCov.start do
     add_filter "/spec/"
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paypal-sdk-rest
 version: !ruby/object:Gem::Version
-  version: 1.4.7
+  version: 1.4.8
 platform: ruby
 authors:
 - PayPal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-20 00:00:00.000000000 Z
+date: 2016-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls
@@ -137,6 +137,7 @@ files:
 - spec/log/rest_http.log
 - spec/payments_examples_spec.rb
 - spec/payouts_examples_spec.rb
+- spec/rest/data_types_spec.rb
 - spec/spec_helper.rb
 - spec/subscription_examples_spec.rb
 - spec/support/sample_data.rb
@@ -182,6 +183,7 @@ test_files:
 - spec/log/rest_http.log
 - spec/payments_examples_spec.rb
 - spec/payouts_examples_spec.rb
+- spec/rest/data_types_spec.rb
 - spec/spec_helper.rb
 - spec/subscription_examples_spec.rb
 - spec/support/sample_data.rb