paypal-frete-facil 0.0.3 → 0.1.0

data/Gemfile

@@ -1,9 +1,11 @@
 source "http://rubygems.org"
 
-gem "nokogiri"
+gem "log-me", "~> 0.0.2"
+gem "nokogiri", "~> 1.4.6"
 
 group :development do
-  gem "rspec"
+  gem "rspec", "~> 2.6.0"
   gem "bundler", "~> 1.0.0"
-  gem "jeweler"
+  gem "jeweler", "~> 1.6.2"
+  gem "rcov", ">= 0"
 end

data/Gemfile.lock

@@ -7,8 +7,10 @@ GEM
       bundler (~> 1.0)
       git (>= 1.2.5)
       rake
+    log-me (0.0.2)
     nokogiri (1.4.6)
     rake (0.9.2)
+    rcov (0.9.10)
     rspec (2.6.0)
       rspec-core (~> 2.6.0)
       rspec-expectations (~> 2.6.0)
@@ -23,6 +25,8 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 1.0.0)
-  jeweler
-  nokogiri
-  rspec
+  jeweler (~> 1.6.2)
+  log-me (~> 0.0.2)
+  nokogiri (~> 1.4.6)
+  rcov
+  rspec (~> 2.6.0)

data/README.rdoc

@@ -1,11 +1,11 @@
 = paypal-frete-facil
 
-Cálculo de frete através do Frete Fácil do PayPal.
+Cálculo de frete através do PayPal Frete Fácil (http://www.paypal-brasil.com.br/fretefacil/).
 
 == Instalando
 
 === Gemfile
-  gem 'paypal-frete-facil'
+  gem 'paypal-frete-facil', '~> 0.1.0'
 
 === Instalação direta
   $ gem install paypal-frete-facil
@@ -22,8 +22,43 @@ Cálculo de frete através do Frete Fácil do PayPal.
                                         :profundidade => 30,
                                         :peso => 0.3
 
-  frete.calcular  # => 13.873999999999999
-  frete.calculate # => 13.873999999999999
+  frete.calcular  # => 13.87
+  frete.calculate # => 13.87
+
+
+== Log
+
+Por padrão, cada chamada ao Web Service do PayPal Frete Fácil é logada em STDOUT, usando a gem {LogMe}[http://github.com/prodis/log-me].
+
+Para desabilitar o log ou configurar um outro mecanismo de log, você pode configurar o módulo PayPal::FreteFacil.
+
+  PayPal::FreteFacil.configure do |config|
+    config.log_enabled = false   # Desabilita o log
+    config.log_level = :debug    # Altera o nível do log
+    config.logger = Rails.logger # Usa o logger do Rails
+  end
+
+Exemplo de log:
+  I, [2011-08-29T22:00:52.624430 #2186]  INFO -- : PayPal-Frete-Facil Request:
+  https://ff.paypal-brasil.com.br/FretesPayPalWS/WSFretesPayPal
+  accept: */*
+  user-agent: Ruby
+  content-type: text/xml; charset=utf-8
+  soapaction: https://ff.paypal-brasil.com.br/FretesPayPalWS/WSFretesPayPal/getPreco
+  <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:frete="https://ff.paypal-brasil.com.br/FretesPayPalWS"><soapenv:Header /><soapenv:Body><frete:getPreco><cepOrigem>04094-050</cepOrigem><cepDestino>90619-900</cepDestino><largura>15</largura><altura>2</altura><profundidade>30</profundidade><peso>0.3</peso></frete:getPreco></soapenv:Body></soapenv:Envelope>
+
+  I, [2011-08-29T22:00:53.917895 #2186]  INFO -- : PayPal-Frete-Facil Response:
+  HTTP/1.1 200 OK
+  date: Tue, 30 Aug 2011 01:00:52 GMT
+  server: Apache/2.2.17 (Unix) mod_ssl/2.2.17 OpenSSL/0.9.8e-fips-rhel5 DAV/2 mod_jk/1.2.30
+  content-length: 271
+  content-type: text/xml;charset=utf-8
+  set-cookie: ROUTEID=.2; path=/
+  connection: close
+  <?xml version='1.0' encoding='UTF-8'?><S:Envelope xmlns:S="http://schemas.xmlsoap.org/soap/envelope/"><S:Body><ns2:getPrecoResponse xmlns:ns2="https://ff.paypal-brasil.com.br/FretesPayPalWS"><return>13.873999999999999</return></ns2:getPrecoResponse></S:Body></S:Envelope>
+
+
+== Informações adicionais
 
 === Maneiras de configurar atributos no construtor de Correios::Frete::Calculador
 

data/lib/paypal-frete-facil.rb

@@ -1,5 +1,6 @@
 # encoding: UTF-8
 require 'rubygems'
+require 'paypal/fretefacil'
 require 'paypal/fretefacil/frete'
 require 'paypal/fretefacil/parser'
 require 'paypal/fretefacil/web_service'

data/lib/paypal/fretefacil.rb

@@ -0,0 +1,8 @@
+# encoding: UTF-8
+require 'log-me'
+
+module PayPal
+  module FreteFacil
+    extend LogMe
+  end
+end

data/lib/paypal/fretefacil/frete.rb

@@ -5,6 +5,7 @@ module PayPal
       attr_accessor :cep_origem, :cep_destino
       attr_accessor :largura, :altura, :profundidade
       attr_accessor :peso
+      attr_writer :web_service, :parser
 
       DEFAULT_OPTIONS = {
         :largura => 0,

data/lib/paypal/fretefacil/parser.rb

@@ -5,7 +5,7 @@ module PayPal
   module FreteFacil
     class Parser
       def parse(xml)
-        Nokogiri::XML(xml).root.elements.children.children.children.text.to_f
+        Nokogiri::XML(xml).xpath("//return").text.to_f.round(2)
       end
     end
   end

data/lib/paypal/fretefacil/version.rb

@@ -3,8 +3,8 @@ module PayPal
   module FreteFacil
     module Version
       MAJOR = 0
-      MINOR = 0
-      PATCH = 3
+      MINOR = 1
+      PATCH = 0
       VERSION = [MAJOR, MINOR, PATCH].join(".")
     end
   end

data/lib/paypal/fretefacil/web_service.rb

@@ -21,8 +21,7 @@ module PayPal
         request["SoapAction"] = "#{URL}/getPreco"
         request.body = request_body_for(frete)
 
-        response = http.request(request)
-        response.body
+        with_log(request) { http.request(request) }
       end
 
       private
@@ -42,6 +41,35 @@ module PayPal
           "</soapenv:Body>" +
         "</soapenv:Envelope>"
       end
+
+      def with_log(request)
+        PayPal::FreteFacil.log format_request_message(request)
+        response = yield
+        PayPal::FreteFacil.log format_response_message(response)
+        response.body
+      end
+
+      def format_request_message(request)
+        message =  with_line_break { "PayPal-Frete-Facil Request:" }
+        message << with_line_break { URL }
+        message << with_line_break { format_headers_for(request) }
+        message << with_line_break { request.body }
+      end
+
+      def format_response_message(response)
+        message =  with_line_break { "PayPal-Frete-Facil Response:" }
+        message << with_line_break { "HTTP/#{response.http_version} #{response.code} #{response.message}" }
+        message << with_line_break { format_headers_for(response) }
+        message << with_line_break { response.body }
+      end
+
+      def format_headers_for(http)
+        http.each_header.map { |name, value| "#{name}: #{value}" }.join("\n")
+      end
+
+      def with_line_break
+        "#{yield}\n"
+      end
     end
   end
 end

data/paypal-frete-facil.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{paypal-frete-facil}
-  s.version = "0.0.3"
+  s.version = "0.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Prodis a.k.a. Fernando Hamasaki"]
-  s.date = %q{2011-08-22}
+  s.date = %q{2011-08-29}
   s.description = %q{Cálculo de frete utilizando o Web Service do Frete Fácil do PayPal.}
   s.email = %q{prodis@gmail.com}
   s.extra_rdoc_files = [
@@ -23,12 +23,14 @@ Gem::Specification.new do |s|
     "README.rdoc",
     "Rakefile",
     "lib/paypal-frete-facil.rb",
+    "lib/paypal/fretefacil.rb",
     "lib/paypal/fretefacil/frete.rb",
     "lib/paypal/fretefacil/parser.rb",
     "lib/paypal/fretefacil/version.rb",
     "lib/paypal/fretefacil/web_service.rb",
     "paypal-frete-facil.gemspec",
-    "spec/paypal-frete-facil_spec.rb",
+    "spec/paypal/fretefacil/frete_spec.rb",
+    "spec/paypal/fretefacil/parser_spec.rb",
     "spec/spec_helper.rb"
   ]
   s.homepage = %q{http://github.com/prodis/paypal-frete-facil}
@@ -42,21 +44,27 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<nokogiri>, [">= 0"])
-      s.add_development_dependency(%q<rspec>, [">= 0"])
+      s.add_runtime_dependency(%q<log-me>, ["~> 0.0.2"])
+      s.add_runtime_dependency(%q<nokogiri>, ["~> 1.4.6"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.6.0"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_development_dependency(%q<jeweler>, [">= 0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.6.2"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
     else
-      s.add_dependency(%q<nokogiri>, [">= 0"])
-      s.add_dependency(%q<rspec>, [">= 0"])
+      s.add_dependency(%q<log-me>, ["~> 0.0.2"])
+      s.add_dependency(%q<nokogiri>, ["~> 1.4.6"])
+      s.add_dependency(%q<rspec>, ["~> 2.6.0"])
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_dependency(%q<jeweler>, [">= 0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.6.2"])
+      s.add_dependency(%q<rcov>, [">= 0"])
     end
   else
-    s.add_dependency(%q<nokogiri>, [">= 0"])
-    s.add_dependency(%q<rspec>, [">= 0"])
+    s.add_dependency(%q<log-me>, ["~> 0.0.2"])
+    s.add_dependency(%q<nokogiri>, ["~> 1.4.6"])
+    s.add_dependency(%q<rspec>, ["~> 2.6.0"])
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-    s.add_dependency(%q<jeweler>, [">= 0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.6.2"])
+    s.add_dependency(%q<rcov>, [">= 0"])
   end
 end
 

data/spec/paypal/fretefacil/frete_spec.rb

@@ -0,0 +1,59 @@
+# encoding: UTF-8
+require 'spec_helper'
+
+describe PayPal::FreteFacil::Frete do
+  describe ".new" do
+    context "create with default value of" do
+      before(:each) { @frete = PayPal::FreteFacil::Frete.new }
+
+      { :largura => 0,
+        :altura => 0,
+        :profundidade => 0,
+        :peso => 0.0
+      }.each do |attr, value|
+        it attr do
+          @frete.send(attr).should == value
+        end
+      end
+    end
+
+    { :cep_origem => "01000-000",
+      :cep_destino => "021222-222",
+      :largura => 15,
+      :altura => 2,
+      :profundidade => 30,
+      :peso => 0.321,
+      :web_service => PayPal::FreteFacil::WebService.new,
+      :parser => PayPal::FreteFacil::Parser.new
+    }.each do |attr, value|
+      context "when #{attr} is supplied" do
+        it "sets #{attr}" do
+          @frete = PayPal::FreteFacil::Frete.new(attr => value)
+          @frete.send(attr).should == value
+        end
+      end
+
+      context "when #{attr} is supplied in a block" do
+        it "sets #{attr}" do
+          @frete = PayPal::FreteFacil::Frete.new { |f| f.send("#{attr}=", value) }
+          @frete.send(attr).should == value
+        end
+      end
+    end
+  end
+
+  describe "#calcular" do
+    before :each do
+      web_service = PayPal::FreteFacil::WebService.new
+      parser = PayPal::FreteFacil::Parser.new
+      @frete = PayPal::FreteFacil::Frete.new(:web_service => web_service, :parser => parser)
+      
+      web_service.stub(:request).with(@frete).and_return('<?xml version="1.0" encoding="UTF-8"?><S:Envelope xmlns:S="http://schemas.xmlsoap.org/soap/envelope/"><S:Body><ns2:getPrecoResponse xmlns:ns2="https://ff.paypal-brasil.com.br/FretesPayPalWS"><return>8.19</return></ns2:getPrecoResponse></S:Body></S:Envelope>')
+      parser.stub(:parser).and_return(8.19)
+    end
+
+    it "returns shipping price" do
+      @frete.calcular.should == 8.19
+    end
+  end
+end

data/spec/paypal/fretefacil/parser_spec.rb

@@ -0,0 +1,43 @@
+# encoding: UTF-8
+require 'spec_helper'
+
+describe PayPal::FreteFacil::Parser do
+  describe "#parse" do
+    before(:each) { @parser = PayPal::FreteFacil::Parser.new }
+
+    context "when XML is correct" do
+      it "returns shipping price" do
+        xml = """<?xml version=\"1.0\" encoding=\"UTF-8\"?>
+                 <S:Envelope xmlns:S=\"http://schemas.xmlsoap.org/soap/envelope/\">
+                   <S:Body>
+                     <ns2:getPrecoResponse xmlns:ns2=\"https://ff.paypal-brasil.com.br/FretesPayPalWS\">
+                       <return>8.19</return>
+                     </ns2:getPrecoResponse>
+                   </S:Body>
+                 </S:Envelope>"""
+        @parser.parse(xml).should == 8.19
+      end
+
+      context "and shipping price has more then two decimal places" do
+        it "returns shipping price rounded to two decimal places" do
+          xml = """<?xml version=\"1.0\" encoding=\"UTF-8\"?>
+                   <S:Envelope xmlns:S=\"http://schemas.xmlsoap.org/soap/envelope/\">
+                     <S:Body>
+                       <ns2:getPrecoResponse xmlns:ns2=\"https://ff.paypal-brasil.com.br/FretesPayPalWS\">
+                         <return>8.2261234567</return>
+                       </ns2:getPrecoResponse>
+                     </S:Body>
+                   </S:Envelope>"""
+          @parser.parse(xml).should == 8.23
+        end
+      end
+    end
+
+    context "when XML is not correct" do
+      it "returns zero" do
+        xml = "<error>Error message.</error>"
+        @parser.parse(xml).should be_zero
+      end
+    end
+  end
+end

metadata

@@ -2,7 +2,7 @@
 name: paypal-frete-facil
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors: 
 - Prodis a.k.a. Fernando Hamasaki
@@ -10,45 +10,67 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-22 00:00:00 -03:00
+date: 2011-08-29 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: nokogiri
+  name: log-me
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        version: "0"
+        version: 0.0.2
   type: :runtime
   prerelease: false
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  name: nokogiri
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        version: "0"
-  type: :development
+        version: 1.4.6
+  type: :runtime
   prerelease: false
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: bundler
+  name: rspec
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 1.0.0
+        version: 2.6.0
   type: :development
   prerelease: false
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: jeweler
+  name: bundler
   requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: jeweler
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 1.6.2
+  type: :development
+  prerelease: false
+  version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: rcov
+  requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -56,7 +78,7 @@ dependencies:
         version: "0"
   type: :development
   prerelease: false
-  version_requirements: *id004
+  version_requirements: *id006
 description: "C\xC3\xA1lculo de frete utilizando o Web Service do Frete F\xC3\xA1cil do PayPal."
 email: prodis@gmail.com
 executables: []
@@ -73,12 +95,14 @@ files:
 - README.rdoc
 - Rakefile
 - lib/paypal-frete-facil.rb
+- lib/paypal/fretefacil.rb
 - lib/paypal/fretefacil/frete.rb
 - lib/paypal/fretefacil/parser.rb
 - lib/paypal/fretefacil/version.rb
 - lib/paypal/fretefacil/web_service.rb
 - paypal-frete-facil.gemspec
-- spec/paypal-frete-facil_spec.rb
+- spec/paypal/fretefacil/frete_spec.rb
+- spec/paypal/fretefacil/parser_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
 homepage: http://github.com/prodis/paypal-frete-facil

data/spec/paypal-frete-facil_spec.rb

@@ -1,7 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
-
-describe "PaypalFreteFacil" do
-  it "fails" do
-    fail "hey buddy, you should probably rename this file and start specing for real"
-  end
-end