paypal-express 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8bdf6de40dccab7020f6aec90598360e9ef5a4c
-  data.tar.gz: 58a4ab67ab38a81f6ca04c806c0771657b9b6455
+  metadata.gz: a7f72f535c8cd6e0b76346fb390c07371a0622c1
+  data.tar.gz: 9028bbaaded2cd53c0f63b4b027ac8a0e228165a
 SHA512:
-  metadata.gz: 5a0cc3dd83e0d42ac61b0ed5cef08a700b17b1b30fa45605645ef7a45e1b0dcffd81487ca62398dc99bdeb680b6e5771b4cf3f0029bfa74ba1f5803673884ff0
-  data.tar.gz: b2b16f82df3015e6c2e807c53a9e0b14d6c4019ab75db0cfc780379f8f63dd0ec0caae38f0983789b4cd6610e74472272bb7b2ed7e560a33cda0e6761612e819
+  metadata.gz: defabc0e45346b1a6d2e0988caedfbe0312c3f85ac4381c9efbaf0db5a8209d967d3bb4a19c8d36cf17f8cd1ae41aaf97d2c4f6d9bc2315e363884755c1074d7
+  data.tar.gz: 1398ae44f8c36d17778d832f264b12ba4c2d397ac56f11a4d428235bf250b7e8fb28c68d33060ef8751f787894b399752e32bdd28e263a883c478baba301d91c

data/.gitignore

@@ -19,3 +19,4 @@ rdoc
 pkg
 
 ## PROJECT::SPECIFIC
+Gemfile.lock

data/VERSION

@@ -1 +1 @@
-0.6.0
+0.7.0

data/lib/paypal.rb

@@ -75,7 +75,7 @@ require 'paypal/payment/response/item'
 require 'paypal/payment/response/payer'
 require 'paypal/payment/response/reference'
 require 'paypal/payment/response/refund'
-require 'paypal/payment/response/ship_to'
+require 'paypal/payment/response/address'
 require 'paypal/payment/recurring'
 require 'paypal/payment/recurring/activation'
 require 'paypal/payment/recurring/billing'

data/lib/paypal/express/request.rb

@@ -69,6 +69,16 @@ module Paypal
         Response.new response
       end
 
+      def void!(authorization_id, params={})
+        params = {
+          :AUTHORIZATIONID => authorization_id,
+          :NOTE => params[:note]
+        }
+
+        response = self.request :DoVoid, params
+        Response.new response
+      end
+
       # Recurring Payment Specific
 
       def subscribe!(token, recurring_profile)
@@ -128,7 +138,7 @@ module Paypal
 
       def agreement(reference_id)
         params = {
-          :REFERENCEID => reference_id,
+          :REFERENCEID => reference_id
         }
         response = self.request :BillAgreementUpdate, params
         Response.new response

data/lib/paypal/nvp/response.rb

@@ -38,7 +38,7 @@ module Paypal
       }
       attr_accessor *@@attribute_mapping.values
       attr_accessor :shipping_options_is_default, :success_page_redirect_requested, :insurance_option_selected
-      attr_accessor :amount, :description, :ship_to, :payer, :recurring, :billing_agreement, :refund
+      attr_accessor :amount, :description, :ship_to, :bill_to, :payer, :recurring, :billing_agreement, :refund
       attr_accessor :payment_responses, :payment_info, :items
 
       def initialize(attributes = {})
@@ -59,7 +59,7 @@ module Paypal
           :tax => attrs.delete(:TAXAMT),
           :fee => attrs.delete(:FEEAMT)
         )
-        @ship_to = Payment::Response::ShipTo.new(
+        @ship_to = Payment::Response::Address.new(
           :owner => attrs.delete(:SHIPADDRESSOWNER),
           :status => attrs.delete(:SHIPADDRESSSTATUS),
           :name => attrs.delete(:SHIPTONAME),
@@ -71,13 +71,25 @@ module Paypal
           :country_code => attrs.delete(:SHIPTOCOUNTRYCODE),
           :country_name => attrs.delete(:SHIPTOCOUNTRYNAME)
         )
+        @bill_to = Payment::Response::Address.new(
+          :owner => attrs.delete(:ADDRESSID),
+          :status => attrs.delete(:ADDRESSSTATUS),
+          :name => attrs.delete(:BILLINGNAME),
+          :zip => attrs.delete(:ZIP),
+          :street => attrs.delete(:STREET),
+          :street2 => attrs.delete(:STREET2),
+          :city => attrs.delete(:CITY),
+          :state => attrs.delete(:STATE),
+          :country_code => attrs.delete(:COUNTRY)
+        )
         if attrs[:PAYERID]
           @payer = Payment::Response::Payer.new(
             :identifier => attrs.delete(:PAYERID),
             :status => attrs.delete(:PAYERSTATUS),
             :first_name => attrs.delete(:FIRSTNAME),
             :last_name => attrs.delete(:LASTNAME),
-            :email => attrs.delete(:EMAIL)
+            :email => attrs.delete(:EMAIL),
+            :company => attrs.delete(:BUSINESS)
           )
         end
         if attrs[:PROFILEID]

data/lib/paypal/payment/response.rb

@@ -1,7 +1,7 @@
 module Paypal
   module Payment
     class Response < Base
-      attr_accessor :amount, :ship_to, :description, :note, :items, :notify_url, :insurance_option_offered, :currency_code, :short_message, :long_message, :error_code, :severity_code, :ack, :transaction_id, :billing_agreement_id, :request_id, :seller_id
+      attr_accessor :amount, :ship_to, :bill_to, :description, :note, :items, :notify_url, :insurance_option_offered, :currency_code, :short_message, :long_message, :error_code, :severity_code, :ack, :transaction_id, :billing_agreement_id, :request_id, :seller_id
 
       def initialize(attributes = {})
         attrs = attributes.dup
@@ -14,7 +14,7 @@ module Paypal
           :shipping => attrs.delete(:SHIPPINGAMT),
           :tax => attrs.delete(:TAXAMT)
         )
-        @ship_to = Payment::Response::ShipTo.new(
+        @ship_to = Payment::Response::Address.new(
           :name => attrs.delete(:SHIPTONAME),
           :zip => attrs.delete(:SHIPTOZIP),
           :street => attrs.delete(:SHIPTOSTREET),
@@ -24,6 +24,17 @@ module Paypal
           :country_code => attrs.delete(:SHIPTOCOUNTRYCODE),
           :country_name => attrs.delete(:SHIPTOCOUNTRYNAME)
         )
+        @bill_to = Payment::Response::Address.new(
+          :owner => attrs.delete(:ADDRESSID),
+          :status => attrs.delete(:ADDRESSSTATUS),
+          :name => attrs.delete(:BILLINGNAME),
+          :zip => attrs.delete(:ZIP),
+          :street => attrs.delete(:STREET),
+          :street2 => attrs.delete(:STREET2),
+          :city => attrs.delete(:CITY),
+          :state => attrs.delete(:STATE),
+          :country_code => attrs.delete(:COUNTRY)
+        )
         @description = attrs.delete(:DESC)
         @note = attrs.delete(:NOTETEXT)
         @notify_url = attrs.delete(:NOTIFYURL)

data/lib/paypal/payment/response/{ship_to.rb → address.rb}

@@ -1,6 +1,6 @@
 module Paypal
   module Payment
-    class Response::ShipTo < Base
+    class Response::Address < Base
       attr_optional :owner, :status, :name, :zip, :street, :street2, :city, :state, :country_code, :country_name
     end
   end

data/lib/paypal/payment/response/payer.rb

@@ -1,7 +1,7 @@
 module Paypal
   module Payment
     class Response::Payer < Base
-      attr_optional :identifier, :status, :first_name, :last_name, :email
+      attr_optional :identifier, :status, :first_name, :last_name, :email, :company
     end
   end
 end

data/spec/fake_response/DoVoid/success.txt

@@ -0,0 +1 @@
+ACK=Success&AUTHORIZATIONID=1a2b3c4d5e6f&BUILD=13055236&TIMESTAMP=2014-10-03T17%3A34%3A56Z

data/spec/paypal/express/request_spec.rb

@@ -287,6 +287,26 @@ describe Paypal::Express::Request do
     end
   end
 
+  describe "#void!" do
+    it 'should return Paypal::Express::Response' do
+      fake_response 'DoVoid/success'
+      response = instance.void! 'authorization_id', note: "note"
+      response.should be_instance_of Paypal::Express::Response
+    end
+
+    it 'should call DoVoid' do
+      expect do
+        instance.void! 'authorization_id', note: "note"
+      end.to request_to nvp_endpoint, :post
+
+      instance._method_.should == :DoVoid
+      instance._sent_params_.should == {
+        :AUTHORIZATIONID => 'authorization_id',
+        :NOTE => "note"
+      }
+    end
+  end
+
   describe '#checkout!' do
     it 'should return Paypal::Express::Response' do
       fake_response 'DoExpressCheckoutPayment/success'

data/spec/paypal/payment/response/{ship_to_spec.rb → address_spec.rb}

@@ -1,13 +1,13 @@
 require 'spec_helper.rb'
 
-describe Paypal::Payment::Response::ShipTo do
+describe Paypal::Payment::Response::Address do
   let :keys do
-    Paypal::Payment::Response::ShipTo.optional_attributes
+    Paypal::Payment::Response::Address.optional_attributes
   end
 
   describe '.new' do
     it 'should allow nil for attributes' do
-      payer = Paypal::Payment::Response::ShipTo.new
+      payer = Paypal::Payment::Response::Address.new
       keys.each do |key|
         payer.send(key).should be_nil
       end
@@ -17,7 +17,7 @@ describe Paypal::Payment::Response::ShipTo do
       attributes = keys.inject({}) do |attributes, key|
         attributes.merge!(key => "xyz")
       end
-      payer = Paypal::Payment::Response::ShipTo.new attributes
+      payer = Paypal::Payment::Response::Address.new attributes
       keys.each do |key|
         payer.send(key).should == "xyz"
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paypal-express
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - nov matake
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-12 00:00:00.000000000 Z
+date: 2014-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -145,12 +145,12 @@ files:
 - lib/paypal/payment/request.rb
 - lib/paypal/payment/request/item.rb
 - lib/paypal/payment/response.rb
+- lib/paypal/payment/response/address.rb
 - lib/paypal/payment/response/info.rb
 - lib/paypal/payment/response/item.rb
 - lib/paypal/payment/response/payer.rb
 - lib/paypal/payment/response/reference.rb
 - lib/paypal/payment/response/refund.rb
-- lib/paypal/payment/response/ship_to.rb
 - lib/paypal/util.rb
 - paypal-express.gemspec
 - spec/fake_response/BillAgreementUpdate/fetch.txt
@@ -166,6 +166,7 @@ files:
 - spec/fake_response/DoExpressCheckoutPayment/success_with_many_items.txt
 - spec/fake_response/DoReferenceTransaction/failure.txt
 - spec/fake_response/DoReferenceTransaction/success.txt
+- spec/fake_response/DoVoid/success.txt
 - spec/fake_response/GetExpressCheckoutDetails/failure.txt
 - spec/fake_response/GetExpressCheckoutDetails/success.txt
 - spec/fake_response/GetExpressCheckoutDetails/with_billing_accepted_status.txt
@@ -193,10 +194,10 @@ files:
 - spec/paypal/payment/recurring_spec.rb
 - spec/paypal/payment/request/item_spec.rb
 - spec/paypal/payment/request_spec.rb
+- spec/paypal/payment/response/address_spec.rb
 - spec/paypal/payment/response/info_spec.rb
 - spec/paypal/payment/response/item_spec.rb
 - spec/paypal/payment/response/payer_spec.rb
-- spec/paypal/payment/response/ship_to_spec.rb
 - spec/paypal/payment/response_spec.rb
 - spec/paypal/util_spec.rb
 - spec/spec_helper.rb
@@ -239,6 +240,7 @@ test_files:
 - spec/fake_response/DoExpressCheckoutPayment/success_with_many_items.txt
 - spec/fake_response/DoReferenceTransaction/failure.txt
 - spec/fake_response/DoReferenceTransaction/success.txt
+- spec/fake_response/DoVoid/success.txt
 - spec/fake_response/GetExpressCheckoutDetails/failure.txt
 - spec/fake_response/GetExpressCheckoutDetails/success.txt
 - spec/fake_response/GetExpressCheckoutDetails/with_billing_accepted_status.txt
@@ -266,10 +268,10 @@ test_files:
 - spec/paypal/payment/recurring_spec.rb
 - spec/paypal/payment/request/item_spec.rb
 - spec/paypal/payment/request_spec.rb
+- spec/paypal/payment/response/address_spec.rb
 - spec/paypal/payment/response/info_spec.rb
 - spec/paypal/payment/response/item_spec.rb
 - spec/paypal/payment/response/payer_spec.rb
-- spec/paypal/payment/response/ship_to_spec.rb
 - spec/paypal/payment/response_spec.rb
 - spec/paypal/util_spec.rb
 - spec/spec_helper.rb