payola-payments 1.3.0 → 1.3.1

data/spec/services/payola/#start_subscription_spec.rb#

@@ -0,0 +1,95 @@
+require 'spec_helper'
+
+module Payola
+  describe StartSubscription do
+    let(:stripe_helper) { StripeMock.create_test_helper }
+    let(:token){ StripeMock.generate_card_token({}) }
+    let(:user){ User.create }
+
+    describe "#call" do
+      it "should create a customer" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token)
+        StartSubscription.call(subscription)
+        expect(subscription.reload.stripe_customer_id).to_not be_nil
+      end
+      it "should capture credit card info" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token)
+        StartSubscription.call(subscription)
+        expect(subscription.reload.stripe_id).to_not be_nil
+        expect(subscription.reload.card_last4).to_not be_nil
+        expect(subscription.reload.card_expiration).to_not be_nil
+        expect(subscription.reload.card_type).to_not be_nil
+      end
+
+      it "should pass through coupon code" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token, coupon: 'test')
+        StartSubscription.call(subscription)
+        expect(subscription.reload.stripe_id).to_not be_nil
+        sub = Stripe::Customer.retrieve(subscription.stripe_customer_id).subscriptions.retrieve(subscription.stripe_id)
+      end
+
+      describe "on error" do
+        it "should update the error attribute" do
+          StripeMock.prepare_card_error(:card_declined, :new_customer)
+          plan = create(:subscription_plan)
+          subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token)
+          StartSubscription.call(subscription)
+          expect(subscription.reload.error).to_not be_nil
+          expect(subscription.errored?).to be true
+        end
+      end
+
+      it "should re-use an existing customer" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token, owner: user)
+        StartSubscription.call(subscription)
+        CancelSubscription.call(subscription)
+
+        subscription2 = create(:subscription, state: 'processing', plan: plan, owner: user)
+        StartSubscription.call(subscription2)
+        expect(subscription2.reload.stripe_customer_id).to_not be_nil
+        expect(subscription2.reload.stripe_customer_id).to eq subscription.reload.stripe_customer_id
+      end
+
+      it "should not re-use an existing customer that has been deleted" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token, owner: user)
+        StartSubscription.call(subscription)
+        deleted_customer_id = subscription.reload.stripe_customer_id
+        Stripe::Customer.retrieve(deleted_customer_id).delete
+
+        subscription2 = create(:subscription, state: 'processing', plan: plan, owner: user)
+        StartSubscription.call(subscription2)
+        expect(subscription2.reload.stripe_customer_id).to_not be_nil
+        expect(subscription2.reload.stripe_customer_id).to_not eq deleted_customer_id
+      end
+
+      it "should create an invoice item with a setup fee" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token, owner: user, setup_fee: 100)
+        StartSubscription.call(subscription)
+
+        ii = Stripe::InvoiceItem.all(customer: subscription.stripe_customer_id).first
+        expect(ii).to_not be_nil
+        expect(ii.amount).to eq 100
+        expect(ii.description).to eq "Setup Fee"
+      end
+
+      it "should allow the plan to override the setup fee description" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token, owner: user, setup_fee: 100)
+
+        expect(plan).to receive(:setup_fee_description).with(subscription).and_return('Random Mystery Fee')
+        StartSubscription.call(subscription)
+
+        ii = Stripe::InvoiceItem.all(customer: subscription.stripe_customer_id).first
+        expect(ii).to_not be_nil
+        expect(ii.amount).to eq 100
+        expect(ii.description).to eq 'Random Mystery Fee'
+      end
+    end
+  end
+end

data/spec/services/payola/change_subscription_quantity_spec.rb

@@ -5,13 +5,17 @@ module Payola
     let(:stripe_helper) { StripeMock.create_test_helper }
 
     describe "#call" do
-      before do
+      before(:each) do
         @plan = create(:subscription_plan)
+        expect(@plan.errors).to be_blank
 
         token = StripeMock.generate_card_token({})
-        @subscription = create(:subscription, quantity: 1, stripe_token: token)
+        @subscription = create(:subscription, quantity: 1, stripe_token: token, plan: @plan, state: 'processing')
         StartSubscription.call(@subscription)
-        Payola::ChangeSubscriptionQuantity.call(@subscription, 2)
+        expect(@subscription.error).to be_nil
+        expect(@subscription.active?).to be_truthy
+        @subscription = Payola::ChangeSubscriptionQuantity.call(@subscription, 2)
+        expect(@subscription.errors).to be_blank
       end
 
       it "should change the quantity on the stripe subscription" do

data/spec/services/payola/start_subscription_spec.rb

@@ -45,6 +45,19 @@ module Payola
         expect(subscription2.reload.stripe_customer_id).to eq subscription.reload.stripe_customer_id
       end
 
+      it "should not re-use an existing customer that has been deleted" do
+        plan = create(:subscription_plan)
+        subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token, owner: user)
+        StartSubscription.call(subscription)
+        deleted_customer_id = subscription.reload.stripe_customer_id
+        Stripe::Customer.retrieve(deleted_customer_id).delete
+
+        subscription2 = create(:subscription, state: 'processing', plan: plan, owner: user)
+        StartSubscription.call(subscription2)
+        expect(subscription2.reload.stripe_customer_id).to_not be_nil
+        expect(subscription2.reload.stripe_customer_id).to_not eq deleted_customer_id
+      end
+
       it "should create an invoice item with a setup fee" do
         plan = create(:subscription_plan)
         subscription = create(:subscription, state: 'processing', plan: plan, stripe_token: token, owner: user, setup_fee: 100)
@@ -66,7 +79,7 @@ module Payola
         ii = Stripe::InvoiceItem.all(customer: subscription.stripe_customer_id).first
         expect(ii).to_not be_nil
         expect(ii.amount).to eq 100
-        expect(ii.description).to eq 'Random Mystery Fee'        
+        expect(ii.description).to eq 'Random Mystery Fee'
       end
     end
   end

data/spec/services/payola/update_card_spec.rb

@@ -9,8 +9,10 @@ module Payola
         @plan = create(:subscription_plan)
 
         token = StripeMock.generate_card_token({})
-        @subscription = create(:subscription, plan: @plan, stripe_token: token)
+        @subscription = create(:subscription, plan: @plan, stripe_token: token, state: 'processing')
         StartSubscription.call(@subscription)
+        expect(@subscription.error).to be_nil
+        expect(@subscription.active?).to be_truthy
         token2 = StripeMock.generate_card_token({last4: '2233', exp_year: '2021', exp_month: '11', brand: 'JCB'})
         Payola::UpdateCard.call(@subscription, token2)
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: payola-payments
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Pete Keen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-01 00:00:00.000000000 Z
+date: 2015-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -42,14 +42,14 @@ dependencies:
   name: stripe
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
         version: 1.20.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
         version: 1.20.1
 - !ruby/object:Gem::Dependency
@@ -198,6 +198,7 @@ files:
 - app/models/payola/sale.rb
 - app/models/payola/stripe_webhook.rb
 - app/models/payola/subscription.rb
+- app/services/payola/#update_card.rb#
 - app/services/payola/cancel_subscription.rb
 - app/services/payola/change_subscription_plan.rb
 - app/services/payola/change_subscription_quantity.rb
@@ -374,6 +375,7 @@ files:
 - spec/models/payola/stripe_webhook_spec.rb
 - spec/models/payola/subscription_spec.rb
 - spec/payola_spec.rb
+- spec/services/payola/#start_subscription_spec.rb#
 - spec/services/payola/cancel_subscription_spec.rb
 - spec/services/payola/change_subscription_plan_spec.rb
 - spec/services/payola/change_subscription_quantity_spec.rb
@@ -524,6 +526,7 @@ test_files:
 - spec/models/payola/stripe_webhook_spec.rb
 - spec/models/payola/subscription_spec.rb
 - spec/payola_spec.rb
+- spec/services/payola/#start_subscription_spec.rb#
 - spec/services/payola/cancel_subscription_spec.rb
 - spec/services/payola/change_subscription_plan_spec.rb
 - spec/services/payola/change_subscription_quantity_spec.rb