paymob_accept 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 519375883a2c35dd6406dc2aee7e471f3525905ded1faee4c286d9d4518014aa
-  data.tar.gz: dbb89c1765419b3114e0366302494097dae654d13fc9d0bdf20794420230b07e
+  metadata.gz: 9be4b1690f4a848451740b6b49bed06814dece0eb6cfc8d4bebb8e0445fbd86f
+  data.tar.gz: 94ab14e1b12819055f982b23e29e5fb7c8f4a35b87ed18d2f8a122ff5aca2a45
 SHA512:
-  metadata.gz: 0e9bb8812b46f509a9ccbb96bfc97a140726fb360e044980eec42bad30828575e457361ba5a61df608324021bdf58424815c7ef828dad7909322b20ffdaae3a4
-  data.tar.gz: 7d2811bd93ee7c9a43492c984fa8a5c237929b64ad1f3393bb528f24f489d666427fccff34d15d914f55002e8e52cbce7501b7efa1aad9006b03467fafde577d
+  metadata.gz: 86ab02b708a4415b8c1cb4a17d96f7e303472a431653b449c7805a0ae884c512930929c8db34045ab83f470f63f819c0f130acb68bef2e7de594aaa913867353
+  data.tar.gz: d846e0ccf9ad28d591f923c56193e25d98a073794ec3da2c13dbcd7db6bc2815606a1432422dc4f340119378260571e0785ba706b65c22cb7e619a38efc3917f

data/CODE_OF_CONDUCT.md

@@ -2,73 +2,83 @@
 
 ## Our Pledge
 
-In the interest of fostering an open and welcoming environment, we as
-contributors and maintainers pledge to making participation in our project and
-our community a harassment-free experience for everyone, regardless of age, body
-size, disability, ethnicity, gender identity and expression, level of experience,
-nationality, personal appearance, race, religion, or sexual identity and
-orientation.
+We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
 
 ## Our Standards
 
-Examples of behavior that contributes to creating a positive environment
-include:
+Examples of behavior that contributes to a positive environment for our community include:
 
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the overall community
 
-Examples of unacceptable behavior by participants include:
+Examples of unacceptable behavior include:
 
-* The use of sexualized language or imagery and unwelcome sexual attention or
-advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
+* The use of sexualized language or imagery, and sexual attention or
+  advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
 * Public or private harassment
-* Publishing others' private information, such as a physical or electronic
-  address, without explicit permission
+* Publishing others' private information, such as a physical or email
+  address, without their explicit permission
 * Other conduct which could reasonably be considered inappropriate in a
   professional setting
 
-## Our Responsibilities
+## Enforcement Responsibilities
 
-Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
+Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
 
-Project maintainers have the right and responsibility to remove, edit, or
-reject comments, commits, code, wiki edits, issues, and other contributions
-that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
-threatening, offensive, or harmful.
+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
 
 ## Scope
 
-This Code of Conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community. Examples of
-representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an appointed
-representative at an online or offline event. Representation of a project may be
-further defined and clarified by project maintainers.
+This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at hesham_magdy97@hotmail.com. All
-complaints will be reviewed and investigated and will result in a response that
-is deemed necessary and appropriate to the circumstances. The project team is
-obligated to maintain confidentiality with regard to the reporter of an incident.
-Further details of specific enforcement policies may be posted separately.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at tech@oneorder.net All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series of actions.
 
-Project maintainers who do not follow or enforce the Code of Conduct in good
-faith may face temporary or permanent repercussions as determined by other
-members of the project's leadership.
+**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior,  harassment of an individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within the community.
 
 ## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at [https://contributor-covenant.org/version/1/4][version]
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.0,
+available at https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).
+
+[homepage]: https://www.contributor-covenant.org
 
-[homepage]: https://contributor-covenant.org
-[version]: https://contributor-covenant.org/version/1/4/
+For answers to common questions about this code of conduct, see the FAQ at
+https://www.contributor-covenant.org/faq. Translations are available at https://www.contributor-covenant.org/translations.

data/Gemfile

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in paymob.gemspec
+# Specify your gem's dependencies in paymob_accept.gemspec
 gemspec
 
-gem "rake", "~> 12.0"
+gem "rake", "~> 13.0"
+
 gem "rspec", "~> 3.0"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    paymob_accept (0.1.0)
+    paymob_accept (0.2.0)
       faraday
       json-schema
 
@@ -18,7 +18,7 @@ GEM
     json-schema (3.0.0)
       addressable (>= 2.8)
     public_suffix (4.0.7)
-    rake (12.3.3)
+    rake (13.0.6)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
       rspec-expectations (~> 3.11.0)
@@ -39,7 +39,7 @@ PLATFORMS
 
 DEPENDENCIES
   paymob_accept!
-  rake (~> 12.0)
+  rake (~> 13.0)
   rspec (~> 3.0)
 
 BUNDLED WITH

data/README.md

@@ -1,11 +1,10 @@
-
 # PaymobAccept
 
 `paymob_accept` is a Ruby gem created by [OneOrder](https://www.oneorder.net/) for integrating [Paymob](https://paymob.com/en) payment solutions with your Ruby application.
 
 ## Installation
 
-Add this line to your application's Gemfile:
+Add this line to your appliciation's Gemfile:
 
 ```ruby
 gem 'paymob_accept'
@@ -23,89 +22,115 @@ Or install it yourself as:
 
 ### Configuration
 
-Configure the gem with your `api_key`
+Configure the gem with your configuration
 
 ```ruby
 PaymobAccept.configure do |config|
-  config.api_key = YOUR_API_KEY
+	config.api_key = "######"
+	config.online_integration_id = "######"
+	config.kiosk_integration_id = "######"
+	config.cash_integration_id = "######"
+	config.wallet_integration_id = "######"
+	config.auth_integration_id = "######"
+	config.moto_integration_id = "######"
 end
 ```
 
-Also you can pass the api_key to the constructor when initializing your payment service
+Optionally, any configuration parameters mentioned above could be passed to the constructor when initializing the payment service.
 
-:raised_back_of_hand: You get your API_KEY from Settings -> Account info -> API Key in your Paymob portal
+:bulb: You can get your API_KEY from Settings -> Account info -> API Key in your Paymob portal.
 
-### Creating the payment service
+For reference on the internals & specifics of Paymob, please head to their official documentation [here](https://docs.paymob.com/)
 
-  When performing a payment we expect to have two hashes (customer, address)
+## Creating a charge:
 
-- Customer schema
+1. Initialize your payment service
 
+    ```ruby
+    service = PaymobAccept::Api::Pay.new(api_key: api_key, online_integration_id: "12345678")
+    ```
 
-## Payment service
+2. Prepare your customer data using the following schemas (All fields are required):
 
-  - Initialize your payment service
     ```ruby
-    service = PaymobAccept::Api::Pay.new(api_key: api_key) 
+      customer_data = {name:  "test",  email:  "test@test.com",  phone_number:  "01000000000"}
+      billing_address_data = {address_line1:  "10 street name", address_line2: "apt x. floor x",  region: "region", city: "Cairo", country: "EG"}
     ```
+3. Create a charge:
 
-   - To charge:
-      ```ruby
-      customer_data = {name:  "test",  email:  "test@test.com",  phone_number:  "01000000000"}
-      address_data = {address_line1:  "10 street name", address_line2: "apt x. floor x",  region: "region", city: "Cairo", country: "EG"}
-      service.charge(customer: customer, address: address, integration_id: 'xxxxx', method: :online, iframe_id: 'xxxxx', amount_cents: 1000, amount_currency: 'EGP', order_id: order_id)
-      ```
-      If  order_id is not provided, an order is created then linked to this payment_intent
+    ```ruby
+    service.charge(customer: customer_data, address: billing_address_data, method: :online, iframe_id: 'xxxxx', amount_cents: 1000)
+    ```
+
+Note. All integration id methods are public and could so it could be easily used to set an integration as:
+
+```ruby
+service.online_integration_id = "123"
+```
+
+### Alternatively, you can you create a charge step by step (Not recommended):
+
+1. Authentication request
 
----
- ### Also, You can do it step by step
- 
- - Step #1  Get auth_token
     ```ruby
-    token =  service.get_auth_token
+    token = service.get_auth_token
     ```
 
- - Step #2 Create_order
+2.  Create_order
     ```ruby
-    service.create_order(auth_token: auth_token, amount_cents:  1000,  amount_currency:  'EGP', items:  [])
+    service.create_order(auth_token: token, amount_cents:  1000,  amount_currency:  'EGP', items:  [])
     ```
 
-   auth_token is optional if not passed, it will be automatically generated.
-  </br>
     - Items are optional
 
       ```ruby
-        items  =  [{
+      items  =  [{
           "name":  "xxxxxxx-1",
           "amount_cents": "5000",
           "description": "Smart Watch",
           "quantity": "10"
-          }]
+      }]
       ```
 
-  </br>
+3. Create payment key
 
-  - Step #3 Create payment key
-  
     ```ruby
-    generate_payment_intent(customer: customer, address: address, integration_id: "xxxxx", amount_cents: amount_cents, amount_currency: "EGP", iframe_id: "xxxxxx", order_id: "xxxxxx")
+    service.generate_payment_intent(customer: customer, address: address, integration_id: "xxxxx", amount_cents: amount_cents, amount_currency: "EGP", iframe_id: "xxxxxx", order_id: "xxxxxx")
     ```
----
-## Dealing with charges 
-- retrieve transaction `PaymobAccept::Api::Charge.new.charge(transaction_id: transaction_id)`
-- refund transaction `PaymobAccept::Api::Charge.new.refund!(transaction_id: transaction_id, amount_cents: amount_cents)`
-- void a transaction using `PaymobAccept::Api::Charge.new.void!(transaction_id: transaction_id)`
 
-## Development
+## Supported payment methods
+
+The `:method` key in the `charge` method could be one of the following:
+
+- :online => 3D Secure payments with external redirection
+- :auth => Auth/Capture payments
+- :kiosk => Aman/Masary kiosk network
+- :cash => Cash on delivery
+- :wallet => Vodafone cash
+- :moto => Paying with a saved token
+
+Please refer to the official Paymob documentation for in-depth explanation about each payment method.
+
+The return value of the `charge` method in general is the response of Paymob's server which varies according to the payment method except in `:online`. In an `:online` payment if an `iframe_id` is provided, the return value is an iFrame URL with an embedded payment token. If the `iframe_id` is not provided, only the payment token is returned
+
+## Dealing with charges
+
+- **Initialize your Charge service**
+
+  ```ruby
+  service = PaymobAccept::Api::Charge.new
+  ```
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+- Retrieve transaction: `service.charge(transaction_id: transaction_id)`
+- Refund transaction: `service.refund!(transaction_id: transaction_id, amount_cents: amount_cents)`
+- Void a transaction: `service.void!(transaction_id: transaction_id)`
+- Capture an auth transaction: `service.capture!(transaction_id: transaction_id, amount_cents: amount_cents)`
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 
-Bug reports and pull requests are welcome on [GitHub](https://github.com/HeshamMagdy97/paymob).
-This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/HeshamMagdy97/paymob/blob/master/CODE_OF_CONDUCT.md).
+Bug reports and pull requests are welcome on [GitHub](https://github.com/oneorder-tech/paymob).
+This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/oneorder-tech/paymob/blob/master/CODE_OF_CONDUCT.md).
 
 ## License
 
@@ -113,4 +138,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the PaymobAccept project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/HeshamMagdy97/paymob/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the PaymobAccept project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/oneorder-tech/paymob/blob/master/CODE_OF_CONDUCT.md).

data/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
-require "paymob"
+require "paymob_accept"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

data/lib/paymob_accept/api/base.rb

@@ -1,16 +1,14 @@
 module PaymobAccept
   module Api
     class Base
-      attr_reader :integration_id, :method, :customer, :address
-      attr_accessor :api_key, :iframe_id
+      attr_reader :api_key, :client
 
-      def initialize(api_key: PaymobAccept.configuration.api_key)
+      def initialize(api_key:)
         @client = PaymobAccept::Api::Client.new
         @api_key = api_key
-        @address = address
       end
 
-      # STEP #!
+      # 1. Authentication Request
       def get_auth_token
         response = @client.request('/auth/tokens', { api_key: api_key })
         response['token']
@@ -29,6 +27,7 @@ module PaymobAccept
         @client.request('/ecommerce/orders', body)
       end
 
+      # 3. Payment Key Request
       def generate_payment_intent(customer:, address:, integration_id:, amount_cents:, amount_currency:, iframe_id: nil, order_id: nil, auth_token: get_auth_token)
         if order_id.nil?
           order = create_order(amount_cents: amount_cents, amount_currency: amount_currency)
@@ -40,8 +39,6 @@ module PaymobAccept
         format_bill_reference(payment_token, iframe_id)
       end
 
-      # 3. Payment Key Request
-
       private
 
       def generate_payment_key(customer:, address:, amount_cents:, amount_currency:, integration_id:, order_id: nil, auth_token: get_auth_token)
@@ -82,13 +79,13 @@ module PaymobAccept
       def customer_validator(customer)
         JSON::Validator.validate!(customer_schema, customer)
       rescue JSON::Schema::ValidationError => e
-        raise ArgumentError, "Customer field has the following error: #{e.message}"
+        raise ArgumentError, "Customer hash has the following error: #{e.message}"
       end
 
       def address_validator(address)
         JSON::Validator.validate!(address_schema, address)
       rescue JSON::Schema::ValidationError => e
-        raise ArgumentError, "Address field has the following error: #{e.message}"
+        raise ArgumentError, "Address hash has the following error: #{e.message}"
       end
 
       def customer_schema

data/lib/paymob_accept/api/client.rb

@@ -2,6 +2,7 @@ module PaymobAccept
   module Api
     class Client
       API_ENDPOINT = 'https://accept.paymobsolutions.com/api'.freeze
+
       def initialize; end
 
       def get(endpoint:, params: {}, headers: {})
@@ -29,8 +30,6 @@ module PaymobAccept
         end
 
         unless response.success?
-          # TODO: Instead of setting the status to failed, this payment intent could be destroyed
-
           message = parsed_body&.dig('message') || response.body || default_error_message
           raise PaymobAccept::Errors::BadGateway.new(message: "code: #{response.status}, gateway response: #{message}")
         end

data/lib/paymob_accept/api/pay.rb

@@ -3,63 +3,79 @@
 module PaymobAccept
   module Api
     class Pay < Base
-      def initialize(api_key: PaymobAccept.configuration.api_key)
+      SUPPORTED_PAYMENT_METHODS = %i[online auth kiosk cash wallet moto].freeze
+
+      attr_accessor :api_key, :online_integration_id, :cash_integration_id, :kiosk_integration_id,
+                    :auth_integration_id, :wallet_integration_id, :moto_integration_id
+
+      def initialize(api_key: PaymobAccept.configuration.api_key, online_integration_id: PaymobAccept.configuration.online_integration_id, cash_integration_id: PaymobAccept.configuration.cash_integration_id, kiosk_integration_id: PaymobAccept.configuration.kiosk_integration_id,
+                     auth_integration_id: PaymobAccept.configuration.auth_integration_id, wallet_integration_id: PaymobAccept.configuration.wallet_integration_id, moto_integration_id: PaymobAccept.configuration.moto_integration_id)
         super(api_key: api_key)
+        @api_key = api_key
+        @online_integration_id = online_integration_id
+        @cash_integration_id = cash_integration_id
+        @kiosk_integration_id = kiosk_integration_id
+        @auth_integration_id = auth_integration_id
+        @wallet_integration_id = wallet_integration_id
+        @moto_integration_id = moto_integration_id
       end
 
-      def charge(customer:, address:, amount_cents:, integration_id:, method:, amount_currency: 'EGP', order_id: nil, iframe_id: nil, auth_token: get_auth_token)
-        raise ArgumentError, "unsupported payment method #{method}" unless %i[online moto kiosk cash auth
-                                                                              wallet].include? method
+      def charge(method:, **kwargs)
+        raise ArgumentError, "unsupported payment method #{method}" unless SUPPORTED_PAYMENT_METHODS.include? method
 
-        send("pay_#{method}".to_sym,
-             { auth_token: auth_token, customer: customer, address: address, amount_cents: amount_cents, amount_currency: amount_currency,
-               integration_id: integration_id, iframe_id: iframe_id, order_id: order_id })
+        # Override any currencies, only EGP is currently supported
+        kwargs[:amount_currency] = 'EGP'
+        send("pay_#{method}".to_sym, **kwargs)
       end
 
       private
 
-      def request_auth(customer:, address:, amount_cents:, amount_currency:, integration_id:, iframe_id:, order_id:, auth_token:)
+      def pay_auth(customer:, address:, amount_cents:, amount_currency:)
         generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents, amount_currency: amount_currency,
-                                integration_id: integration_id, iframe_id: iframe_id, order_id: order_id, auth_token: auth_token)
+                                integration_id: auth_integration_id)
       end
 
-      # Returns iFrame URL. The iframe will be prepoulated if the credit card token is provided
-      def pay_online(customer:, address:, amount_cents:, amount_currency:, integration_id:, iframe_id:, order_id:, auth_token:)
+      # Return an iFrame URL if an iframe_id is provided. Otherwise, returns a payment token
+      # The iFrame will be prepoulated with the credit card info if customer[cc_token] is present and is valid stored credit card token on Paymob's server
+      def pay_online(customer:, address:, amount_cents:, amount_currency:, iframe_id: nil)
         generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents, amount_currency: amount_currency,
-                                integration_id: integration_id, iframe_id: iframe_id, order_id: order_id, auth_token: auth_token)
+                                integration_id: online_integration_id, iframe_id: iframe_id)
       end
 
-      def pay_moto(customer:, address:, amount_cents:, amount_currency:, integration_id:, iframe_id:, order_id:, auth_token:)
+      # Paying MOTO (ie. with a saved card token)
+      def pay_moto(customer:, address:, amount_cents:, amount_currency:)
         if customer[:cc_token].nil?
           raise ArgumentError,
-                'You need to provide a credit card token for moto payments'
+                'You need to provide a credit card token for MOTO payments'
         end
 
         bill_reference = generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents, amount_currency: amount_currency,
-                                                 integration_id: integration_id, iframe_id: iframe_id, order_id: order_id, auth_token: auth_token)
+                                                 integration_id: auth_integration_id)
         body = {
-          "source": { "subtype": 'TOKEN', "identifier": cc_token },
+          "source": { "subtype": 'TOKEN', "identifier": customer[:cc_token] },
           "payment_token": bill_reference
         }
         @client.request('/acceptance/payments/pay', body)
       end
 
-      def pay_wallet(customer:, address:, amount_cents:, amount_currency:, integration_id:, iframe_id:, order_id:, auth_token:)
-        if customer[:wallet_mobile_number].nil?
+      def pay_wallet(customer:, address:, amount_cents:, amount_currency:)
+        wallet_phone_number = customer[:wallet_phone_number] || customer[:phone_number]
+
+        if wallet_phone_number.nil?
           raise ArgumentError,
                 'You need to provide a mobile number for wallet payments'
         end
 
         bill_reference = generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents, amount_currency: amount_currency,
-                                                 integration_id: integration_id, iframe_id: iframe_id, order_id: order_id, auth_token: auth_token)
+                                                 integration_id: wallet_integration_id)
         body = {
-          "source": { "subtype": 'WALLET', "identifier": wallet_mobile_number },
+          "source": { "subtype": 'WALLET', "identifier": wallet_phone_number },
           "payment_token": bill_reference
         }
         @client.request('/acceptance/payments/pay', body)
       end
 
-      def pay_cash(customer:, address:, amount_cents:, amount_currency:, integration_id:, iframe_id:, order_id:, auth_token:)
+      def pay_cash(customer:, address:, amount_cents:, amount_currency:)
         if address.nil?
           raise ArgumentError,
                 "Please provide a valid address in options. You must provide those keys: #{address_schema[:required]}"
@@ -67,8 +83,8 @@ module PaymobAccept
 
         address_validator(address)
 
-        bill_reference = generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents, amount_currency: amount_currency,
-                                                 integration_id: integration_id, iframe_id: iframe_id, order_id: order_id, auth_token: auth_token)
+        bill_reference = generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents,
+                                                 amount_currency: amount_currency, integration_id: cash_integration_id)
         body = {
           "source": { "subtype": 'CASH', "identifier": 'cash' },
           "payment_token": bill_reference
@@ -76,9 +92,9 @@ module PaymobAccept
         @client.request('/acceptance/payments/pay', body)
       end
 
-      def pay_kiosk(customer:, address:, amount_cents:, amount_currency:, integration_id:, iframe_id:, order_id:, auth_token:)
-        bill_reference = generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents, amount_currency: amount_currency,
-                                                 integration_id: integration_id, iframe_id: iframe_id, order_id: order_id, auth_token: auth_token)
+      def pay_kiosk(customer:, address:, amount_cents:, amount_currency:)
+        bill_reference = generate_payment_intent(customer: customer, address: address, amount_cents: amount_cents,
+                                                 amount_currency: amount_currency, integration_id: kiosk_integration_id)
         body = {
           "source": { "subtype": 'AGGREGATOR', "identifier": 'aggregator' },
           "payment_token": bill_reference

data/lib/paymob_accept/configuration.rb

@@ -1,13 +1,7 @@
-# require 'erb'
-# require 'yaml'
-
 module PaymobAccept
   class Configuration
-    attr_accessor :api_key, :amount_currency
-
-    def initialize
-      @amount_currency = 'EGP'
-    end
+    attr_accessor :api_key, :online_integration_id, :cash_integration_id, :kiosk_integration_id,
+                  :auth_integration_id, :wallet_integration_id, :moto_integration_id
   end
 
   class ConfigurationMissingError < StandardError; end

data/lib/paymob_accept/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PaymobAccept
-  VERSION = "0.1.0"
+  VERSION = '0.2.0'
 end

data/lib/paymob_accept.rb

@@ -1,18 +1,22 @@
+# frozen_string_literal: true
+
+require_relative 'paymob_accept/version'
+
+require 'paymob_accept/configuration'
 require 'paymob_accept'
 require 'paymob_accept/api/base'
 require 'paymob_accept/api/pay'
 require 'paymob_accept/api/client'
 require 'paymob_accept/api/charge'
-require 'paymob_accept/configuration'
 
 require 'json'
 require 'faraday'
 require 'faraday/net_http'
 require 'paymob_accept/errors/bad_gateway'
 require 'json-schema'
-
 module PaymobAccept
   class Error < StandardError; end
+
   class << self
     def configure
       yield configuration

data/{paymob.gemspec → paymob_accept.gemspec}

@@ -5,20 +5,19 @@ require_relative 'lib/paymob_accept/version'
 Gem::Specification.new do |spec|
   spec.name          = 'paymob_accept'
   spec.version       = PaymobAccept::VERSION
-  spec.authors       = ['Hesham Magdy']
-  spec.email         = ['hesham_magdy97@hotmail.com']
+  spec.authors       = ['OneOrder']
+  spec.email         = ['tech@oneorder.net']
 
   spec.summary       = 'Easy integration of Paymob payment gateway'
-  spec.description   = 'Paymob is a Ruby gem created by OneOrder tech team for integrating Paymob payment solutions with your Ruby application.'
-  spec.homepage      = "https://github.com/oneorder-tech/paymob"
+  spec.description   = 'PaymobAccept is a Ruby gem created by OneOrder tech team for integrating Paymob payment solutions with your Ruby application.'
+  spec.homepage      = 'https://github.com/oneorder-tech/paymob-accept'
   spec.license       = 'MIT'
-  spec.homepage = 'https://github.com/oneorder-tech/paymob'
+  spec.homepage = 'https://github.com/oneorder-tech/paymob-accept'
   spec.required_ruby_version = Gem::Requirement.new('>= 2.6.0')
 
-
   spec.metadata['homepage_uri'] = spec.homepage
-  spec.metadata['source_code_uri'] = 'https://github.com/oneorder-tech/paymob'
-  spec.metadata['changelog_uri'] = 'https://github.com/oneorder-tech/paymob'
+  spec.metadata['source_code_uri'] = 'https://github.com/oneorder-tech/paymob-accept'
+  spec.metadata['changelog_uri'] = 'https://github.com/oneorder-tech/paymob-accept'
 
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paymob_accept
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
-- Hesham Magdy
+- OneOrder
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-08-18 00:00:00.000000000 Z
+date: 2022-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -38,17 +38,16 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Paymob is a Ruby gem created by OneOrder tech team for integrating Paymob
-  payment solutions with your Ruby application.
+description: PaymobAccept is a Ruby gem created by OneOrder tech team for integrating
+  Paymob payment solutions with your Ruby application.
 email:
-- hesham_magdy97@hotmail.com
+- tech@oneorder.net
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -65,14 +64,14 @@ files:
 - lib/paymob_accept/configuration.rb
 - lib/paymob_accept/errors/bad_gateway.rb
 - lib/paymob_accept/version.rb
-- paymob.gemspec
-homepage: https://github.com/oneorder-tech/paymob
+- paymob_accept.gemspec
+homepage: https://github.com/oneorder-tech/paymob-accept
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/oneorder-tech/paymob
-  source_code_uri: https://github.com/oneorder-tech/paymob
-  changelog_uri: https://github.com/oneorder-tech/paymob
+  homepage_uri: https://github.com/oneorder-tech/paymob-accept
+  source_code_uri: https://github.com/oneorder-tech/paymob-accept
+  changelog_uri: https://github.com/oneorder-tech/paymob-accept
 post_install_message: 
 rdoc_options: []
 require_paths:

data/.travis.yml

@@ -1,6 +0,0 @@
----
-language: ruby
-cache: bundler
-rvm:
-  - 2.7.2
-before_install: gem install bundler -v 2.1.4