payment_dta 0.0.1 → 1.0.0

data/lib/payment_dta/version.rb

@@ -0,0 +1,3 @@
+module DTA
+  VERSION = "1.0.0"
+end

data/payment_dta.gemspec

@@ -0,0 +1,29 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'payment_dta/version'
+
+Gem::Specification.new do |spec|
+  spec.name = "payment_dta"
+  spec.version       = DTA::VERSION
+  spec.require_paths = ["lib"]
+  spec.authors = ["Patrick Huesler"]
+  spec.description = "Generate Swiss DTA payment files to extract payments from your existing application"
+  spec.summary = "Ruby library to generate Swiss DTA payment files"
+  spec.email = "patrick.huesler@gmail.com"
+  spec.extra_rdoc_files = [
+    "LICENSE",
+    "README.rdoc"
+  ]
+  spec.license = "MIT"
+  spec.files         = `git ls-files`.split($/)
+  spec.homepage = "http://github.com/phuesler/payment_dta"
+
+  spec.add_development_dependency "bundler", "~> 1.2"
+  spec.add_development_dependency "rubigen"
+  spec.add_development_dependency "rdoc"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "rake"
+end
+

data/spec/factory.rb

@@ -1,3 +1,4 @@
+# coding: utf-8
 require 'payment_dta/payments/esr_payment'
 require 'payment_dta/payments/total_record'
 class Factory
@@ -75,8 +76,8 @@ class Factory
       :payment_amount_currency         => 'CHF',
       :issuer_identification           => 'ABC01',
       :transaction_number              => rand(100000000000).to_s,
-      :output_sequence_number          => 1,
+      :output_sequence_number          => 0,
       :payment_amount_value_date => Date.today.strftime('%y%m%d')
     }.merge(attributes)
   end
-end
+end

data/spec/lib/bank_cheque_payment_spec.rb

@@ -32,7 +32,7 @@ describe BankChequePayment do
     end
     
     it 'should have a payment amount justified left filled with blanks' do
-      Factory.create_bank_cheque_payment(:payment_amount => '3949.75').segment1[102,15].should == '3949.75'.ljust(15)
+      Factory.create_bank_cheque_payment(:payment_amount => '3949.75').segment1[102,15].should == '3949,75'.ljust(15)
     end
     
     it 'should have a reserve field' do

data/spec/lib/character_conversion_spec.rb

@@ -1,3 +1,4 @@
+# coding: utf-8
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 require 'character_conversion'
 
@@ -237,7 +238,7 @@ def create_character_from_ut8_decimal_code(code)
   if code < 128
     code.chr
   else
-    [code.to_s[0,3].to_i,code.to_s[3,3].to_i].pack("C*")
+    [code.to_s[0,3].to_i,code.to_s[3,3].to_i].pack("C*").force_encoding('utf-8')
   end
 end
 describe "dta character conversion and encoding" do
@@ -249,7 +250,7 @@ describe "dta character conversion and encoding" do
   end
   
   it "should encode the strings" do
-    Converter.should_receive(:encode_characters).with("AEoeue").and_return(Iconv.conv("ISO-8859-1", "UTF8","Äöü"))
+    Converter.should_receive(:encode_characters).with("AEoeue").and_return("Äöü".encode('iso-8859-1'))
     Converter.dta_string("Äöü")
   end
   
@@ -267,14 +268,9 @@ describe "dta character conversion and encoding" do
   end
     
   describe 'DTA character encoding' do
-    
-    it "should have a default system encoding of utf8" do
-      $KCODE.should == 'UTF8'
-    end
-    
     it "should convert the encoding from UTF8 to ISO Latincode 8859-1" do
       encoded_string = Converter.encode_characters("Ä")
-      encoded_string.size.should == 1
+      encoded_string.bytes.to_a.size.should == 1
     end
   end
-end
+end

data/spec/lib/domestic_chf_payment_spec.rb

@@ -33,7 +33,12 @@ describe DomesticCHFPayment do
     end
     
     it 'should have a payment amount justified left filled with blanks' do
-      Factory.create_domestic_chf_payment(:payment_amount => '3949.75').segment1[102,12].should == '3949.75     '
+      Factory.create_domestic_chf_payment(:payment_amount => '3949,75').segment1[102,12].should == '3949,75     '
+    end
+
+    it 'should use the swift convention to format the amount' do
+      Factory.create_domestic_chf_payment(:payment_amount => '110.45').segment1[102,12].should == '110,45      '
+      Factory.create_domestic_chf_payment(:payment_amount => 237.05).segment1[102,12].should == '237,05      '
     end
     
     it 'should have a reserve field' do

data/spec/lib/dta_file_spec.rb

@@ -25,8 +25,8 @@ describe DTAFile do
     file << Factory.create_esr_payment
     file << Factory.create_esr_payment
 
-    file.records.to_a.first.output_sequence_number.should == "00001"
-    file.records.to_a[1].output_sequence_number.should == "00002"
+    file.records.to_a.first.entry_sequence_number.should == "00001"
+    file.records.to_a[1].entry_sequence_number.should == "00002"
   end
   
   it "should calculate the total amount" do
@@ -36,6 +36,12 @@ describe DTAFile do
     file.total.should == (420.50 + 320.20)
   end
   
+  it 'should correctly sum up floats' do
+    file = DTAFile.new nil
+    3.times { file << Factory.create_esr_payment(:payment_amount => 0.1) }
+    file.total.should eq 0.3
+  end
+
   describe DTAFile, "file records" do
     before(:each) do
       @record1 = Factory.create_esr_payment(:payment_amount => 2222.22)
@@ -53,7 +59,14 @@ describe DTAFile do
     end
     
     it "should add a total record" do
-      @file_records.last.should include(Factory.create_total_record(:total_amount => 6666.66).to_dta)
+      @file_records.last.should include(Factory.create_total_record(
+        :entry_sequence_number => 3, :total_amount => 6666.66).to_dta)
+    end
+
+    describe '#dta_string' do
+      it 'equals file contents' do
+        @dta_file.dta_string.size.should == IO.read(@path).size
+      end
     end
   end
   

data/spec/lib/esr_payment_spec.rb

@@ -32,7 +32,7 @@ describe 'ESRPayment' do
     end
     
     it 'should have a payment amount justified left filled with blanks' do
-      Factory.create_esr_payment(:payment_amount => '3949.75').segment1[102,12].should == '3949.75     '
+      Factory.create_esr_payment(:payment_amount => '3949.75').segment1[102,12].should == '3949,75     '
     end
     
     it 'should have a reserve field' do
@@ -154,4 +154,4 @@ describe 'ESRPayment' do
       (@record1 < @record2).should be_true
     end
   end
-end
+end

data/spec/lib/financial_institution_payment_spec.rb

@@ -33,7 +33,7 @@ describe FinancialInstitutionPayment do
     end
     
     it 'should have a payment amount justified left filled with blanks' do
-      Factory.create_financial_institution_payment(:payment_amount => '3949.75').segment1[102,15].should == '3949.75'.ljust(15)
+      Factory.create_financial_institution_payment(:payment_amount => '3949.75').segment1[102,15].should == '3949,75'.ljust(15)
     end
     
     it 'should have a reserve field' do

data/spec/lib/iban_payment_spec.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 require 'payments/iban_payment'
 
@@ -32,7 +33,7 @@ describe IBANPayment do
     end
     
     it 'should have a payment amount justified left filled with blanks' do
-      Factory.create_iban_payment(:payment_amount => '3949.75').segment1[102,15].should == '3949.75'.ljust(15)
+      Factory.create_iban_payment(:payment_amount => '3949.75').segment1[102,15].should == '3949,75'.ljust(15)
     end
     
     it 'should have a reserve field' do
@@ -64,6 +65,11 @@ describe IBANPayment do
       Factory.create_iban_payment(:ordering_partys_address_line3 => '8000 Zurich').segment2[84,35].should == '8000 Zurich'.ljust(35)
     end
     
+    it 'should have the correct length when containing umlauts' do
+      Factory.create_iban_payment(:ordering_partys_address_line3 => '8000 Zürich').
+        segment2[84,35].should == '8000 Zuerich'.ljust(35)
+    end
+
     it 'should have a reserve field' do
       Factory.create_iban_payment.segment2[114,9].should == ' '.ljust(9) 
     end
@@ -124,6 +130,12 @@ describe IBANPayment do
       Factory.create_iban_payment(:beneficiary_address_line1 => 'Michael Recipient').segment4[2,35].should == 'Michael Recipient'.ljust(35)
     end
 
+    it 'should truncate input longer than 35 characters' do
+      name = 'Joannes Chrysostomus Wolfgangus Theophilus Mozart'
+      Factory.create_iban_payment(:beneficiary_address_line1 => name).
+        beneficiary_address_line1(35).should == name[0, 35]
+    end
+
     it 'should have a beneficiary address line 2' do
       Factory.create_iban_payment(:beneficiary_address_line2 => 'Empfaengerstrasse 1').segment4[37,35].should == 'Empfaengerstrasse 1'.ljust(35)
     end

data/spec/lib/payment_header_spec.rb

@@ -7,25 +7,25 @@ shared_examples_for "all headers" do
   it 'should have a total length of 51 characters' do
     Factory.create_payment(@type).header.size.should == 51
   end
-    
+
   it 'should fill out a blank output sequence number' do
     Factory.create_payment(@type).header[18,5].should == '00000'
   end
-  
+
   it 'should set the creation date' do
     Factory.create_payment(@type).header[23,6].should == Date.today.strftime('%y%m%d')
   end
-  
+
   it 'should set the data file sender identification' do
     Factory.create_payment(@type,:data_file_sender_identification => 'ABC12').header[36,5].should == 'ABC12'
   end
-  
+
   it 'should should set the entry sequence number' do
    Factory.create_payment(@type,:entry_sequence_number => 1).header[41,5].should == '00001'
   end
-  
+
   it 'should set the processing flag to 0' do
-   Factory.create_payment(@type).header[50,1].should == '0' 
+   Factory.create_payment(@type).header[50,1].should == '0'
   end
 end
 
@@ -33,27 +33,27 @@ describe ESRPayment, 'header' do
   before(:each) do
     @type = :esr
   end
-  
+
   it_should_behave_like 'all headers'
-  
+
   it 'should set a the correct processing date' do
     Factory.create_esr_payment(:requested_processing_date => '051021').header[0,6].should == '051021'
   end
-    
+
   it 'should fill the beneficiarys bank clearing number with blanks' do
     Factory.create_esr_payment.header[6,12].should == ''.ljust(12,' ')
   end
 
   it 'should set the ordering party bank clearing number' do
-    Factory.create_esr_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '2540000'
+    Factory.create_esr_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '254    '
   end
 
   it 'should should set the transaction type to 826' do
-   Factory.create_esr_payment.header[46,3].should == '826' 
+   Factory.create_esr_payment.header[46,3].should == '826'
   end
 
   it 'should set the payment type to 0' do
-   Factory.create_esr_payment.header[49,1].should == '0' 
+   Factory.create_esr_payment.header[49,1].should == '0'
   end
 end
 
@@ -62,25 +62,25 @@ describe DomesticCHFPayment, 'header' do
     @type = :domestic_chf
   end
   it_should_behave_like 'all headers'
-  
+
   it 'should set a the correct processing date' do
     Factory.create_domestic_chf_payment(:requested_processing_date => '051021').header[0,6].should == '051021'
   end
-  
+
   it 'should fill the beneficiarys bank clearing number with blanks' do
     Factory.create_domestic_chf_payment(:beneficiary_bank_clearing_number => "99999").header[6,12].should == '99999'.ljust(12,' ')
   end
-  
+
   it 'should set the ordering party bank clearing number' do
-    Factory.create_domestic_chf_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '2540000'
+    Factory.create_domestic_chf_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '254    '
   end
-  
+
   it 'should should set the transaction type to 827' do
-   Factory.create_domestic_chf_payment.header[46,3].should == '827' 
+   Factory.create_domestic_chf_payment.header[46,3].should == '827'
   end
 
   it 'should set the payment type to 0' do
-   Factory.create_domestic_chf_payment.header[49,1].should == '0' 
+   Factory.create_domestic_chf_payment.header[49,1].should == '0'
   end
 end
 
@@ -88,27 +88,27 @@ describe FinancialInstitutionPayment, 'header' do
   before(:each) do
     @type = :financial_institution
   end
-  
+
   it_should_behave_like 'all headers'
-  
+
   it 'should fill the requested processing date with zeros' do
     Factory.create_financial_institution_payment.header[0,6].should == '000000'
   end
-  
+
   it 'should fill the beneficiarys bank clearing number with blanks' do
     Factory.create_financial_institution_payment.header[6,12].should == ''.ljust(12,' ')
   end
-  
+
   it 'should set the ordering party bank clearing number' do
-    Factory.create_financial_institution_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '2540000'
+    Factory.create_financial_institution_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '254    '
   end
 
   it 'should should set the transaction type to 830' do
-   Factory.create_financial_institution_payment.header[46,3].should == '830' 
+   Factory.create_financial_institution_payment.header[46,3].should == '830'
   end
 
   it 'should set the payment type to 0' do
-   Factory.create_financial_institution_payment.header[49,1].should == '0' 
+   Factory.create_financial_institution_payment.header[49,1].should == '0'
   end
 end
 
@@ -116,27 +116,27 @@ describe BankChequePayment, 'header' do
   before(:each) do
     @type = :bank_cheque
   end
-  
+
   it_should_behave_like 'all headers'
-  
+
   it 'should fill the requested processing date with zeros' do
     Factory.create_bank_cheque_payment.header[0,6].should == '000000'
   end
-  
+
   it 'should fill the beneficiarys bank clearing number with blanks' do
     Factory.create_bank_cheque_payment.header[6,12].should == ''.ljust(12,' ')
   end
-  
+
   it 'should set the ordering party bank clearing number' do
-    Factory.create_bank_cheque_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '2540000'
+    Factory.create_bank_cheque_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '254    '
   end
-  
+
   it 'should should set the transaction type to 832' do
-   Factory.create_bank_cheque_payment.header[46,3].should == '832' 
+   Factory.create_bank_cheque_payment.header[46,3].should == '832'
   end
 
   it 'should set the payment type to 0' do
-   Factory.create_bank_cheque_payment.header[49,1].should == '0' 
+   Factory.create_bank_cheque_payment.header[49,1].should == '0'
   end
 end
 
@@ -144,27 +144,27 @@ describe IBANPayment, 'header' do
   before(:each) do
     @type = :iban
   end
-  
+
   it_should_behave_like 'all headers'
-  
+
   it 'should fill the requested processing date with zeros' do
     Factory.create_iban_payment.header[0,6].should == '000000'
   end
-  
+
   it 'should fill the beneficiarys bank clearing number with blanks' do
     Factory.create_iban_payment.header[6,12].should == ''.ljust(12,' ')
   end
-  
+
   it 'should set the ordering party bank clearing number' do
-    Factory.create_iban_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '2540000'
+    Factory.create_iban_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '254    '
   end
-  
+
   it 'should should set the transaction type to 836' do
-   Factory.create_iban_payment.header[46,3].should == '836' 
+   Factory.create_iban_payment.header[46,3].should == '836'
   end
 
   it 'should set the payment type to 1' do
-   Factory.create_iban_payment.header[49,1].should == '1' 
+   Factory.create_iban_payment.header[49,1].should == '1'
   end
 end
 
@@ -172,27 +172,27 @@ describe SpecialFinancialInstitutionPayment, 'header' do
   before(:each) do
     @type = :special_financial_institution
   end
-  
+
   it_should_behave_like 'all headers'
-  
+
   it 'should fill the requested processing date with zeros' do
     Factory.create_special_financial_institution_payment.header[0,6].should == '000000'
   end
-  
+
   it 'should fill the beneficiarys bank clearing number with blanks' do
     Factory.create_special_financial_institution_payment.header[6,12].should == ''.ljust(12,' ')
   end
-  
+
   it 'should set the ordering party bank clearing number' do
-    Factory.create_special_financial_institution_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '2540000'
+    Factory.create_special_financial_institution_payment(:ordering_party_bank_clearing_number => '254').header[29,7].should == '254    '
   end
 
   it 'should should set the transaction type to 837' do
-   Factory.create_special_financial_institution_payment.header[46,3].should == '837' 
+   Factory.create_special_financial_institution_payment.header[46,3].should == '837'
   end
 
   it 'should set the payment type to 1' do
-   Factory.create_special_financial_institution_payment.header[49,1].should == '1' 
+   Factory.create_special_financial_institution_payment.header[49,1].should == '1'
   end
 end
 
@@ -200,22 +200,22 @@ describe TotalRecord, 'header' do
   before(:each) do
     @type = :total
   end
-  
+
   it_should_behave_like 'all headers'
-  
+
   it 'should fill the ordering party bank clearing number with blanks' do
     Factory.create_total_payment.header[29,7].should == '       '
   end
-  
+
   it 'should should set the transaction type to 890' do
-   Factory.create_total_payment.header[46,3].should == '890' 
+   Factory.create_total_payment.header[46,3].should == '890'
   end
-  
+
   it 'should set the payment type to 0' do
-   Factory.create_total_payment.header[49,1].should == '0' 
+   Factory.create_total_payment.header[49,1].should == '0'
   end
-  
+
   it 'should set a the correct processing date' do
     Factory.create_total_payment.header[0,6].should == '000000'
   end
-end
+end