paylane 1.1.0 → 1.1.1

data/README.md

@@ -1,4 +1,4 @@
-# Paylane
+# Paylane [![Build Status](https://travis-ci.org/shellycloud/paylane.png)](https://travis-ci.org/shellycloud/paylane) [![Code Climate](https://codeclimate.com/github/shellycloud/paylane.png)](https://codeclimate.com/github/shellycloud/paylane)
 
 Ruby client for [PayLane](http://www.paylane.com) payments.
 

data/lib/paylane.rb

@@ -2,6 +2,7 @@ require "savon"
 require "paylane/version"
 require "paylane/gateway"
 require "paylane/api"
+require "paylane/product"
 require "paylane/payment"
 require "paylane/recurring_payment"
 require "paylane/railtie" if defined?(Rails)

data/lib/paylane/payment.rb

@@ -4,6 +4,7 @@ module PayLane
       gateway = Gateway.new(PayLane.login, PayLane.password)
       @api = API.new(gateway.connect)
       @options = options
+      @product = Product.new @options[:product]
     end
 
     def charge_card(amount)
@@ -14,15 +15,6 @@ module PayLane
       do_payment(amount, {'account_data' => account_data})
     end
 
-    private
-
-    def do_payment(amount, payment_method)
-      @amount = amount
-      response = @api.multi_sale(params.merge('payment_method' => payment_method))
-      PayLane.logger.info("[PayLane] #{response}")
-      response
-    end
-
     protected
 
     def params
@@ -32,7 +24,7 @@ module PayLane
         'currency_code' => PayLane.currency,
         'processing_date' => "#{Date.today}",
         'product' => {
-          'description' => "[#{@options[:product]}][#{Time.now.getutc}]"
+          'description' => @product.description
         }
       }
     end
@@ -48,6 +40,15 @@ module PayLane
     def customer
       {}
     end
+
+    private
+
+    def do_payment(amount, payment_method)
+      @amount = amount
+      response = @api.multi_sale(params.merge('payment_method' => payment_method))
+      PayLane.logger.info("[PayLane] #{response}")
+      response
+    end
   end
 end
 

data/lib/paylane/product.rb

@@ -0,0 +1,13 @@
+module PayLane
+  class Product
+    def initialize(attributes)
+      @attributes = attributes
+    end
+
+    def description
+      attributes = Array(@attributes) << Time.now.getutc
+      attributes.map { |a| "[#{a}]" }.join ''
+    end
+  end
+end
+

data/lib/paylane/recurring_payment.rb

@@ -5,6 +5,7 @@ module PayLane
       @api = API.new(gateway.connect)
       @previous_sale_id = previous_sale_id
       @options = options
+      @product = Product.new @options[:product]
     end
 
     def charge_card(amount)
@@ -21,7 +22,7 @@ module PayLane
         'id_sale' => @previous_sale_id,
         'amount' => @amount,
         'currency' => PayLane.currency,
-        'description' => "[#{@options[:product]}][#{Time.now.getutc}]"
+        'description' => @product.description
       }
     end
   end

data/lib/paylane/version.rb

@@ -1,3 +1,3 @@
 module PayLane
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/paylane/payment_spec.rb

@@ -12,14 +12,15 @@ describe PayLane::Payment do
         'currency_code' => 'EUR',
         'processing_date' => "#{Date.today}",
         'product' => {
-          'description' => '[][2012-11-30 06:30:00 UTC]'
+          'description' => '[2012-11-30 06:30:00 UTC]'
         }
       }
     end
 
     before do
       PayLane.stub_chain(:logger, :info)
-      Time.stub_chain(:now, :getutc).and_return(Time.utc(2012, 11, 30, 6, 30))
+      PayLane::Product.stub_chain(:new, :description).
+        and_return('[2012-11-30 06:30:00 UTC]')
     end
 
     describe '#charge_card' do

data/spec/paylane/product_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe PayLane::Product do
+  before do
+    Time.stub_chain(:now, :getutc).and_return(Time.utc(2012, 11, 30, 6, 30))
+  end
+
+  describe '#description' do
+    it 'handles product description' do
+      product = PayLane::Product.new 'tank'
+      product.description.should == '[tank][2012-11-30 06:30:00 UTC]'
+
+      product = PayLane::Product.new %w(black tank)
+      product.description.should == '[black][tank][2012-11-30 06:30:00 UTC]'
+    end
+  end
+end
+

data/spec/paylane/recurring_payment_spec.rb

@@ -2,23 +2,25 @@ require 'spec_helper'
 
 describe PayLane::RecurringPayment do
   let(:api) { PayLane::API }
-  let(:recurring_payment) { PayLane::RecurringPayment.new(12345) }
 
   before do
     PayLane.stub_chain(:logger, :info)
-    Time.stub_chain(:now, :getutc).and_return(Time.utc(2012, 11, 30, 6, 30))
+    PayLane::Product.stub_chain(:new, :description).
+      and_return('[2012-11-30 06:30:00 UTC]')
   end
 
   describe '#charge_card' do
     it 'charges previosuly charged account' do
+      payment = PayLane::RecurringPayment.new(1)
       expected_params = {
-        'id_sale' => 12345,
+        'id_sale' => 1,
         'amount' => 20.00,
         'currency' => 'EUR',
-        'description' => '[][2012-11-30 06:30:00 UTC]'
+        'description' => '[2012-11-30 06:30:00 UTC]'
       }
+
       api.any_instance.should_receive(:resale).with(expected_params)
-      recurring_payment.charge_card(20.00)
+      payment.charge_card 20.00
     end
   end
 end

metadata

@@ -2,79 +2,79 @@
 name: paylane
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Bartlomiej Kozal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-26 00:00:00.000000000 Z
+date: 2013-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
   type: :runtime
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.2.0
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.2.0
+    none: false
+  prerelease: false
 - !ruby/object:Gem::Dependency
   name: rake
   type: :development
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  prerelease: false
 - !ruby/object:Gem::Dependency
   name: rspec
   type: :development
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  prerelease: false
 - !ruby/object:Gem::Dependency
   name: fakeweb
   type: :development
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  prerelease: false
 description: Ruby client for PayLane service.
 email:
 - bkzl@me.com
@@ -94,6 +94,7 @@ files:
 - lib/paylane/connection_error.rb
 - lib/paylane/gateway.rb
 - lib/paylane/payment.rb
+- lib/paylane/product.rb
 - lib/paylane/railtie.rb
 - lib/paylane/recurring_payment.rb
 - lib/paylane/response.rb
@@ -103,6 +104,7 @@ files:
 - spec/paylane/api_spec.rb
 - spec/paylane/gateway_spec.rb
 - spec/paylane/payment_spec.rb
+- spec/paylane/product_spec.rb
 - spec/paylane/recurring_payment_spec.rb
 - spec/paylane/resposne_spec.rb
 - spec/spec_helper.rb
@@ -113,17 +115,23 @@ rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
+      segments:
+      - 0
+      hash: -486414746515133137
       version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
+required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
+      segments:
+      - 0
+      hash: -486414746515133137
       version: '0'
+  none: false
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -135,6 +143,7 @@ test_files:
 - spec/paylane/api_spec.rb
 - spec/paylane/gateway_spec.rb
 - spec/paylane/payment_spec.rb
+- spec/paylane/product_spec.rb
 - spec/paylane/recurring_payment_spec.rb
 - spec/paylane/resposne_spec.rb
 - spec/spec_helper.rb