payhyper 0.1.1 → 0.2.0

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YTJkOTg5N2Q0ZTMwNjI5ZmE0MmM2OGIyNmNlMzg5ZTQ0N2NlZTE4Mg==
+  data.tar.gz: !binary |-
+    NjNkODQwYmQ4MGM2NjY0Y2ZkNjI1YzRlOGU1MWVmMjMxZTc0N2VlYw==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    NWRjNDE5ZDA3ZjBiZDlmODJkNzU1ZWUzZjhhZDVkYTUwZjE4NDBkZWIwNTM3
+    NTU3MWNjYWY5ZjVmYjFhMjNjODZjNDE3MzlkNmM3NGQ0MDA4YzEwZGJkZjdi
+    ZWYyNGI1ZmU5YjU1OTdhMDk4NzY1MmI5ZmRkZmU0Zjc4NGNiMzQ=
+  data.tar.gz: !binary |-
+    ODhhYjAwYWM4ZGMzZGQ4YzE2ZDE3NTdhZjNhYjgzNGYwNjQwZTM1NzU0ZTgx
+    ZjIyMWQyYzJjMjVhZTI5YzVkZmNlZGEzMmE1YTg2ZTZiZDFjMDBmYmEzNGI4
+    NDc3YjUyZGExYjkxOWM0ZTYxMzQwOWZlMTI0ZmRlODRmM2MwZDc=

data/lib/payhyper/version.rb

@@ -1,3 +1,3 @@
 module PayHyper
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/lib/payhyper.rb

@@ -13,15 +13,21 @@ module PayHyper
   unless defined?(DEBUG)
     BASE_URLS = {
       :live => "http://api.payhyper.com",
-      :sandbox => "http://api.sandbox.payhyper.com",
+      :sandbox => "http://sandbox-api.payhyper.com",
     }
   else
     BASE_URLS = {
       :live => "http://api.local.local:3000",
-      :sandbox => "http://api.sandbox.local.local:3001",
+      :sandbox => "http://sandbox-api.local.local:3001",
     }
   end
 
+  CURRENCIES = %w{JOD USD BHD GBP EGP KWD OMR QAR SAR TRY AED}
+  COUNTRY_CODES = {
+    "JO" => "962",
+  }
+  COUNTRIES = COUNTRY_CODES.keys
+
   def self.setup(access_key_id, access_key_secret, mode)
     raise PayHyperError, "Mode must be one of #{BASE_URLS.keys.map { |k| k.inspect }.join(" or ")}" unless BASE_URLS.keys.include?(mode)
     @access_key_id = access_key_id
@@ -33,15 +39,28 @@ module PayHyper
     raise PayHyperError, "Must call setup() first" if @access_key_id.nil? || @access_key_secret.nil? || @base_url.nil?
   end
 
-  def self.create_order!(params)
+  def self.create_order!(service, country, amount, currency, phone, email, tag = nil)
     raise_if_not_setup!
+    # == Clean-up fields ==
+    service = service.to_s.gsub("_", "-") if [:at_door, :in_store].include?(service)
+    currency = currency.upcase if currency && currency.is_a?(String)
+    country = country.upcase if country && country.is_a?(String)
+    if phone && phone.is_a?(String)
+      phone = phone(/[^0-9]/, "") # Remove non-numeric characters.
+      phone = phone.gsub(/^0*/, "") # Remove leading zeros.
+      if country && COUNTRY_CODES[country] && !phone.start_with?(COUNTRY_CODES[country])
+        phone = COUNTRY_CODES[country] + phone # Add country code.
+      end
+    end
     # == Validate ==
-    raise ValidationError, "Incorrect amount." if params[:amount].to_i <= 0
-    raise ValidationError, "Incorrect currency." unless %w{JOD USD BHD GBP EGP KWD QMR QAR SAR TRY AED}.include?(params[:currency].upcase)
-    raise ValidationError, "Incorrect email." if params[:email].nil? || !params[:email].match(/\A[^@\s]+@([^@\s]+\.)+[^@\s]+\z/)
-    raise ValidationError, "Incorrect phone." if params[:phone].nil? || !params[:phone].match(/\A\+962[0-9]{8,9}\z/)
+    raise ValidationError, "Incorrect service specified." unless ["at-door", "in-store"].include?(service)
+    raise ValidationError, "Country specified is incorrect or not supported." unless COUNTRIES.include?(country)
+    raise ValidationError, "Incorrect amount, must be positive." if amount.to_i <= 0
+    raise ValidationError, "Currency is incorrect or not supported." unless CURRENCIES.include?(currency)
+    raise ValidationError, "Incorrect phone, or not in a supported country." if phone.nil? || !phone.match(/\A\+962[0-9]{8,9}\z/)
+    raise ValidationError, "Invalid email." if email.nil? || !email.match(/\A[^@\s]+@([^@\s]+\.)+[^@\s]+\z/)
     # == Do the request ==
-    body = JSON.dump({ :email => params[:email], :phone => params[:phone], :amount => params[:amount], :currency => params[:currency] })
+    body = JSON.dump({ :service => service, :country => country, :amount => amount, :currency => currency, :phone => phone, :email => email, :tag => tag })
     failure = "Unknown error"
     begin
       uri = URI.parse(@base_url + "/v1/orders")
@@ -88,7 +107,7 @@ module PayHyper
     request.env["rack.input"].rewind # In case someone forgot to rewind the input.
     body = request.env["rack.input"].read
     request.env["rack.input"].rewind # Be nice to others.
-    canonical_request_representation = [request.env["REQUEST_METHOD"], request.env["HTTP_HOST"], request.env["PATH_INFO"], request.env["CONTENT_TYPE"], body].join("\n")
+    canonical_request_representation = [request.env["REQUEST_METHOD"], request.env["HTTP_HOST"], request.env["PATH_INFO"], request.env["CONTENT_TYPE"], body].join("\n") # TODO: security bug if the webserver doesn't check host headers.
     correct_signature = Security.sign(@access_key_secret, canonical_request_representation)
     return Security.secure_compare(correct_signature, input_signature)
   end
@@ -106,7 +125,6 @@ module PayHyper
   end
 
   class PayHyperError < StandardError; end
-  class AuthenticationError < PayHyperError; end
   class ValidationError < PayHyperError; end
   class CommunicationError < PayHyperError; end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: payhyper
 version: !ruby/object:Gem::Version
-  version: 0.1.1
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - Sinan Taifour
@@ -14,7 +13,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -41,7 +37,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -63,26 +58,25 @@ files:
 - payhyper.gemspec
 homepage: http://payhyper.com
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.7
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: The Ruby bindings of the Hyper API
 test_files: []