payfort_start 0.0.1 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21a5936818d47f37354f17ab24a9844da1456fd2
-  data.tar.gz: 7af678b629882d5d4be4c9528c1a17a50a41da9b
+  metadata.gz: 9994dbb1a740bdcbe93086d2e8684092aa56eaa8
+  data.tar.gz: e07d81561889e8c2487eadc8e9dd42cd018d078a
 SHA512:
-  metadata.gz: 56f81f4e54b67e62b2f8e132cc3478cc6cac42672419133080e076b335812a2c0c444ef5d04d6e6c00fb8ac9da8145a189c324fa20a65d76b9d490b3ecea9638
-  data.tar.gz: 35421f2a412b24dd33e9e65a0fe857a48eb0e70e9fd612d4d47fca081208539e4ea485a46c8b521ac2a923d886d4627feb974166878bbd4b101f7831c8109e74
+  metadata.gz: 0e62095aa67552e6ae29ee2cb5904504afe81aa0b718a80a9db8da4eec163e83e28bc4a922a22ac278336ea11af7527121fe16402cd9d99165442135aed88ebb
+  data.tar.gz: ba7095377e5ba1734d5926860008ba60d3cb26ba4d749ec90f89c01893e986b049e8885d52d26e5e6f9ca0998bbeb869450836bf8f7baedcea4a188a54c5f7fb

data/.gitignore

@@ -32,3 +32,4 @@ build/
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc
+tags

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    payfort (0.1)
+    payfort_start (0.0.6)
       httparty (~> 0.13)
       json (~> 1.8)
 
@@ -15,7 +15,7 @@ GEM
     columnize (0.9.0)
     debugger-linecache (1.2.0)
     diff-lcs (1.2.5)
-    httparty (0.13.5)
+    httparty (0.13.7)
       json (~> 1.8)
       multi_xml (>= 0.5.2)
     json (1.8.3)
@@ -40,5 +40,8 @@ PLATFORMS
 
 DEPENDENCIES
   byebug
-  payfort!
+  payfort_start!
   rspec
+
+BUNDLED WITH
+   1.11.2

data/README.md

@@ -51,7 +51,7 @@ Start::Charge.create(
   )
 ```
 
-This transaction should be successful since we used the `4242 4242 4242 4242` test credit card. For a complete list of test cards, and their expected output you can check out this link [here](https://docs.start.payfort.com/testing/).
+This transaction should be successful since we used the `4242 4242 4242 4242` test credit card. For a complete list of test cards, and their expected output you can check out this link [here](https://docs.start.payfort.com/guides/testing/).
 
 How can you tell that it was successful? Well, if no exception is raised then you're in the clear.
 

data/lib/start.rb

@@ -1,8 +1,10 @@
 require "httparty"
 require "start/base_resource"
+require "start/version"
 require "start/customer"
 require "start/charge"
-require "start/errors/payfort_error"
+require "start/token"
+require "start/errors/start_error"
 require "start/errors/authentication_error"
 require "start/errors/banking_error"
 require "start/errors/request_error"
@@ -15,6 +17,8 @@ module Start
 
   ssl_ca_file File.dirname(__FILE__) + '/data/ssl-bundle.crt'
 
+  headers 'User-Agent' => "Start/Ruby/#{Start::VERSION}"
+
   def self.api_key=(value)
     default_options[:basic_auth] = {username: value, password: ''}
   end

data/lib/start/base_resource.rb

@@ -8,7 +8,7 @@ module Start
       end
 
       def get(id)
-        handle_response Start.post("#{path}/#{id}")
+        handle_response Start.get("#{path}/#{id}")
       end
 
       def all
@@ -25,23 +25,13 @@ module Start
           return body
         end
 
-        # There was an error .. check the response
-        case body['error']['type']
-        when 'banking'
-          raise Start::BankingError.new(body['error']['message'], body['error']['code'], response.code)
+        exception_class = if ['banking', 'authentication', 'processing', 'request'].include?(body['error']['type'])
+                            Object.const_get "Start::#{body['error']['type'].capitalize}Error"
+                          else
+                            StartError
+                          end
 
-        when 'authentication'
-          raise Start::AuthenticationError.new(body['error']['message'], body['error']['code'], response.code)
-
-        when 'processing'
-          raise Start::ProcessingError.new(body['error']['message'], body['error']['code'], response.code)
-
-        when 'request'
-          raise Start::RequestError.new(body['error']['message'], body['error']['code'], response.code)
-        end
-
-        # Otherwise, raise a General error
-        raise Start::StartError.new(body['error']['message'], body['error']['code'], response.code)
+        raise exception_class.new(body['error']['message'], body['error']['code'], response.code, body['error']['extras'])
       end
     end
   end

data/lib/start/errors/{payfort_error.rb → start_error.rb}

@@ -1,13 +1,12 @@
 module Start
   class StartError < StandardError
-    attr_reader :message
-    attr_reader :code
-    attr_reader :http_status
+    attr_reader :message, :code, :http_status, :extras
 
-    def initialize(message=nil, code=nil, http_status=nil)
+    def initialize(message = nil, code = nil, http_status = nil, extras = {})
       @message = message
       @code = code
       @http_status = http_status
+      @extras = extras
     end
 
     def to_s

data/lib/start/token.rb

@@ -0,0 +1,5 @@
+module Start
+  class Token < BaseResource
+    self.path = '/tokens'
+  end
+end

data/lib/start/version.rb

@@ -1,3 +1,3 @@
 module Start
-  VERSION = '0.0.1'
+  VERSION = '0.0.6'
 end

data/spec/lib/start/charge_spec.rb

@@ -23,6 +23,30 @@ describe Start::Charge do
     expect(response['captured_amount']).to eq(400)
   end
 
+  context 'when metadata parameter is passed' do
+    it 'creates charge with metadata' do
+      response = Start::Charge.create(
+        :amount => 400,
+        :currency => "usd",
+        :email => "ahmed@example.com",
+        :card => {
+          :name => "Abdullah Ahmed",
+          :number => "4242424242424242",
+          :exp_month => 11,
+          :exp_year => 2016,
+          :cvc => 123
+        },
+        :description => "Charge for test@example.com",
+        :metadata => {
+          :reference_id => "12334567890",
+          :tag => "new"
+        }
+      )
+
+      expect(response['metadata']).to eq({"reference_id"=>"12334567890", "tag"=>"new"})
+    end
+  end
+
    it "must list created charges" do
     response = Start::Charge.all()
 

data/spec/lib/start/error/banking_error_spec.rb

@@ -21,6 +21,7 @@ describe Start::BankingError do
     rescue Start::BankingError => e
       expect(e.code).to eq('card_declined')
       expect(e.http_status).to eq(402)
+      expect(e.extras).to include('charge')
     end
   end
 end

data/spec/lib/start/token_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe Start::Token do
+  before do
+    Start.api_key = "test_open_k_d93727030f5ae0e5ff73"
+  end
+
+  it "must create a new token" do
+    response = Start::Token.create(
+      :number => "4242424242424242",
+      :exp_month => 11,
+      :exp_year => 2016,
+      :cvc => 123
+    )
+
+    expect(response['id']).to start_with('tok_')
+  end
+
+  context 'when holder name is passed' do
+    it "must create a card with holder name" do
+      response = Start::Token.create(
+        :number => "4242424242424242",
+        :exp_month => 11,
+        :exp_year => 2016,
+        :cvc => 123,
+        :name => "Abdullah Mohammed"
+      )
+
+      expect(response['card']['name']).to eq('Abdullah Mohammed')
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: payfort_start
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.6
 platform: ruby
 authors:
 - Pavel Gabriel
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-22 00:00:00.000000000 Z
+date: 2016-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -61,9 +61,10 @@ files:
 - lib/start/customer.rb
 - lib/start/errors/authentication_error.rb
 - lib/start/errors/banking_error.rb
-- lib/start/errors/payfort_error.rb
 - lib/start/errors/processing_error.rb
 - lib/start/errors/request_error.rb
+- lib/start/errors/start_error.rb
+- lib/start/token.rb
 - lib/start/version.rb
 - payfort_start.gemspec
 - spec/lib/start/charge_spec.rb
@@ -71,6 +72,7 @@ files:
 - spec/lib/start/error/authentication_error_spec.rb
 - spec/lib/start/error/banking_error_spec.rb
 - spec/lib/start/error/request_error_spec.rb
+- spec/lib/start/token_spec.rb
 - spec/spec_helper.rb
 homepage: https://start.payfort.com/docs/
 licenses:
@@ -92,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Payfort Start API
@@ -102,4 +104,5 @@ test_files:
 - spec/lib/start/error/authentication_error_spec.rb
 - spec/lib/start/error/banking_error_spec.rb
 - spec/lib/start/error/request_error_spec.rb
+- spec/lib/start/token_spec.rb
 - spec/spec_helper.rb