payday 1.1.3 → 1.1.4

data/lib/payday/version.rb

@@ -1,6 +1,5 @@
 # This is Payday!
 module Payday
-
   # Current Version
-  VERSION = "1.1.3"
+  VERSION = "1.1.4"
 end

data/payday.gemspec

@@ -1,5 +1,5 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
+$LOAD_PATH.push File.expand_path("../lib", __FILE__)
 require "payday/version"
 
 Gem::Specification.new do |s|
@@ -8,19 +8,24 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Alan Johnson"]
   s.email       = ["alan@commondream.net"]
-  s.homepage    = ""
-  s.summary     = %q{git remote add origin git@github.com:commondream/payday.git}
-  s.description = %q{Payday is a library for rendering invoices. At present it supports rendering invoices to pdfs, but we're planning on adding support for other formats in the near future.}
+  s.homepage    = "https://github.com/commondream/payday"
+  s.summary     = "A simple library for rendering invoices."
+  s.description = <<-EOF
+    Payday is a library for rendering invoices. At present it supports rendering
+    invoices to pdfs, but we're planning on adding support for other formats in
+    the near future.
+  EOF
 
   s.add_dependency("prawn", "~> 1.0.0")
-  s.add_dependency("money", "~> 6.1")
+  s.add_dependency("money", "~> 6.5")
   s.add_dependency("prawn-svg", "~> 0.15.0.0")
-  s.add_dependency("i18n", ">= 0.6.9")
+  s.add_dependency("i18n", "~> 0.7")
 
   s.add_development_dependency("rspec", "~> 3.1.0")
 
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.files = `git ls-files`.split("\n")
+  s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.executables =
+    `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ["lib"]
 end

data/spec/invoice_spec.rb

@@ -1,15 +1,16 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Payday
   describe Invoice do
 
     it "should be able to be initalized with a hash of options" do
-      i = Invoice.new(:invoice_number => 20, :bill_to => "Here", :ship_to => "There",
-          :notes => "These are some notes.",
-          :line_items => [LineItem.new(:price => 10, :quantity => 3, :description => "Shirts")],
-          :shipping_rate => 15.00, :shipping_description => "USPS Priority Mail:",
-          :tax_rate => 0.125, :tax_description => "Local Sales Tax, 12.5%",
-          :invoice_date => Date.civil(1993, 4, 12))
+      i = Invoice.new(invoice_number: 20, bill_to: "Here", ship_to: "There",
+          notes: "These are some notes.",
+          line_items:
+            [LineItem.new(price: 10, quantity: 3, description: "Shirts")],
+          shipping_rate: 15.00, shipping_description: "USPS Priority Mail:",
+          tax_rate: 0.125, tax_description: "Local Sales Tax, 12.5%",
+          invoice_date: Date.civil(1993, 4, 12))
 
       expect(i.invoice_number).to eq(20)
       expect(i.bill_to).to eq("Here")
@@ -27,58 +28,61 @@ module Payday
       i = Invoice.new
 
       # $100 in Pants
-      i.line_items << LineItem.new(:price => 20, :quantity => 5, :description => "Pants")
+      i.line_items << LineItem.new(price: 20, quantity: 5, description: "Pants")
 
       # $30 in Shirts
-      i.line_items << LineItem.new(:price => 10, :quantity => 3, :description => "Shirts")
+      i.line_items <<
+        LineItem.new(price: 10, quantity: 3, description: "Shirts")
 
       # $1000 in Hats
-      i.line_items << LineItem.new(:price => 5, :quantity => 200, :description => "Hats")
+      i.line_items << LineItem.new(price: 5, quantity: 200, description: "Hats")
 
       expect(i.subtotal).to eq(BigDecimal.new("1130"))
     end
 
-    it "should calculate the correct tax amount, rounded to two decimal places" do
-      i = Invoice.new(:tax_rate => 0.1)
-      i.line_items << LineItem.new(:price => 20, :quantity => 5, :description => "Pants")
+    it "should calculate the correct tax rounded to two decimal places" do
+      i = Invoice.new(tax_rate: 0.1)
+      i.line_items << LineItem.new(price: 20, quantity: 5, description: "Pants")
 
       expect(i.tax).to eq(BigDecimal.new("10"))
     end
 
-    it "shouldn't apply taxes to invoices with a subtotal of 0 or a negative amount" do
-      i = Invoice.new(:tax_rate => 0.1)
-      i.line_items << LineItem.new(:price => -1, :quantity => 100, :description => "Negative Priced Pants")
+    it "shouldn't apply taxes to invoices with subtotal <= 0" do
+      i = Invoice.new(tax_rate: 0.1)
+      i.line_items << LineItem.new(price: -1, quantity: 100,
+        description: "Negative Priced Pants")
 
       expect(i.tax).to eq(BigDecimal.new("0"))
     end
 
     it "should calculate the total for an invoice correctly" do
-      i = Invoice.new(:tax_rate => 0.1)
+      i = Invoice.new(tax_rate: 0.1)
 
       # $100 in Pants
-      i.line_items << LineItem.new(:price => 20, :quantity => 5, :description => "Pants")
+      i.line_items << LineItem.new(price: 20, quantity: 5, description: "Pants")
 
       # $30 in Shirts
-      i.line_items << LineItem.new(:price => 10, :quantity => 3, :description => "Shirts")
+      i.line_items <<
+        LineItem.new(price: 10, quantity: 3, description: "Shirts")
 
       # $1000 in Hats
-      i.line_items << LineItem.new(:price => 5, :quantity => 200, :description => "Hats")
+      i.line_items << LineItem.new(price: 5, quantity: 200, description: "Hats")
 
       expect(i.total).to eq(BigDecimal.new("1243"))
     end
 
     it "is overdue when it's past date and unpaid" do
-      i = Invoice.new(:due_at => Date.today - 1)
+      i = Invoice.new(due_at: Date.today - 1)
       expect(i.overdue?).to eq(true)
     end
 
     it "isn't overdue when past due date and paid" do
-      i = Invoice.new(:due_at => Date.today - 1, :paid_at => Date.today)
+      i = Invoice.new(due_at: Date.today - 1, paid_at: Date.today)
       expect(i.overdue?).not_to eq(true)
     end
 
     it "is overdue when due date is a time before the current date" do
-      i = Invoice.new(:due_at => Time.parse("Jan 1 14:33:20 GMT 2011"))
+      i = Invoice.new(due_at: Time.parse("Jan 1 14:33:20 GMT 2011"))
       expect(i.overdue?).to eq(true)
     end
 
@@ -88,7 +92,7 @@ module Payday
     end
 
     it "should be refunded when marked as refunded" do
-      i = Invoice.new(:refunded_at => Date.today)
+      i = Invoice.new(refunded_at: Date.today)
       expect(i.refunded?).to eq(true)
     end
 
@@ -98,37 +102,38 @@ module Payday
     end
 
     it "should be paid when marked as paid" do
-      i = Invoice.new(:paid_at => Date.today)
+      i = Invoice.new(paid_at: Date.today)
       expect(i.paid?).to eq(true)
     end
 
     it "should be able to iterate over details" do
-      i = Invoice.new(:invoice_details => [["Test", "Yes"], ["Awesome", "Absolutely"]])
+      i = Invoice.new(invoice_details: [%w(Test Yes), %w(Awesome Absolutely)])
       details = []
       i.each_detail do |key, value|
         details << [key, value]
       end
 
       expect(details.length).to eq(2)
-      expect(details).to include(["Test", "Yes"])
-      expect(details).to include(["Awesome", "Absolutely"])
+      expect(details).to include(%w(Test Yes))
+      expect(details).to include(%w(Awesome Absolutely))
     end
 
     it "should be able to iterate through invoice_details as a hash" do
-      i = Invoice.new(:invoice_details => {"Test" => "Yes", "Awesome" => "Absolutely"})
+      i = Invoice.new(invoice_details:
+        { "Test" => "Yes", "Awesome" => "Absolutely" })
       details = []
       i.each_detail do |key, value|
         details << [key, value]
       end
 
       expect(details.length).to eq(2)
-      expect(details).to include(["Test", "Yes"])
-      expect(details).to include(["Awesome", "Absolutely"])
+      expect(details).to include(%w(Test Yes))
+      expect(details).to include(%w(Awesome Absolutely))
     end
 
     describe "rendering" do
       before do
-        Dir.mkdir("tmp") unless File.exists?("tmp")
+        Dir.mkdir("tmp") unless File.exist?("tmp")
         Config.default.reset
       end
 
@@ -136,58 +141,69 @@ module Payday
       let(:invoice_params) { {} }
 
       it "should render to a file" do
-        File.unlink("tmp/testing.pdf") if File.exists?("tmp/testing.pdf")
+        File.unlink("tmp/testing.pdf") if File.exist?("tmp/testing.pdf")
 
         invoice.render_pdf_to_file("tmp/testing.pdf")
 
-        expect(File.exists?("tmp/testing.pdf")).to be true
+        expect(File.exist?("tmp/testing.pdf")).to be true
       end
 
-      context 'with some invoice details' do
-        let(:invoice_params) { {
-          :invoice_details => { "Ordered By:" => "Alan Johnson", "Paid By:" => "Dude McDude" }
-        } }
+      context "with some invoice details" do
+        let(:invoice_params) do
+          {
+            invoice_details: {
+              "Ordered By:" => "Alan Johnson",
+              "Paid By:" => "Dude McDude"
+            }
+          }
+        end
 
         it "should render an invoice correctly" do
-          Payday::Config.default.company_details = "10 This Way\nManhattan, NY 10001\n800-111-2222\nawesome@awesomecorp.com"
+          Payday::Config.default.company_details = <<-EOF
+            10 This Way
+            Manhattan, NY 10001
+            800-111-2222
+            awesome@awesomecorp.com
+          EOF
 
           invoice.line_items += [
-            LineItem.new(:price => 20, :quantity => 5, :description => "Pants"),
-            LineItem.new(:price => 10, :quantity => 3, :description => "Shirts"),
-            LineItem.new(:price => 5, :quantity => 200, :description => "Hats")
+            LineItem.new(price: 20, quantity: 5, description: "Pants"),
+            LineItem.new(price: 10, quantity: 3, description: "Shirts"),
+            LineItem.new(price: 5, quantity: 200, description: "Hats")
           ] * 30
 
-          expect(invoice.render_pdf).to match_binary_asset 'testing.pdf'
+          expect(invoice.render_pdf).to match_binary_asset "testing.pdf"
         end
       end
 
-      context 'paid, with an svg logo' do
+      context "paid, with an svg logo" do
         before do
-          Payday::Config.default.invoice_logo = { :filename => "spec/assets/tiger.svg", :size => "100x100" }
+          logo = { filename: "spec/assets/tiger.svg", size: "100x100" }
+          Payday::Config.default.invoice_logo = logo
         end
 
-        let(:invoice_params) { { :paid_at => Date.civil(2012, 2, 22) } }
+        let(:invoice_params) { { paid_at: Date.civil(2012, 2, 22) } }
 
-        it 'should render an invoice correctly' do
+        it "should render an invoice correctly" do
           invoice.line_items += [
-            LineItem.new(:price => 20, :quantity => 5, :description => "Pants"),
-            LineItem.new(:price => 10, :quantity => 3, :description => "Shirts"),
-            LineItem.new(:price => 5, :quantity => 200.0, :description => "Hats")
+            LineItem.new(price: 20, quantity: 5, description: "Pants"),
+            LineItem.new(price: 10, quantity: 3, description: "Shirts"),
+            LineItem.new(price: 5, quantity: 200.0, description: "Hats")
           ] * 3
 
-          expect(invoice.render_pdf).to match_binary_asset 'svg.pdf'
+          expect(invoice.render_pdf).to match_binary_asset "svg.pdf"
         end
       end
 
       def new_invoice(params = {})
         default_params = {
-          :tax_rate => 0.1,
-          :notes => "These are some crazy awesome notes!",
-          :invoice_number => 12,
-          :invoice_date => Date.civil(2011, 1, 1),
-          :due_at => Date.civil(2011, 1, 22),
-          :bill_to => "Alan Johnson\n101 This Way\nSomewhere, SC 22222",
-          :ship_to => "Frank Johnson\n101 That Way\nOther, SC 22229"
+          tax_rate: 0.1,
+          notes: "These are some crazy awesome notes!",
+          invoice_number: 12,
+          invoice_date: Date.civil(2011, 1, 1),
+          due_at: Date.civil(2011, 1, 22),
+          bill_to: "Alan Johnson\n101 This Way\nSomewhere, SC 22222",
+          ship_to: "Frank Johnson\n101 That Way\nOther, SC 22229"
         }
 
         Invoice.new(default_params.merge(params))

data/spec/line_item_spec.rb

@@ -1,26 +1,25 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Payday
   describe LineItem do
     it "should be able to be initilized with a price" do
-      li = LineItem.new(:price => BigDecimal.new("20"))
+      li = LineItem.new(price: BigDecimal.new("20"))
       expect(li.price).to eq(BigDecimal.new("20"))
     end
 
     it "should be able to be initialized with a quantity" do
-      li = LineItem.new(:quantity => 30)
+      li = LineItem.new(quantity: 30)
       expect(li.quantity).to eq(BigDecimal.new("30"))
     end
 
     it "should be able to be initlialized with a description" do
-      li = LineItem.new(:description => "12 Pairs of Pants")
+      li = LineItem.new(description: "12 Pairs of Pants")
       expect(li.description).to eq("12 Pairs of Pants")
     end
 
     it "should return the correct amount" do
-      li = LineItem.new(:price => 10, :quantity => 12)
+      li = LineItem.new(price: 10, quantity: 12)
       expect(li.amount).to eq(BigDecimal.new("120"))
     end
   end
 end
-

data/spec/pdf_renderer_spec.rb

@@ -1,11 +1,11 @@
 require "spec_helper"
 
 module Payday
-	describe PdfRenderer do
-		describe ".number_to_currency" do
-			it "formats numbers to currency currectly" do
-				expect(PdfRenderer.number_to_currency(20, nil)).to eq("$20.00")
-			end
-		end
-	end
+  describe PdfRenderer do
+    describe ".number_to_currency" do
+      it "formats numbers to currency currectly" do
+        expect(PdfRenderer.number_to_currency(20, nil)).to eq("$20.00")
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,9 +1,9 @@
-require_relative '../lib/payday'
+require_relative "../lib/payday"
 
 # Requires supporting ruby files with custom matchers and macros, etc, in
 # spec/support/ and its subdirectories.
 Dir["spec/support/**/*.rb"].each { |f| require f[5..-1] }
 
-RSpec.configure do |config|
+RSpec.configure do |_config|
   # some (optional) config here
 end

data/spec/support/asset_matchers.rb

@@ -1,14 +1,14 @@
-require 'fileutils'
+require "fileutils"
 
 # Usage: expect(renderer.render).to match_binary_asset('pdf/test.pdf')
 RSpec::Matchers.define(:match_binary_asset) do |file_name|
   match do |actual_output|
-    expected_path = File.join('spec/assets', file_name)
+    expected_path = File.join("spec/assets", file_name)
     expected_output = File.binread(expected_path)
 
     (actual_output == expected_output).tap do |result|
       unless result
-        output_path = File.join('tmp/rendered_output', file_name)
+        output_path = File.join("tmp/rendered_output", file_name)
 
         FileUtils.mkdir_p(File.dirname(output_path))
         File.open(output_path, "wb") { |f| f.write actual_output }
@@ -16,10 +16,11 @@ RSpec::Matchers.define(:match_binary_asset) do |file_name|
     end
   end
 
-  failure_message do |actual_output|
-    expected_output_path = File.join('spec/assets', file_name)
-    actual_output_path = File.join('tmp/rendered_output', file_name)
+  failure_message do |_actual_output|
+    expected_output_path = File.join("spec/assets", file_name)
+    actual_output_path = File.join("tmp/rendered_output", file_name)
 
-    "expected output to match '#{expected_output_path}' (see #{actual_output_path})"
+    "expected output to match '#{expected_output_path}' "\
+      "(see #{actual_output_path})"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: payday
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Alan Johnson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-02 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prawn
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '6.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '6.5'
 - !ruby/object:Gem::Dependency
   name: prawn-svg
   requirement: !ruby/object:Gem::Requirement
@@ -56,16 +56,16 @@ dependencies:
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.9
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.9
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -80,9 +80,10 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
-description: Payday is a library for rendering invoices. At present it supports rendering
-  invoices to pdfs, but we're planning on adding support for other formats in the
-  near future.
+description: |2
+      Payday is a library for rendering invoices. At present it supports rendering
+      invoices to pdfs, but we're planning on adding support for other formats in
+      the near future.
 email:
 - alan@commondream.net
 executables: []
@@ -91,6 +92,7 @@ extra_rdoc_files: []
 files:
 - ".gitattributes"
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-version"
 - CHANGELOG.md
 - Gemfile
@@ -126,7 +128,7 @@ files:
 - spec/pdf_renderer_spec.rb
 - spec/spec_helper.rb
 - spec/support/asset_matchers.rb
-homepage: ''
+homepage: https://github.com/commondream/payday
 licenses: []
 metadata: {}
 post_install_message: 
@@ -148,7 +150,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: git remote add origin git@github.com:commondream/payday.git
+summary: A simple library for rendering invoices.
 test_files:
 - spec/assets/default_logo.png
 - spec/assets/svg.pdf
@@ -159,4 +161,3 @@ test_files:
 - spec/pdf_renderer_spec.rb
 - spec/spec_helper.rb
 - spec/support/asset_matchers.rb
-has_rdoc: