paybox_direct 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4560e9bb17790d500e2ad2a8846c632f276a946f
-  data.tar.gz: ebecf0c8f22b8f6b050d66d4863e5ee0968ed1c9
+  metadata.gz: 4df2da7d7c8afeef4c54db857c9d8d0605722a4d
+  data.tar.gz: e1ba1979d9f90e90797c6d541e241a9ada88ecc5
 SHA512:
-  metadata.gz: bfc2e620e34d4f6d1339f787f45ef7db1c38728267abfeca187ba3b1329279bc68f8a527bef7ba2bb24a5fe4f6fe782583fca6ef5bf187b808d6fbf29c85b920
-  data.tar.gz: 8a018aca42b66a1d7c24abc7ad06ed936b41f5a19137bf2acb9cf2e9beef73595ca2c224f3ce782e0507ea8f99ad1038946329a5ab8262f50445a70261e3a4f2
+  metadata.gz: 289343c6722ad3850ff64aa2c1ba35d4ef756ad1a2ee9f49e68e7146f00c4c5b941d263527df77c460d60a0e48d1ee937b880d72519535f6011a7dedba80cec1
+  data.tar.gz: 66268de49aaa502702d1c15a02f5b43bcaec166ca3fc522c68f515637d24974b7db29c8d0d27db780da9c32cde322ae76ac1d7d8dd8b86ff3fd875d557d04ddf

data/lib/paybox_direct.rb

@@ -7,20 +7,20 @@ require 'ostruct'
 require 'net/http'
 
 module PayboxDirect
-  DEV_URL           = 'https://preprod-ppps.paybox.com/PPPS.php'
-  PROD_URL          = 'https://ppps.paybox.com/PPPS.php'
-  PROD_FALLBACK_URL = 'https://ppps1.paybox.com/PPPS.php'
+  DEV_URL           = URI("https://preprod-ppps.paybox.com/PPPS.php")
+  PROD_URL          = URI("https://ppps.paybox.com/PPPS.php")
+  PROD_FALLBACK_URL = URI("https://ppps1.paybox.com/PPPS.php")
 
   CURRENCIES = {
-    :AUD => 36,
-    :CAD => 124,
-    :CHF => 756,
-    :DKK => 208,
-    :EUR => 978,
-    :GBP => 826,
-    :HKD => 344,
-    :JPY => 392,
-    :USD => 840
+    AUD: 36,
+    CAD: 124,
+    CHF: 756,
+    DKK: 208,
+    EUR: 978,
+    GBP: 826,
+    HKD: 344,
+    JPY: 392,
+    USD: 840
   }
 
   @@config = OpenStruct.new({

data/lib/paybox_direct/request.rb

@@ -7,7 +7,7 @@ require 'rack'
 
 class PayboxDirect::Request
   attr_reader   :vars, :post_request, :fields, :http_resp
-  attr_accessor :response
+  attr_accessor :response, :http_connection
 
   @@request_callbacks = []
   @@undo_callbacks = []
@@ -20,7 +20,7 @@ class PayboxDirect::Request
     @@undo_callbacks << block
   end
 
-  def initialize(vars)
+  def initialize(vars, http_conn = nil)
     defaults = {
       "VERSION"     => PayboxDirect.config.version.to_s.rjust(5, "0"),
       "SITE"        => PayboxDirect.config.site.to_s.rjust(7, "0"),
@@ -39,6 +39,7 @@ class PayboxDirect::Request
 
     @post_request = nil
     @fields = nil
+    @http_connection = http_conn
     @response = {}
     @is_executed = false
   end
@@ -50,9 +51,7 @@ class PayboxDirect::Request
   def execute!
     use_alt = false
     begin
-      prod_url = use_alt ? PayboxDirect::PROD_FALLBACK_URL : PayboxDirect::PROD_URL
-      uri = URI(PayboxDirect.config.is_prod ? prod_url : PayboxDirect::DEV_URL)
-      resp = run_http_post!(uri)
+      resp = run_http_post!(self.class.uri(use_alt))
       raise PayboxDirect::ServerUnavailableError if resp.code != "200"
       @fields = Rack::Utils.parse_query(resp.body)
       if !@fields.has_key?("CODEREPONSE") or @fields["CODEREPONSE"] == "00001"
@@ -102,8 +101,12 @@ class PayboxDirect::Request
     return @fields["COMMENTAIRE"]
   end
 
+  def self.uri(alt = false)
+    prod_url = alt ? PayboxDirect::PROD_FALLBACK_URL : PayboxDirect::PROD_URL
+    return PayboxDirect.config.is_prod ? prod_url : PayboxDirect::DEV_URL
+  end
+
   def self.http_connection(uri)
-    # We may want to execute multiple requests on a single HTTP connection in the future.
     http = Net::HTTP.new(uri.host, uri.port)
     http.use_ssl = true
     return http
@@ -112,7 +115,7 @@ class PayboxDirect::Request
 private
 
   def run_http_post!(uri)
-    http = self.class.http_connection(uri)
+    http = @http_connection || self.class.http_connection(uri)
     @post_request = Net::HTTP::Post.new(uri.request_uri)
     @post_request.set_form_data(@vars)
     begin

data/spec/request_spec.rb

@@ -61,10 +61,32 @@ RSpec.describe PayboxDirect::Request do
     req.execute!
   end
 
+  it "#uri" do
+    PayboxDirect.config.is_prod = true
+    expect(PayboxDirect::Request.uri(false)).to eq PayboxDirect::PROD_URL
+    expect(PayboxDirect::Request.uri(true)).to eq PayboxDirect::PROD_FALLBACK_URL
+    PayboxDirect.config.is_prod = false
+    expect(PayboxDirect::Request.uri(false)).to eq PayboxDirect::DEV_URL
+    expect(PayboxDirect::Request.uri(true)).to eq PayboxDirect::DEV_URL
+  end
+
+  it "accepts a specific connection" do
+    http = PayboxDirect::Request.http_connection(PayboxDirect::Request.uri)
+    req = PayboxDirect::Request.new("VAR1" => "VAL1", "VAR2" => "VAL2")
+    req.http_connection = http
+    expect(http).to receive(:request) do
+      OpenStruct.new({
+        code: "200",
+        body: "CODEREPONSE=00000&COMMENTAIRE=OK"
+      })
+    end
+    req.execute!
+  end
+
   it "should raise ServerUnavailable in dev" do
     was_prod = PayboxDirect.config.is_prod
     PayboxDirect.config.is_prod = false
-    dev_uri = URI(PayboxDirect::DEV_URL)
+    dev_uri = PayboxDirect::DEV_URL
 
     req = PayboxDirect::Request.new("VAR1" => "VAL1", "VAR2" => "VAL2")
     expect_any_instance_of(Net::HTTP).to receive(:request).and_raise(SocketError)
@@ -78,8 +100,8 @@ RSpec.describe PayboxDirect::Request do
   it "should fallback on alt URL in prod" do
     was_prod = PayboxDirect.config.is_prod
     PayboxDirect.config.is_prod = true
-    prod_uri = URI(PayboxDirect::PROD_URL)
-    prod_fallback_uri = URI(PayboxDirect::PROD_FALLBACK_URL)
+    prod_uri = PayboxDirect::PROD_URL
+    prod_fallback_uri = PayboxDirect::PROD_FALLBACK_URL
 
     req = PayboxDirect::Request.new("VAR1" => "VAL1", "VAR2" => "VAL2")
     expect(req).to receive(:run_http_post!).with(prod_uri).and_raise(PayboxDirect::ServerUnavailableError)
@@ -98,8 +120,8 @@ RSpec.describe PayboxDirect::Request do
   it "should raise ServerUnavailable in prod" do
     was_prod = PayboxDirect.config.is_prod
     PayboxDirect.config.is_prod = true
-    prod_uri = URI(PayboxDirect::PROD_URL)
-    prod_fallback_uri = URI(PayboxDirect::PROD_FALLBACK_URL)
+    prod_uri = PayboxDirect::PROD_URL
+    prod_fallback_uri = PayboxDirect::PROD_FALLBACK_URL
 
     req = PayboxDirect::Request.new("VAR1" => "VAL1", "VAR2" => "VAL2")
     expect(req).to receive(:run_http_post!).with(prod_uri).and_raise(PayboxDirect::ServerUnavailableError)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paybox_direct
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Kévin Lesénéchal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-13 00:00:00.000000000 Z
+date: 2015-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake